Re: [E-devel] [PATCH 2/2] elem_cnp: Add Copy and Paste support for wayland.
On 26 July 2012 10:18, wrote: > From: Alex Wu > > Just support type of ELM_SEL_TYPE_CLIPBOARD. If not define > HAVE_ELEMENTARY_X, the wayland path will be built. This is not sufficient - please surround if with #ifdef ELEMENTARY_WAYLAND. You will also need to do a runtime check that we're running under wayland. Take a look at ecore_evas_software_x11_window_get() and friends. And how they are used by e.g. elm_win_xwindow_get() This is currently the key for runtime differentiation. Cheers, Rob -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH][wayland] Enhance unicode generation for key events (fixes #1105)
Patch attached: Here is the ChangeLog entry: 2012-08-01 Rob Bradford * Use libxkbcommon function to map keysym to unicode characters in the Wayland backend. Removing the need to have our own function to do this and increasing the range of supported keysms. Fixes #1105. Cheers, Rob 0001-Ecore_Evas-wayland-Use-new-xkb_keysym_to_utf8-functi.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Deprecation / removal of API
What's the process for deprecating / removing API. I've found at least one example where this makes sense for Wayland: /* @since 1.2 */ EAPI void- ecore_wl_pointer_xy_get(int *x, int *y) This function returns an x and y value saved into global variable in the motion event handler - my guess was that this was leftover from when there were global co-ordinates available in the motion event handler. Now since there are only surface relative positions - these values are not particularly helpful and probably downright confusing since they will change depending on what surface has focus. How can we mark this as deprecated and ultimately remove it? Cheers, Rob -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Deprecation / removal of API
> > We can add eina_deprecated to it for now. Yes, it is a left-over from the > global coordinates era ;) Although, please hold off on sending a patch for > that because I need to verify (for other use cases which are in development) > that this function is in fact safe to deprecate. Sure - of course it might be useful to have a version that takes an Ecore_Evas and gets/stores the position on that structure. But this global version is bound to give "interesting" results if you don't know what it's doing :-) Cheers, Rob -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH][wayland] Fix bug in fullscreening
ChangeLog entry: 2012-08-01 Rob Bradford * Support setting fullscreen on Ecore_Evas's under the Wayland engine before they are visible. The fullscreening will then be applied when they become visible. Patch attached. Cheers, Rob 0001-Ecore_Evas-wayland-Don-t-check-for-visibility-when-f.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH][wayland] Check for NULL surface/shell surface pointers on events
2012-08-03 Rob Bradford * In the Wayland backend handle the case that events can be received for surfaces that have been since destroyed - the client side marshaller changes the pointer to NULL to when the object is destroyed on the client side. Fixes #1258. Patch attached. Cheers, Rob 0001-Ecore-wayland-Check-for-NULL-shell-surfaces-on-event.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Wayland: Complete support for keyboard events
Patch is attached. Cheers, Rob 0001-Ecore_Evas-wayland-Complete-implementation-of-key-ev.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Wayland: Complete support for keyboard events
On 2 May 2012 08:40, wrote: > > The attached patch is a good start, many Thanks :) there are some minor > things that need changing (EFL formatting, better function name, using > 'unsigned int' rather than 'uin32_t', etc, etc) but I will address those this > evening before I commit the patch. Much appreciated. Cheers, Rob -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Wayland: Port to latest input protocol
The Wayland protocol has changed to used a fixed point representation for positions on the input events. The attached patch adapts the implementation in Ecore to convert to integers where necessary. Cheers, Rob 0001-Ecore_Evas-wayland-Adapt-input-handlers-to-reflect-p.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Wayland: Enable vertical/horizontal mouse wheel scrolling
Ecore_wayland: Support vertical/horizontal scrolling Set the direction on the event based on the axis (horizontal/vertical) and z value based on the negative of the value from the compositor. This results in scrolling that is consistent with the X11 implementation. Cheers, Rob 0001-Ecore_wayland-Support-vertical-horizontal-scrolling.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Wayland: Refactor out SHM pool creation
Ecore (wayland): Refactor out SHM pool allocation to common location Also adjust the pool calculation algorithm so that that each time the pool exhausted allocate a pool that is 50% bigger than needed. This should give some scope to reuse the existing allocation to ensure a smoother resize. In future this algorithm can be tweaked because the pool is managed in a single place. -- Cheers, Rob 0001-Ecore-wayland-Refactor-out-SHM-pool-allocation-to-co.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Ecore/Elementary: Only return X11 Window when we have an X11 Ecore_Evas
The challenge here is that the native window representation is stored in Ecore_Evas's prop.window. But currently there is no checking of what driver the Ecore_Evas is for when calls are made to e.g. ecore_evas_software_x11_window_get. The attached change to Ecore makes the appropriate functions return 0 or NULL if the driver for the Ecore doesn't match as expected. This can then be used to identify if an Ecore_Evas is e.g. from X11 or from Wayland. The attached change to Elementary makes a small refactor to use existing code that was already conditional on the Elm engine to retrieve the underlying window - thus allowing elm_win_xwindow_get to return 0 in the case when called on a Wayland based Elm window. Patches have been tested against X11 and Wayland built together by running elementary_test. Cheers, Rob 0001-Ecore_Evas-Return-zero-from-ecore_evas_-_window_get-.patch Description: Binary data 0001-elementary-win-Refactor-X11-code-to-use-evas_-_windo.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore/Elementary: Only return X11 Window when we have an X11 Ecore_Evas
Of course...attached. Cheers, Rob On 28 May 2012 12:13, Chris Michael wrote: > Hi Robert, > > Would you mind a slight modification in the Ecore patch ? > > + if (!(!strcmp(ee->driver, "wayland_egl")) || > + !(!strcmp(ee->driver, "wayland_shm"))) > + return NULL; > > Is easier to do: > > If (!strncmp(ee->driver, "wayland", 7)) > > Thanks :) > Dh > > >> -Original Message- >> From: Bradford, Robert [mailto:robert.bradf...@intel.com] >> Sent: 28 May 2012 11:54 >> To: Enlightenment developer list >> Subject: [E-devel] Ecore/Elementary: Only return X11 Window when we >> have an X11 Ecore_Evas >> >> The challenge here is that the native window representation is stored >> in Ecore_Evas's prop.window. But currently there is no checking of what >> driver the Ecore_Evas is for when calls are made to e.g. >> ecore_evas_software_x11_window_get. >> >> The attached change to Ecore makes the appropriate functions return 0 >> or NULL if the driver for the Ecore doesn't match as expected. This can >> then be used to identify if an Ecore_Evas is e.g. from X11 or from >> Wayland. >> >> The attached change to Elementary makes a small refactor to use >> existing code that was already conditional on the Elm engine to >> retrieve the underlying window - thus allowing elm_win_xwindow_get to >> return 0 in the case when called on a Wayland based Elm window. >> >> Patches have been tested against X11 and Wayland built together by >> running elementary_test. >> >> Cheers, >> >> Rob > 0001-Ecore_Evas-Return-zero-from-ecore_evas_-_window_get-.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Ecore/Elm: Cursors on Wayland (patches)
Chris, Raster, Here are some first patches relating to supporting cursors under Wayland. Ecore - just the one patch - the ChangeLog entry is: 2012-05-29 Rob Bradford * Initial cursor support for Wayland: * Add api to the ecore_wl_input_ namespace to allow setting the buffer to use for the pointer and for loading a named cursor from a cursor theme. Under the Wayland protocol the cursor is associated with the input device. * Add helper functions to ecore_wl_window to set the cursor based on the active pointer input device for the window. * Load the cursor theme when the SHM interface is ready and provide an API call to provide a wl_cursor for a given name. * Add API to restore to the default cursor and then use that when the pointer enters the surface to ensure compliance with the Wayland protocol. This is initial support. It should be enhanced to support dealing with a different cursor theme (currently just uses the "default") cursor theme. Feedback on the naming and structure of the API calls is also welcome. Elementary - several patches i'm afraid but logically separate. The first two are effectively aesthetic * Separate the X11 bits from Elm_Cursor into an "x" substruct to make it cleaner to support multiple cursor types * Separate the X11 bits from _Elm_Win_Smart_Data into their own substruct * Add support for using cursors in Elementary under Wayland: 2012-05-30 Rob Bradford * Add support for setting the cursor under Wayland: * Introduce a configure option and #define to as per other engines * Add always-built API function to allow identification of running under Wayland (like for X11) * Call into Ecore to set the cursor when the mouse enters the desired widget. Looking forward to hearing your review comments. Cheers, Rob 0001-Ecore_Wayland-Add-basic-support-for-setting-the-curs.patch Description: Binary data 0003-elementary-window-Add-support-for-setting-the-cursor.patch Description: Binary data 0002-elementary-window-Move-X11-related-bits-to-substruct.patch Description: Binary data 0001-elementary-cursor-Put-X-specific-datatypes-inside-a-.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Ecore_Wayland: Keyboard input patch
Attached is a patch that enhances the keyboard input a bit more and allows you to type most characters inside an elm entry. Here is the ChangeLog from the patch: 2012-06-06 Rob Bradford * Ecore_Wayland: Enhance the keyboard input handling * Associate the keymap with the input device rather than the display since you could could have different keymaps associated with different devices. * Increase the size of character arrays used for the string representations of the keyname, keysym and for the string representing the key. * Re-enable the code that converts the keysym to a printable definition - this is required where the keysym is not the same as the printable definition Cheers, Rob 0001-Ecore_Wayland-Enhance-the-keyboard-input-handling.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore/Elm: Cursors on Wayland (patches)
Here are the two patches rebased - including ChangeLog rebases. Cheers, Rob On 6 June 2012 09:42, Chris Michael wrote: > Rob, > > I have applied the first two patches (ecore & elm_win) however, the third > would not apply cleanly due to changes in elm_cursor. If you find some time, > would you mind resending the third patch after an svn update of efl ? > > Cheers, > Dh > > >> -Original Message- >> From: Bradford, Robert [mailto:robert.bradf...@intel.com] >> Sent: 30 May 2012 14:00 >> To: Enlightenment developer list >> Subject: [E-devel] Ecore/Elm: Cursors on Wayland (patches) >> >> Chris, Raster, >> >> Here are some first patches relating to supporting cursors under >> Wayland. >> >> Ecore - just the one patch - the ChangeLog entry is: >> >> 2012-05-29 Rob Bradford >> >> * Initial cursor support for Wayland: >> * Add api to the ecore_wl_input_ namespace to allow setting the >> buffer >> to use for the pointer and for loading a named cursor from a >> cursor >> theme. Under the Wayland protocol the cursor is associated with >> the >> input device. >> * Add helper functions to ecore_wl_window to set the cursor >> based on >> the active pointer input device for the window. >> * Load the cursor theme when the SHM interface is ready and >> provide an >> API call to provide a wl_cursor for a given name. >> * Add API to restore to the default cursor and then use that >> when the >> pointer enters the surface to ensure compliance with the >> Wayland >> protocol. >> >> This is initial support. It should be enhanced to support dealing with >> a different cursor theme (currently just uses the "default") cursor >> theme. Feedback on the naming and structure of the API calls is also >> welcome. >> >> Elementary - several patches i'm afraid but logically separate. The >> first two are effectively aesthetic >> >> * Separate the X11 bits from Elm_Cursor into an "x" substruct to make >> it cleaner to support multiple cursor types >> * Separate the X11 bits from _Elm_Win_Smart_Data into their own >> substruct >> * Add support for using cursors in Elementary under Wayland: >> >> >> 2012-05-30 Rob Bradford >> >> * Add support for setting the cursor under Wayland: >> * Introduce a configure option and #define to as per other >> engines >> * Add always-built API function to allow identification of >> running >> under Wayland (like for X11) >> * Call into Ecore to set the cursor when the mouse enters the >> desired >> widget. >> >> Looking forward to hearing your review comments. >> >> Cheers, >> >> Rob > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel 0001-elementary-cursor-Put-X-specific-datatypes-inside-a-.patch Description: Binary data 0002-elementary-window-Add-support-for-setting-the-cursor.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Ecore_Wayland: Update to reflect protocol change
Axis events are now wl_fixed_t. We need to convert before pushing into an Ecore event. Cheers, Rob 0001-Ecore_Wayland-Update-to-latest-protocol-axis-events-.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Ecore_Wayland: Patch to fix ticket #1031
Hi Christopher, Not all input devices are keyboards therefore don't have xkb state / keymap. We must therefore check that the state and keymap are non-NULL before freeing/unreffing the state and map. Cheers, Rob 0001-Ecore_Wayland-Check-for-xkb-state-and-map-when-freei.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Patches: Ecore_Wayland - Update to latest protocol and fix #1030
Patches are attached: commit f0a14043eb0019caa095bab235d90884bda0b168 Author: Rob Bradford Date: Fri Jun 15 17:29:33 2012 +0100 Ecore_Wayland: Drop the unused timestamp from the configure event Rationale: - The timestamp isn't used by the recipient of this internal ECORE_WL_EVENT_WINDOW_CONFIGURE event. - The configure event we receive from the compositor doesn't have a timestam - The ecore_wl_window_maximized_set and ecore_wl_window_fullscreen_set had a implicit requirement that the window had keyboard focus to retrieve a timestamp that wasn't used. This also removes that requirement. As a result the segfault in the following issue: http://trac.enlightenment.org/e/ticket/1030 commit 594ce5bff5595d6191290186f9ca406004fb1f89 Author: Rob Bradford Date: Fri Jun 15 18:04:13 2012 +0100 Ecore_Wayland: Port to updated Wayland API The cursor on the pointer is now a Wayland surface rather than a buffer. Cheers, Rob 0002-Ecore_Wayland-Drop-the-unused-timestamp-from-the-con.patch Description: Binary data 0001-Ecore_Wayland-Port-to-updated-Wayland-API.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Elm: Wayland: Fix crash when not running under X
Chris, Hope you're well. First patch in a while - i've been off on holiday and then catching up! -- If you don't have display set then you get a crash when trying to retrieve the X window. ChangeLog entry: 2012-07-10 Rob Bradford * Expose into private API a function for getting the X window from an Ecore_Evas using the backend safe functions. * Use this new API to replace a non backend safe call in the copy and paste code Cheers, Rob 0001-Elm-wayland-Expose-and-use-a-backend-safe-call-for-g.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
