Re: [E-devel] [PATCH] evas: hide the evas object after it's smart object deleted.
On Friday, August 10, 2012, Christopher Michael wrote: On 08/10/2012 09:55 AM, Carsten Haitzler (The Rasterman) wrote: > On Fri, 10 Aug 2012 07:53:07 +0100 Christopher Michael > > said: > >> On 08/10/2012 03:25 AM, wuzhiwen wrote: >>> >>> -Original Message- From: Gustavo Sverzut Barbieri [mailto:barbi...@profusion.mobi] Sent: Thursday, August 09, 2012 8:53 PM To: Enlightenment developer list Cc: eduardo.de.barros.l...@intel.com Subject: Re: [E-devel] [PATCH] evas: hide the evas object after it's smart >>> object deleted. On Thursday, August 9, 2012, Alex Wu wrote: > Hi, > This patch fix the bug http://trac.enlightenment.org/e/ticket/1308 > > The root cause of this bug is that when closing the window, the glview > widget need to invoke eng_gl_make_current() before calling it's > del_func. In eng_gl_make_current(), the re->win->egl_display make the > segfualt. It is because re->win has been nullized by > evas_object_hide()<--evas_object_del()<--evas_object_unref()<-- > _elm_win_frame_cb_close() which is triggered by clicking the "close" > button. > > I think it is resonable to destroy the re->win of a elm_win after all > smart data deleted. Although the patch does not look problematic per se, it fixes an egl bug in >>> a generic code? That do not seem right. Why don't you hande this condition in >>> egl engine? >>> I think this issue is not only for engine using egl, but for all the cases >>> using re->win after it is hid. >>> >> >> For once I would agree with Gustavo on this one. I do not see this > > OMG! agreeing with gustavo... Noo! > Hahaha, I know right ? Should probably write this on my calendar so I can remember the day it happened ;) >> problem when using the opengl_x11 engine which makes me think that it is >> indeed engine specific and that the patch would need to be changed for >> the specific engine, not in a generic way. > > i will have to agree with you (not gustavo though :) ) - this is an engine LOL ;) We often agree on TECHNICAL details. If it was source code style, language preference, git, Elementary API, Enlightenment features, themes or release plan... then they are subjective and we'll always disagree :-) > issue - not to be solved by workarounds that create implicit side-effects that > HAPPEN to plug the bug. :) > Indeed, indeed. dh >> dh >> > > Patch attached. > > > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 --- -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: kakaroto IN trunk/GAMES/eskiss: . src/bin
To disable cursor we can just use standard ecore_evas and set a
transparent rectangle. But really, it is so common we could add it in
ecore_evas itself
--Gustavo
Sent from my iPhone
On 07/09/2011, at 03:59, Enlightenment SVN wrote:
> Log:
> Eskiss: Disable forced dependency on ecore-x
>
> Author: kakaroto
> Date: 2011-09-06 23:58:54 -0700 (Tue, 06 Sep 2011)
> New Revision: 63257
> Trac: http://trac.enlightenment.org/e/changeset/63257
>
> Modified:
> trunk/GAMES/eskiss/configure.ac trunk/GAMES/eskiss/src/bin/main.c
>
> Modified: trunk/GAMES/eskiss/configure.ac
> ===
> --- trunk/GAMES/eskiss/configure.ac2011-09-07 06:58:48 UTC (rev 63256)
> +++ trunk/GAMES/eskiss/configure.ac2011-09-07 06:58:54 UTC (rev 63257)
> @@ -54,8 +54,14 @@
>
> # Eina library
>
> -PKG_CHECK_MODULES(ESKISS, [edje ecore-evas ecore-x ecore-file ecore evas eet
> eina])
> +PKG_CHECK_MODULES(ESKISS, [edje ecore-evas ecore-file ecore evas eet eina])
> +PKG_CHECK_MODULES(ECORE_X, [ecore-x], [have_ecore_x="yes"],
> [have_ecore_x="no"])
>
> +AM_CONDITIONAL(HAVE_ECORE_X, test "x$have_ecore_x" = "xyes")
> +if test "x$have_ecore_x" = "xyes"; then
> + AC_DEFINE(HAVE_ECORE_X, 1, [Ecore-x available])
> +fi
> +
> ### Checks for header files
>
> AC_CHECK_HEADER([chipmunk/chipmunk.h],
>
> Modified: trunk/GAMES/eskiss/src/bin/main.c
> ===
> --- trunk/GAMES/eskiss/src/bin/main.c2011-09-07 06:58:48 UTC (rev 63256)
> +++ trunk/GAMES/eskiss/src/bin/main.c2011-09-07 06:58:54 UTC (rev 63257)
> @@ -24,7 +24,10 @@
> #include "level.h"
> #include "level_editor.h"
> #include "level_chooser.h"
> +
> +#ifdef HAVE_ECORE_X
> #include
> +#endif
>
> int _drawin_log_domain = -1;
>
> @@ -311,11 +314,13 @@
> if (is_fullscreen)
> ecore_evas_fullscreen_set(application->ee, EINA_TRUE);
>
> +#ifdef HAVE_ECORE_X
> if (!has_cursor &&
> !strcmp(ecore_evas_engine_name_get(application->ee), "software_x11"))
> {
> Ecore_X_Window ewin =
> ecore_evas_software_x11_window_get(application->ee);
> ecore_x_window_cursor_show(ewin, 0);
> }
> +#endif
>
> ecore_evas_show(application->ee);
>
>
>
> --
> Using storage to extend the benefits of virtualization and iSCSI
> Virtualization increases hardware utilization and delivers a new level of
> agility. Learn what those decisions are and how to modernize your storage
> and backup environments for virtualization.
> http://www.accelacomm.com/jaw/sfnl/114/51434361/
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e_dbus/src/lib/connman
What's the error message?
--Gustavo
Sent from my iPhone
On 07/09/2011, at 02:45, Enlightenment SVN wrote:
> Log:
> no, really. stfu connman.
>
>
> Author: discomfitor
> Date: 2011-09-06 22:45:03 -0700 (Tue, 06 Sep 2011)
> New Revision: 63244
> Trac: http://trac.enlightenment.org/e/changeset/63244
>
> Modified:
> trunk/e_dbus/src/lib/connman/e_connman_private.h
>
> Modified: trunk/e_dbus/src/lib/connman/e_connman_private.h
> ===
> --- trunk/e_dbus/src/lib/connman/e_connman_private.h2011-09-07 05:38:40
> UTC (rev 63243)
> +++ trunk/e_dbus/src/lib/connman/e_connman_private.h2011-09-07 05:45:03
> UTC (rev 63244)
> @@ -96,7 +96,9 @@
> {
>if (!msg)
> {
> -if (err && (err->name[0] != 'C'))
> +if (err && (err->name[0] == 'C'))
> + return EINA_FALSE;
> +if (err)
>ERR("an error was reported by server: "
>"name=\"%s\", message=\"%s\"",
>err->name, err->message);
>
>
> --
> Using storage to extend the benefits of virtualization and iSCSI
> Virtualization increases hardware utilization and delivers a new level of
> agility. Learn what those decisions are and how to modernize your storage
> and backup environments for virtualization.
> http://www.accelacomm.com/jaw/sfnl/114/51434361/
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e_dbus/src/lib/connman
What's the error?
Never noticed it :-/
--Gustavo
Sent from my iPhone
On 07/09/2011, at 02:24, Enlightenment SVN wrote:
> Log:
> this shit has got to stop. tired of my logs being full of 10gb of this.
>
>
> Author: discomfitor
> Date: 2011-09-06 22:23:07 -0700 (Tue, 06 Sep 2011)
> New Revision: 63242
> Trac: http://trac.enlightenment.org/e/changeset/63242
>
> Modified:
> trunk/e_dbus/src/lib/connman/e_connman_private.h
>
> Modified: trunk/e_dbus/src/lib/connman/e_connman_private.h
> ===
> --- trunk/e_dbus/src/lib/connman/e_connman_private.h2011-09-07 03:54:58
> UTC (rev 63241)
> +++ trunk/e_dbus/src/lib/connman/e_connman_private.h2011-09-07 05:23:07
> UTC (rev 63242)
> @@ -96,7 +96,7 @@
> {
>if (!msg)
> {
> -if (err)
> +if (err && (err->name[0] != 'C'))
>ERR("an error was reported by server: "
>"name=\"%s\", message=\"%s\"",
>err->name, err->message);
>
>
> --
> Using storage to extend the benefits of virtualization and iSCSI
> Virtualization increases hardware utilization and delivers a new level of
> agility. Learn what those decisions are and how to modernize your storage
> and backup environments for virtualization.
> http://www.accelacomm.com/jaw/sfnl/114/51434361/
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Entry "changed, user" additional information - request for opinion
Custom or smart callbacks for me. I'd go with smart and change these alien new callbacks that raster introduced to smart callbacks unless they are in the "single hook" class that sometimes is required (limits to one implementation/provider, in hot paths or in need for complex parameters) Sent from my iPad On 30/08/2011, at 12:26, Tom Hacohen wrote: > Hey everyone, > > As part my effort of improving entry, I started implementing undo/redo > support. I guess there are several ways of doing it, therefore I'd like > to hear what you guys think about the solutions in general, and the one > I chose in particular. > > Before I start, there's one important thing to remember: Elm_Entry > interacts with textblock through edje_entry. Edje_entry's callbacks > aren't "smart callbacks" but are edje signals instead, which means they > aren't called immediately. Edje signals are inserted into the edje queue > with additional information, which means all the data passed with them > has to be allocated on the heap and stored. Also, because it's not > possible to know in advance when a signal will be called, querying the > issuing object upon calling the callback is also not possible, as it may > have changed in the meanwhile. > > This means I have to do one of the following: either I add smart > callbacks to edje (or custom ones like is done with text_filter) which > means I don't have to allocate anything on the heap, and if I do, it's > very contained and will only happen if a callback will actually be > called. The worst thing about this method is probably that it breaks > order of callbacks, as those will be called before signals emitted. The > other alternative is what I currently implemented: I added a way to pass > additional information to c callbacks listening to signals ( (added a > function: edje_object_signal_callback_extra_data_get(void)). > > I really don't know which one is better. I prefer using smart callbacks, > but there are many drawbacks. As for the additional data with signals: > there won't be many allocations because "changed,user" is only called on > user changes, which are very limited anyway. > > So, what do you guys think I should do? > > Thanks, > Tom. > > -- > Special Offer -- Download ArcSight Logger for FREE! > Finally, a world-class log management solution at an even better > price-free! And you'll get a free "Love Thy Logs" t-shirt when you > download Logger. Secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsisghtdev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: barbieri trunk/edje/src/lib
Likely it was wrong and happened to work due wrong collateral effects. --Gustavo Sent from my iPhone On 28/08/2011, at 03:01, Mike Blumenkrantz wrote: > On Sat, 20 Aug 2011 18:38:17 -0700 > "Enlightenment SVN" wrote: > >> Log: >> change text's single recalc to use apply version. >> >> Original _edje_part_recalc_single_text() was not working as >> expected since it was not doing size fit, range, ellipsis and so >> on. >> >> The purpose of this function compared with >> _edje_text_recalc_apply() is to be faster, not calling Evas update >> functions. However for text this is quite difficult given that to >> fit we need to set the font, size, style, etc. If it was done >> correctly, we'd save some calls to move and some color sets, >> however those shouldn't matter much in the overall picture. >> >> I've changed this to force applying the value, it should be more >> correct and not so slow. The previous code is kept below for >> reference but should be removed before next release! >> >> >> >> >> Author: barbieri >> Date: 2011-08-20 18:38:17 -0700 (Sat, 20 Aug 2011) >> New Revision: 62640 >> Trac: http://trac.enlightenment.org/e/changeset/62640 >> >> Modified: >> trunk/edje/src/lib/edje_calc.c >> > this commit totally breaks the text in my theme and I don't know why. > > -- > Mike Blumenkrantz > Zentific: Coding in binary since '10. > > -- > EMC VNX: the world's simplest storage, starting under $10K > The only unified storage solution that offers unified management > Up to 160% more powerful than alternatives and 25% more efficient. > Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
Zero parameters before checking otherwise it will not touch them and
on failure caller will get garbage
--Gustavo
Sent from my iPhone
On 29/08/2011, at 08:40, Enlightenment SVN wrote:
> Log:
> dont need ti check priv - macro did it anyway
>
>
>
> Author: raster
> Date: 2011-08-29 04:39:43 -0700 (Mon, 29 Aug 2011)
> New Revision: 62941
> Trac: http://trac.enlightenment.org/e/changeset/62941
>
> Modified:
> trunk/evas/src/lib/canvas/evas_object_grid.c
>
> Modified: trunk/evas/src/lib/canvas/evas_object_grid.c
> ===
> --- trunk/evas/src/lib/canvas/evas_object_grid.c2011-08-29 11:28:43 UTC
> (rev 62940)
> +++ trunk/evas/src/lib/canvas/evas_object_grid.c2011-08-29 11:39:43 UTC
> (rev 62941)
> @@ -267,16 +267,8 @@
> evas_object_grid_size_get(const Evas_Object *o, int *w, int *h)
> {
>EVAS_OBJECT_GRID_DATA_GET_OR_RETURN(o, priv);
> - if (priv)
> - {
> -if (w) *w = priv->size.w;
> -if (h) *h = priv->size.h;
> - }
> - else
> - {
> -if (w) *w = 0;
> -if (h) *h = 0;
> - }
> + if (w) *w = priv->size.w;
> + if (h) *h = priv->size.h;
> }
>
> EAPI Eina_Bool
>
>
> --
> EMC VNX: the world's simplest storage, starting under $10K
> The only unified storage solution that offers unified management
> Up to 160% more powerful than alternatives and 25% more efficient.
> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/elementary/src/lib
Went bad? But evas_object_data_get() should be safe with it using magic numbers. --Gustavo Sent from my iPhone On 29/08/2011, at 08:36, Tom Hacohen wrote: > On 29/08/11 14:32, Gustavo Barbieri wrote: >> Hey Tasn, need to check but before there were no limits that the >> tooltip must be on an elm object. It could be an edje or a single >> rectangle. All it should use are mouse events. >> >> --Gustavo >> >> Sent from my iPhone > > Ah. I'm sorry then, will revert, my bad. Added it because a colleague of mine > tried to shove an Eina_List in there and he couldn't understand what went > wrong, but I guess my checks are bad. > > Thanks for the notice, > Tom. -- EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/elementary/src/lib
Hey Tasn, need to check but before there were no limits that the
tooltip must be on an elm object. It could be an edje or a single
rectangle. All it should use are mouse events.
--Gustavo
Sent from my iPhone
On 28/08/2011, at 11:13, Enlightenment SVN wrote:
> Log:
> Elm tooltip: Added checks if the object passed is an elm object.
>
> Author: tasn
> Date: 2011-08-28 07:12:38 -0700 (Sun, 28 Aug 2011)
> New Revision: 62919
> Trac: http://trac.enlightenment.org/e/changeset/62919
>
> Modified:
> trunk/elementary/src/lib/elm_widget.c trunk/elementary/src/lib/elm_widget.h
> trunk/elementary/src/lib/els_tooltip.c
>
> Modified: trunk/elementary/src/lib/elm_widget.c
> ===
> --- trunk/elementary/src/lib/elm_widget.c2011-08-28 13:28:12 UTC (rev
> 62918)
> +++ trunk/elementary/src/lib/elm_widget.c2011-08-28 14:12:38 UTC (rev
> 62919)
> @@ -2398,6 +2398,23 @@
> }
>
> EAPI Eina_Bool
> +elm_widget_is_check(const Evas_Object *obj)
> +{
> + static int abort_on_warn = -1;
> + if (elm_widget_is(obj))
> + return EINA_TRUE;
> +
> + ERR("Passing Object: %p.", obj);
> + if (abort_on_warn == -1)
> + {
> +if (getenv("ELM_ERROR_ABORT")) abort_on_warn = 1;
> +else abort_on_warn = 0;
> + }
> + if (abort_on_warn == 1) abort();
> + return EINA_FALSE;
> +}
> +
> +EAPI Eina_Bool
> elm_widget_type_check(const Evas_Object *obj,
> const char*type)
> {
>
> Modified: trunk/elementary/src/lib/elm_widget.h
> ===
> --- trunk/elementary/src/lib/elm_widget.h2011-08-28 13:28:12 UTC (rev
> 62918)
> +++ trunk/elementary/src/lib/elm_widget.h2011-08-28 14:12:38 UTC (rev
> 62919)
> @@ -400,6 +400,7 @@
> EAPI Eina_Boolelm_widget_theme_object_set(Evas_Object *obj,
> Evas_Object *edj, const char *wname, const char *welement, const char
> *wstyle);
> EAPI void elm_widget_type_register(const char **ptr);
> EAPI void elm_widget_type_unregister(const char **ptr);
> +EAPI Eina_Boolelm_widget_is_check(const Evas_Object *obj);
> EAPI Eina_Boolelm_widget_type_check(const Evas_Object *obj, const
> char *type);
> EAPI Eina_List *elm_widget_stringlist_get(const char *str);
> EAPI void elm_widget_stringlist_free(Eina_List *list);
> @@ -671,6 +672,9 @@
> } \
>} while (0)
>
> +#define ELM_CHECK_WID_IS(obj) \
> + if (!elm_widget_is_check(obj)) return
> +
> #define ELM_CHECK_WIDTYPE(obj, widtype) \
>if (!elm_widget_type_check((obj), (widtype))) return
>
>
> Modified: trunk/elementary/src/lib/els_tooltip.c
> ===
> --- trunk/elementary/src/lib/els_tooltip.c2011-08-28 13:28:12 UTC (rev
> 62918)
> +++ trunk/elementary/src/lib/els_tooltip.c2011-08-28 14:12:38 UTC (rev
> 62919)
> @@ -717,6 +717,7 @@
> EAPI void
> elm_object_tooltip_show(Evas_Object *obj)
> {
> + ELM_CHECK_WID_IS(obj);
>ELM_TOOLTIP_GET_OR_RETURN(tt, obj);
>tt->visible_lock = EINA_TRUE;
>_elm_tooltip_show(tt);
> @@ -734,6 +735,7 @@
> EAPI void
> elm_object_tooltip_hide(Evas_Object *obj)
> {
> + ELM_CHECK_WID_IS(obj);
>ELM_TOOLTIP_GET_OR_RETURN(tt, obj);
>tt->visible_lock = EINA_FALSE;
>_elm_tooltip_hide_anim_start(tt);
> @@ -754,6 +756,7 @@
> EAPI void
> elm_object_tooltip_text_set(Evas_Object *obj, const char *text)
> {
> + ELM_CHECK_WID_IS(obj);
>EINA_SAFETY_ON_NULL_RETURN(obj);
>EINA_SAFETY_ON_NULL_RETURN(text);
>
> @@ -785,6 +788,7 @@
> EAPI void
> elm_object_tooltip_content_cb_set(Evas_Object *obj, Elm_Tooltip_Content_Cb
> func, const void *data, Evas_Smart_Cb del_cb)
> {
> + ELM_CHECK_WID_IS(obj);
>elm_object_sub_tooltip_content_cb_set(obj, obj, func, data, del_cb);
> }
>
> @@ -804,6 +808,7 @@
> EAPI void
> elm_object_tooltip_unset(Evas_Object *obj)
> {
> + ELM_CHECK_WID_IS(obj);
>ELM_TOOLTIP_GET_OR_RETURN(tt, obj);
>_elm_tooltip_unset(tt);
> }
> @@ -821,6 +826,7 @@
> EAPI void
> elm_object_tooltip_style_set(Evas_Object *obj, const char *style)
> {
> + ELM_CHECK_WID_IS(obj);
>ELM_TOOLTIP_GET_OR_RETURN(tt, obj);
>if (!eina_stringshare_replace(&tt->style, style)) return;
>elm_tooltip_theme(tt);
> @@ -836,6 +842,7 @@
> EAPI const char *
> elm_object_tooltip_style_get(const Evas_Object *obj)
> {
> + ELM_CHECK_WID_IS(obj);
>ELM_TOOLTIP_GET_OR_RETURN(tt, obj, NULL);
>return tt->style ? tt->style : "default";
> }
> @@ -883,6 +890,7 @@
> EAPI Eina_Bool
> elm_tooltip_size_restrict_disable(Evas_Object *obj, Eina_Bool disable)
> {
> + ELM_CHECK_WID_IS(obj);
>ELM_TOOLTIP_GET_OR_RETURN(tt, obj, EINA_FALSE);
>return tt->free_size = disable;
> }
> @@ -899,6 +907,7 @@
> EAPI Eina_Bool
> elm_tooltip_size_restrict_disabled_get(const Evas_Object *obj)
> {
> + ELM_CHECK_WID_IS(obj);
>ELM_TOOLTIP_GET_OR_RETURN(tt, obj, EINA_FALSE);
>
Re: [E-devel] e_dbus safety checks
Yeah, just missing. Commit to svn please! --Gustavo Sent from my iPhone On 26/08/2011, at 18:42, Mike Blumenkrantz wrote: > On Fri, 26 Aug 2011 23:26:18 +0200 > Leif Middelschulte wrote: > >> Hi all, >> >> by trying out shotgun I found two possible segvs in e_dbus. >> >> I don't know whether the checks are omitted for performance reasons, >> but I created a patch anyway. >> >> > these functions are from the days before null checks were invented > > -- > Mike Blumenkrantz > Zentific: Coding in binary since '10. > > -- > EMC VNX: the world's simplest storage, starting under $10K > The only unified storage solution that offers unified management > Up to 160% more powerful than alternatives and 25% more efficient. > Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/enjoy/src/bin
Leandro, check e17 or ecore itself, some of used approach is not
common. Nitpicking review follows:
1- events are EAPI extern int ENJOY_SOMENAME. We don't export symbols
yet, so just define an EAPI and these symbols inside a new
Enjoy_Plugins.h, see other public headers
2- avoid no_free, just do it if your sending <=sizeof(void*) info into
the pointer itself
3-watch out missing static for globals and functions. No_free miss it
4-add "enjoy_" or "ejy_" namespace everywhere. Enum, typedef,
struct... All missing it now
5-efl name scheme is action at the end. The opposite of webkit you are
used to ;) CAN_SEEK -> ENJOY_CAP_SEEKABLE
6- avoid int array if elements have attached meaning. Use structs
instead. Define them in the public header
Sorry about bring picky here. You did an excellent work so far, keep
the motivation up! Need more great hackers as you to get enjoy to
decent state :-)
--Gustavo
Sent from my iPhone
On 26/08/2011, at 16:24, Enlightenment SVN wrote:
> Log:
> enjoy: Move track list/player events to Ecore_Event.
>
> This is to prepare to move MPRIS stuff to a plugin later.
>
> Author: acidx
> Date: 2011-08-26 12:24:05 -0700 (Fri, 26 Aug 2011)
> New Revision: 62876
> Trac: http://trac.enlightenment.org/e/changeset/62876
>
> Modified:
> trunk/enjoy/src/bin/main.c trunk/enjoy/src/bin/mpris.c
> trunk/enjoy/src/bin/mpris.h trunk/enjoy/src/bin/page.c
> trunk/enjoy/src/bin/private.h trunk/enjoy/src/bin/win.c
>
> Modified: trunk/enjoy/src/bin/main.c
> ===
> --- trunk/enjoy/src/bin/main.c2011-08-26 19:20:05 UTC (rev 62875)
> +++ trunk/enjoy/src/bin/main.c2011-08-26 19:24:05 UTC (rev 62876)
> @@ -85,6 +85,34 @@
>return cache;
> }
>
> +void
> +no_free()
> +{
> +}
> +
> +int
> +enjoy_event_id_get(Event_ID event_id)
> +{
> + switch (event_id)
> + {
> + case ENJOY_EVENT_PLAYER_CAPS_CHANGE: return
> app.event_id.player.caps_change;
> + case ENJOY_EVENT_PLAYER_STATUS_CHANGE: return
> app.event_id.player.status_change;
> + case ENJOY_EVENT_PLAYER_TRACK_CHANGE: return
> app.event_id.player.track_change;
> + case ENJOY_EVENT_TRACKLIST_TRACKLIST_CHANGE: return
> app.event_id.tracklist.tracklist_change;
> + }
> + return -1;
> +}
> +
> +static void
> +enjoy_event_id_init()
> +{
> + ecore_init();
> + app.event_id.player.caps_change = ecore_event_type_new();
> + app.event_id.player.status_change = ecore_event_type_new();
> + app.event_id.player.track_change = ecore_event_type_new();
> + app.event_id.tracklist.tracklist_change = ecore_event_type_new();
> +}
> +
> EAPI int
> elm_main(int argc, char **argv)
> {
> @@ -156,7 +184,8 @@
>fso_init();
>fso_request_resource("CPU");
> #endif
> -
> +
> + enjoy_event_id_init();
>mpris_init();
>cover_init();
>elm_run();
>
> Modified: trunk/enjoy/src/bin/mpris.c
> ===
> --- trunk/enjoy/src/bin/mpris.c2011-08-26 19:20:05 UTC (rev 62875)
> +++ trunk/enjoy/src/bin/mpris.c2011-08-26 19:24:05 UTC (rev 62876)
> @@ -12,6 +12,12 @@
> #define PLAYER_NAME "/Player"
>
>
> +static void _mpris_signal_player_caps_change(int caps);
> +static void _mpris_signal_player_status_change(int playback, int shuffle,
> int repeat, int endless);
> +static void _mpris_signal_player_track_change(Song *song);
> +static void _mpris_signal_tracklist_tracklist_change(int size);
> +
> +static void _mpris_signal_emit(const char *root, const char *signal_name,
> int arg_type, void *arg_value);
> static void _mpris_signals_add(const char *root, const MPRIS_Signal *signals);
> static void _mpris_methods_add(const char *root, const MPRIS_Method *methods);
> static void _mpris_append_dict_entry(DBusMessageIter *dict_iter, const char
> *key,
> @@ -133,7 +139,40 @@
> };
>
>
> +static Ecore_Event_Handler *_event_handler_caps_change,
> + *_event_handler_status_change,
> + *_event_handler_track_change,
> + *_event_handler_tracklist_change;
>
> +static Eina_Bool
> +_cb_player_caps_change(void *data __UNUSED__, int type __UNUSED__, void
> *event)
> +{
> + _mpris_signal_player_caps_change(*(int *)event);
> + return ECORE_CALLBACK_PASS_ON;
> +}
> +
> +static Eina_Bool
> +_cb_player_status_change(void *data __UNUSED__, int type __UNUSED__, void
> *event)
> +{
> + int *new_status = event;
> + _mpris_signal_player_status_change(new_status[0], new_status[1],
> new_status[2], new_status[3]);
> + return ECORE_CALLBACK_PASS_ON;
> +}
> +
> +static Eina_Bool
> +_cb_player_track_change(void *data __UNUSED__, int type __UNUSED__, void
> *event)
> +{
> + _mpris_signal_player_track_change((Song *)event);
> + return ECORE_CALLBACK_PASS_ON;
> +}
> +
> +static Eina_Bool
> +_cb_player_tracklist_change(void *data __UNUSED__, int type __UNUSED__, void
> *event)
> +{
> + _mpris_signal_tracklist_tracklist_change(*(int *)event);
> + return ECORE_CALLBACK_PAS
Re: [E-devel] E SVN: discomfitor IN trunk/e/src/modules: bluez connman
Ugh! Just change the pointer prototype to get const char* instead. It
makes everything more clear
--Gustavo
Sent from my iPhone
On 26/08/2011, at 14:19, Enlightenment SVN wrote:
> Log:
> more warnings
>
>
> Author: discomfitor
> Date: 2011-08-26 10:19:17 -0700 (Fri, 26 Aug 2011)
> New Revision: 62866
> Trac: http://trac.enlightenment.org/e/changeset/62866
>
> Modified:
> trunk/e/src/modules/bluez/e_mod_main.c
> trunk/e/src/modules/connman/e_mod_main.c
>
> Modified: trunk/e/src/modules/bluez/e_mod_main.c
> ===
> --- trunk/e/src/modules/bluez/e_mod_main.c2011-08-26 17:18:53 UTC (rev
> 62865)
> +++ trunk/e/src/modules/bluez/e_mod_main.c2011-08-26 17:19:17 UTC (rev
> 62866)
> @@ -1069,7 +1069,7 @@
> static char *
> _gc_label(E_Gadcon_Client_Class *client_class __UNUSED__)
> {
> - return _(_e_bluez_Name);
> + return (char*)_(_e_bluez_Name);
> }
>
> static Evas_Object *
>
> Modified: trunk/e/src/modules/connman/e_mod_main.c
> ===
> --- trunk/e/src/modules/connman/e_mod_main.c2011-08-26 17:18:53 UTC (rev
> 62865)
> +++ trunk/e/src/modules/connman/e_mod_main.c2011-08-26 17:19:17 UTC (rev
> 62866)
> @@ -1651,7 +1651,7 @@
> static char *
> _gc_label(E_Gadcon_Client_Class *client_class __UNUSED__)
> {
> - return _(_e_connman_Name);
> + return (char*)_(_e_connman_Name);
> }
>
> static Evas_Object *
>
>
> --
> EMC VNX: the world's simplest storage, starting under $10K
> The only unified storage solution that offers unified management
> Up to 160% more powerful than alternatives and 25% more efficient.
> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric IN trunk/edje: . src/bin src/lib
This should be useful to implement the date thing in clock as I did in
detorious!
Sent from my iPhone
On 22/08/2011, at 18:45, "Enlightenment SVN" wrote:
> Log:
> edje: add collection.group.limits.vertical and
> collection.group.limits.horizontal.
>
> The goal is to provide an easy way to do the kind of effect you see in that
> video
> around 00:36 : http://www.youtube.com/watch?v=KVoVLHh8CHc.
>At that time it was really difficult to do such thing and required a lot of
> embryo code, we designed limit with Billiob to be able to do such kind of
> things
> much more easily.
>
> NOTE: so Billiob, now nothing stop you from releasing amsn2 ! ;-)
>
>
> Author: cedric
> Date: 2011-08-22 14:44:49 -0700 (Mon, 22 Aug 2011)
> New Revision: 62701
> Trac: http://trac.enlightenment.org/e/changeset/62701
>
> Modified:
> trunk/edje/ChangeLog trunk/edje/src/bin/edje_cc_handlers.c
> trunk/edje/src/lib/edje_data.c trunk/edje/src/lib/edje_private.h
> trunk/edje/src/lib/edje_smart.c
>
> Modified: trunk/edje/ChangeLog
> ===
> --- trunk/edje/ChangeLog2011-08-22 21:40:31 UTC (rev 62700)
> +++ trunk/edje/ChangeLog2011-08-22 21:44:49 UTC (rev 62701)
> @@ -135,7 +135,7 @@
> * Add entry,selection,all,request for signalling ctrl+a in an entry
> * Add entry,selection,none,request for signalling ctrl+shift+a in an
> entry
> * Fix entry,paste,request* to be emitted after cursor,changed (fixes
> middle mouse paste location)
> -
> +
> 2011-05-27 Carsten Haitzler (The Rasterman)
>
>* Fix edje_shutdown() being called before all evas objects created
> @@ -146,3 +146,10 @@
>
>* Entry: Added changed,user signal. This signal indicates the entry
>has changed because of user interaction, i.e not by code.
> +
> +2011-08-22 Cedric Bail
> +
> +* Add collection.group.limits {
> + vertical: "name" value;
> + horizontal: "name" value;
> + }.
>
> Modified: trunk/edje/src/bin/edje_cc_handlers.c
> ===
> --- trunk/edje/src/bin/edje_cc_handlers.c2011-08-22 21:40:31 UTC (rev
> 62700)
> +++ trunk/edje/src/bin/edje_cc_handlers.c2011-08-22 21:44:49 UTC (rev
> 62701)
> @@ -104,6 +104,9 @@
> static void st_collections_group_data_item(void);
> static void st_collections_group_orientation(void);
>
> +static void st_collections_group_limits_vertical(void);
> +static void st_collections_group_limits_horizontal(void);
> +
> static void ob_collections_group_script(void);
> static void ob_collections_group_lua_script(void);
>
> @@ -296,6 +299,8 @@
> {"collections.group.max", st_collections_group_max},
> {"collections.group.orientation", st_collections_group_orientation},
> {"collections.group.data.item", st_collections_group_data_item},
> + {"collections.group.limits.horizontal",
> st_collections_group_limits_horizontal},
> + {"collections.group.limits.vertical",
> st_collections_group_limits_vertical},
> {"collections.group.externals.external", st_externals_external}, /* dup
> */
> {"collections.group.image", st_images_image}, /* dup */
> {"collections.group.set.name", st_images_set_name},
> @@ -2062,6 +2067,92 @@
>
> /**
> @page edcref
> +@property
> +group {
> +limits {
> +vertical: "limit_name" height_barrier;
> +..
> +}
> +}
> +@parameters
> + [name] [height barrier]
> +@effect
> +This defines when to trigger some even when the Edje object is
> resized.
> +It will send a signal: "limit,name,over" when the object is resized and
> pass
> +the limit by growing over it. And it will send: "limit,name,below" when
> +it pass below that limit.
> +@endproperty
> +*/
> +static void
> +st_collections_group_limits_vertical(void)
> +{
> + Edje_Part_Collection *pc;
> + Edje_Limit *el;
> +
> + check_arg_count(2);
> +
> + el = mem_alloc(SZ(Edje_Limit));
> +
> + pc = eina_list_data_get(eina_list_last(edje_collections));
> + pc->limits.vertical_count++;
> + pc->limits.vertical = realloc(pc->limits.vertical,
> pc->limits.vertical_count * sizeof (Edje_Limit *));
> + if (!pc->limits.vertical || el)
> + {
> +ERR("%s: Error. Not enough memory.", progname);
> +exit(-1);
> + }
> +
> + pc->limits.vertical[pc->limits.vertical_count - 1] = el;
> +
> + el->name = parse_str(0);
> + el->value = parse_int_range(1, 1, 0x);
> +}
> +
> +/**
> +@page edcref
> +@property
> +group {
> +limits {
> +horizontal: "limit_name" width_barrier;
> +..
> +}
> +}
> +@parameters
> + [name] [width barrier]
> +@effect
> +This defines when to trigger some signal when the Edje object is
> resized.
> +It will send a signal: "limit,name,over" when the object is resized and
> pass
> +the li
Re: [E-devel] E SVN: barbieri trunk/THEMES/detourious/bits
It's new stuff I've added and he got the theme without updating the C module :-) provides a "today" line below the clock in detourious, uses strftime but the theme placeholder is "Tod, 12/30/2011". Funny that people noticed Tod (today abbreviation) but not 30-December ;-) Sent from my iPhone On 18/08/2011, at 03:12, Carsten Haitzler (The Rasterman) wrote: > On Thu, 18 Aug 2011 01:21:31 +0200 Nicolas Aguirre > said: > >> 2011/8/17 Enlightenment SVN : >>> Log: >>> THEME/detorious: better calendar and clock. >>> >>> clock will now show date if there is space. >>> >>> calendar is simple and beautiful. >> >> It looks really good ! >> But the day in the date doesn't have the right locale. It should be >> Jeu (for Jeudi in French) instead of Tod or at least display it in >> english ? >> >> http://www.deco-crea.com/files/2011-08-18-011724_1680x1050_scrot.png >> >> Regards, > > the code as i read it is using strftime which should respect locale. did > someone fix/change this? > > -- > - Codito, ergo sum - "I code, therefore I am" -- > The Rasterman (Carsten Haitzler)ras...@rasterman.com > > > -- > Get a FREE DOWNLOAD! and learn more about uberSVN rich system, > user administration capabilities and model configuration. Take > the hassle out of deploying and managing Subversion and the > tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/THEMES/detour-elm
There is an elm inside THEMES/detorious, use it instead ;-) Sent from my iPhone On 17/08/2011, at 23:25, Enlightenment SVN wrote: > Log: > make makefile... work > > > > Author: raster > Date: 2011-08-17 19:24:41 -0700 (Wed, 17 Aug 2011) > New Revision: 62545 > Trac: http://trac.enlightenment.org/e/changeset/62545 > > Modified: > trunk/THEMES/detour-elm/Makefile > > Modified: trunk/THEMES/detour-elm/Makefile > === > --- trunk/THEMES/detour-elm/Makefile2011-08-17 20:15:02 UTC (rev 62544) > +++ trunk/THEMES/detour-elm/Makefile2011-08-18 02:24:41 UTC (rev 62545) > @@ -18,14 +18,14 @@ > > .SILENT : > > -all: version clean build install > +all: version clean detour-elm.edj > > clean: >@echo >@echo "Checking..." >if [ -e $(OUT) ]; then $(RM) $(OUT); fi > > -build: main.edc > +detour-elm.edj: main.edc >@echo "Running make..." >$(COMPILE) $(SRC) -o $(OUT) > > > > -- > Get a FREE DOWNLOAD! and learn more about uberSVN rich system, > user administration capabilities and model configuration. Take > the hassle out of deploying and managing Subversion and the > tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: barbieri trunk/THEMES/detourious/bits
Did not touch (neither have plans to) analog clock, be my guest. It should be simple, copy it from e17 default.edc and replace images. I plan to do battery, mixer and connman soon. Sent from my iPad On 17/08/2011, at 21:57, Mark Dickie wrote: > On 17 August 2011 18:21, Nicolas Aguirre wrote: >> 2011/8/17 Enlightenment SVN : >>> Log: >>> THEME/detorious: better calendar and clock. >>> >>> clock will now show date if there is space. >>> >>> calendar is simple and beautiful. >> >> It looks really good ! >> But the day in the date doesn't have the right locale. It should be >> Jeu (for Jeudi in French) instead of Tod or at least display it in >> english ? >> >> http://www.deco-crea.com/files/2011-08-18-011724_1680x1050_scrot.png >> >> Regards, >> -- >> Nicolas Aguirre >> Mail: aguirre.nico...@gmail.com >> Web: http://enna.geexbox.org >> Blog: http://dev.enlightenment.fr/~captainigloo/ >> >> -- >> Get a FREE DOWNLOAD! and learn more about uberSVN rich system, >> user administration capabilities and model configuration. Take >> the hassle out of deploying and managing Subversion and the >> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > Much slicker! very nice. > Tiny bug though which still exists. When you untick seconds in the > analogue clock the hand still ticks away. > > Thanks > > -- > Mark Dickie > > > Email blaeberr...@gmail.com > Skype blaeberries > > -- > Get a FREE DOWNLOAD! and learn more about uberSVN rich system, > user administration capabilities and model configuration. Take > the hassle out of deploying and managing Subversion and the > tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: barbieri trunk/THEMES/detourious/bits
Update e17 clock module (c code) Sent from my iPad On 17/08/2011, at 20:24, Nicolas Aguirre wrote: > 2011/8/17 Enlightenment SVN : >> Log: >> THEME/detorious: better calendar and clock. >> >> clock will now show date if there is space. >> >> calendar is simple and beautiful. > > It looks really good ! > But the day in the date doesn't have the right locale. It should be > Jeu (for Jeudi in French) instead of Tod or at least display it in > english ? > > http://www.deco-crea.com/files/2011-08-18-011724_1680x1050_scrot.png > > Regards, > -- > Nicolas Aguirre > Mail: aguirre.nico...@gmail.com > Web: http://enna.geexbox.org > Blog: http://dev.enlightenment.fr/~captainigloo/ > > -- > Get a FREE DOWNLOAD! and learn more about uberSVN rich system, > user administration capabilities and model configuration. Take > the hassle out of deploying and managing Subversion and the > tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/eio/src/lib
I don't know eio semantics, but it should incref the stringshared handle and this code will leak reference. There is a bug for sure, either in this code or in eio API. Sent from my iPhone On 16/08/2011, at 18:14, "Enlightenment SVN" wrote: > Log: > eio: obvious typo ! > > > Author: cedric > Date: 2011-08-16 14:13:20 -0700 (Tue, 16 Aug 2011) > New Revision: 62516 > Trac: http://trac.enlightenment.org/e/changeset/62516 > > Modified: > trunk/eio/src/lib/eio_monitor.c > > Modified: trunk/eio/src/lib/eio_monitor.c > === > --- trunk/eio/src/lib/eio_monitor.c2011-08-16 20:53:07 UTC (rev 62515) > +++ trunk/eio/src/lib/eio_monitor.c2011-08-16 21:13:20 UTC (rev 62516) > @@ -162,7 +162,7 @@ >const char *tmp; > >tmp = eina_stringshare_add(path); > - return eio_monitor_stringshared_add(path); > + return eio_monitor_stringshared_add(tmp); > } > > EAPI Eio_Monitor * > > > -- > Get a FREE DOWNLOAD! and learn more about uberSVN rich system, > user administration capabilities and model configuration. Take > the hassle out of deploying and managing Subversion and the > tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/e/src: bin modules/conf_theme
The obvious repetitive string manipulation is all in eina. Extension,
prefix, suffix, split at delimiter to an array, join array using
delimiter were all done.
Sent from my iPhone
On 11/08/2011, at 14:12, Carsten Haitzler wrote:
> On Thu, 11 Aug 2011 13:50:37 +0200 Gustavo Barbieri
> said:
>
> hey - i didn't even know it existed. every time i write a few lines of code do
> u expect me to go reading all the efl headers in case something is there?
>
>> Raster never uses what he didn't write :-D that's discrimination!!!
>>
>> Sent from my iPhone
>>
>> On 11/08/2011, at 13:08, Carsten Haitzler wrote:
>>
>>> On Thu, 11 Aug 2011 12:48:52 +0200 (CEST) Vincent Torri
>>> said:
>>>
>>> probably eina_str_has_extension now i look at it
>>>
>>>>
>>>> usee eina_str_sufix() instead ?
>>>>
>>>> Vincent
>>>>
>>>> On Thu, 11 Aug 2011, Enlightenment SVN wrote:
>>>>
>>>>> Log:
>>>>> ... allow non edj files as wallpapers... if u try. :)
>>>>>
>>>>>
>>>>>
>>>>> Author: raster
>>>>> Date: 2011-08-11 03:39:37 -0700 (Thu, 11 Aug 2011)
>>>>> New Revision: 62340
>>>>> Trac: http://trac.enlightenment.org/e/changeset/62340
>>>>>
>>>>> Modified:
>>>>> trunk/e/src/bin/e_bg.c trunk/e/src/bin/e_icon.c
>>>>> trunk/e/src/bin/e_widget_preview.c
>>>>> trunk/e/src/modules/conf_theme/e_int_config_wallpaper.c
>>>>>
>>>>> Modified: trunk/e/src/bin/e_bg.c
>>>>> ===
>>>>> --- trunk/e/src/bin/e_bg.c2011-08-11 10:30:35 UTC (rev 62339)
>>>>> +++ trunk/e/src/bin/e_bg.c2011-08-11 10:39:37 UTC (rev 62340)
>>>>> @@ -118,7 +118,8 @@
>>>>> EINA_LIST_FOREACH(e_config->desktop_backgrounds, l, cfbg)
>>>>> {
>>>>>int spec;
>>>>> -
>>>>> + const char *ext;
>>>>> +
>>>>>if (!cfbg) continue;
>>>>>spec = 0;
>>>>>if (cfbg->container == container_num) spec++;
>>>>> @@ -142,19 +143,28 @@
>>>>> if (bf) bgfile = bf;
>>>>> }
>>>>> }
>>>>> - entries = edje_file_collection_list(bgfile);
>>>>> - if (entries)
>>>>> - {
>>>>> - EINA_LIST_FOREACH(entries, ll, entry)
>>>>> -{
>>>>> - if (!strcmp(entry, "e/desktop/background"))
>>>>> - {
>>>>> -bg = cfbg;
>>>>> -current_spec = spec;
>>>>> - }
>>>>> -}
>>>>> - edje_file_collection_list_free(entries);
>>>>> - }
>>>>> + ext = strrchr(bgfile, '.');
>>>>> + if ((ext) && (!strcasecmp(ext, ".edj")))
>>>>> + {
>>>>> + entries = edje_file_collection_list(bgfile);
>>>>> + if (entries)
>>>>> +{
>>>>> + EINA_LIST_FOREACH(entries, ll, entry)
>>>>> + {
>>>>> +if (!strcmp(entry, "e/desktop/background"))
>>>>> + {
>>>>> + bg = cfbg;
>>>>> + current_spec = spec;
>>>>> + }
>>>>> + }
>>>>> + edje_file_collection_list_free(entries);
>>>>> +}
>>>>> + }
>>>>> + else
>>>>> + {
>>>>> + bg = cfbg;
>>>>> + current_spec = spec;
>>>>> + }
>>>>> }
>>>>>}
>>>>> return bg;
>>>>> @@ -188,6 +198,8 @@
>>>>>}
>>>>> else
>>>>>{
>>>>> +const char *ext;
>>>>> +
>>>>> bgfile = e_co
Re: [E-devel] error in python-bindings for evas
This is still in the Cython, not python... So need its version Sent from my iPhone On 11/08/2011, at 11:41, libernux wrote: > Op Thu, 11 Aug 2011 10:51:42 +0200 > Boris Faure schreef: > >> What version of python are you using? >> >> > > I'm using python 2.7 > > -- > Get a FREE DOWNLOAD! and learn more about uberSVN rich system, > user administration capabilities and model configuration. Take > the hassle out of deploying and managing Subversion and the > tools developers use with it. > http://p.sf.net/sfu/wandisco-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/e/src: bin modules/conf_theme
Raster never uses what he didn't write :-D that's discrimination!!!
Sent from my iPhone
On 11/08/2011, at 13:08, Carsten Haitzler wrote:
> On Thu, 11 Aug 2011 12:48:52 +0200 (CEST) Vincent Torri
> said:
>
> probably eina_str_has_extension now i look at it
>
>>
>> usee eina_str_sufix() instead ?
>>
>> Vincent
>>
>> On Thu, 11 Aug 2011, Enlightenment SVN wrote:
>>
>>> Log:
>>> ... allow non edj files as wallpapers... if u try. :)
>>>
>>>
>>>
>>> Author: raster
>>> Date: 2011-08-11 03:39:37 -0700 (Thu, 11 Aug 2011)
>>> New Revision: 62340
>>> Trac: http://trac.enlightenment.org/e/changeset/62340
>>>
>>> Modified:
>>> trunk/e/src/bin/e_bg.c trunk/e/src/bin/e_icon.c
>>> trunk/e/src/bin/e_widget_preview.c
>>> trunk/e/src/modules/conf_theme/e_int_config_wallpaper.c
>>>
>>> Modified: trunk/e/src/bin/e_bg.c
>>> ===
>>> --- trunk/e/src/bin/e_bg.c2011-08-11 10:30:35 UTC (rev 62339)
>>> +++ trunk/e/src/bin/e_bg.c2011-08-11 10:39:37 UTC (rev 62340)
>>> @@ -118,7 +118,8 @@
>>>EINA_LIST_FOREACH(e_config->desktop_backgrounds, l, cfbg)
>>> {
>>> int spec;
>>> -
>>> + const char *ext;
>>> +
>>> if (!cfbg) continue;
>>> spec = 0;
>>> if (cfbg->container == container_num) spec++;
>>> @@ -142,19 +143,28 @@
>>> if (bf) bgfile = bf;
>>>}
>>> }
>>> - entries = edje_file_collection_list(bgfile);
>>> - if (entries)
>>> - {
>>> - EINA_LIST_FOREACH(entries, ll, entry)
>>> -{
>>> - if (!strcmp(entry, "e/desktop/background"))
>>> - {
>>> -bg = cfbg;
>>> -current_spec = spec;
>>> - }
>>> -}
>>> - edje_file_collection_list_free(entries);
>>> - }
>>> + ext = strrchr(bgfile, '.');
>>> + if ((ext) && (!strcasecmp(ext, ".edj")))
>>> + {
>>> + entries = edje_file_collection_list(bgfile);
>>> + if (entries)
>>> +{
>>> + EINA_LIST_FOREACH(entries, ll, entry)
>>> + {
>>> +if (!strcmp(entry, "e/desktop/background"))
>>> + {
>>> + bg = cfbg;
>>> + current_spec = spec;
>>> + }
>>> + }
>>> + edje_file_collection_list_free(entries);
>>> +}
>>> + }
>>> + else
>>> + {
>>> + bg = cfbg;
>>> + current_spec = spec;
>>> + }
>>> }
>>> }
>>> return bg;
>>> @@ -188,6 +198,8 @@
>>> }
>>> else
>>> {
>>> +const char *ext;
>>> +
>>>bgfile = e_config->desktop_default_background;
>>>if (bgfile)
>>> {
>>> @@ -199,19 +211,24 @@
>>> if (bf) bgfile = bf;
>>> }
>>> }
>>> -entries = edje_file_collection_list(bgfile);
>>> -if (entries)
>>> - {
>>> - EINA_LIST_FOREACH(entries, l, entry)
>>> - {
>>> - if (!strcmp(entry, "e/desktop/background"))
>>> -{
>>> - ok = 1;
>>> - break;
>>> -}
>>> - }
>>> - edje_file_collection_list_free(entries);
>>> - }
>>> +ext = strrchr(bgfile, '.');
>>> +if ((ext) && (!strcasecmp(ext, ".edj")))
>>> + {
>>> + entries = edje_file_collection_list(bgfile);
>>> + if (entries)
>>> + {
>>> + EINA_LIST_FOREACH(entries, l, entry)
>>> +{
>>> + if (!strcmp(entry, "e/desktop/background"))
>>> + {
>>> +ok = 1;
>>> +break;
>>> + }
>>> +}
>>> + edje_file_collection_list_free(entries);
>>> + }
>>> + }
>>> +else ok = 1;
>>>if (!ok)
>>> bgfile = e_theme_edje_file_get("base/theme/background",
>>> "e/desktop/background");
>>> @@ -226,6 +243,7 @@
>>> Evas_Object *o;
>>> const char *bgfile = "";
>>> const char *trans = "";
>>> + const char *ext;
>>> E_Desk *desk;
>>>
>>> if (transition == E_BG_TRANSITION_START) trans =
>>> e_config->transition_start; @@ -283,10 +301,21 @@
>>>evas_object_clip_set(o, zone->bg_clip_object);
>>>evas_object_show(o);
>>> }
>>> - o = edje_object_add(zone->container->bg_evas);
>>> + ext = strrchr(bgfile, '.');
>>> + if ((ext) && (!strcasecmp(ext, ".edj")))
>>> + {
>>> +o = edje_object_add(zone->container->bg_evas);
>>> +evas_object_data_set(o, "e_zone", zone);
>>> +edje_object_file_set(o, bgfile, "e/desktop/background");
>>> +
Re: [E-devel] HEADER SIZE POLL
On 05/08/2011, at 05:28, Lucas De Marchi wrote: > On Thu, Jul 28, 2011 at 3:17 PM, Iván Briano (Sachiel) > wrote: >> Since this subject is annoying, I will also be annoying by top-posting. >> >> I like my docs in the .c files, and keep in the .h whatever is needed to >> be there only. If needed, doxygen even supports having docs in some >> other random file, but I like headers to be as small and packed as possible >> so the entire list of functions fits in one terminal window. > > I couldn't agree more. > > >> 2011/7/28 Mike Blumenkrantz : >>> On Thu, 28 Jul 2011 20:22:51 +0300 >>> Tom Hacohen wrote: >>> On 28/07/11 19:42, Mike Blumenkrantz wrote: > This is a community project, so we can do stuff like having polls and > taking > votes right? Okay then, since there's been some disagreement with strong > opinions on either side we're voting on a super important issue - header > size. Specifically, the Elementary.h header. > > As with any serious vote, here is your ballot: > > 1) LEAVE AS-IS, CONTINUE ADDING DOCS TO Elementary.h > 2) SPLIT INTO WIDGET HEADERS SIMILAR TO EINA > 3) OTHER (Explain) > > 3) docs should be done in .c files. > My preferences: #2- like eina #3- in c source > > Lucas De Marchi > > -- > BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA > The must-attend event for mobile developers. Connect with experts. > Get tools for creating Super Apps. See the latest technologies. > Sessions, hands-on labs, demos & much more. Register early & save! > http://p.sf.net/sfu/rim-blackberry-1 > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: woohyun IN trunk/elementary/src: bin lib
Sorry, but there is directional scrolling implemented. Why did you
duplicate it with a worse API (directional scrolling takes x,y as
direction parameters and may do diagonal). If it's broken or not
implemented it's better to fix it than to introduce something new.
Sent from my iPhone
On 05/08/2011, at 10:26, "Enlightenment SVN" wrote:
> Log:
> elementary : Focus movement is possible with arrow keys. You can check
> this feature in elementary_test -> focus.
>
>
> Author: woohyun
> Date: 2011-08-05 01:25:07 -0700 (Fri, 05 Aug 2011)
> New Revision: 62125
> Trac: http://trac.enlightenment.org/e/changeset/62125
>
> Modified:
> trunk/elementary/src/bin/test_focus.c
> trunk/elementary/src/lib/Elementary.h.in
> trunk/elementary/src/lib/elm_widget.c trunk/elementary/src/lib/elm_widget.h
> trunk/elementary/src/lib/elm_win.c
>
> Modified: trunk/elementary/src/bin/test_focus.c
> ===
> --- trunk/elementary/src/bin/test_focus.c2011-08-05 07:45:45 UTC (rev
> 62124)
> +++ trunk/elementary/src/bin/test_focus.c2011-08-05 08:25:07 UTC (rev
> 62125)
> @@ -91,7 +91,8 @@
> {
> Evas_Object *lb = elm_label_add(win);
> elm_object_text_set(lb,
> - "Use Tab and Shift+Tab"
> + "Use Tab, Shift+Tab, and"
> + "Arrow Keys"
> );
> evas_object_size_hint_weight_set(lb, 0.0, 0.0);
> evas_object_size_hint_align_set(lb, EVAS_HINT_FILL,
>
> Modified: trunk/elementary/src/lib/Elementary.h.in
> ===
> --- trunk/elementary/src/lib/Elementary.h.in2011-08-05 07:45:45 UTC (rev
> 62124)
> +++ trunk/elementary/src/lib/Elementary.h.in2011-08-05 08:25:07 UTC (rev
> 62125)
> @@ -320,7 +320,11 @@
>typedef enum _Elm_Focus_Direction
> {
> ELM_FOCUS_PREVIOUS,
> -ELM_FOCUS_NEXT
> +ELM_FOCUS_NEXT,
> +ELM_FOCUS_UP,
> +ELM_FOCUS_DOWN,
> +ELM_FOCUS_LEFT,
> +ELM_FOCUS_RIGHT
> } Elm_Focus_Direction;
>
>typedef enum _Elm_Text_Format
>
> Modified: trunk/elementary/src/lib/elm_widget.c
> ===
> --- trunk/elementary/src/lib/elm_widget.c2011-08-05 07:45:45 UTC (rev
> 62124)
> +++ trunk/elementary/src/lib/elm_widget.c2011-08-05 08:25:07 UTC (rev
> 62125)
> @@ -158,6 +158,10 @@
> static Evas_Object *_newest_focus_order_get(Evas_Object *obj,
> unsigned int *newest_focus_order,
> Eina_Bool can_focus_only);
> +static Eina_Bool _focus_list_direction_nearest_get(Evas_Object*obj,
> +Eina_List *list,
> +Elm_Focus_Direction dir,
> +Evas_Object **nearest);
>
> /* local subsystem globals */
> static Evas_Smart *_e_smart = NULL;
> @@ -399,6 +403,96 @@
> }
> }
>
> +static Eina_Bool
> +_focus_list_direction_nearest_get(Evas_Object*obj,
> + Eina_List *list,
> + Elm_Focus_Direction dir,
> + Evas_Object **nearest)
> +{
> + Evas_Object *cur, *next = NULL;
> + Eina_List *l;
> + double weight = 0.0;
> + Evas_Coord x, y, w, h, cx, cy;
> +
> + if (!nearest) return EINA_FALSE;
> + *nearest = NULL;
> +
> + evas_object_geometry_get(obj, &x, &y, &w, &h);
> + cx = x + (w / 2);
> + cy = y + (h / 2);
> +
> + EINA_LIST_FOREACH(list, l, cur)
> + {
> +if (obj == cur) continue;
> +Evas_Coord cur_x, cur_y, cur_w, cur_h;
> +int w_gap = 0, h_gap = 0;
> +double cur_weight = 0.0;
> +
> +evas_object_geometry_get(cur, &cur_x, &cur_y, &cur_w, &cur_h);
> +
> +if (dir == ELM_FOCUS_LEFT)
> + {
> + if (x < (cur_x + cur_w)) continue;
> + w_gap = x - (cur_x + cur_w);
> + if ((cy >= cur_y) && (cy <= (cur_y + cur_h)))
> + h_gap = 0;
> + else if (cy > (cur_y + cur_h))
> + h_gap = cy - (cur_y + cur_h);
> + else if (cy < (cur_y))
> + h_gap = cur_y - cy;
> + }
> +else if (dir == ELM_FOCUS_RIGHT)
> + {
> + if ((x + w) > cur_x) continue;
> + w_gap = cur_x - (x + w);
> + if ((cy >= cur_y) && (cy <= (cur_y + cur_h)))
> + h_gap = 0;
> + else if (cy > (cur_y + cur_h))
> + h_gap = cy - (cur_y + cur_h);
> + else if (cy < (cur_y))
> + h_gap = cur_y - cy;
> + }
> +else if (dir == ELM_FOCUS_UP)
> + {
> + if
