Re: [E-devel] [Patch] Handling the engine creation failed

[ChunEon Park]

Dear cinoo. 
The patch looks good to me ! 
I committed your patch.
But I changed some trivials there. 
Please check the lastest code. 
Thank you.

Let's run together for the best moment!
 -Regards, Hermet-
 
-Original Message-
From: "cnook" 
To: "EFL"
Cc: 
Sent: 11-07-29(금) 22:14:07
Subject: [E-devel] [Patch] Handling the engine creation failedHi All,
If ecore_evas_[not_software_x11]_new(); returns NULL while elm_win_add(); is
called,
then ecore_evas_software_x11_new(); is used instead of other engines.
(FALLBACK_TRY)
But the configuration value for engine is not changed. This makes improper
result.
After FALLBACK_TRY, the elm_win works with different configuration value.
In this case, win->xwin (_elm_win_xwindow_get()) gives NULL.
and elm_win_xsinodow_get() returns 0 also.
Please refer to attached patch. Thanks a lot
Sincerely,
Shinwoo Kim.
--
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] Handling the engine creation failed

[cnook]

Hi All,

If ecore_evas_[not_software_x11]_new(); returns NULL while elm_win_add(); is
called,
then ecore_evas_software_x11_new(); is used instead of other engines.
(FALLBACK_TRY)
But the configuration value for engine is not changed. This makes improper
result.

After FALLBACK_TRY, the elm_win works with different configuration value.
In this case, win->xwin (_elm_win_xwindow_get()) gives NULL.
and elm_win_xsinodow_get() returns 0 also.

Please refer to attached patch. Thanks a lot

Sincerely,
Shinwoo Kim.
Index: src/lib/elm_win.c
===
--- src/lib/elm_win.c	(revision 61887)
+++ src/lib/elm_win.c	(working copy)
@@ -1406,6 +1406,7 @@ elm_win_add(Evas_Object *parent, const char *name,
do {   \
 CRITICAL(engine " engine creation failed. Trying software X11."); \
 win->ee = ecore_evas_software_x11_new(NULL, 0, 0, 0, 1, 1);  \
+elm_engine_set(ELM_SOFTWARE_X11);  \
} while (0)
 #define ENGINE_COMPARE(name) (!strcmp(_elm_config->engine, name))
 
--
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel