Re: [E-devel] [EGIT] [apps/terminology] master 01/01: tycat: fix videos aspect ratio when emotion_object_video_handled_get() fails

2013-05-21 Thread Boris Faure
On 13-05-21 09:40, Cedric BAIL wrote:
 On Mon, May 20, 2013 at 11:22 PM, Boris Faure - Enlightenment Git
 no-re...@enlightenment.org wrote:
  billiob pushed a commit to branch master.
 
  commit 3d804bf38d70225de3034451c98ed13eee027206
  Author: Boris Faure bill...@gmail.com
  Date:   Mon May 20 16:12:39 2013 +0200
 
  tycat: fix videos aspect ratio when emotion_object_video_handled_get() 
  fails
 
  Sometimes, emotion_object_video_handled_get() will return NULL. In that 
  case, the video will be stretched to the terminal's width but only 3 lines 
  high. Use A/R information for better scaling.
  Also support videos and fix aspect ratio.
 
  Patch by jpeg.

 I think you should use git commit --amend --author before pushing
 those change upstream.

I used arc patch D135 as stated on
https://phab.enlightenment.org/D135 .
Then that dumb command wanted me to enter a commit message without
providing an obvious one: the one from the patch.
Then the git commit is done.

I don't know why it didn't work about authorship this time.
It worked fine with commit 5010b5fa0 as shown below:
Author: Godfath3r galatsan...@gmail.com
Commit: Boris Faure bill...@gmail.com

--
Boris Faure
Pointer Arithmetician

--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [EGIT] [apps/terminology] master 01/01: tycat: fix videos aspect ratio when emotion_object_video_handled_get() fails

2013-05-21 Thread Cedric BAIL
On Tue, May 21, 2013 at 5:32 PM, Boris Faure bo...@fau.re wrote:
 On 13-05-21 09:40, Cedric BAIL wrote:
 On Mon, May 20, 2013 at 11:22 PM, Boris Faure - Enlightenment Git
 no-re...@enlightenment.org wrote:
  billiob pushed a commit to branch master.
 
  commit 3d804bf38d70225de3034451c98ed13eee027206
  Author: Boris Faure bill...@gmail.com
  Date:   Mon May 20 16:12:39 2013 +0200
 
  tycat: fix videos aspect ratio when emotion_object_video_handled_get() 
  fails
 
  Sometimes, emotion_object_video_handled_get() will return NULL. In 
  that case, the video will be stretched to the terminal's width but only 3 
  lines high. Use A/R information for better scaling.
  Also support videos and fix aspect ratio.
 
  Patch by jpeg.

 I think you should use git commit --amend --author before pushing
 those change upstream.

 I used arc patch D135 as stated on
 https://phab.enlightenment.org/D135 .
 Then that dumb command wanted me to enter a commit message without
 providing an obvious one: the one from the patch.
 Then the git commit is done.

 I don't know why it didn't work about authorship this time.
 It worked fine with commit 5010b5fa0 as shown below:
 Author: Godfath3r galatsan...@gmail.com
 Commit: Boris Faure bill...@gmail.com

Maybe because JP didn't use arc and Godfath3r did ?
--
Cedric BAIL

--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [EGIT] [apps/terminology] master 01/01: tycat: fix videos aspect ratio when emotion_object_video_handled_get() fails

2013-05-21 Thread Daniel Juyung Seo
On Tue, May 21, 2013 at 5:32 PM, Boris Faure bo...@fau.re wrote:
 On 13-05-21 09:40, Cedric BAIL wrote:
 On Mon, May 20, 2013 at 11:22 PM, Boris Faure - Enlightenment Git
 no-re...@enlightenment.org wrote:
  billiob pushed a commit to branch master.
 
  commit 3d804bf38d70225de3034451c98ed13eee027206
  Author: Boris Faure bill...@gmail.com
  Date:   Mon May 20 16:12:39 2013 +0200
 
  tycat: fix videos aspect ratio when emotion_object_video_handled_get() 
  fails
 
  Sometimes, emotion_object_video_handled_get() will return NULL. In 
  that case, the video will be stretched to the terminal's width but only 3 
  lines high. Use A/R information for better scaling.
  Also support videos and fix aspect ratio.
 
  Patch by jpeg.

 I think you should use git commit --amend --author before pushing
 those change upstream.

 I used arc patch D135 as stated on
 https://phab.enlightenment.org/D135 .
 Then that dumb command wanted me to enter a commit message without
 providing an obvious one: the one from the patch.

By the way, isn't this same to other arc patches?
This always happens to me.
It will be great if this can be automated though.

Daniel Juyung Seo (SeoZ)


 Then the git commit is done.

 I don't know why it didn't work about authorship this time.
 It worked fine with commit 5010b5fa0 as shown below:
 Author: Godfath3r galatsan...@gmail.com
 Commit: Boris Faure bill...@gmail.com

 --
 Boris Faure
 Pointer Arithmetician

 --
 Try New Relic Now  We'll Send You this Cool Shirt
 New Relic is the only SaaS-based application performance monitoring service
 that delivers powerful full stack analytics. Optimize and monitor your
 browser, app,  servers with just a few lines of code. Try New Relic
 and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [EGIT] [apps/terminology] master 01/01: tycat: fix videos aspect ratio when emotion_object_video_handled_get() fails

2013-05-20 Thread Cedric BAIL
On Mon, May 20, 2013 at 11:22 PM, Boris Faure - Enlightenment Git
no-re...@enlightenment.org wrote:
 billiob pushed a commit to branch master.

 commit 3d804bf38d70225de3034451c98ed13eee027206
 Author: Boris Faure bill...@gmail.com
 Date:   Mon May 20 16:12:39 2013 +0200

 tycat: fix videos aspect ratio when emotion_object_video_handled_get() 
 fails

 Sometimes, emotion_object_video_handled_get() will return NULL. In that 
 case, the video will be stretched to the terminal's width but only 3 lines 
 high. Use A/R information for better scaling.
 Also support videos and fix aspect ratio.

 Patch by jpeg.

I think you should use git commit --amend --author before pushing
those change upstream.
--
Cedric BAIL

--
Try New Relic Now  We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app,  servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel