Re: [E-devel] [EGIT] [apps/terminology] master 04/04: fix crash when closing top-level split. Closes T256.
Am Mittwoch, 28. August 2013 um 17:14 schrieb Boris Faure - Enlightenment Git:
> billiob pushed a commit to branch master.
>
> commit 441f2ef39e7f9912cfa1002e84e7d809368c5a0c
> Author: Boris Faure mailto:bill...@gmail.com)>
> Date: Wed Aug 28 17:11:48 2013 +0200
>
> fix crash when closing top-level split. Closes T256.
> ---
> src/bin/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/bin/main.c b/src/bin/main.c
> index c0e11d1..92d6910 100644
> --- a/src/bin/main.c
> +++ b/src/bin/main.c
> @@ -493,6 +493,8 @@ _split_merge(Split *spp, Split *sp, const char *slot)
> spp->s2->parent = spp;
> spp->horizontal = sp->horizontal;
> o = sp->panes;
> + elm_object_part_content_unset(sp->parent->panes,
> + (strcmp(slot, PANES_TOP)) ? PANES_TOP : PANES_BOTTOM);
>
>
sure that it shouldn't be "!strcmp" or "(stcmp(..) == 0)"?
--
Leif
> if (spp->parent)
> {
> elm_object_part_content_unset(spp->parent->panes, slot);
>
> --
>
> --
> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
> Discover the easy way to master current and previous Microsoft technologies
> and advance your career. Get an incredible 1,500+ hours of step-by-step
> tutorial videos with LearnDevNow. Subscribe today and save!
> http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
>
>
--
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [apps/terminology] master 04/04: fix crash when closing top-level split. Closes T256.
On 13-08-28 17:23, Leif Middelschulte wrote: > Am Mittwoch, 28. August 2013 um 17:14 schrieb Boris Faure - Enlightenment Git: > > billiob pushed a commit to branch master. > > > > commit 441f2ef39e7f9912cfa1002e84e7d809368c5a0c > > Author: Boris Faure mailto:bill...@gmail.com)> > > Date: Wed Aug 28 17:11:48 2013 +0200 > > > > fix crash when closing top-level split. Closes T256. > > --- > > src/bin/main.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/bin/main.c b/src/bin/main.c > > index c0e11d1..92d6910 100644 > > --- a/src/bin/main.c > > +++ b/src/bin/main.c > > @@ -493,6 +493,8 @@ _split_merge(Split *spp, Split *sp, const char *slot) > > spp->s2->parent = spp; > > spp->horizontal = sp->horizontal; > > o = sp->panes; > > + elm_object_part_content_unset(sp->parent->panes, > > + (strcmp(slot, PANES_TOP)) ? PANES_TOP : PANES_BOTTOM); > > > > > > sure that it shouldn't be "!strcmp" or "(stcmp(..) == 0)"? It's the correct way. "slot" is the empty part, so the part that should be unset is the other one. I'll rewrite it with a !strcmp that we usually see. -- Boris Faure Pointer Arithmetician -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [apps/terminology] master 04/04: fix crash when closing top-level split. Closes T256.
On Wed, 28 Aug 2013 17:23:25 +0200
Leif Middelschulte wrote:
> Am Mittwoch, 28. August 2013 um 17:14 schrieb Boris Faure - Enlightenment Git:
> > billiob pushed a commit to branch master.
> >
> > commit 441f2ef39e7f9912cfa1002e84e7d809368c5a0c
> > Author: Boris Faure mailto:bill...@gmail.com)>
> > Date: Wed Aug 28 17:11:48 2013 +0200
> >
> > fix crash when closing top-level split. Closes T256.
> > ---
> > src/bin/main.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/src/bin/main.c b/src/bin/main.c
> > index c0e11d1..92d6910 100644
> > --- a/src/bin/main.c
> > +++ b/src/bin/main.c
> > @@ -493,6 +493,8 @@ _split_merge(Split *spp, Split *sp, const char *slot)
> > spp->s2->parent = spp;
> > spp->horizontal = sp->horizontal;
> > o = sp->panes;
> > + elm_object_part_content_unset(sp->parent->panes,
> > + (strcmp(slot, PANES_TOP)) ? PANES_TOP : PANES_BOTTOM);
> >
> >
>
> sure that it shouldn't be "!strcmp" or "(stcmp(..) == 0)"?
>
> --
> Leif
> > if (spp->parent)
> > {
> > elm_object_part_content_unset(spp->parent->panes, slot);
> >
> > --
> >
leave ternary operators alone!
--
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
