Re: [E-devel] [EGIT] [core/efl] master 07/12: docs: efl_network*: add missing documentation

[Gustavo Sverzut Barbieri]

Yeah, likely copy & pasta ;)

Em segunda-feira, 14 de novembro de 2016, Stefan Schmidt <
ste...@osg.samsung.com> escreveu:

> Hello.
>
> On 11/11/16 15:53, Gustavo Sverzut Barbieri wrote:
> > Efl_network won't be in our API, only efl_net. So don't worry
> >
>
> I go through all eo files right now. No matter if they are public API or
> not. And efl_network* had a lot more gaps to fill up compared to efl_net*
> :D
>
> I know that they are actively worked on right now but please take the
> extra two minutes to document all parts.
>
> Doing so I found a strange strange value name in:
>
> src/lib/ecore_con/efl_net_server_udp.eo line 103.
>
> The value is named loopback while the property itself is @property
> multicast_time_to_live. To me this looks like a multicast_loopback
> property copy and paste error. I would expect the value to be named ttl.
> Do you agree?
>
> I added a fixme while documenting but I guess raising it here has more
> chance of getting noticed.
>
> regards
> Stefan Schmidt
>
> 
> --
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today. http://sdm.link/xeonphi
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net 
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>


-- 
Gustavo Sverzut Barbieri
--
Mobile: +55 (16) 99354-9890
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 07/12: docs: efl_network*: add missing documentation

[Stefan Schmidt]

Hello.

On 11/11/16 15:53, Gustavo Sverzut Barbieri wrote:
> Efl_network won't be in our API, only efl_net. So don't worry
>

I go through all eo files right now. No matter if they are public API or 
not. And efl_network* had a lot more gaps to fill up compared to efl_net* :D

I know that they are actively worked on right now but please take the 
extra two minutes to document all parts.

Doing so I found a strange strange value name in:

src/lib/ecore_con/efl_net_server_udp.eo line 103.

The value is named loopback while the property itself is @property 
multicast_time_to_live. To me this looks like a multicast_loopback 
property copy and paste error. I would expect the value to be named ttl. 
Do you agree?

I added a fixme while documenting but I guess raising it here has more 
chance of getting noticed.

regards
Stefan Schmidt

--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 07/12: docs: efl_network*: add missing documentation

[Gustavo Sverzut Barbieri]

Efl_network won't be in our API, only efl_net. So don't worry

Em sexta-feira, 11 de novembro de 2016, Stefan Schmidt <
ste...@datenfreihafen.org> escreveu:

> stefan pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=
> 6570c2692100b4b9b1440d1a7244620d586773c6
>
> commit 6570c2692100b4b9b1440d1a7244620d586773c6
> Author: Stefan Schmidt >
> Date:   Fri Nov 11 15:28:49 2016 +0100
>
> docs: efl_network*: add missing documentation
> ---
>  src/lib/ecore_con/efl_network.eo | 6 +++---
>  src/lib/ecore_con/efl_network_url.eo | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/lib/ecore_con/efl_network.eo b/src/lib/ecore_con/efl_
> network.eo
> index e2cdc79..2f95a05 100644
> --- a/src/lib/ecore_con/efl_network.eo
> +++ b/src/lib/ecore_con/efl_network.eo
> @@ -104,7 +104,7 @@ abstract Efl.Network (Efl.Object) {
>   legacy: null;
>   }
>   values {
> -connected: bool; [[Returns true if connected, false
> otherwise.]]
> +connected: bool; [[$true if connected, $false otherwise.]]
>   }
>}
>@property timeout @virtual_pure {
> @@ -172,12 +172,12 @@ abstract Efl.Network (Efl.Object) {
>  done_cb: Ecore_Con_Dns_Cb; [[Callback to notify when done.]]
>  data: const(void_ptr); [[User data to be given to done_cb.]]
>   }
> - return: bool; [[true if the request did not fail to be set up,
> false otherwise.]]
> + return: bool; [[$true if the request did not fail to be set up,
> $false otherwise.]]
>}
> }
> events {
>  data,received: Ecore.Con.Event_Data.Received; [[Data received on
> connection]]
> -connection,upgraded;
> +connection,upgraded; [[FIXME: what does upgrade mean here??]]
>  connection,error: string; [[Error received on connection]]
> }
>  }
> diff --git a/src/lib/ecore_con/efl_network_url.eo b/src/lib/ecore_con/efl_
> network_url.eo
> index 971d6d5..9dacb51 100644
> --- a/src/lib/ecore_con/efl_network_url.eo
> +++ b/src/lib/ecore_con/efl_network_url.eo
> @@ -5,7 +5,7 @@ class Efl.Network.Url (Efl.Object) {
>@property url {
>   [[Controls the URL to send the request to.]]
>   set {
> -return: bool (false); [[true on success, false on error.]]
> +return: bool (false); [[$true on success, $false on error.]]
>   }
>   get {
>   }
>
> --
>
>
>

-- 
Gustavo Sverzut Barbieri
--
Mobile: +55 (16) 99354-9890
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel