[E-devel] [Elementary]: Test case fail fixes. - hover, flipselector, genlist, multibuttonentry
Hi All, Please check the attached patch for elementary test case fail fixes. Genlist - crash fix (if itc parameter is passed as NULL ) Hover -> crash fix (when swallow part is passed as NULL in content_set_hook, here "smart" is assumed as default ). Multibuttonentry, flipselector -> item text set fail on NULL parameter. i.e, When elm_object_item_part_text_set(it, NULL, NULL); is called and then elm_object_item_part_text_get(it, NULL) is called. We should get return as NULL instead we get previously set text. Change description: "Test case fail fixes. - hover,flipselector,genlist, multibuttonentry". Signed-off by: Shilpa Singh Thanks & Regards Shilpa Singh elm.patch Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Elementary]: Test case fail fixes. - hover, flipselector, genlist, multibuttonentry
Hello. Shilpa :) Because elementary 1.0 was released, we should also maintain backport as Daniel did ~ http://trac.enlightenment.org/e/changeset/70520 And for trunk, you should update ChangeLog as Herment did ~ http://trac.enlightenment.org/e/changeset/70621 Can you make new patch including above ? Thanks :) -Original Message- From: "SHILPA ONKAR SINGH"<shilpa.si...@samsung.com> To: <enlightenment-devel@lists.sourceforge.net>; Cc: "csm...@samsung.com"<csm...@samsung.com>; "sreena...@samsung.com"<sreena...@samsung.com>; Sent: 2012-05-03 (목) 15:01:21 Subject: [E-devel] [Elementary]: Test case fail fixes. - hover, flipselector, genlist, multibuttonentry Hi All, Please check the attached patch for elementary test case fail fixes. Genlist - crash fix (if itc parameter is passed as NULL ) Hover -> crash fix (when swallow part is passed as NULL in content_set_hook, here "smart" is assumed as default ). Multibuttonentry, flipselector -> item text set fail on NULL parameter. i.e, When elm_object_item_part_text_set(it, NULL, NULL); is called and then elm_object_item_part_text_get(it, NULL) is called. We should get return as NULL instead we get previously set text. Change description: "Test case fail fixes. - hover,flipselector,genlist, multibuttonentry". Signed-off by: Shilpa Singh Thanks & Regards Shilpa Singh-- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Elementary]: Test case fail fixes. - hover, flipselector, genlist, multibuttonentry
hmm your patch is not acceptable because elm is changed totally. :( -Original Message- From: "SHILPA ONKAR SINGH"<shilpa.si...@samsung.com> To: <enlightenment-devel@lists.sourceforge.net>; Cc: "csm...@samsung.com"<csm...@samsung.com>; "sreena...@samsung.com"<sreena...@samsung.com>; Sent: 2012-05-03 (목) 15:01:21 Subject: [E-devel] [Elementary]: Test case fail fixes. - hover, flipselector, genlist, multibuttonentry Hi All, Please check the attached patch for elementary test case fail fixes. Genlist - crash fix (if itc parameter is passed as NULL ) Hover -> crash fix (when swallow part is passed as NULL in content_set_hook, here "smart" is assumed as default ). Multibuttonentry, flipselector -> item text set fail on NULL parameter. i.e, When elm_object_item_part_text_set(it, NULL, NULL); is called and then elm_object_item_part_text_get(it, NULL) is called. We should get return as NULL instead we get previously set text. Change description: "Test case fail fixes. - hover,flipselector,genlist, multibuttonentry". Signed-off by: Shilpa Singh Thanks & Regards Shilpa Singh-- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Elementary]: Test case fail fixes. - hover, flipselector, genlist, multibuttonentry
On Thu, 03 May 2012 06:01:21 + (GMT) SHILPA ONKAR SINGH said: at least some of these are already in svn in one way or another. i took a look, so i think no need to worry about this anymore. :) > Hi All, > > Please check the attached patch for elementary test case fail fixes. > > Genlist - crash fix (if itc parameter is passed as NULL ) > > Hover -> crash fix (when swallow part is passed as NULL in content_set_hook, > here "smart" is assumed as default ). > > Multibuttonentry, flipselector -> item text set fail on NULL parameter. > i.e, When elm_object_item_part_text_set(it, NULL, NULL); is called and then > elm_object_item_part_text_get(it, NULL) is called. We should get return as > NULL instead we get previously set text. > > Change description: "Test case fail fixes. - hover,flipselector,genlist, > multibuttonentry". > > Signed-off by: Shilpa Singh > > Thanks & Regards > Shilpa Singh -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
