Re: [E-devel] [PATCH] e17: use #!/bin/bash for e_remote since it uses bash-specific features

2013-01-07 Thread Albin Tonnerre 
On Sun, Dec 30, 2012 at 5:14 AM, P Purkayastha ppu...@gmail.com wrote:
 Are you sure variable substitution (using #, %, etc) is not POSIX? As
 far I could remember, it is POSIX. I also found it mentioned here, and a
 couple of other places on Google search:

I stand corrected :) Looks like some other forms of variable
substitutions aren't in POSIX, but the ones we use actually are.
Thanks for pointing this out.

 There are only two lines in enlightenment_remote which use echo -e and
 I think in both the lines they are unnecessary.

True. I have a couple other patches fixing issues in Eet, I guess I'll
just send a patch dropping the echo -e along with that.

Cheers,
--
Albin

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [PATCH] e17: use #!/bin/bash for e_remote since it uses bash-specific features

2012-12-29 Thread Albin Tonnerre 
enlightenment_remote uses at least variable substitution (${var%%.*})
and options (echo -e) that are not guaranteed to be available in
stricter (wrt. what's in POSIX) shell implementations, which may lead to
malfunction. Running the script using bash ensures things work as
intended.
---
 data/tools/enlightenment_remote |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/tools/enlightenment_remote b/data/tools/enlightenment_remote
index 45295bb..a5e5d74 100644
--- a/data/tools/enlightenment_remote
+++ b/data/tools/enlightenment_remote
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 #
 # See the function show_help_new_tool in order to know more about this tool
 
-- 
1.7.10.4


--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] e17: use #!/bin/bash for e_remote since it uses bash-specific features

2012-12-29 Thread Brian 'morlenxus' Miculcy 
Hm, i suggest to use

#!/usr/bin/env bash

then.

On 12/29/2012 06:26 PM, Albin Tonnerre wrote:
 enlightenment_remote uses at least variable substitution (${var%%.*})
 and options (echo -e) that are not guaranteed to be available in
 stricter (wrt. what's in POSIX) shell implementations, which may lead to
 malfunction. Running the script using bash ensures things work as
 intended.
 ---
   data/tools/enlightenment_remote |2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/data/tools/enlightenment_remote b/data/tools/enlightenment_remote
 index 45295bb..a5e5d74 100644
 --- a/data/tools/enlightenment_remote
 +++ b/data/tools/enlightenment_remote
 @@ -1,4 +1,4 @@
 -#!/bin/sh
 +#!/bin/bash
   #
   # See the function show_help_new_tool in order to know more about this tool
   


--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] e17: use #!/bin/bash for e_remote since it uses bash-specific features

2012-12-29 Thread Albin Tonnerre 
On Sat, Dec 29, 2012 at 6:30 PM, Brian 'morlenxus' Miculcy
morlen...@gmx.net wrote:
 Hm, i suggest to use

 #!/usr/bin/env bash

The common usage for shell scripts seems to be /bin/$SHELL (since
unlike perl or python there tends not be several competing versions of
a given shell interpreter), but feel free to use whatever you think is
appropriate :)

Cheers,
--
Albin

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] e17: use #!/bin/bash for e_remote since it uses bash-specific features

2012-12-29 Thread Brian 'morlenxus' Miculcy 
Absolutely, but as e17 is targeting different platforms, we should keep 
in mind that the bash can be on different places (e.g. if i remember 
correctly on OpenBSD in /usr/bin/bash).

On 12/29/2012 06:39 PM, Albin Tonnerre wrote:
 On Sat, Dec 29, 2012 at 6:30 PM, Brian 'morlenxus' Miculcy
 morlen...@gmx.net wrote:
 Hm, i suggest to use

 #!/usr/bin/env bash
 The common usage for shell scripts seems to be /bin/$SHELL (since
 unlike perl or python there tends not be several competing versions of
 a given shell interpreter), but feel free to use whatever you think is
 appropriate :)

 Cheers,
 --
 Albin


--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] e17: use #!/bin/bash for e_remote since it uses bash-specific features

2012-12-29 Thread P Purkayastha 
On 12/30/2012 01:26 AM, Albin Tonnerre wrote:
 enlightenment_remote uses at least variable substitution (${var%%.*})
 and options (echo -e) that are not guaranteed to be available in
 stricter (wrt. what's in POSIX) shell implementations, which may lead to
 malfunction. Running the script using bash ensures things work as
 intended.
 ---
   data/tools/enlightenment_remote |2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/data/tools/enlightenment_remote b/data/tools/enlightenment_remote
 index 45295bb..a5e5d74 100644
 --- a/data/tools/enlightenment_remote
 +++ b/data/tools/enlightenment_remote
 @@ -1,4 +1,4 @@
 -#!/bin/sh
 +#!/bin/bash
   #
   # See the function show_help_new_tool in order to know more about this tool



Are you sure variable substitution (using #, %, etc) is not POSIX? As 
far I could remember, it is POSIX. I also found it mentioned here, and a 
couple of other places on Google search:

http://publib.boulder.ibm.com/infocenter/pseries/v5r3/index.jsp?topic=/com.ibm.aix.baseadmn/doc/baseadmndita/korn_shell_parmsub1.htm

There are only two lines in enlightenment_remote which use echo -e and 
I think in both the lines they are unnecessary.


--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel