Re: [E-devel] [PATCH] evas-framebuffer.pc.in rename

2008-04-11 Thread Vincent Torri



On Mon, 7 Apr 2008, Lars Munch wrote:


Hi

Unfortunately the addition off expedite_check_engine.m4 in expedite
broke the detection of the framebuffer engine in expedite. The course of
this is an inconsistent naming of the file evas-framebuffer.pc.in
which should be named evas-fb.pc.in to be consistent with the other
engine names.


can't we just modify what is checked in expedite ? That is configure.in, a 
Makefile.am and 1 or 2 files.


Vincent



The attached patch renames this file an changes Configure.in and
Makefile.am in ecore and evas accordingly.

A quick grep in the cvs repository indicates that expedite is the only
project that actually uses evas-framebuffer.pc, so the breakage of
applying this patch should be minimal.

Regards
Lars Munch


--
Ce message a été vérifié par MailScanner
pour des virus ou des polluriels et rien de
suspect n'a été trouvé.
Message délivré par le serveur de messagerie de l'Université d'Evry.

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [PATCH] evas-framebuffer.pc.in rename

2008-04-11 Thread Lars Munch
On Fri, Apr 11, 2008 at 04:27:18PM +0200, Vincent Torri wrote:
 
 
 On Mon, 7 Apr 2008, Lars Munch wrote:
 
 Hi
 
 Unfortunately the addition off expedite_check_engine.m4 in expedite
 broke the detection of the framebuffer engine in expedite. The course of
 this is an inconsistent naming of the file evas-framebuffer.pc.in
 which should be named evas-fb.pc.in to be consistent with the other
 engine names.
 
 can't we just modify what is checked in expedite ? That is configure.in, a 
 Makefile.am and 1 or 2 files.
 

yes, that's the easy solution, but IMHO consistent naming is better in
the long run.

Regards
Lars Munch

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [PATCH] evas-framebuffer.pc.in rename

2008-04-11 Thread The Rasterman
On Fri, 11 Apr 2008 16:27:18 +0200 (CEST) Vincent Torri [EMAIL PROTECTED]
babbled:

 
 
 On Mon, 7 Apr 2008, Lars Munch wrote:
 
  Hi
 
  Unfortunately the addition off expedite_check_engine.m4 in expedite
  broke the detection of the framebuffer engine in expedite. The course of
  this is an inconsistent naming of the file evas-framebuffer.pc.in
  which should be named evas-fb.pc.in to be consistent with the other
  engine names.
 
 can't we just modify what is checked in expedite ? That is configure.in, a 
 Makefile.am and 1 or 2 files.

consistency does make sense :)

  The attached patch renames this file an changes Configure.in and
  Makefile.am in ecore and evas accordingly.
 
  A quick grep in the cvs repository indicates that expedite is the only
  project that actually uses evas-framebuffer.pc, so the breakage of
  applying this patch should be minimal.
 
  Regards
  Lars Munch
 
 
  -- 
  Ce message a été vérifié par MailScanner
  pour des virus ou des polluriels et rien de
  suspect n'a été trouvé.
  Message délivré par le serveur de messagerie de l'Université d'Evry.
 
 


-- 
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)[EMAIL PROTECTED]


-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [PATCH] evas-framebuffer.pc.in rename

2008-04-11 Thread The Rasterman
On Mon, 7 Apr 2008 18:31:02 +0200 [EMAIL PROTECTED] (Lars Munch) babbled:

 Hi
 
 Unfortunately the addition off expedite_check_engine.m4 in expedite
 broke the detection of the framebuffer engine in expedite. The course of
 this is an inconsistent naming of the file evas-framebuffer.pc.in
 which should be named evas-fb.pc.in to be consistent with the other
 engine names.
 
 The attached patch renames this file an changes Configure.in and
 Makefile.am in ecore and evas accordingly.
 
 A quick grep in the cvs repository indicates that expedite is the only
 project that actually uses evas-framebuffer.pc, so the breakage of
 applying this patch should be minimal.

in cvs :)


-- 
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)[EMAIL PROTECTED]


-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] [PATCH] evas-framebuffer.pc.in rename

2008-04-07 Thread Lars Munch
Hi

Unfortunately the addition off expedite_check_engine.m4 in expedite
broke the detection of the framebuffer engine in expedite. The course of
this is an inconsistent naming of the file evas-framebuffer.pc.in
which should be named evas-fb.pc.in to be consistent with the other
engine names.

The attached patch renames this file an changes Configure.in and
Makefile.am in ecore and evas accordingly.

A quick grep in the cvs repository indicates that expedite is the only
project that actually uses evas-framebuffer.pc, so the breakage of
applying this patch should be minimal.

Regards
Lars Munch

diff -urN e17-orig/libs/ecore/configure.in e17/libs/ecore/configure.in
--- e17-orig/libs/ecore/configure.in	2008-03-28 15:38:35.0 +0100
+++ e17/libs/ecore/configure.in	2008-04-07 17:32:33.0 +0200
@@ -606,7 +606,7 @@
   AC_MSG_RESULT($want_ecore_evas_fb)
   
   if test x$want_ecore_evas_fb = xyes; then
-PKG_CHECK_MODULES(EVAS_FRAMEBUFFER, evas-framebuffer,
+PKG_CHECK_MODULES(EVAS_FB, evas-fb,
   [
 AC_DEFINE(BUILD_ECORE_EVAS_FB, 1, [Support for Linux FB in Ecore_Evas])
 have_ecore_evas_fb=yes
diff -urN e17-orig/libs/evas/configure.in e17/libs/evas/configure.in
--- e17-orig/libs/evas/configure.in	2008-03-14 17:49:47.0 +0100
+++ e17/libs/evas/configure.in	2008-04-07 17:31:04.0 +0200
@@ -1560,7 +1560,7 @@
 Makefile
 evas-cairo-x11.pc
 evas-directfb.pc
-evas-framebuffer.pc
+evas-fb.pc
 evas-glitz-x11.pc
 evas-opengl-glew.pc
 evas-opengl-x11.pc
diff -urN e17-orig/libs/evas/evas-fb.pc.in e17/libs/evas/evas-fb.pc.in
--- e17-orig/libs/evas/evas-fb.pc.in	1970-01-01 01:00:00.0 +0100
+++ e17/libs/evas/evas-fb.pc.in	2008-04-07 17:27:53.0 +0200
@@ -0,0 +1,3 @@
+Name: evas-fb
+Description: Evas framebuffer engine
+Version: @VERSION@
diff -urN e17-orig/libs/evas/evas-framebuffer.pc.in e17/libs/evas/evas-framebuffer.pc.in
--- e17-orig/libs/evas/evas-framebuffer.pc.in	2007-03-31 18:07:43.0 +0200
+++ e17/libs/evas/evas-framebuffer.pc.in	1970-01-01 01:00:00.0 +0100
@@ -1,3 +0,0 @@
-Name: evas-framebuffer
-Description: Evas framebuffer engine
-Version: @VERSION@
diff -urN e17-orig/libs/evas/Makefile.am e17/libs/evas/Makefile.am
--- e17-orig/libs/evas/Makefile.am	2008-02-18 08:20:50.0 +0100
+++ e17/libs/evas/Makefile.am	2008-04-07 17:30:25.0 +0200
@@ -10,7 +10,7 @@
 		   README \
 		   evas-cairo-x11.pc \
 		   evas-directfb.pc \
-		   evas-framebuffer.pc \
+		   evas-fb.pc \
 		   evas-glitz-x11.pc \
 		   evas-opengl-x11.pc \
 		   evas-opengl-glew.pc \
@@ -36,7 +36,7 @@
 	 evas.pc.in \
 	 evas-cairo-x11.pc \
 	 evas-directfb.pc \
-	 evas-framebuffer.pc \
+	 evas-fb.pc \
 	 evas-glitz-x11.pc \
 	 evas-opengl-x11.pc \
 	 evas-opengl-glew.pc \
@@ -72,7 +72,7 @@
 endif
 
 if BUILD_ENGINE_FB
-pframebuffer = evas-framebuffer.pc
+pfb = evas-fb.pc
 endif
 
 if BUILD_ENGINE_GLITZ_X11
@@ -125,7 +125,7 @@
 
 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = \
-	evas.pc $(psoftwarex11) $(psoftwarexcb) $(pdirectfb) $(pframebuffer) \
+	evas.pc $(psoftwarex11) $(psoftwarexcb) $(pdirectfb) $(pfb) \
 	$(psoftwarebuffer) $(psoftwareqtopia) $(popenglx11) $(pcairox11) \
 	$(pxrenderx11) $(pxrenderxcb) $(pglitzx11) $(psoftwareddraw) $(psoftwaresdl) \
 	$(psoftware16x11) $(pdirect3d) $(psoftwared16draw) $(popenglglew)
-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel