Re: [E-devel] [PATCH] evas DirectFB CVS changes
On Wed, 21 Sep 2005 21:14:09 -0300 Rob Shortt <[EMAIL PROTECTED]> babbled: > Hello, > > I am running DirectFB CVS (aka 0.9.23) and have just checked out and > installed evas. There was a small problem with a DirectFB API change > that I fixed with this patch. for now the patch is fair enouhg i'd say. into cvs we go. :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 [EMAIL PROTECTED] Tokyo, Japan (東京 日本) --- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] evas DirectFB CVS changes
Hi, Mike Frysinger wrote: > On Wednesday 21 September 2005 08:14 pm, Rob Shortt wrote: > >>I am running DirectFB CVS (aka 0.9.23) and have just checked out and >>installed evas. There was a small problem with a DirectFB API change >>that I fixed with this patch. > > > wouldnt it be saner to just keep evas compatible with the latest released > version ? otherwise, we'll end up with ugly #ifdef-ed code all over the > place ... especially with DirectFB which tends to change a little with every > release To a certain point I'd agree with you, if we had #ifdefs for multiple versions back and various API changes. But there's no checking here for versions older than the last release and I don't think it's unreasonable for one project's CVS to support another's. Many developers working on different projects need to build CVS versions all over the place. Also, once DirectFB 0.9.23 is released, if there is a desire to get rid of these #ifdefs, I could send a patch to remove them and tweak the version check in configure. Thanks, -Rob -- --- Rob Shortt| http://tvcentric.com | Freevo [EMAIL PROTECTED] | http://freevo.sf.net | Free your TV --- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] evas DirectFB CVS changes
On Wednesday 21 September 2005 08:14 pm, Rob Shortt wrote: > I am running DirectFB CVS (aka 0.9.23) and have just checked out and > installed evas. There was a small problem with a DirectFB API change > that I fixed with this patch. wouldnt it be saner to just keep evas compatible with the latest released version ? otherwise, we'll end up with ugly #ifdef-ed code all over the place ... especially with DirectFB which tends to change a little with every release -mike --- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] evas DirectFB CVS changes
Hello, I am running DirectFB CVS (aka 0.9.23) and have just checked out and installed evas. There was a small problem with a DirectFB API change that I fixed with this patch. Thanks, -Rob -- --- Rob Shortt| http://tvcentric.com | Freevo [EMAIL PROTECTED] | http://freevo.sf.net | Free your TV ? evas_directfb_cardcaps.patch Index: src/bin/evas_directfb_main.c === RCS file: /cvsroot/enlightenment/e17/libs/evas/src/bin/evas_directfb_main.c,v retrieving revision 1.4 diff -u -r1.4 evas_directfb_main.c --- src/bin/evas_directfb_main.c 22 May 2005 02:49:35 - 1.4 +++ src/bin/evas_directfb_main.c 21 Sep 2005 01:33:19 - @@ -26,7 +26,11 @@ IDirectFBEventBuffer *buffer; DFBResult err; DFBSurfaceDescription dsc; +#if (DIRECTFB_MAJOR_VERSION == 0) && (DIRECTFB_MINOR_VERSION == 9) && (DIRECTFB_MICRO_VERSION < 23) DFBCardCapabilities caps; +#else + DFBGraphicsDeviceDescription caps; +#endif DFBDisplayLayerConfig layer_config; DFBInputEvent evt; Index: src/bin/evas_directfb_window.c === RCS file: /cvsroot/enlightenment/e17/libs/evas/src/bin/evas_directfb_window.c,v retrieving revision 1.5 diff -u -r1.5 evas_directfb_window.c --- src/bin/evas_directfb_window.c 22 May 2005 02:49:35 - 1.5 +++ src/bin/evas_directfb_window.c 21 Sep 2005 01:33:19 - @@ -75,7 +75,11 @@ IDirectFBEventBuffer *buffer; DFBDisplayLayerConfig layer_config; +#if (DIRECTFB_MAJOR_VERSION == 0) && (DIRECTFB_MINOR_VERSION == 9) && (DIRECTFB_MICRO_VERSION < 23) DFBCardCapabilitiescaps; +#else + DFBGraphicsDeviceDescription caps; +#endif IDirectFBWindow* upper; DFBWindowIDid1; @@ -88,7 +92,11 @@ DFBCHECK(DirectFBInit( &argc, &argv )); DFBCHECK(DirectFBCreate( &dfb )); +#if (DIRECTFB_MAJOR_VERSION == 0) && (DIRECTFB_MINOR_VERSION == 9) && (DIRECTFB_MICRO_VERSION < 23) dfb->GetCardCapabilities( dfb, &caps ); +#else + dfb->GetDeviceDescription( dfb, &caps ); +#endif dfb->GetDisplayLayer( dfb, DLID_PRIMARY, &layer );
