Re: [E-devel] [PATCH] expedite cross build fix
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mike Frysinger schreef: | On Tuesday 18 March 2008, Koen Kooi wrote: |> Mike Frysinger schreef: |> | On Tuesday 18 March 2008, Lars Munch wrote: |> |> The attached patch fixes expedite cross build. Without this patch it |> |> will look in /usr/include for include files when cross building. |> | |> | ugh, anyone doing -i$(includedir) needs to get smacked. |> |> That's a pretty long list, sadly :( That's why things like this: |> |> http://www.openembedded.org/repo/org.openembedded.dev/packages/gcc/gcc-4.2. |> 2/zecke-no-host-includes.patch |> |> come in handy. | | eh, that's pretty heavy handed and sneaky. It is, but it forces people to stop doing stupid things like - -I${includedir} and makes QA on builds a lot easier | i dont think ive seen /opt/include probably qtopia | before, and /sw/include only applies to fink/OS X. Some people compile for arm-linux on osx :) regards, Koen -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFH4sVcMkyGM64RGpERAo41AKCuo36QZGXhVYsHyq7aAkA6Slpg0wCeKXM8 d8b54Eu/6tHv1O83SnMTcTo= =wdzL -END PGP SIGNATURE- - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
On Tuesday 18 March 2008, Michael Jennings wrote: > On Tuesday, 18 March 2008, at 08:52:12 (+0100), > Lars Munch wrote: > > The attached patch fixes expedite cross build. Without this patch it > > will look in /usr/include for include files when cross building. > > So could someone please explain to those of us who don't do > cross-compiling why $(includedir) would/should not be redefined when > cross-compiling? configure paths reflect the runtime paths for the package, not the build time > Please note that $(includedir) is not guaranteed to > be /usr/include or any other directory used by default, so being able > to ensure that headers in $(includedir) are found, particularly on > non-Linux systems, is of value. there's already a mechanism here that people stuck with such compilers can use that doesnt break people doing it the right way: CPPFLAGS= ./configure -mike signature.asc Description: This is a digitally signed message part. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
On Tuesday 18 March 2008, Koen Kooi wrote: > Mike Frysinger schreef: > | On Tuesday 18 March 2008, Lars Munch wrote: > |> The attached patch fixes expedite cross build. Without this patch it > |> will look in /usr/include for include files when cross building. > | > | ugh, anyone doing -i$(includedir) needs to get smacked. > > That's a pretty long list, sadly :( That's why things like this: > > http://www.openembedded.org/repo/org.openembedded.dev/packages/gcc/gcc-4.2. >2/zecke-no-host-includes.patch > > come in handy. eh, that's pretty heavy handed and sneaky. i dont think ive seen /opt/include before, and /sw/include only applies to fink/OS X. -mike signature.asc Description: This is a digitally signed message part. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
On Tuesday, 18 March 2008, at 19:34:48 (+0100), Koen Kooi wrote: > If you do builds like that you probably already pass in -isystem via > CFLAGS and/or use gcc sysroot and/or use pkgconfig sysroot and/or > plain pkgconfig. It is way easier to add something to CFLAGS or to > ./configure --with-foo-incloudes=/bar/qipl than to *remove* bogus > assumptions. > > And redefining ${includedir} means that I get headers installed to > /crazy/crossbuild/path/of/my/buildmachine/user/include on my *target > device* instead of /usr/include where I want them. Okay, that's fine. As long as I have someone to refer people to when they arrive in #E complaining. :-) Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> Linux Server/Cluster Admin, LBL.gov Author, Eterm (www.eterm.org) --- "Take me in to the Holy of Holies. Take me in by the blood of the Lamb. Take me in to the Holy of Holies. Take the coal; cleanse my lips; here I am."-- Petra - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Jennings schreef: | On Tuesday, 18 March 2008, at 18:49:11 (+0100), | Koen Kooi wrote: | |> It's not about redefining $(includedir), it's about this situation: |> |> arm-angstrom-linuxgnueabi-gcc something-doing-math.c -I/usr/include |> - -I/data/cross/arm/usr/include -o foo |> |> something-doing-math.c looks something like: |> |> .. |> #include |> .. |> |> The build will pick up the mmx version of the header from /usr/include |> (assuming you build on an intel system) and the compiler will choke on |> strange asm and datasizes. | | Only if you fail to redefine $(includedir). If $(includedir) were set | to, say, /data/cross/arm/usr/include instead, it would work fine. | |> Redefining ${includedir} won't help, since you want the software to end |> up in ${prefix} on the target when installing the package. | | It will help, insofar as the problem you mention above won't occur. | | If we don't include stuff in $(includedir), what is the appropriate | method for people who use, for example, --prefix=/opt/e17 to make sure | that /opt/e17/include/*.h gets picked up? Up until now, that was | handled automatically by the stuff you all just nuked. :) If you do builds like that you probably already pass in -isystem via CFLAGS and/or use gcc sysroot and/or use pkgconfig sysroot and/or plain pkgconfig. It is way easier to add something to CFLAGS or to ./configure - --with-foo-incloudes=/bar/qipl than to *remove* bogus assumptions. And redefining ${includedir} means that I get headers installed to /crazy/crossbuild/path/of/my/buildmachine/user/include on my *target device* instead of /usr/include where I want them. regards, Koen -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFH4AtIMkyGM64RGpERAmusAKCmrv5KTsOapTqf/s8tMMxzP1TnSwCdGKWb hY91COrqz3jIs+zRMdbDH24= =IMQ8 -END PGP SIGNATURE- - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
On Tuesday, 18 March 2008, at 18:49:11 (+0100), Koen Kooi wrote: > It's not about redefining $(includedir), it's about this situation: > > arm-angstrom-linuxgnueabi-gcc something-doing-math.c -I/usr/include > - -I/data/cross/arm/usr/include -o foo > > something-doing-math.c looks something like: > > .. > #include > .. > > The build will pick up the mmx version of the header from /usr/include > (assuming you build on an intel system) and the compiler will choke on > strange asm and datasizes. Only if you fail to redefine $(includedir). If $(includedir) were set to, say, /data/cross/arm/usr/include instead, it would work fine. > Redefining ${includedir} won't help, since you want the software to end > up in ${prefix} on the target when installing the package. It will help, insofar as the problem you mention above won't occur. If we don't include stuff in $(includedir), what is the appropriate method for people who use, for example, --prefix=/opt/e17 to make sure that /opt/e17/include/*.h gets picked up? Up until now, that was handled automatically by the stuff you all just nuked. :) Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> Linux Server/Cluster Admin, LBL.gov Author, Eterm (www.eterm.org) --- "Love, like a road that never ends. How it leads me back again to heartache, I don't understand." -- Peter Cetera and Amy Grant, "Next Time I Fall" - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mike Frysinger schreef: | On Tuesday 18 March 2008, Lars Munch wrote: |> The attached patch fixes expedite cross build. Without this patch it |> will look in /usr/include for include files when cross building. | | ugh, anyone doing -i$(includedir) needs to get smacked. I suspect raster fled to brazil to avoid the smacking he would get from the build engineers at openmoko ;) -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFH4ADdMkyGM64RGpERAqifAJ0WH6YLbfRhxLgHmE30YF3t0oiYsACgjVLp uK7Fa/3ewvtzvlfinuGeNlc= =7JdC -END PGP SIGNATURE- - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Jennings schreef: | On Tuesday, 18 March 2008, at 08:52:12 (+0100), | Lars Munch wrote: | |> The attached patch fixes expedite cross build. Without this patch it |> will look in /usr/include for include files when cross building. | | So could someone please explain to those of us who don't do | cross-compiling why $(includedir) would/should not be redefined when | cross-compiling? Please note that $(includedir) is not guaranteed to | be /usr/include or any other directory used by default, so being able | to ensure that headers in $(includedir) are found, particularly on | non-Linux systems, is of value. It's not about redefining $(includedir), it's about this situation: arm-angstrom-linuxgnueabi-gcc something-doing-math.c -I/usr/include - -I/data/cross/arm/usr/include -o foo something-doing-math.c looks something like: .. #include .. The build will pick up the mmx version of the header from /usr/include (assuming you build on an intel system) and the compiler will choke on strange asm and datasizes. Or if you are want to build against freetype 2.0 and your host has freetype 2.4 Things get even worse if you are cross-compiling to *bsd, aros, wince, etc. Redefining ${includedir} won't help, since you want the software to end up in $[{prefix} on the target when installing the package. Hopefully this clears things up a bit regards, Koen -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFH4ACXMkyGM64RGpERAg9RAJ0ZgVtglcFmIbPVpgMbiKcqE3tBlwCgkOmr bZ0aYYrAKyIqODhTLdaM+KY= =m7cc -END PGP SIGNATURE- - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
On Tuesday, 18 March 2008, at 08:52:12 (+0100), Lars Munch wrote: > The attached patch fixes expedite cross build. Without this patch it > will look in /usr/include for include files when cross building. So could someone please explain to those of us who don't do cross-compiling why $(includedir) would/should not be redefined when cross-compiling? Please note that $(includedir) is not guaranteed to be /usr/include or any other directory used by default, so being able to ensure that headers in $(includedir) are found, particularly on non-Linux systems, is of value. Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> Linux Server/Cluster Admin, LBL.gov Author, Eterm (www.eterm.org) --- "So when I'm far away, I will always be with you. You will never be alone. So if you feel the need, take my hand and share this night. It will be Eternity." -- Blessid Union of Souls, "Forever for Tonight" - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mike Frysinger schreef: | On Tuesday 18 March 2008, Lars Munch wrote: |> The attached patch fixes expedite cross build. Without this patch it |> will look in /usr/include for include files when cross building. | | ugh, anyone doing -i$(includedir) needs to get smacked. That's a pretty long list, sadly :( That's why things like this: http://www.openembedded.org/repo/org.openembedded.dev/packages/gcc/gcc-4.2.2/zecke-no-host-includes.patch come in handy. regards, Koen -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFH38Y+MkyGM64RGpERAr36AKC2cgbGfnRyiH/hyyIW/AH8aNpopgCggtxq 7Q5MGg69S2aDQf5xXmW4bqA= =FHk6 -END PGP SIGNATURE- - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] expedite cross build fix
On Tuesday 18 March 2008, Lars Munch wrote: > The attached patch fixes expedite cross build. Without this patch it > will look in /usr/include for include files when cross building. ugh, anyone doing -i$(includedir) needs to get smacked. added your change, thanks. -mike signature.asc Description: This is a digitally signed message part. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] expedite cross build fix
The attached patch fixes expedite cross build. Without this patch it will look in /usr/include for include files when cross building. Please apply. Regards Lars Munch Index: src/bin/Makefile.am === RCS file: /var/cvs/e/e17/apps/expedite/src/bin/Makefile.am,v retrieving revision 1.12 diff -u -r1.12 Makefile.am --- src/bin/Makefile.am 25 Feb 2008 06:08:34 - 1.12 +++ src/bin/Makefile.am 17 Mar 2008 21:39:29 - @@ -1,6 +1,5 @@ MAINTAINERCLEANFILES = Makefile.in -INCLUDES = -I$(includedir) \ - -I$(top_srcdir) \ +INCLUDES = -I$(top_srcdir) \ -I$(top_srcdir)/src/bin \ @EVAS_CFLAGS@ @x_cflags@ @SDL_CFLAGS@ @DIRECTFB_CFLAGS@ \ -DPACKAGE_BIN_DIR=\"@[EMAIL PROTECTED]" \ - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel