[E-devel] [PATCH] systemd: change from simple e18 service to target
This has a few advantages over the current approach: - only depends on user-session-units, not the flawed systemd-user-units - allows isolating the target to switch between e.g. e17 and e18 at runtime - works much more reliably for me Important: please don't commit without review by Cedric! --- data/units/Makefile.am | 6 +- data/units/e18.service | 9 +++-- data/units/e18.target | 6 ++ 3 files changed, 14 insertions(+), 7 deletions(-) create mode 100644 data/units/e18.target diff --git a/data/units/Makefile.am b/data/units/Makefile.am index 04ed87f..fd4190e 100644 --- a/data/units/Makefile.am +++ b/data/units/Makefile.am @@ -3,7 +3,11 @@ MAINTAINERCLEANFILES = Makefile.in if HAVE_SYSTEMD_USER_SESSION unitsdir = $(USER_SESSION_DIR) -units_DATA = e18.service +units_DATA = e18.service e18.target + +install-data-hook: + $(mkinstalldirs) $(DESTDIR)$(USER_SESSION_DIR)/e18.target.wants + @ln -sf e18.service $(DESTDIR)$(USER_SESSION_DIR)/e18.target.wants/ endif EXTRA_DIST = $(units_DATA) diff --git a/data/units/e18.service b/data/units/e18.service index ad413b9..d4c3441 100644 --- a/data/units/e18.service +++ b/data/units/e18.service @@ -1,12 +1,9 @@ [Unit] -Description=Enlightenment 18 service -Before=end.target +Description=The Enlightenment Window Manager After=xorg.target -Requires=xorg.target +Before=exit.target Requires=dbus.socket Wants=pulseaudio.service -Wants=ssh-agent.service -AllowIsolate=true [Service] Type=notify @@ -24,4 +21,4 @@ TimeoutSec=5 NotifyAccess=all [Install] -WantedBy=wm.target +WantedBy=e18.target diff --git a/data/units/e18.target b/data/units/e18.target new file mode 100644 index 000..ac9c340 --- /dev/null +++ b/data/units/e18.target @@ -0,0 +1,6 @@ + +[Unit] +Description=The Englightenment Desktop Environment built on EFL +Wants=xorg.target +Requires=dbus.socket +AllowIsolate=true -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] systemd: change from simple e18 service to target
Hello everyone, If this lands, https://phab.enlightenment.org/w/e18_with_systemd_user_session/ should be updated. -- Leif Am Samstag, 20. Juli 2013 um 16:50 schrieb Thomas Gstädtner: > > This has a few advantages over the current approach: > - only depends on user-session-units, not the flawed systemd-user-units > - allows isolating the target to switch between e.g. e17 and e18 at > runtime > - works much more reliably for me > > Important: please don't commit without review by Cedric! > --- > data/units/Makefile.am (http://Makefile.am) | 6 +- > data/units/e18.service | 9 +++-- > data/units/e18.target | 6 ++ > 3 files changed, 14 insertions(+), 7 deletions(-) > create mode 100644 data/units/e18.target > > -- > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > (mailto:enlightenment-devel@lists.sourceforge.net) > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > Anhänge: > - 0001-systemd-change-from-simple-e18-service-to-target.patch > -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] systemd: change from simple e18 service to target
On Tue, Jul 23, 2013 at 2:31 PM, Leif Middelschulte wrote: > Hello everyone, > > If this lands, > https://phab.enlightenment.org/w/e18_with_systemd_user_session/ should be > updated. > > -- > Leif > I will do that once it is in. I talked to Cedric already and am waiting until he gets his systemd machine running again and tests it. In the meantime, if you want to test it: There isn't actually much changing, just ignore the "systemd-user-units" part of the article and everything will be fine (in fact, the current howto isn't enough to use it like described anyway, it is much more likely that you get the new stuff working with it than the existing one :). Other than that, simply use the documentation of sofar's user-session-units and replace e17 by e18, it is fully compatible to this and should work on any machine with systemd (not just arch). Sidenote: There still is a bug with systemd's watchdog in E, so the watchdog doesn't actually work, but that's not directly related to this and happens with both approaches. I will have a look at this, soon. > > Am Samstag, 20. Juli 2013 um 16:50 schrieb Thomas Gstädtner: > >> >> This has a few advantages over the current approach: >> - only depends on user-session-units, not the flawed systemd-user-units >> - allows isolating the target to switch between e.g. e17 and e18 at >> runtime >> - works much more reliably for me >> >> Important: please don't commit without review by Cedric! >> --- >> data/units/Makefile.am (http://Makefile.am) | 6 +- >> data/units/e18.service | 9 +++-- >> data/units/e18.target | 6 ++ >> 3 files changed, 14 insertions(+), 7 deletions(-) >> create mode 100644 data/units/e18.target >> >> -- >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> (mailto:enlightenment-devel@lists.sourceforge.net) >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> >> >> Anhänge: >> - 0001-systemd-change-from-simple-e18-service-to-target.patch >> > > > -- > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] systemd: change from simple e18 service to target
Hello, On Tue, Jul 23, 2013 at 6:37 PM, thomasg wrote: > On Tue, Jul 23, 2013 at 2:31 PM, Leif Middelschulte > wrote: >> Hello everyone, >> >> If this lands, >> https://phab.enlightenment.org/w/e18_with_systemd_user_session/ should be >> updated. > > I will do that once it is in. I talked to Cedric already and am > waiting until he gets his systemd machine running again and tests it. > In the meantime, if you want to test it: There isn't actually much > changing, just ignore the "systemd-user-units" part of the article and > everything will be fine (in fact, the current howto isn't enough to > use it like described anyway, it is much more likely that you get the > new stuff working with it than the existing one :). > Other than that, simply use the documentation of sofar's > user-session-units and replace e17 by e18, it is fully compatible to > this and should work on any machine with systemd (not just arch). Ok, I finally got the time to try it. There is something weird after I apply your patch it doesn't seems to honor the KillMode=process anymore. Hum, in fact, I didn't try with the previous unit since I upgraded systemd, maybe that's an issue related to systemd (And my install is still quite not working as I need to manually do a 'systemctl start user-session@1000.service' even when the enable has been done). > Sidenote: There still is a bug with systemd's watchdog in E, so the > watchdog doesn't actually work, but that's not directly related to > this and happens with both approaches. I will have a look at this, > soon. I also quickly noted that the watchdog is indeed not working anymore. For what it is, by moving AllowIsolate in e18.service, the delay between restart of enlightenment seems to be quite higher, but not sure yet why. What was the reason of moving AllowIsolate in the .target ? Need some investigation on why this watchdog is not working anymore. I will investigate that in the evening if I get some time. If I get some time I will update the step needed to set it up with latest systemd on arch (should be working on any distribution with latest systemd). Regards, Cedric >> Am Samstag, 20. Juli 2013 um 16:50 schrieb Thomas Gstädtner: >>> This has a few advantages over the current approach: >>> - only depends on user-session-units, not the flawed systemd-user-units >>> - allows isolating the target to switch between e.g. e17 and e18 at >>> runtime >>> - works much more reliably for me >>> >>> Important: please don't commit without review by Cedric! >>> --- >>> data/units/Makefile.am (http://Makefile.am) | 6 +- >>> data/units/e18.service | 9 +++-- >>> data/units/e18.target | 6 ++ >>> 3 files changed, 14 insertions(+), 7 deletions(-) >>> create mode 100644 data/units/e18.target >>> >>> -- >>> See everything from the browser to the database with AppDynamics >>> Get end-to-end visibility with application monitoring from AppDynamics >>> Isolate bottlenecks and diagnose root cause in seconds. >>> Start your free trial of AppDynamics Pro today! >>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >>> >>> ___ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> (mailto:enlightenment-devel@lists.sourceforge.net) >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> >>> >>> >>> >>> Anhänge: >>> - 0001-systemd-change-from-simple-e18-service-to-target.patch >>> >> >> >> -- >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Cedric BAIL -- Get your SQL database under version control now! Version control is standard for application code, but databases havent caught
Re: [E-devel] [PATCH] systemd: change from simple e18 service to target
On Wed, Jul 31, 2013 at 5:13 AM, Cedric BAIL wrote: > Hello, > > On Tue, Jul 23, 2013 at 6:37 PM, thomasg wrote: >> On Tue, Jul 23, 2013 at 2:31 PM, Leif Middelschulte >> wrote: >>> Hello everyone, >>> >>> If this lands, >>> https://phab.enlightenment.org/w/e18_with_systemd_user_session/ should be >>> updated. >> >> I will do that once it is in. I talked to Cedric already and am >> waiting until he gets his systemd machine running again and tests it. >> In the meantime, if you want to test it: There isn't actually much >> changing, just ignore the "systemd-user-units" part of the article and >> everything will be fine (in fact, the current howto isn't enough to >> use it like described anyway, it is much more likely that you get the >> new stuff working with it than the existing one :). >> Other than that, simply use the documentation of sofar's >> user-session-units and replace e17 by e18, it is fully compatible to >> this and should work on any machine with systemd (not just arch). > > Ok, I finally got the time to try it. There is something weird after I > apply your patch it doesn't seems to honor the KillMode=process > anymore. Hum, in fact, I didn't try with the previous unit since I > upgraded systemd, maybe that's an issue related to systemd (And my > install is still quite not working as I need to manually do a > 'systemctl start user-session@1000.service' even when the enable has > been done). > >> Sidenote: There still is a bug with systemd's watchdog in E, so the >> watchdog doesn't actually work, but that's not directly related to >> this and happens with both approaches. I will have a look at this, >> soon. > > I also quickly noted that the watchdog is indeed not working anymore. > For what it is, by moving AllowIsolate in e18.service, the delay > between restart of enlightenment seems to be quite higher, but not > sure yet why. What was the reason of moving AllowIsolate in the > .target ? Need some investigation on why this watchdog is not working > anymore. > > I will investigate that in the evening if I get some time. If I get > some time I will update the step needed to set it up with latest > systemd on arch (should be working on any distribution with latest > systemd). > > Regards, > Cedric Please don't invest too much time, because there have been a few developments in systemd that make it not worth your time. Starting with systemd 205, systemd --user behavior has changed, and it is not even slightly compatible with the behaviour until 204. So user sessions as they were do not exist anymore. I haven't looked much closer into it because systemd 206 has some bugs that break my system and will be fixed in future releases, but when I can safely upgrade from 204, I'll have a look at how to do things in future, as the old behavior will not come back and all current approaches are not supported anymore. >>> Am Samstag, 20. Juli 2013 um 16:50 schrieb Thomas Gstädtner: This has a few advantages over the current approach: - only depends on user-session-units, not the flawed systemd-user-units - allows isolating the target to switch between e.g. e17 and e18 at runtime - works much more reliably for me Important: please don't commit without review by Cedric! --- data/units/Makefile.am (http://Makefile.am) | 6 +- data/units/e18.service | 9 +++-- data/units/e18.target | 6 ++ 3 files changed, 14 insertions(+), 7 deletions(-) create mode 100644 data/units/e18.target -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net (mailto:enlightenment-devel@lists.sourceforge.net) https://lists.sourceforge.net/lists/listinfo/enlightenment-devel Anhänge: - 0001-systemd-change-from-simple-e18-service-to-target.patch >>> >>> >>> -- >>> See everything from the browser to the database with AppDynamics >>> Get end-to-end visibility with application monitoring from AppDynamics >>> Isolate bottlenecks and diagnose root cause in seconds. >>> Start your free trial of AppDynamics Pro today! >>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >>> ___ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >>
Re: [E-devel] [PATCH] systemd: change from simple e18 service to target
On Wed, Jul 31, 2013 at 6:47 PM, thomasg wrote: > On Wed, Jul 31, 2013 at 5:13 AM, Cedric BAIL wrote: >> On Tue, Jul 23, 2013 at 6:37 PM, thomasg wrote: >>> On Tue, Jul 23, 2013 at 2:31 PM, Leif Middelschulte >>> wrote: Hello everyone, If this lands, https://phab.enlightenment.org/w/e18_with_systemd_user_session/ should be updated. >>> >>> I will do that once it is in. I talked to Cedric already and am >>> waiting until he gets his systemd machine running again and tests it. >>> In the meantime, if you want to test it: There isn't actually much >>> changing, just ignore the "systemd-user-units" part of the article and >>> everything will be fine (in fact, the current howto isn't enough to >>> use it like described anyway, it is much more likely that you get the >>> new stuff working with it than the existing one :). >>> Other than that, simply use the documentation of sofar's >>> user-session-units and replace e17 by e18, it is fully compatible to >>> this and should work on any machine with systemd (not just arch). >> >> Ok, I finally got the time to try it. There is something weird after I >> apply your patch it doesn't seems to honor the KillMode=process >> anymore. Hum, in fact, I didn't try with the previous unit since I >> upgraded systemd, maybe that's an issue related to systemd (And my >> install is still quite not working as I need to manually do a >> 'systemctl start user-session@1000.service' even when the enable has >> been done). >> >>> Sidenote: There still is a bug with systemd's watchdog in E, so the >>> watchdog doesn't actually work, but that's not directly related to >>> this and happens with both approaches. I will have a look at this, >>> soon. >> >> I also quickly noted that the watchdog is indeed not working anymore. >> For what it is, by moving AllowIsolate in e18.service, the delay >> between restart of enlightenment seems to be quite higher, but not >> sure yet why. What was the reason of moving AllowIsolate in the >> .target ? Need some investigation on why this watchdog is not working >> anymore. >> >> I will investigate that in the evening if I get some time. If I get >> some time I will update the step needed to set it up with latest >> systemd on arch (should be working on any distribution with latest >> systemd). > > Please don't invest too much time, because there have been a few > developments in systemd that make it not worth your time. > Starting with systemd 205, systemd --user behavior has changed, and it > is not even slightly compatible with the behaviour until 204. So user > sessions as they were do not exist anymore. > I haven't looked much closer into it because systemd 206 has some bugs > that break my system and will be fixed in future releases, but when I > can safely upgrade from 204, I'll have a look at how to do things in > future, as the old behavior will not come back and all current > approaches are not supported anymore. Yeah, I have rolled back to 204 myself to. It is working fine (except the watchdog, that is to be investigated). I will wait for the borking on systemd user session to come back in a usable state and try to update the unit again at that time. Will see when that roll in arch. Btw what distribution do you use ? -- Cedric BAIL -- Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
