[E-devel] [Patch] add edje_object_all_parts_default_state_set API
Dear all, I made a API "edje_object_all_parts_default_state_set(Evas_Object obj)" This work was requested by Daniel Juyung Seo. This API sets the state of all parts to default. Please check attached patch file. Thanks. edje_object_all_parts_default_state_set.patch Description: Binary data -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] add edje_object_all_parts_default_state_set API
The code itself looks good :) I just question the choice of Function name for the API. Why not simply edje_object_default_state_set ?? which would then reset the Whole edje object to default state (all parts included). dh - Original Message - From: "Jaehwan Kim" To: enlightenment-devel@lists.sourceforge.net Sent: Friday, September 23, 2011 1:26:13 AM Subject: [E-devel] [Patch] add edje_object_all_parts_default_state_set API Dear all, I made a API "edje_object_all_parts_default_state_set(Evas_Object obj)" This work was requested by Daniel Juyung Seo. This API sets the state of all parts to default. Please check attached patch file. Thanks. -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] add edje_object_all_parts_default_state_set API
2011/9/23 Jaehwan Kim : > Dear all, > > I made a API "edje_object_all_parts_default_state_set(Evas_Object obj)" > This work was requested by Daniel Juyung Seo. > This API sets the state of all parts to default. > Please check attached patch file. The patch is simple to understand, so far so good. First remark, you should better call _edje_recalc(ed); instead of edje_object_calc_force as their is no need yet to recalculate everything it can wait. The second and most concerning issue to me, is that you are changing part state without resetting the embryo or lua vm and other internal program. I think it is necessary, because you don't know what is currently running inside it. So I would prefer this patch to implement just a edje_object_reset(Evas_Object obj) that will also reset the various vm, destroy all pending timer, destroy the content of the event queue and stop all pending program. With that function we could easily reuse the Edje object from a cache without the need to add a special state that would reset it to default. -- Cedric BAIL -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] add edje_object_all_parts_default_state_set API
Good observation. Thanks a lot. This is what we really need :) Daniel Juyung Seo (SeoZ) On Fri, Sep 23, 2011 at 5:29 PM, Cedric BAIL wrote: > 2011/9/23 Jaehwan Kim : >> Dear all, >> >> I made a API "edje_object_all_parts_default_state_set(Evas_Object obj)" >> This work was requested by Daniel Juyung Seo. >> This API sets the state of all parts to default. >> Please check attached patch file. > > The patch is simple to understand, so far so good. First remark, you > should better call _edje_recalc(ed); instead of edje_object_calc_force > as their is no need yet to recalculate everything it can wait. > > The second and most concerning issue to me, is that you are changing > part state without resetting the embryo or lua vm and other internal > program. I think it is necessary, because you don't know what is > currently running inside it. So I would prefer this patch to implement > just a edje_object_reset(Evas_Object obj) that will also reset the > various vm, destroy all pending timer, destroy the content of the > event queue and stop all pending program. With that function we could > easily reuse the Edje object from a cache without the need to add a > special state that would reset it to default. > -- > Cedric BAIL > > -- > All of the data generated in your IT infrastructure is seriously valuable. > Why? It contains a definitive record of application performance, security > threats, fraudulent activity, and more. Splunk takes this data and makes > sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-d2dcopy2 > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] add edje_object_all_parts_default_state_set API
On Fri, 23 Sep 2011 17:42:15 +0900 Daniel Juyung Seo said: yup. you really want a "reset to state just after load" ... ie reset.. not just the part states. everything (embryo vm's, lua etc.) > Good observation. Thanks a lot. This is what we really need :) > > Daniel Juyung Seo (SeoZ) > > On Fri, Sep 23, 2011 at 5:29 PM, Cedric BAIL wrote: > > 2011/9/23 Jaehwan Kim : > >> Dear all, > >> > >> I made a API "edje_object_all_parts_default_state_set(Evas_Object obj)" > >> This work was requested by Daniel Juyung Seo. > >> This API sets the state of all parts to default. > >> Please check attached patch file. > > > > The patch is simple to understand, so far so good. First remark, you > > should better call _edje_recalc(ed); instead of edje_object_calc_force > > as their is no need yet to recalculate everything it can wait. > > > > The second and most concerning issue to me, is that you are changing > > part state without resetting the embryo or lua vm and other internal > > program. I think it is necessary, because you don't know what is > > currently running inside it. So I would prefer this patch to implement > > just a edje_object_reset(Evas_Object obj) that will also reset the > > various vm, destroy all pending timer, destroy the content of the > > event queue and stop all pending program. With that function we could > > easily reuse the Edje object from a cache without the need to add a > > special state that would reset it to default. > > -- > > Cedric BAIL > > > > -- > > All of the data generated in your IT infrastructure is seriously valuable. > > Why? It contains a definitive record of application performance, security > > threats, fraudulent activity, and more. Splunk takes this data and makes > > sense of it. IT sense. And common sense. > > http://p.sf.net/sfu/splunk-d2dcopy2 > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > All of the data generated in your IT infrastructure is seriously valuable. > Why? It contains a definitive record of application performance, security > threats, fraudulent activity, and more. Splunk takes this data and makes > sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-d2dcopy2 > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
