[E-devel] [patch] esmart: Add autogen.sh to dist tarball
Is the following appropriate? - Subject: Add autogen.sh to dist tarball autogen.sh is used by the debian packaging so it seems appropriate to include it in the dist tarball Index: esmart/Makefile.am === --- esmart.orig/Makefile.am 2009-09-09 09:12:57.0 +1000 +++ esmart/Makefile.am 2009-09-09 09:13:03.0 +1000 @@ -18,7 +18,7 @@ EXTRA_DIST = README AUTHORS COPYING esma esmart_text_entry.pc.in \ esmart_thumb.pc.in \ esmart_trans_x11.pc.in \ -esmart_xpixmap.pc.in +esmart_xpixmap.pc.in autogen.sh pkgconfigdir = $(libdir)/pkgconfig -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] esmart: Add autogen.sh to dist tarball
On Wed, 09 Sep 2009 09:24 +1000, Simon Horman wrote : > Is the following appropriate? > > - > > Subject: Add autogen.sh to dist tarball > > autogen.sh is used by the debian packaging so it seems > appropriate to include it in the dist tarball Either you're packaging from SVN and therefore don't need it to be part of the dist tarball, or you're packaging from the snapshots at download.enlightenment.org (or snapshots you generated) and then your packaging should be fixed to use directly ./configure instead of configure.sh. Is there an actual use case I'm missing, for which this change would be required? Regards, -- Albin Tonnerre signature.asc Description: Digital signature -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] esmart: Add autogen.sh to dist tarball
On Wed, 9 Sep 2009, Albin Tonnerre wrote: > On Wed, 09 Sep 2009 09:24 +1000, Simon Horman wrote : >> Is the following appropriate? >> >> - >> >> Subject: Add autogen.sh to dist tarball >> >> autogen.sh is used by the debian packaging so it seems >> appropriate to include it in the dist tarball > > Either you're packaging from SVN and therefore don't need it to be part of the > dist tarball, or you're packaging from the snapshots at > download.enlightenment.org (or snapshots you generated) and then your > packaging > should be fixed to use directly ./configure instead of configure.sh. > Is there an actual use case I'm missing, for which this change would be > required? i needed it once for libpng (no repository) for the windows ce port. But usually, autoreconf is called if you modify configure.ac in the EFL, autogen.sh is usually added to the tarball. But i think that it can be removed from it. Vincent -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] esmart: Add autogen.sh to dist tarball
On Wed, Sep 09, 2009 at 09:30:24AM +0200, Albin Tonnerre wrote: > On Wed, 09 Sep 2009 09:24 +1000, Simon Horman wrote : > > Is the following appropriate? > > > > - > > > > Subject: Add autogen.sh to dist tarball > > > > autogen.sh is used by the debian packaging so it seems > > appropriate to include it in the dist tarball > > Either you're packaging from SVN and therefore don't need it to be part of the > dist tarball, or you're packaging from the snapshots at > download.enlightenment.org (or snapshots you generated) and then your > packaging > should be fixed to use directly ./configure instead of configure.sh. > Is there an actual use case I'm missing, for which this change would be > required? Thanks for filling me in on the expected usage. I was thinking of the case where you want to test what is in SVN by: 1) creating a tarball 2) building a debian package from that tarball after unpacking is and manually copying over the debian/ directory from SVN. But if thats not valid, I'll stop doing it. When you say fixed to use ./configure directly, when and how does that occur? I agree that calling ./configure is preferable when building Debian packages. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] esmart: Add autogen.sh to dist tarball
On Thu, 10 Sep 2009 09:50:04 +1000 Simon Horman said: > On Wed, Sep 09, 2009 at 09:30:24AM +0200, Albin Tonnerre wrote: > > On Wed, 09 Sep 2009 09:24 +1000, Simon Horman wrote : > > > Is the following appropriate? > > > > > > - > > > > > > Subject: Add autogen.sh to dist tarball > > > > > > autogen.sh is used by the debian packaging so it seems > > > appropriate to include it in the dist tarball > > > > Either you're packaging from SVN and therefore don't need it to be part of > > the dist tarball, or you're packaging from the snapshots at > > download.enlightenment.org (or snapshots you generated) and then your > > packaging should be fixed to use directly ./configure instead of > > configure.sh. Is there an actual use case I'm missing, for which this > > change would be required? > > Thanks for filling me in on the expected usage. actually. alibin is wrong (sorry!) autogen's do get packaged. look at existing efl. we put it in so if u get a tarball u CAN easily modify the configure.ac, Makefile.am's etc. and re-generate the autofoo. the script will be there with all the magic. not everyone will want or need to do this from a tarball dist - but it dos happen. people patching packages are often the ones using it. so it's not valid. it's an omission in the esmart build foo. :) (even if albin was right - eet, evas, elementary, edje, ... etc. all include autogen.sh in their EXTRA_DIST, so it'd go in for consistency sake. it's goo to have everything in svn have consistent autofoo files and work the same way. it makes everything hav the same bug o everything is right. not some things buggy, some not, in terms of autofoo usage/structure, so if u do find a bug/issue - u can know that fixing it everywhere else is trivial) > I was thinking of the case where you want to test what is > in SVN by: > > 1) creating a tarball > 2) building a debian package from that tarball after unpacking is >and manually copying over the debian/ directory from SVN. > > But if thats not valid, I'll stop doing it. > > When you say fixed to use ./configure directly, when and how does that occur? > I agree that calling ./configure is preferable when building Debian packages. > > > > -- > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] esmart: Add autogen.sh to dist tarball
On Thu, Sep 10, 2009 at 10:46:54AM +1000, Carsten Haitzler wrote: > On Thu, 10 Sep 2009 09:50:04 +1000 Simon Horman said: > > > On Wed, Sep 09, 2009 at 09:30:24AM +0200, Albin Tonnerre wrote: > > > On Wed, 09 Sep 2009 09:24 +1000, Simon Horman wrote : > > > > Is the following appropriate? > > > > > > > > - > > > > > > > > Subject: Add autogen.sh to dist tarball > > > > > > > > autogen.sh is used by the debian packaging so it seems > > > > appropriate to include it in the dist tarball > > > > > > Either you're packaging from SVN and therefore don't need it to be part of > > > the dist tarball, or you're packaging from the snapshots at > > > download.enlightenment.org (or snapshots you generated) and then your > > > packaging should be fixed to use directly ./configure instead of > > > configure.sh. Is there an actual use case I'm missing, for which this > > > change would be required? > > > > Thanks for filling me in on the expected usage. > > actually. alibin is wrong (sorry!) autogen's do get packaged. look at existing > efl. we put it in so if u get a tarball u CAN easily modify the configure.ac, > Makefile.am's etc. and re-generate the autofoo. the script will be there with > all the magic. not everyone will want or need to do this from a tarball dist - > but it dos happen. people patching packages are often the ones using it. so > it's not valid. it's an omission in the esmart build foo. :) (even if albin > was > right - eet, evas, elementary, edje, ... etc. all include autogen.sh in their > EXTRA_DIST, so it'd go in for consistency sake. it's goo to have everything in > svn have consistent autofoo files and work the same way. it makes everything > hav the same bug o everything is right. not some things buggy, some not, in > terms of autofoo usage/structure, so if u do find a bug/issue - u can know > that > fixing it everywhere else is trivial) Ok, I should have pointed out in the beginning that I really just wanted to make things consistent. With that in mind I'll commit my change. It can always be changed if in the future it is decided to consistently do something else. [snip] -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] esmart: Add autogen.sh to dist tarball
On Thu, 10 Sep 2009 10:54:01 +1000 Simon Horman said: > > actually. alibin is wrong (sorry!) autogen's do get packaged. look at > > existing efl. we put it in so if u get a tarball u CAN easily modify the > > configure.ac, Makefile.am's etc. and re-generate the autofoo. the script > > will be there with all the magic. not everyone will want or need to do this > > from a tarball dist - but it dos happen. people patching packages are often > > the ones using it. so it's not valid. it's an omission in the esmart build > > foo. :) (even if albin was right - eet, evas, elementary, edje, ... etc. > > all include autogen.sh in their EXTRA_DIST, so it'd go in for consistency > > sake. it's goo to have everything in svn have consistent autofoo files and > > work the same way. it makes everything hav the same bug o everything is > > right. not some things buggy, some not, in terms of autofoo > > usage/structure, so if u do find a bug/issue - u can know that fixing it > > everywhere else is trivial) > > Ok, I should have pointed out in the beginning that I really just wanted > to make things consistent. With that in mind I'll commit my change. It can > always be changed if in the future it is decided to consistently do > something else. no need. i already added it :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] esmart: Add autogen.sh to dist tarball
On Thu, 10 Sep 2009, Carsten Haitzler (The Rasterman) wrote: > On Thu, 10 Sep 2009 09:50:04 +1000 Simon Horman said: > >> On Wed, Sep 09, 2009 at 09:30:24AM +0200, Albin Tonnerre wrote: >>> On Wed, 09 Sep 2009 09:24 +1000, Simon Horman wrote : Is the following appropriate? - Subject: Add autogen.sh to dist tarball autogen.sh is used by the debian packaging so it seems appropriate to include it in the dist tarball >>> >>> Either you're packaging from SVN and therefore don't need it to be part of >>> the dist tarball, or you're packaging from the snapshots at >>> download.enlightenment.org (or snapshots you generated) and then your >>> packaging should be fixed to use directly ./configure instead of >>> configure.sh. Is there an actual use case I'm missing, for which this >>> change would be required? >> >> Thanks for filling me in on the expected usage. > > actually. alibin is wrong (sorry!) autogen's do get packaged. look at existing > efl. we put it in so if u get a tarball u CAN easily modify the configure.ac, > Makefile.am's etc. and re-generate the autofoo. the script will be there with > all the magic. not everyone will want or need to do this from a tarball dist - > but it dos happen. people patching packages are often the ones using it. so > it's not valid. it's an omission in the esmart build foo. :) (even if albin > was > right - eet, evas, elementary, edje, ... etc. all include autogen.sh in their > EXTRA_DIST, so it'd go in for consistency sake. it's goo to have everything in > svn have consistent autofoo files and work the same way. it makes everything > hav the same bug o everything is right. not some things buggy, some not, in > terms of autofoo usage/structure, so if u do find a bug/issue - u can know > that > fixing it everywhere else is trivial) get a source, modify configure.ac, run make. The autotools commands will be re-launched. Sometimes, when the modifications are too big, you need autogen.sh (i had that problem), or use autoreconf. Vincent -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] esmart: Add autogen.sh to dist tarball
On Thu, 10 Sep 2009 06:48:27 +0200 (CEST) Vincent Torri said: > > > On Thu, 10 Sep 2009, Carsten Haitzler (The Rasterman) wrote: > > > On Thu, 10 Sep 2009 09:50:04 +1000 Simon Horman said: > > > >> On Wed, Sep 09, 2009 at 09:30:24AM +0200, Albin Tonnerre wrote: > >>> On Wed, 09 Sep 2009 09:24 +1000, Simon Horman wrote : > Is the following appropriate? > > - > > Subject: Add autogen.sh to dist tarball > > autogen.sh is used by the debian packaging so it seems > appropriate to include it in the dist tarball > >>> > >>> Either you're packaging from SVN and therefore don't need it to be part of > >>> the dist tarball, or you're packaging from the snapshots at > >>> download.enlightenment.org (or snapshots you generated) and then your > >>> packaging should be fixed to use directly ./configure instead of > >>> configure.sh. Is there an actual use case I'm missing, for which this > >>> change would be required? > >> > >> Thanks for filling me in on the expected usage. > > > > actually. alibin is wrong (sorry!) autogen's do get packaged. look at > > existing efl. we put it in so if u get a tarball u CAN easily modify the > > configure.ac, Makefile.am's etc. and re-generate the autofoo. the script > > will be there with all the magic. not everyone will want or need to do this > > from a tarball dist - but it dos happen. people patching packages are often > > the ones using it. so it's not valid. it's an omission in the esmart build > > foo. :) (even if albin was right - eet, evas, elementary, edje, ... etc. > > all include autogen.sh in their EXTRA_DIST, so it'd go in for consistency > > sake. it's goo to have everything in svn have consistent autofoo files and > > work the same way. it makes everything hav the same bug o everything is > > right. not some things buggy, some not, in terms of autofoo > > usage/structure, so if u do find a bug/issue - u can know that fixing it > > everywhere else is trivial) > > get a source, modify configure.ac, run make. The autotools commands will > be re-launched. > > Sometimes, when the modifications are too big, you need autogen.sh (i had > that problem), or use autoreconf. yeah. you can get into that state of it not being able to re-bootstrap itself, thus the need for autogen -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
