Re: [E-devel] eina_safety check ERRs

2018-07-14 Thread Mike Blumenkrantz
Thanks for bringing this up. In an attempt to discover and fix more bugs,
we've added some error messages to functions which should never be passed
null--such as the ones you've listed here. Any time null is passed to one
of these functions, it means that the author of the code was not aware of
an object's existence, and it's likely that a bug will result.

There's an overall tracking task for this here (
https://phab.enlightenment.org/T7030) with subtasks being created for each
area that the errors are found in.

This is a good place for new contributors to jump in, as the fixes for
these issues just involve reading the code a bit to see why the passed
object does not exist.

On Sat, Jul 14, 2018 at 9:06 AM Jean Rene Dawin <
jda...@math.uni-bielefeld.de> wrote:

> Hello,
>
> since about commit b0e0fcf3d60eac53229ce107b01c6d31ce8aa817
>
> elementary_test, elementary_config, terminology throw lots of verbose
> eina_safety ERR messages (see below).
> Just wanted to ask if these messages point to real errors (and how to fix
> them) or if they are maybe false positives.
>
> The tests below were done with efl from commit
> 6fa8c581b564cf85eba89cbb61ebaa067f7da051
> With earlier commit 3c8bc31e75478137c08ea9492c685cb4261a9499 the ERR
> messages were gone or less verbose.
>
> 1. Run elementary_test
> 2. Click "Lyayot2"
> 3. Close Layout2 window.
>
> Output:
>
> ERR<28170>:eina_safety lib/evas/canvas/evas_callbacks.c:539
> evas_object_event_callback_del_full() safety check failed: obj == NULL
> ## Copy & Paste the below (until EOF) into a terminal, then hit Enter
>
>
> eina_btlog << EOF
> /usr/local/lib/libeina.so.1  0x7f1fb57c8462 0x7f1fb5795000
> ...
>
>
>
>
> 1. Run elementary_config
> 2. Close window
>
> Output:
>
> ERR<28279>:eina_safety lib/elementary/elm_main.c:1760
> elm_object_signal_emit() safety check failed: obj == NULL
> ## Copy & Paste the below (until EOF) into a terminal, then hit Enter
>
>
> eina_btlog << EOF
> /usr/local/lib/libeina.so.1  0x7f7c7a8e8462 0x7f7c7a8b5000
> ...
>
>
>
>
> 1. Run terminology
> 2. Right Click
> 3. Click Settings
>
> Output:
>
> CRI<27896>:eina_log ../src/bin/win.c:1762 win_new() unknown log domain -1,
> original message level was: WRN
>
> ERR<27896>:eo lib/eo/eo.c:2113 efl_data_scope_get() Eo ID 0x55ddef262c10
> is not a valid object. Current thread: main. This ID has probably been
> deleted or this was never a valid object ID. (domain=2, current_do
> main=0, local_domain=0, available_domains=[0 1], generation=10,
> id=98b, ref=1)
> ## Copy & Paste the below (until EOF) into a terminal, then hit Enter
>
> eina_btlog << EOF
> /usr/local/lib/libeina.so.1  0x7fb0e87f4462 0x7fb0e87c1000
> ...
>
> ERR<28445>:eina_safety lib/evas/canvas/evas_callbacks.c:539
> evas_object_event_callback_del_full() safety check failed: obj == NULL
> ## Copy & Paste the below (until EOF) into a terminal, then hit Enter
> ...
>
>
> Regards,
> Jean Rene
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] eina_safety check ERRs

2018-07-14 Thread Jean Rene Dawin
Hello,

since about commit b0e0fcf3d60eac53229ce107b01c6d31ce8aa817

elementary_test, elementary_config, terminology throw lots of verbose 
eina_safety ERR messages (see below).
Just wanted to ask if these messages point to real errors (and how to fix them) 
or if they are maybe false positives.

The tests below were done with efl from commit 
6fa8c581b564cf85eba89cbb61ebaa067f7da051
With earlier commit 3c8bc31e75478137c08ea9492c685cb4261a9499 the ERR messages 
were gone or less verbose.

1. Run elementary_test
2. Click "Lyayot2"
3. Close Layout2 window.

Output:

ERR<28170>:eina_safety lib/evas/canvas/evas_callbacks.c:539 
evas_object_event_callback_del_full() safety check failed: obj == NULL
## Copy & Paste the below (until EOF) into a terminal, then hit Enter   
  

  
eina_btlog << EOF
/usr/local/lib/libeina.so.1  0x7f1fb57c8462 0x7f1fb5795000
...




1. Run elementary_config 
2. Close window

Output:
   
ERR<28279>:eina_safety lib/elementary/elm_main.c:1760 elm_object_signal_emit() 
safety check failed: obj == NULL
## Copy & Paste the below (until EOF) into a terminal, then hit Enter   
   

   
eina_btlog << EOF
/usr/local/lib/libeina.so.1  0x7f7c7a8e8462 0x7f7c7a8b5000
...




1. Run terminology
2. Right Click
3. Click Settings

Output:

CRI<27896>:eina_log ../src/bin/win.c:1762 win_new() unknown log domain -1, 
original message level was: WRN

ERR<27896>:eo lib/eo/eo.c:2113 efl_data_scope_get() Eo ID 0x55ddef262c10 is not 
a valid object. Current thread: main. This ID has probably been deleted or this 
was never a valid object ID. (domain=2, current_do
main=0, local_domain=0, available_domains=[0 1], generation=10, id=98b, 
ref=1)
## Copy & Paste the below (until EOF) into a terminal, then hit Enter

eina_btlog << EOF
/usr/local/lib/libeina.so.1  0x7fb0e87f4462 0x7fb0e87c1000
...

ERR<28445>:eina_safety lib/evas/canvas/evas_callbacks.c:539 
evas_object_event_callback_del_full() safety check failed: obj == NULL
## Copy & Paste the below (until EOF) into a terminal, then hit Enter
...


Regards,
Jean Rene

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel