Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
this code still has lots of (bad) compile warnings. I'm not your dad, fix them
before you commit in the future
On Fri, 30 Nov 2012 10:28:55 -0800
Enlightenment SVN no-re...@enlightenment.org wrote:
Log:
come on guys, run 'make' or (if you get paid to develop, you may consider)
distcheck before committing
Author: discomfitor
Date: 2012-11-30 10:28:55 -0800 (Fri, 30 Nov 2012)
New Revision: 79937
Trac: http://trac.enlightenment.org/e/changeset/79937
Modified:
trunk/elementary/src/lib/elm_prefs.h
Modified: trunk/elementary/src/lib/elm_prefs.h
===
--- trunk/elementary/src/lib/elm_prefs.h 2012-11-30 18:16:00 UTC (rev
79936)
+++ trunk/elementary/src/lib/elm_prefs.h 2012-11-30 18:28:55 UTC (rev
79937)
@@ -428,7 +428,7 @@
*
* @since 1.8
*/
-typedef enum _Elm_Prefs_Item_Type
+enum _Elm_Prefs_Item_Type
{
ELM_PREFS_TYPE_UNKNOWN = 0,
ELM_PREFS_TYPE_ACTION, /*** action type, bound to button-like UI
elements */
@@ -444,7 +444,7 @@
ELM_PREFS_TYPE_SAVE, /** saving trigger type, bound to button-like UI
elements */
ELM_PREFS_TYPE_SEPARATOR, /** separator type, bound to separator-like UI
elements */
ELM_PREFS_TYPE_SWALLOW /** swallow type, bound to an empty 'spot' on the
UI meant to receive and display external content */
-} Elm_Prefs_Item_Type;
+};
/**
* Modes of resetting a prefs widget.
--
Keep yourself connected to Go Parallel:
TUNE You got it built. Now make it sing. Tune shows you how.
http://goparallel.sourceforge.net
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Friday, November 30, 2012, Enlightenment SVN wrote:
Log:
come on guys, run 'make' or (if you get paid to develop, you may consider)
distcheck before committing
Author: discomfitor
Date: 2012-11-30 10:28:55 -0800 (Fri, 30 Nov 2012)
New Revision: 79937
Trac: http://trac.enlightenment.org/e/changeset/79937
Modified:
trunk/elementary/src/lib/elm_prefs.h
Modified: trunk/elementary/src/lib/elm_prefs.h
===
--- trunk/elementary/src/lib/elm_prefs.h2012-11-30 18:16:00 UTC
(rev 79936)
+++ trunk/elementary/src/lib/elm_prefs.h2012-11-30 18:28:55 UTC
(rev 79937)
@@ -428,7 +428,7 @@
*
* @since 1.8
*/
-typedef enum _Elm_Prefs_Item_Type
+enum _Elm_Prefs_Item_Type
{
ELM_PREFS_TYPE_UNKNOWN = 0,
ELM_PREFS_TYPE_ACTION, /*** action type, bound to button-like UI
elements */
@@ -444,7 +444,7 @@
ELM_PREFS_TYPE_SAVE, /** saving trigger type, bound to button-like UI
elements */
ELM_PREFS_TYPE_SEPARATOR, /** separator type, bound to separator-like
UI elements */
ELM_PREFS_TYPE_SWALLOW /** swallow type, bound to an empty 'spot' on
the UI meant to receive and display external content */
-} Elm_Prefs_Item_Type;
+};
Hu? This didnt work?! Usual typedef, no?
/**
* Modes of resetting a prefs widget.
--
Keep yourself connected to Go Parallel:
TUNE You got it built. Now make it sing. Tune shows you how.
http://goparallel.sourceforge.net
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net javascript:;
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Keep yourself connected to Go Parallel:
TUNE You got it built. Now make it sing. Tune shows you how.
http://goparallel.sourceforge.net
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Fri, 30 Nov 2012 17:46:14 -0200
Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote:
On Friday, November 30, 2012, Enlightenment SVN wrote:
Log:
come on guys, run 'make' or (if you get paid to develop, you may consider)
distcheck before committing
Author: discomfitor
Date: 2012-11-30 10:28:55 -0800 (Fri, 30 Nov 2012)
New Revision: 79937
Trac: http://trac.enlightenment.org/e/changeset/79937
Modified:
trunk/elementary/src/lib/elm_prefs.h
Modified: trunk/elementary/src/lib/elm_prefs.h
===
--- trunk/elementary/src/lib/elm_prefs.h2012-11-30 18:16:00 UTC
(rev 79936)
+++ trunk/elementary/src/lib/elm_prefs.h2012-11-30 18:28:55 UTC
(rev 79937)
@@ -428,7 +428,7 @@
*
* @since 1.8
*/
-typedef enum _Elm_Prefs_Item_Type
+enum _Elm_Prefs_Item_Type
{
ELM_PREFS_TYPE_UNKNOWN = 0,
ELM_PREFS_TYPE_ACTION, /*** action type, bound to button-like UI
elements */
@@ -444,7 +444,7 @@
ELM_PREFS_TYPE_SAVE, /** saving trigger type, bound to button-like UI
elements */
ELM_PREFS_TYPE_SEPARATOR, /** separator type, bound to separator-like
UI elements */
ELM_PREFS_TYPE_SWALLOW /** swallow type, bound to an empty 'spot' on
the UI meant to receive and display external content */
-} Elm_Prefs_Item_Type;
+};
Hu? This didnt work?! Usual typedef, no?
/**
* Modes of resetting a prefs widget.
double typedef...
--
Keep yourself connected to Go Parallel:
TUNE You got it built. Now make it sing. Tune shows you how.
http://goparallel.sourceforge.net
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
* Gustavo Sverzut Barbieri barbi...@profusion.mobi [2012-11-30 17:46:14
-0200]:
On Friday, November 30, 2012, Enlightenment SVN wrote:
Log:
come on guys, run 'make' or (if you get paid to develop, you may consider)
distcheck before committing
Author: discomfitor
Date: 2012-11-30 10:28:55 -0800 (Fri, 30 Nov 2012)
New Revision: 79937
Trac: http://trac.enlightenment.org/e/changeset/79937
Modified:
trunk/elementary/src/lib/elm_prefs.h
Modified: trunk/elementary/src/lib/elm_prefs.h
===
--- trunk/elementary/src/lib/elm_prefs.h2012-11-30 18:16:00 UTC
(rev 79936)
+++ trunk/elementary/src/lib/elm_prefs.h2012-11-30 18:28:55 UTC
(rev 79937)
@@ -428,7 +428,7 @@
*
* @since 1.8
*/
-typedef enum _Elm_Prefs_Item_Type
+enum _Elm_Prefs_Item_Type
{
ELM_PREFS_TYPE_UNKNOWN = 0,
ELM_PREFS_TYPE_ACTION, /*** action type, bound to button-like UI
elements */
@@ -444,7 +444,7 @@
ELM_PREFS_TYPE_SAVE, /** saving trigger type, bound to button-like UI
elements */
ELM_PREFS_TYPE_SEPARATOR, /** separator type, bound to separator-like
UI elements */
ELM_PREFS_TYPE_SWALLOW /** swallow type, bound to an empty 'spot' on
the UI meant to receive and display external content */
-} Elm_Prefs_Item_Type;
+};
Hu? This didnt work?! Usual typedef, no?
I think it was repeated on other header, something like that.
I have centralized it on prefs_data header now, it should be
OK. Sorry for the inconvenience.
/**
* Modes of resetting a prefs widget.
--
Keep yourself connected to Go Parallel:
TUNE You got it built. Now make it sing. Tune shows you how.
http://goparallel.sourceforge.net
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net javascript:;
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Keep yourself connected to Go Parallel:
TUNE You got it built. Now make it sing. Tune shows you how.
http://goparallel.sourceforge.net
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Gustavo Lima Chaves
Senior Developer @ ProFUSION Embedded Systems
--
Keep yourself connected to Go Parallel:
TUNE You got it built. Now make it sing. Tune shows you how.
http://goparallel.sourceforge.net
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Friday, November 30, 2012, Michael Blumenkrantz wrote:
On Fri, 30 Nov 2012 17:46:14 -0200
Gustavo Sverzut Barbieri barbi...@profusion.mobi javascript:; wrote:
On Friday, November 30, 2012, Enlightenment SVN wrote:
Log:
come on guys, run 'make' or (if you get paid to develop, you may
consider)
distcheck before committing
Author: discomfitor
Date: 2012-11-30 10:28:55 -0800 (Fri, 30 Nov 2012)
New Revision: 79937
Trac: http://trac.enlightenment.org/e/changeset/79937
Modified:
trunk/elementary/src/lib/elm_prefs.h
Modified: trunk/elementary/src/lib/elm_prefs.h
===
--- trunk/elementary/src/lib/elm_prefs.h2012-11-30 18:16:00 UTC
(rev 79936)
+++ trunk/elementary/src/lib/elm_prefs.h2012-11-30 18:28:55 UTC
(rev 79937)
@@ -428,7 +428,7 @@
*
* @since 1.8
*/
-typedef enum _Elm_Prefs_Item_Type
+enum _Elm_Prefs_Item_Type
{
ELM_PREFS_TYPE_UNKNOWN = 0,
ELM_PREFS_TYPE_ACTION, /*** action type, bound to button-like UI
elements */
@@ -444,7 +444,7 @@
ELM_PREFS_TYPE_SAVE, /** saving trigger type, bound to
button-like UI
elements */
ELM_PREFS_TYPE_SEPARATOR, /** separator type, bound to
separator-like
UI elements */
ELM_PREFS_TYPE_SWALLOW /** swallow type, bound to an empty 'spot'
on
the UI meant to receive and display external content */
-} Elm_Prefs_Item_Type;
+};
Hu? This didnt work?! Usual typedef, no?
/**
* Modes of resetting a prefs widget.
double typedef...
A, IC
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Keep yourself connected to Go Parallel:
TUNE You got it built. Now make it sing. Tune shows you how.
http://goparallel.sourceforge.net
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
* Daniel Juyung Seo seojuyu...@gmail.com [2012-05-30 13:46:39 +0900]: On Tue, May 29, 2012 at 10:59 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: On Tue, May 29, 2012 at 6:04 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: fix case where user can specify item block size 1; this also reveals an api error since the param here should obviously be a uint. Author: discomfitor Date: 2012-05-29 02:04:42 -0700 (Tue, 29 May 2012) New Revision: 71498 Trac: http://trac.enlightenment.org/e/changeset/71498 Modified: trunk/elementary/src/lib/elm_genlist.c Modified: trunk/elementary/src/lib/elm_genlist.c === --- trunk/elementary/src/lib/elm_genlist.c 2012-05-29 09:04:37 UTC (rev 71497) +++ trunk/elementary/src/lib/elm_genlist.c 2012-05-29 09:04:42 UTC (rev 71498) @@ -5447,6 +5447,7 @@ ELM_CHECK_WIDTYPE(obj, widtype); Widget_Data *wd = elm_widget_data_get(obj); if (!wd) return; + if (count 1) return; If so, then EINA_SAFETY_ON_TRUE_RETURN(count 1); it will play nice and warn the user. This is true. I will correct this. I know the line before !wd is checked without such, but in that case ELM_CHECK_WIDTYPE would have complained anyway, making this check useless. I think ELM_CHECK_WIDTYPE does not guarantee widget data exists. How do you think? Here we go. Most of the old checks for widget data were there just to account for race conditions, bad callbacks timing and stuff. An object's smart data should be guaranteed safe during a widget's whole life, period. Only if you the user goes on making evas_object_smart_data_set() on his own, on widgets, could he get screwed, but hey! My work on Elm's infra and widgets includes finding these wrong accesses and fixing them. Daniel Juyung Seo (SeoZ) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Lima Chaves Computer Engineer @ ProFUSION Embedded Systems -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Tue, May 29, 2012 at 6:04 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: fix case where user can specify item block size 1; this also reveals an api error since the param here should obviously be a uint. Author: discomfitor Date: 2012-05-29 02:04:42 -0700 (Tue, 29 May 2012) New Revision: 71498 Trac: http://trac.enlightenment.org/e/changeset/71498 Modified: trunk/elementary/src/lib/elm_genlist.c Modified: trunk/elementary/src/lib/elm_genlist.c === --- trunk/elementary/src/lib/elm_genlist.c 2012-05-29 09:04:37 UTC (rev 71497) +++ trunk/elementary/src/lib/elm_genlist.c 2012-05-29 09:04:42 UTC (rev 71498) @@ -5447,6 +5447,7 @@ ELM_CHECK_WIDTYPE(obj, widtype); Widget_Data *wd = elm_widget_data_get(obj); if (!wd) return; + if (count 1) return; If so, then EINA_SAFETY_ON_TRUE_RETURN(count 1); it will play nice and warn the user. I know the line before !wd is checked without such, but in that case ELM_CHECK_WIDTYPE would have complained anyway, making this check useless. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Tue, May 29, 2012 at 10:59 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: On Tue, May 29, 2012 at 6:04 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: fix case where user can specify item block size 1; this also reveals an api error since the param here should obviously be a uint. Author: discomfitor Date: 2012-05-29 02:04:42 -0700 (Tue, 29 May 2012) New Revision: 71498 Trac: http://trac.enlightenment.org/e/changeset/71498 Modified: trunk/elementary/src/lib/elm_genlist.c Modified: trunk/elementary/src/lib/elm_genlist.c === --- trunk/elementary/src/lib/elm_genlist.c 2012-05-29 09:04:37 UTC (rev 71497) +++ trunk/elementary/src/lib/elm_genlist.c 2012-05-29 09:04:42 UTC (rev 71498) @@ -5447,6 +5447,7 @@ ELM_CHECK_WIDTYPE(obj, widtype); Widget_Data *wd = elm_widget_data_get(obj); if (!wd) return; + if (count 1) return; If so, then EINA_SAFETY_ON_TRUE_RETURN(count 1); it will play nice and warn the user. This is true. I will correct this. I know the line before !wd is checked without such, but in that case ELM_CHECK_WIDTYPE would have complained anyway, making this check useless. I think ELM_CHECK_WIDTYPE does not guarantee widget data exists. How do you think? Daniel Juyung Seo (SeoZ) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Thu, 1 Mar 2012 11:14:46 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: revert 68495 and all subsequent toolbar refactoring (rewriting) commits because they broke toolbar use for everyone. in the future, rewrites like this MUST be submitted as PATCHES, not direct commits. this allows application authors to continue having fun writing code without suddenly having broken widgets. I have left the newly committed edc, as it does not seem likely to cause issues on its own. Author: discomfitor Date: 2012-03-01 11:14:46 -0800 (Thu, 01 Mar 2012) New Revision: 68586 Trac: http://trac.enlightenment.org/e/changeset/68586 Modified: trunk/elementary/src/lib/elm_toolbar.c This commit was necessary as a result of the growing (and currently fairly substantial) number of complaints that toolbar is broken! and why is my toolbar doing this? As I have said in my commit message, let's, as a community, try to ensure that developers currently using our libraries can continue to do so without breaking the widgets and utilities they are accustomed to. For massive and complete rewrites/redesigns of existing codebases, always submit the proposed changes to the mailing list in patch form first. The ONLY exception to this is when you are either the initial or subsequent primary author of the code in question. Bottom line, we are a community of open source developers, and we should rely on each other more for reviews and help instead of trying to write/rewrite everything on our own. Thanks. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
Hi Sorry about the toolbar broken. I should have tested and reviewed it enough. I reverted the elm_button.c and button.edc. It related to 68495. It's not necessary whitout the revision. I'll try to change the code for focusing later. And I'll send the patch. Thanks -- Jaehwan Kim. 2012년 3월 2일 금요일에 Michael Blumenkrantz님이 작성: On Thu, 1 Mar 2012 11:14:46 -0800 Enlightenment SVN no-re...@enlightenment.org javascript:; wrote: Log: revert 68495 and all subsequent toolbar refactoring (rewriting) commits because they broke toolbar use for everyone. in the future, rewrites like this MUST be submitted as PATCHES, not direct commits. this allows application authors to continue having fun writing code without suddenly having broken widgets. I have left the newly committed edc, as it does not seem likely to cause issues on its own. Author: discomfitor Date: 2012-03-01 11:14:46 -0800 (Thu, 01 Mar 2012) New Revision: 68586 Trac: http://trac.enlightenment.org/e/changeset/68586 Modified: trunk/elementary/src/lib/elm_toolbar.c This commit was necessary as a result of the growing (and currently fairly substantial) number of complaints that toolbar is broken! and why is my toolbar doing this? As I have said in my commit message, let's, as a community, try to ensure that developers currently using our libraries can continue to do so without breaking the widgets and utilities they are accustomed to. For massive and complete rewrites/redesigns of existing codebases, always submit the proposed changes to the mailing list in patch form first. The ONLY exception to this is when you are either the initial or subsequent primary author of the code in question. Bottom line, we are a community of open source developers, and we should rely on each other more for reviews and help instead of trying to write/rewrite everything on our own. Thanks. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net javascript:; https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Thu, 1 Mar 2012 14:26:07 -0500 Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Thu, 1 Mar 2012 11:14:46 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: revert 68495 and all subsequent toolbar refactoring (rewriting) commits because they broke toolbar use for everyone. in the future, rewrites like this MUST be submitted as PATCHES, not direct commits. this allows application authors to continue having fun writing code without suddenly having broken widgets. I have left the newly committed edc, as it does not seem likely to cause issues on its own. Author: discomfitor Date: 2012-03-01 11:14:46 -0800 (Thu, 01 Mar 2012) New Revision: 68586 Trac: http://trac.enlightenment.org/e/changeset/68586 Modified: trunk/elementary/src/lib/elm_toolbar.c This commit was necessary as a result of the growing (and currently fairly substantial) number of complaints that toolbar is broken! and why is my toolbar doing this? As I have said in my commit message, let's, as a community, try to ensure that developers currently using our libraries can continue to do so without breaking the widgets and utilities they are accustomed to. For massive and complete rewrites/redesigns of existing codebases, always submit the proposed changes to the mailing list in patch form first. The ONLY exception to this is when you are either the initial or subsequent primary author of the code in question. Bottom line, we are a community of open source developers, and we should rely on each other more for reviews and help instead of trying to write/rewrite everything on our own. It helps if you are changing something that is being used elsewhere in SVN, to check those things that use it still work, and perhaps patch them up to keep working. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
2011/12/5 Enlightenment SVN no-re...@enlightenment.org:
Log:
fix super annoying elm_win bug that went something like this:
win_resize_object_add(win, subobj);
object_content_set(otherobj, subobj);
object_del(win);
ERR21326:elm-externals elm_widget.c:978 elm_widget_sub_object_del()
removing sub object 0xdeadbeef (some_stupid_widget) from parent 0x
(win), but elm-parent is different 0xFUCKTHIS (NOT EVEN A WIDGET)!
Author: discomfitor
Date: 2011-12-04 20:26:32 -0800 (Sun, 04 Dec 2011)
New Revision: 65884
Trac: http://trac.enlightenment.org/e/changeset/65884
Modified:
trunk/elementary/src/lib/elm_widget.c trunk/elementary/src/lib/elm_win.c
Modified: trunk/elementary/src/lib/elm_widget.c
===
--- trunk/elementary/src/lib/elm_widget.c 2011-12-05 04:03:12 UTC (rev
65883)
+++ trunk/elementary/src/lib/elm_widget.c 2011-12-05 04:26:32 UTC (rev
65884)
@@ -945,7 +945,7 @@
_sub_obj_del);
}
}
-
+ evas_object_smart_callback_call(sobj,
win-resize-del-private-dont-use-this. seriously, NULL);
Don't do this, the object added as resize object to the window is added
to the widgets sub-objects list, so when it's deleted or moved somewhere else
it should trigger the sub-object-del smart callback. The window should
be listening to add instead of creating random private things in other
components.
sd-subobjs = eina_list_append(sd-subobjs, sobj);
evas_object_data_set(sobj, elm-parent, obj);
evas_object_event_callback_add(sobj, EVAS_CALLBACK_DEL, _sub_obj_del, sd);
Modified: trunk/elementary/src/lib/elm_win.c
===
--- trunk/elementary/src/lib/elm_win.c 2011-12-05 04:03:12 UTC (rev 65883)
+++ trunk/elementary/src/lib/elm_win.c 2011-12-05 04:26:32 UTC (rev 65884)
@@ -1367,6 +1367,21 @@
_win_img_focus_out, win);
}
+static void
+_subobj_del(Evas_Object *obj, Evas_Object *subobj, void *event_info
__UNUSED__)
+{
+ Elm_Win *win = elm_widget_data_get(obj);
+ evas_object_event_callback_del_full(subobj,
+ EVAS_CALLBACK_CHANGED_SIZE_HINTS,
+
_elm_win_subobj_callback_changed_size_hints,
+ obj);
+ evas_object_event_callback_del_full(subobj, EVAS_CALLBACK_DEL,
+ _elm_win_subobj_callback_del, obj);
+ win-subobjs = eina_list_remove(win-subobjs, subobj);
+ evas_object_smart_callback_del(subobj,
win-resize-del-private-dont-use-this. seriously,
(Evas_Smart_Cb)_subobj_del);
+ _elm_win_eval_subobjs(obj);
+}
+
EAPI Evas_Object *
elm_win_add(Evas_Object *parent, const char *name, Elm_Win_Type type)
{
@@ -1678,6 +1693,7 @@
evas_object_geometry_get(obj, NULL, NULL, w, h);
evas_object_move(subobj, 0, 0);
evas_object_resize(subobj, w, h);
+ evas_object_smart_callback_add(subobj,
win-resize-del-private-dont-use-this. seriously,
(Evas_Smart_Cb)_subobj_del, obj);
_elm_win_eval_subobjs(obj);
}
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Sat, 3 Dec 2011 23:35:34 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: front...front...front...BACK! BACK! NO WAIT FRONT! NO, BACK! ARRG finding this commit wasted an hour of my life. Author: discomfitor Date: 2011-12-03 23:35:33 -0800 (Sat, 03 Dec 2011) New Revision: 65867 Trac: http://trac.enlightenment.org/e/changeset/65867 Modified: trunk/elementary/src/lib/elm_flip.c for those wondering, this fixes the bug where setting the front content deleted the back content. I would guess that anyone having flip issues will no longer have them after this commit. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
In this regard, no they should no longer have issues w/ some text rendering...Good Catch !! ;) Sometimes, you don't necessarily want to get rid of the back buffer context. Use it to swap. In a flip context, this is correct i believe (normally i do not top post) dh On 12/04/11 04:09, Michael Blumenkrantz wrote: On Sat, 3 Dec 2011 23:35:34 -0800 Enlightenment SVNno-re...@enlightenment.org wrote: Log: front...front...front...BACK! BACK! NO WAIT FRONT! NO, BACK! ARRG finding this commit wasted an hour of my life. Author: discomfitor Date: 2011-12-03 23:35:33 -0800 (Sat, 03 Dec 2011) New Revision: 65867 Trac: http://trac.enlightenment.org/e/changeset/65867 Modified: trunk/elementary/src/lib/elm_flip.c for those wondering, this fixes the bug where setting the front content deleted the back content. I would guess that anyone having flip issues will no longer have them after this commit. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On 12/04/11 00:02, Enlightenment SVN wrote: Log: header and docs for elm_win_center got lost in an earlier merge I guess Fix the algorithm yet ? I've seen a place where you still can fall throughtisk, tick dh Author: discomfitor Date: 2011-12-03 21:02:02 -0800 (Sat, 03 Dec 2011) New Revision: 65866 Trac: http://trac.enlightenment.org/e/changeset/65866 Modified: trunk/elementary/src/lib/Elementary.h.in Modified: trunk/elementary/src/lib/Elementary.h.in === --- trunk/elementary/src/lib/Elementary.h.in 2011-12-04 04:29:55 UTC (rev 65865) +++ trunk/elementary/src/lib/Elementary.h.in 2011-12-04 05:02:02 UTC (rev 65866) @@ -4188,6 +4188,16 @@ */ EAPI void elm_win_raise(Evas_Object *obj) EINA_ARG_NONNULL(1); /** +* Center a window on its screen +* +* This function centers window @p obj horizontally and/or vertically based on the values +* of @p h and @v. +* @param obj The window object +* @param h If true, center horizontally. If false, do not change horizontal location. +* @param v If true, center vertically. If false, do not change vertical location. +*/ + EAPI void elm_win_center(Evas_Object *obj, Eina_Bool h, Eina_Bool v) EINA_ARG_NONNULL(1); + /** * Set the borderless state of a window. * * This function requests the Window Manager to not draw any decoration -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Sun, 04 Dec 2011 05:46:34 -0500 Christopher Michael cpmicha...@comcast.net wrote: On 12/04/11 00:02, Enlightenment SVN wrote: Log: header and docs for elm_win_center got lost in an earlier merge I guess Fix the algorithm yet ? I've seen a place where you still can fall throughtisk, tick dh Author: discomfitor Date: 2011-12-03 21:02:02 -0800 (Sat, 03 Dec 2011) New Revision: 65866 Trac: http://trac.enlightenment.org/e/changeset/65866 Modified: trunk/elementary/src/lib/Elementary.h.in Modified: trunk/elementary/src/lib/Elementary.h.in === --- trunk/elementary/src/lib/Elementary.h.in2011-12-04 04:29:55 UTC (rev 65865) +++ trunk/elementary/src/lib/Elementary.h.in2011-12-04 05:02:02 UTC (rev 65866) @@ -4188,6 +4188,16 @@ */ EAPI void elm_win_raise(Evas_Object *obj) EINA_ARG_NONNULL(1); /** +* Center a window on its screen +* +* This function centers window @p obj horizontally and/or vertically based on the values +* of @p h and @v. +* @param obj The window object +* @param h If true, center horizontally. If false, do not change horizontal location. +* @param v If true, center vertically. If false, do not change vertical location. +*/ + EAPI void elm_win_center(Evas_Object *obj, Eina_Bool h, Eina_Bool v) EINA_ARG_NONNULL(1); + /** * Set the borderless state of a window. * * This function requests the Window Manager to not draw any decoration I was in a rush to finish stuff last night so I didn't add safety checks. It's on my whiteboard. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On 12/04/11 14:06, Michael Blumenkrantz wrote: On Sun, 04 Dec 2011 05:46:34 -0500 Christopher Michaelcpmicha...@comcast.net wrote: On 12/04/11 00:02, Enlightenment SVN wrote: Log: header and docs for elm_win_center got lost in an earlier merge I guess Fix the algorithm yet ? I've seen a place where you still can fall throughtisk, tick dh Author: discomfitor Date: 2011-12-03 21:02:02 -0800 (Sat, 03 Dec 2011) New Revision: 65866 Trac: http://trac.enlightenment.org/e/changeset/65866 Modified: trunk/elementary/src/lib/Elementary.h.in Modified: trunk/elementary/src/lib/Elementary.h.in === --- trunk/elementary/src/lib/Elementary.h.in2011-12-04 04:29:55 UTC (rev 65865) +++ trunk/elementary/src/lib/Elementary.h.in2011-12-04 05:02:02 UTC (rev 65866) @@ -4188,6 +4188,16 @@ */ EAPI void elm_win_raise(Evas_Object *obj) EINA_ARG_NONNULL(1); /** +* Center a window on its screen +* +* This function centers window @p obj horizontally and/or vertically based on the values +* of @p h and @v. +* @param obj The window object +* @param h If true, center horizontally. If false, do not change horizontal location. +* @param v If true, center vertically. If false, do not change vertical location. +*/ + EAPI void elm_win_center(Evas_Object *obj, Eina_Bool h, Eina_Bool v) EINA_ARG_NONNULL(1); + /** * Set the borderless state of a window. * * This function requests the Window Manager to not draw any decoration I was in a rush to finish stuff last night so I didn't add safety checks. It's on my whiteboard. No worries ;) dh -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Sun, 04 Dec 2011 15:09:21 -0500 Christopher Michael cpmicha...@comcast.net wrote: On 12/04/11 14:06, Michael Blumenkrantz wrote: On Sun, 04 Dec 2011 05:46:34 -0500 Christopher Michaelcpmicha...@comcast.net wrote: On 12/04/11 00:02, Enlightenment SVN wrote: Log: header and docs for elm_win_center got lost in an earlier merge I guess Fix the algorithm yet ? I've seen a place where you still can fall throughtisk, tick dh Author: discomfitor Date: 2011-12-03 21:02:02 -0800 (Sat, 03 Dec 2011) New Revision: 65866 Trac: http://trac.enlightenment.org/e/changeset/65866 Modified: trunk/elementary/src/lib/Elementary.h.in Modified: trunk/elementary/src/lib/Elementary.h.in === --- trunk/elementary/src/lib/Elementary.h.in 2011-12-04 04:29:55 UTC (rev 65865) +++ trunk/elementary/src/lib/Elementary.h.in 2011-12-04 05:02:02 UTC (rev 65866) @@ -4188,6 +4188,16 @@ */ EAPI void elm_win_raise(Evas_Object *obj) EINA_ARG_NONNULL(1); /** +* Center a window on its screen +* +* This function centers window @p obj horizontally and/or vertically based on the values +* of @p h and @v. +* @param obj The window object +* @param h If true, center horizontally. If false, do not change horizontal location. +* @param v If true, center vertically. If false, do not change vertical location. +*/ + EAPI void elm_win_center(Evas_Object *obj, Eina_Bool h, Eina_Bool v) EINA_ARG_NONNULL(1); + /** * Set the borderless state of a window. * * This function requests the Window Manager to not draw any decoration I was in a rush to finish stuff last night so I didn't add safety checks. It's on my whiteboard. No worries ;) dh whiteboard item cleared! -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Fri, 02 Dec 2011 08:34:55 +0900
ChunEon Parkher...@naver.com wrote:
Skimming over, it looks same with elm_toolbar_item_icon_set().
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-12-02(금) 04:14:49
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
+elm_toolbar_item_icon_file_set()
at some point this whole item api should probably be replaced with generic
object stuff
Author: discomfitor
Date: 2011-12-01 11:14:48 -0800 (Thu, 01 Dec 2011)
New Revision: 65785
Trac: http://trac.enlightenment.org/e/changeset/65785
Modified:
trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_toolbar.c Modified:
trunk/elementary/src/lib/Elementary.h.in
=== ---
trunk/elementary/src/lib/Elementary.h.in 2011-12-01 16:53:57 UTC (rev 65784)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-12-01 19:14:48 UTC (rev
65785) @@ -15185,7 +15185,8 @@
* @param it The toolbar item.
* @return The icon object
*
- * @see elm_toolbar_item_icon_set() or elm_toolbar_item_icon_memfile_set()
for details.
+ * @see elm_toolbar_item_icon_set(), elm_toolbar_item_icon_file_set(),
+ * or elm_toolbar_item_icon_memfile_set() for details.
*
* @ingroup Toolbar
*/
@@ -15207,7 +15208,24 @@
* @ingroup Toolbar
*/
EAPI Eina_Bool elm_toolbar_item_icon_memfile_set(Elm_Object_Item *it, const
void *img, size_t size, const char *format, const char *key)
EINA_ARG_NONNULL(1); + /**
+ * Set the icon associated with @p item to an image in a binary buffer.
+ *
+ * @param it The toolbar item.
+ * @param file The file that contains the image
+ * @param key Optional key of @p img to pass to the image loader (eg. if @p
img is an edje file)
+ *
+ * @return (@c EINA_TRUE = success, @c EINA_FALSE = error)
+ *
+ * @note The icon image set by this function can be changed by
+ * elm_toolbar_item_icon_set().
+ *
+ * @ingroup Toolbar
+ */
+ EAPI Eina_Bool elm_toolbar_item_icon_file_set(Elm_Object_Item *it, const
char *file, const char *key) EINA_ARG_NONNULL(1); +
+ /**
* Delete them item from the toolbar.
*
* @param it The item of toolbar to be deleted.
Modified: trunk/elementary/src/lib/elm_toolbar.c
===
--- trunk/elementary/src/lib/elm_toolbar.c 2011-12-01 16:53:57 UTC (rev 65784)
+++ trunk/elementary/src/lib/elm_toolbar.c 2011-12-01 19:14:48 UTC (rev 65785)
@@ -1391,6 +1391,39 @@
return EINA_TRUE;
}
+EAPI Eina_Bool
+elm_toolbar_item_icon_file_set(Elm_Object_Item *it, const char *file, const
char *key) +{
+ ELM_OBJ_ITEM_CHECK_OR_RETURN(it, EINA_FALSE);
+
+ Evas_Object *icon_obj;
+ Widget_Data *wd;
+ Evas_Object *obj;
+ Eina_Bool ret;
+ Elm_Toolbar_Item *item = (Elm_Toolbar_Item *) it;
+
+ obj = WIDGET(item);
+ wd = elm_widget_data_get(obj);
+ if (!wd) return EINA_FALSE;
+
+ if (file)
+ {
+ icon_obj = _els_smart_icon_add(evas_object_evas_get(obj));
+ evas_object_repeat_events_set(icon_obj, EINA_TRUE);
+ ret = _els_smart_icon_file_key_set(icon_obj, file, key);
+ if (!ret)
+ {
+ evas_object_del(icon_obj);
+ return EINA_FALSE;
+ }
+ _elm_toolbar_item_icon_obj_set(obj, item, icon_obj, NULL, wd-icon_size,
+ elm,state,icon_set);
+ }
+ else
+ _elm_toolbar_item_icon_obj_set(obj, item, NULL, NULL, 0,
elm,state,icon_set);
+ return EINA_TRUE;
+}
+
EAPI void
elm_toolbar_item_del(Elm_Object_Item *it)
{
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
nope
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more.
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
Skimmed over, it looked similar with
elm_toolbar_item_icon_set( ITEM, FILEPATH ).
-Regards, Hermet-
-Original Message-
From: Enlightenment
SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-12-02(금) 04:14:49
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
+elm_toolbar_item_icon_file_set()
at some point this whole item api should probably be replaced with
generic object stuff
Author: discomfitor
Date: 2011-12-01 11:14:48 -0800 (Thu, 01 Dec 2011)
New Revision: 65785
Trac: http://trac.enlightenment.org/e/changeset/65785
Modified:
trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_toolbar.c
Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-12-01 16:53:57
UTC (rev 65784)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-12-01 19:14:48
UTC (rev 65785)
@@ -15185,7 +15185,8 @@
* @param it The toolbar item.
* @return The icon object
*
- * @see elm_toolbar_item_icon_set() or
elm_toolbar_item_icon_memfile_set() for details.
+ * @see elm_toolbar_item_icon_set(),
elm_toolbar_item_icon_file_set(),
+ * or elm_toolbar_item_icon_memfile_set() for details.
*
* @ingroup Toolbar
*/
@@ -15207,7 +15208,24 @@
* @ingroup Toolbar
*/
EAPI Eina_Bool elm_toolbar_item_icon_memfile_set(Elm_Object_Item
*it, const void *img, size_t size, const char *format, const char
*key) EINA_ARG_NONNULL(1);
+
/**
+ * Set the icon associated with @p item to an image in a binary
buffer.
+ *
+ * @param it The toolbar item.
+ * @param file The file that contains the image
+ * @param key Optional key of @p img to pass to the image loader
(eg. if @p img is an edje file)
+ *
+ * @return (@c EINA_TRUE = success, @c EINA_FALSE = error)
+ *
+ * @note The icon image set by this function can be changed by
+ * elm_toolbar_item_icon_set().
+ *
+ * @ingroup Toolbar
+ */
+ EAPI Eina_Bool elm_toolbar_item_icon_file_set(Elm_Object_Item
*it, const char *file, const char *key) EINA_ARG_NONNULL(1);
+
+ /**
* Delete them item from the toolbar.
*
* @param it The item of toolbar to be deleted.
Modified: trunk/elementary/src/lib/elm_toolbar.c
===
--- trunk/elementary/src/lib/elm_toolbar.c 2011-12-01 16:53:57 UTC
(rev 65784)
+++ trunk/elementary/src/lib/elm_toolbar.c 2011-12-01 19:14:48 UTC
(rev 65785)
@@ -1391,6 +1391,39 @@
return EINA_TRUE;
}
+EAPI Eina_Bool
+elm_toolbar_item_icon_file_set(Elm_Object_Item *it, const char
*file, const char *key)
+{
+ ELM_OBJ_ITEM_CHECK_OR_RETURN(it, EINA_FALSE);
+
+ Evas_Object *icon_obj;
+ Widget_Data *wd;
+ Evas_Object *obj;
+ Eina_Bool ret;
+ Elm_Toolbar_Item *item = (Elm_Toolbar_Item *) it;
+
+ obj = WIDGET(item);
+ wd = elm_widget_data_get(obj);
+ if (!wd) return EINA_FALSE;
+
+ if (file)
+ {
+ icon_obj = _els_smart_icon_add(evas_object_evas_get(obj));
+ evas_object_repeat_events_set(icon_obj, EINA_TRUE);
+ ret = _els_smart_icon_file_key_set(icon_obj, file, key);
+ if (!ret)
+ {
+ evas_object_del(icon_obj);
+ return EINA_FALSE;
+ }
+ _elm_toolbar_item_icon_obj_set(obj, item, icon_obj, NULL,
wd-icon_size,
+ elm,state,icon_set);
+ }
+ else
+ _elm_toolbar_item_icon_obj_set(obj, item, NULL, NULL, 0,
elm,state,icon_set);
+ return EINA_TRUE;
+}
+
EAPI void
elm_toolbar_item_del(Elm_Object_Item *it)
{
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application
performance,
security threats, fraudulent activity, and more. Splunk takes
this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
hmm.. does elm_icon_object_get API good to go?
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-11-07(월) 00:56:31
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add function to return image object for use with evas apis
Author: discomfitor
Date: 2011-11-06 07:56:31 -0800 (Sun, 06 Nov 2011)
New Revision: 64830
Trac: http://trac.enlightenment.org/e/changeset/64830
Modified:
trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_icon.c
Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-11-06 15:43:48 UTC (rev 64829)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-11-06 15:56:31 UTC (rev 64830)
@@ -5053,6 +5053,15 @@
*/
EAPI int elm_icon_prescale_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
/**
+ * Gets the image object of the icon. DO NOT MODIFY THIS.
+ *
+ * @param obj The icon object
+ * @return The internal icon object
+ *
+ * @ingroup Icon
+ */
+ EAPI Evas_Object *elm_icon_object_get(Evas_Object *obj) EINA_ARG_NONNULL(1);
+ /**
* Sets the icon lookup order used by elm_icon_standard_set().
*
* @param obj The icon object
Modified: trunk/elementary/src/lib/elm_icon.c
===
--- trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:43:48 UTC (rev 64829)
+++ trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:56:31 UTC (rev 64830)
@@ -1014,3 +1014,13 @@
if (!wd) return 0;
return _els_smart_icon_scale_size_get(wd-img);
}
+
+EAPI Evas_Object *
+elm_icon_object_get(Evas_Object *obj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype) 0;
+ Widget_Data *wd = elm_widget_data_get(obj);
+
+ if (!wd) return NULL;
+ return wd-img;
+}
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
Actually, we never do that! We never expose internal objects for outside
manipulation, even if it's just for querying purposes. I don't know if
that decision is good or not, but it's a fact.
If this rule is broken, it should be discussed as I'd like to do the
same in elm_entry.
--
Tom.
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-11-07(월) 00:56:31
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add function to return image object for use with evas apis
Author: discomfitor
Date: 2011-11-06 07:56:31 -0800 (Sun, 06 Nov 2011)
New Revision: 64830
Trac: http://trac.enlightenment.org/e/changeset/64830
Modified:
trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_icon.c
Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-11-06 15:43:48 UTC (rev
64829)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-11-06 15:56:31 UTC (rev
64830)
@@ -5053,6 +5053,15 @@
*/
EAPI int elm_icon_prescale_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
/**
+ * Gets the image object of the icon. DO NOT MODIFY THIS.
+ *
+ * @param obj The icon object
+ * @return The internal icon object
+ *
+ * @ingroup Icon
+ */
+ EAPI Evas_Object *elm_icon_object_get(Evas_Object *obj) EINA_ARG_NONNULL(1);
+ /**
* Sets the icon lookup order used by elm_icon_standard_set().
*
* @param obj The icon object
Modified: trunk/elementary/src/lib/elm_icon.c
===
--- trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:43:48 UTC (rev 64829)
+++ trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:56:31 UTC (rev 64830)
@@ -1014,3 +1014,13 @@
if (!wd) return 0;
return _els_smart_icon_scale_size_get(wd-img);
}
+
+EAPI Evas_Object *
+elm_icon_object_get(Evas_Object *obj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype) 0;
+ Widget_Data *wd = elm_widget_data_get(obj);
+
+ if (!wd) return NULL;
+ return wd-img;
+}
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Mon, 07 Nov 2011 17:35:47 +0200
Tom Hacohen tom.haco...@partner.samsung.com wrote:
Actually, we never do that! We never expose internal objects for outside
manipulation, even if it's just for querying purposes. I don't know if
that decision is good or not, but it's a fact.
If this rule is broken, it should be discussed as I'd like to do the
same in elm_entry.
--
Tom.
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-11-07(월) 00:56:31
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add function to return image object for use with evas apis
Author: discomfitor
Date: 2011-11-06 07:56:31 -0800 (Sun, 06 Nov 2011)
New Revision: 64830
Trac: http://trac.enlightenment.org/e/changeset/64830
Modified:
trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_icon.c
Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-11-06 15:43:48 UTC (rev
64829) +++ trunk/elementary/src/lib/Elementary.h.in 2011-11-06 15:56:31 UTC
(rev 64830) @@ -5053,6 +5053,15 @@
*/
EAPI int elm_icon_prescale_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
/**
+ * Gets the image object of the icon. DO NOT MODIFY THIS.
+ *
+ * @param obj The icon object
+ * @return The internal icon object
+ *
+ * @ingroup Icon
+ */
+ EAPI Evas_Object *elm_icon_object_get(Evas_Object *obj)
EINA_ARG_NONNULL(1);
+ /**
* Sets the icon lookup order used by elm_icon_standard_set().
*
* @param obj The icon object
Modified: trunk/elementary/src/lib/elm_icon.c
===
--- trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:43:48 UTC (rev 64829)
+++ trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:56:31 UTC (rev 64830)
@@ -1014,3 +1014,13 @@
if (!wd) return 0;
return _els_smart_icon_scale_size_get(wd-img);
}
+
+EAPI Evas_Object *
+elm_icon_object_get(Evas_Object *obj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype) 0;
+ Widget_Data *wd = elm_widget_data_get(obj);
+
+ if (!wd) return NULL;
+ return wd-img;
+}
Actually, most widgets have an object_get function now. You need it in order to
get geometry and whatnot.
--
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
Shouldnt be needed or done. Geometry is not a good reason.
On Monday, November 7, 2011, Mike Blumenkrantz m...@zentific.com wrote:
On Mon, 07 Nov 2011 17:35:47 +0200
Tom Hacohen tom.haco...@partner.samsung.com wrote:
Actually, we never do that! We never expose internal objects for outside
manipulation, even if it's just for querying purposes. I don't know if
that decision is good or not, but it's a fact.
If this rule is broken, it should be discussed as I'd like to do the
same in elm_entry.
--
Tom.
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-11-07(월) 00:56:31
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add function to return image object for use with evas apis
Author: discomfitor
Date: 2011-11-06 07:56:31 -0800 (Sun, 06 Nov 2011)
New Revision: 64830
Trac: http://trac.enlightenment.org/e/changeset/64830
Modified:
trunk/elementary/src/lib/Elementary.h.intrunk/elementary/src/lib/elm_icon.c
Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-11-06 15:43:48 UTC
(rev
64829) +++ trunk/elementary/src/lib/Elementary.h.in 2011-11-06
15:56:31 UTC
(rev 64830) @@ -5053,6 +5053,15 @@
*/
EAPI int elm_icon_prescale_get(const Evas_Object *obj)
EINA_ARG_NONNULL(1);
/**
+ * Gets the image object of the icon. DO NOT MODIFY THIS.
+ *
+ * @param obj The icon object
+ * @return The internal icon object
+ *
+ * @ingroup Icon
+ */
+ EAPI Evas_Object *elm_icon_object_get(Evas_Object *obj)
EINA_ARG_NONNULL(1);
+ /**
* Sets the icon lookup order used by elm_icon_standard_set().
*
* @param obj The icon object
Modified: trunk/elementary/src/lib/elm_icon.c
===
--- trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:43:48 UTC (rev
64829)
+++ trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:56:31 UTC (rev
64830)
@@ -1014,3 +1014,13 @@
if (!wd) return 0;
return _els_smart_icon_scale_size_get(wd-img);
}
+
+EAPI Evas_Object *
+elm_icon_object_get(Evas_Object *obj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype) 0;
+ Widget_Data *wd = elm_widget_data_get(obj);
+
+ if (!wd) return NULL;
+ return wd-img;
+}
Actually, most widgets have an object_get function now. You need it in
order to
get geometry and whatnot.
--
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Mon, 7 Nov 2011 14:36:50 -0200
Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote:
Shouldnt be needed or done. Geometry is not a good reason.
Sure, but it was the first example that came to mind. A better one would be
creating a dbus notification event from an image. You need the row stride and
image data pointer, which obviously can't be gotten from the opaque pointer.
On Monday, November 7, 2011, Mike Blumenkrantz m...@zentific.com wrote:
On Mon, 07 Nov 2011 17:35:47 +0200
Tom Hacohen tom.haco...@partner.samsung.com wrote:
Actually, we never do that! We never expose internal objects for outside
manipulation, even if it's just for querying purposes. I don't know if
that decision is good or not, but it's a fact.
If this rule is broken, it should be discussed as I'd like to do the
same in elm_entry.
--
Tom.
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-11-07(월) 00:56:31
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add function to return image object for use with evas apis
Author: discomfitor
Date: 2011-11-06 07:56:31 -0800 (Sun, 06 Nov 2011)
New Revision: 64830
Trac: http://trac.enlightenment.org/e/changeset/64830
Modified:
trunk/elementary/src/lib/Elementary.h.intrunk/elementary/src/lib/elm_icon.c
Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-11-06 15:43:48 UTC
(rev
64829) +++ trunk/elementary/src/lib/Elementary.h.in 2011-11-06
15:56:31 UTC
(rev 64830) @@ -5053,6 +5053,15 @@
*/
EAPI int elm_icon_prescale_get(const Evas_Object *obj)
EINA_ARG_NONNULL(1);
/**
+ * Gets the image object of the icon. DO NOT MODIFY THIS.
+ *
+ * @param obj The icon object
+ * @return The internal icon object
+ *
+ * @ingroup Icon
+ */
+ EAPI Evas_Object *elm_icon_object_get(Evas_Object *obj)
EINA_ARG_NONNULL(1);
+ /**
* Sets the icon lookup order used by elm_icon_standard_set().
*
* @param obj The icon object
Modified: trunk/elementary/src/lib/elm_icon.c
===
--- trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:43:48 UTC (rev
64829)
+++ trunk/elementary/src/lib/elm_icon.c 2011-11-06 15:56:31 UTC (rev
64830)
@@ -1014,3 +1014,13 @@
if (!wd) return 0;
return _els_smart_icon_scale_size_get(wd-img);
}
+
+EAPI Evas_Object *
+elm_icon_object_get(Evas_Object *obj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype) 0;
+ Widget_Data *wd = elm_widget_data_get(obj);
+
+ if (!wd) return NULL;
+ return wd-img;
+}
Actually, most widgets have an object_get function now. You need it in
order to
get geometry and whatnot.
--
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On 07/11/11 18:41, Mike Blumenkrantz wrote: On Mon, 7 Nov 2011 14:36:50 -0200 Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Shouldnt be needed or done. Geometry is not a good reason. Sure, but it was the first example that came to mind. A better one would be creating a dbus notification event from an image. You need the row stride and image data pointer, which obviously can't be gotten from the opaque pointer. But you can create a new function that just wraps around the inside function, that's what's done in all of elementary atm. I don't mind doing this, just saying, it's against the rules we all set, and I want to know, if it's allowed, I wanna do it as well. I was avoiding it until now because I'm a law abiding citizen of the e community. ;P -- Tom. -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Mon, 07 Nov 2011 22:23:53 +0200 Tom Hacohen t...@stosb.com wrote: On 07/11/11 18:41, Mike Blumenkrantz wrote: On Mon, 7 Nov 2011 14:36:50 -0200 Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Shouldnt be needed or done. Geometry is not a good reason. Sure, but it was the first example that came to mind. A better one would be creating a dbus notification event from an image. You need the row stride and image data pointer, which obviously can't be gotten from the opaque pointer. But you can create a new function that just wraps around the inside function, that's what's done in all of elementary atm. I don't mind doing this, just saying, it's against the rules we all set, and I want to know, if it's allowed, I wanna do it as well. I was avoiding it until now because I'm a law abiding citizen of the e community. ;P -- Tom. So you're saying now that I should add specific elm functions to wrap other libraries just to avoid exposing stuff? I knew the elm api was shitty, but I didn't expect that it would go that far... -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On 07/11/11 22:33, Mike Blumenkrantz wrote: So you're saying now that I should add specific elm functions to wrap other libraries just to avoid exposing stuff? I knew the elm api was shitty, but I didn't expect that it would go that far... Don't shoot the messenger, but yes, that's what's done in elementary atm. It wasn't me who decided that. -- Tom. -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Mon, 07 Nov 2011 22:44:37 +0200 Tom Hacohen t...@stosb.com said: On 07/11/11 22:33, Mike Blumenkrantz wrote: So you're saying now that I should add specific elm functions to wrap other libraries just to avoid exposing stuff? I knew the elm api was shitty, but I didn't expect that it would go that far... Don't shoot the messenger, but yes, that's what's done in elementary atm. It wasn't me who decided that. the real problem here is edbus's e_notify requiring an evas image object - that's the poor api. the only way to do what you want nicely is: 1. make elm_icon handle notification stuff itself directly (kind of not too nice - but yes - the idea is elm wraps up these kinds of thnigs so the programmer just points elm at what they want it to do and it goes off to do it) or 2. you create the image object outside of elm and SET it as the icon obj for elm_icon telling em_icon to adopt the image obj as its icon and manage it from then on. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Tue, 8 Nov 2011 08:48:10 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Mon, 07 Nov 2011 22:44:37 +0200 Tom Hacohen t...@stosb.com said: On 07/11/11 22:33, Mike Blumenkrantz wrote: So you're saying now that I should add specific elm functions to wrap other libraries just to avoid exposing stuff? I knew the elm api was shitty, but I didn't expect that it would go that far... Don't shoot the messenger, but yes, that's what's done in elementary atm. It wasn't me who decided that. the real problem here is edbus's e_notify requiring an evas image object - that's the poor api. the only way to do what you want nicely is: I added this function the other day and made it take an evas object to keep in line with other notify functions which took evas objects. 1. make elm_icon handle notification stuff itself directly (kind of not too nice - but yes - the idea is elm wraps up these kinds of thnigs so the programmer just points elm at what they want it to do and it goes off to do it) or 2. you create the image object outside of elm and SET it as the icon obj for elm_icon telling em_icon to adopt the image obj as its icon and manage it from then on. -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On 28/10/11 13:25, WooHyun Jung wrote: +1 ~ (wanna hear Tom's opinion. Is there any reason that this API is not deprecated yet?) Because entry is a special case. Entry is all about manipulating text, so you'll end up keeping entry_entry_append and more will probably be added in the future. For the sake of consistency, this API is kept. Dropping entry_entry_set/get and keeping teh rest would be too weird. -- Tom. -- Get your Android app more play: Bring it to the BlackBerry PlayBook in minutes. BlackBerry App World#153; now supports Android#153; Apps for the BlackBerryreg; PlayBook#153;. Discover just how easy and simple it is! http://p.sf.net/sfu/android-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
+1 ~ (wanna hear Tom's opinion. Is there any reason that this API is not deprecated yet?) 2011/10/28, Mike Blumenkrantz m...@zentific.com: On Thu, 27 Oct 2011 12:12:54 -0700 Enlightenment SVN no-re...@enlightenment.org wrote: Log: add long forgotten note for entry filters Author: discomfitor Date: 2011-10-27 12:12:53 -0700 (Thu, 27 Oct 2011) New Revision: 64446 Trac: http://trac.enlightenment.org/e/changeset/64446 Modified: trunk/elementary/src/lib/Elementary.h.in Modified: trunk/elementary/src/lib/Elementary.h.in === --- trunk/elementary/src/lib/Elementary.h.in 2011-10-27 18:59:57 UTC (rev 64445) +++ trunk/elementary/src/lib/Elementary.h.in 2011-10-27 19:12:53 UTC (rev 64446) @@ -11062,6 +11062,7 @@ * @param entry The text to be displayed * * @deprecated Use elm_object_text_set() instead. +* @note Using this function bypasses text filters */ EAPI void elm_entry_entry_set(Evas_Object *obj, const char *entry) EINA_ARG_NONNULL(1); /** -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn debated putting this on text_set() too. thoughts? -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Thu, 27 Oct 2011 12:12:54 -0700 Enlightenment SVN no-re...@enlightenment.org wrote: Log: add long forgotten note for entry filters Author: discomfitor Date: 2011-10-27 12:12:53 -0700 (Thu, 27 Oct 2011) New Revision: 64446 Trac: http://trac.enlightenment.org/e/changeset/64446 Modified: trunk/elementary/src/lib/Elementary.h.in Modified: trunk/elementary/src/lib/Elementary.h.in === --- trunk/elementary/src/lib/Elementary.h.in 2011-10-27 18:59:57 UTC (rev 64445) +++ trunk/elementary/src/lib/Elementary.h.in 2011-10-27 19:12:53 UTC (rev 64446) @@ -11062,6 +11062,7 @@ * @param entry The text to be displayed * * @deprecated Use elm_object_text_set() instead. +* @note Using this function bypasses text filters */ EAPI void elm_entry_entry_set(Evas_Object *obj, const char *entry) EINA_ARG_NONNULL(1); /** -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn debated putting this on text_set() too. thoughts? -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 14:50:44 +0900
ChunEon Parkher...@naver.com wrote:
they can call evas_object_del and content_pop for subobj.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-12(수) 06:06:59
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add elm_pager_content_del() for deleting arbitrary pages from a pager
Author: discomfitor
Date: 2011-10-11 14:06:59 -0700 (Tue, 11 Oct 2011)
New Revision: 63993
Trac: http://trac.enlightenment.org/e/changeset/63993
Modified:
trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_pager.c Modified:
trunk/elementary/src/lib/Elementary.h.in
=== ---
trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:06:59 UTC (rev
63993) @@ -19692,6 +19692,14 @@ */
EAPI void elm_pager_content_push(Evas_Object *obj, Evas_Object *content)
EINA_ARG_NONNULL(1); /**
+ * @brief Delete an arbitrary page from the stack
+ * @param obj The pager object
+ * @param subobj The content object to remove
+ * This removes a content item from the pager stack. If necessary,
elm_pager_content_pop()
+ * will be called to animate a change.
+ */
+ EAPI void elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
EINA_ARG_NONNULL(1, 2);
+ /**
* @brief Pop the object that is on top of the stack
*
* @param obj The pager object
Modified: trunk/elementary/src/lib/elm_pager.c
===
--- trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:06:59 UTC (rev 63993)
@@ -372,6 +372,21 @@
}
EAPI void
+elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype);
+ Widget_Data *wd = elm_widget_data_get(obj);
+ if (!subobj) return;
+ if (!wd) return;
+ if (!wd-stack) return;
+
+ if (subobj == wd-top-content)
+ elm_pager_content_pop(obj);
+ else
+ _content_del(obj, NULL, subobj, NULL);
+}
+
+EAPI void
elm_pager_content_pop(Evas_Object *obj)
{
ELM_CHECK_WIDTYPE(obj, widtype);
not the same thing.
--
Mike Blumenkrantz
Zentific: Coding in binary since '10.
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
same.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: Enlightenment developer
listlt;enlightenment-devel@lists.sourceforge.netgt;
Cc: her...@naver.com
Sent: 11-10-12(수) 14:59:03
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 14:50:44 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
they can call evas_object_del and content_pop for subobj.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-12(수) 06:06:59
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add elm_pager_content_del() for deleting arbitrary pages from a pager
Author: discomfitor
Date: 2011-10-11 14:06:59 -0700 (Tue, 11 Oct 2011)
New Revision: 63993
Trac: http://trac.enlightenment.org/e/changeset/63993
Modified:
trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_pager.c Modified:
trunk/elementary/src/lib/Elementary.h.in
=== ---
trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:06:59 UTC (rev
63993) @@ -19692,6 +19692,14 @@ */
EAPI void elm_pager_content_push(Evas_Object *obj, Evas_Object *content)
EINA_ARG_NONNULL(1); /**
+ * @brief Delete an arbitrary page from the stack
+ * @param obj The pager object
+ * @param subobj The content object to remove
+ * This removes a content item from the pager stack. If necessary,
elm_pager_content_pop()
+ * will be called to animate a change.
+ */
+ EAPI void elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
EINA_ARG_NONNULL(1, 2);
+ /**
* @brief Pop the object that is on top of the stack
*
* @param obj The pager object
Modified: trunk/elementary/src/lib/elm_pager.c
===
--- trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:06:59 UTC (rev 63993)
@@ -372,6 +372,21 @@
}
EAPI void
+elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype);
+ Widget_Data *wd = elm_widget_data_get(obj);
+ if (!subobj) return;
+ if (!wd) return;
+ if (!wd-stack) return;
+
+ if (subobj == wd-top-content)
+ elm_pager_content_pop(obj);
+ else
+ _content_del(obj, NULL, subobj, NULL);
+}
+
+EAPI void
elm_pager_content_pop(Evas_Object *obj)
{
ELM_CHECK_WIDTYPE(obj, widtype);
not the same thing.
--
Mike Blumenkrantz
Zentific: Coding in binary since '10.
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 16:06:19 +0900
ChunEon Parkher...@naver.com wrote:
same.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: Enlightenment developer
listlt;enlightenment-devel@lists.sourceforge.netgt; Cc: her...@naver.com
Sent: 11-10-12(수) 14:59:03
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 14:50:44 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
they can call evas_object_del and content_pop for subobj.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-12(수) 06:06:59
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add elm_pager_content_del() for deleting arbitrary pages from a pager
Author: discomfitor
Date: 2011-10-11 14:06:59 -0700 (Tue, 11 Oct 2011)
New Revision: 63993
Trac: http://trac.enlightenment.org/e/changeset/63993
Modified:
trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_pager.c Modified:
trunk/elementary/src/lib/Elementary.h.in
=== ---
trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:06:59 UTC (rev
63993) @@ -19692,6 +19692,14 @@ */
EAPI void elm_pager_content_push(Evas_Object *obj, Evas_Object *content)
EINA_ARG_NONNULL(1); /**
+ * @brief Delete an arbitrary page from the stack
+ * @param obj The pager object
+ * @param subobj The content object to remove
+ * This removes a content item from the pager stack. If necessary,
elm_pager_content_pop()
+ * will be called to animate a change.
+ */
+ EAPI void elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
EINA_ARG_NONNULL(1, 2);
+ /**
* @brief Pop the object that is on top of the stack
*
* @param obj The pager object
Modified: trunk/elementary/src/lib/elm_pager.c
===
--- trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:06:59 UTC (rev 63993)
@@ -372,6 +372,21 @@
}
EAPI void
+elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype);
+ Widget_Data *wd = elm_widget_data_get(obj);
+ if (!subobj) return;
+ if (!wd) return;
+ if (!wd-stack) return;
+
+ if (subobj == wd-top-content)
+ elm_pager_content_pop(obj);
+ else
+ _content_del(obj, NULL, subobj, NULL);
+}
+
+EAPI void
elm_pager_content_pop(Evas_Object *obj)
{
ELM_CHECK_WIDTYPE(obj, widtype);
not the same thing.
not same!
--
Mike Blumenkrantz
Zentific: Coding in binary since '10.
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
Yes. it's the convenient API for users.
But they can call the evas_object_del to delete the content,
or if it's a top item, they can call pager_content_pop API.
That's all.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: ChunEon Parklt;her...@naver.comgt;
Cc: Enlightenment develolt;enlightenment-devel@lists.sourceforge.netgt;
Sent: 11-10-12(수) 16:18:22
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 16:06:19 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
same.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: Enlightenment developer
listlt;enlightenment-devel@lists.sourceforge.netgt; Cc: her...@naver.com
Sent: 11-10-12(수) 14:59:03
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 14:50:44 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
they can call evas_object_del and content_pop for subobj.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-12(수) 06:06:59
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add elm_pager_content_del() for deleting arbitrary pages from a pager
Author: discomfitor
Date: 2011-10-11 14:06:59 -0700 (Tue, 11 Oct 2011)
New Revision: 63993
Trac: http://trac.enlightenment.org/e/changeset/63993
Modified:
trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_pager.c Modified:
trunk/elementary/src/lib/Elementary.h.in
=== ---
trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:06:59 UTC (rev
63993) @@ -19692,6 +19692,14 @@ */
EAPI void elm_pager_content_push(Evas_Object *obj, Evas_Object *content)
EINA_ARG_NONNULL(1); /**
+ * @brief Delete an arbitrary page from the stack
+ * @param obj The pager object
+ * @param subobj The content object to remove
+ * This removes a content item from the pager stack. If necessary,
elm_pager_content_pop()
+ * will be called to animate a change.
+ */
+ EAPI void elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
EINA_ARG_NONNULL(1, 2);
+ /**
* @brief Pop the object that is on top of the stack
*
* @param obj The pager object
Modified: trunk/elementary/src/lib/elm_pager.c
===
--- trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:06:59 UTC (rev 63993)
@@ -372,6 +372,21 @@
}
EAPI void
+elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype);
+ Widget_Data *wd = elm_widget_data_get(obj);
+ if (!subobj) return;
+ if (!wd) return;
+ if (!wd-stack) return;
+
+ if (subobj == wd-top-content)
+ elm_pager_content_pop(obj);
+ else
+ _content_del(obj, NULL, subobj, NULL);
+}
+
+EAPI void
elm_pager_content_pop(Evas_Object *obj)
{
ELM_CHECK_WIDTYPE(obj, widtype);
not the same thing.
not same!
--
Mike Blumenkrantz
Zentific: Coding in binary since '10.
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 17:02:33 +0900
ChunEon Parkher...@naver.com wrote:
Yes. it's the convenient API for users.
But they can call the evas_object_del to delete the content,
or if it's a top item, they can call pager_content_pop API.
That's all.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: ChunEon Parklt;her...@naver.comgt;
Cc: Enlightenment develolt;enlightenment-devel@lists.sourceforge.netgt;
Sent: 11-10-12(수) 16:18:22
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 16:06:19 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
same.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: Enlightenment developer
listlt;enlightenment-devel@lists.sourceforge.netgt; Cc: her...@naver.com
Sent: 11-10-12(수) 14:59:03
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 14:50:44 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
they can call evas_object_del and content_pop for subobj.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-12(수) 06:06:59
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add elm_pager_content_del() for deleting arbitrary pages from a pager
Author: discomfitor
Date: 2011-10-11 14:06:59 -0700 (Tue, 11 Oct 2011)
New Revision: 63993
Trac: http://trac.enlightenment.org/e/changeset/63993
Modified:
trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_pager.c Modified:
trunk/elementary/src/lib/Elementary.h.in
=== ---
trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:05:32 UTC (rev
63992) +++ trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:06:59
UTC (rev 63993) @@ -19692,6 +19692,14 @@ */
EAPI void elm_pager_content_push(Evas_Object *obj, Evas_Object *content)
EINA_ARG_NONNULL(1); /**
+ * @brief Delete an arbitrary page from the stack
+ * @param obj The pager object
+ * @param subobj The content object to remove
+ * This removes a content item from the pager stack. If necessary,
elm_pager_content_pop()
+ * will be called to animate a change.
+ */
+ EAPI void elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
EINA_ARG_NONNULL(1, 2);
+ /**
* @brief Pop the object that is on top of the stack
*
* @param obj The pager object
Modified: trunk/elementary/src/lib/elm_pager.c
===
--- trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:05:32 UTC (rev
63992) +++ trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:06:59 UTC
(rev 63993) @@ -372,6 +372,21 @@
}
EAPI void
+elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype);
+ Widget_Data *wd = elm_widget_data_get(obj);
+ if (!subobj) return;
+ if (!wd) return;
+ if (!wd-stack) return;
+
+ if (subobj == wd-top-content)
+ elm_pager_content_pop(obj);
+ else
+ _content_del(obj, NULL, subobj, NULL);
+}
+
+EAPI void
elm_pager_content_pop(Evas_Object *obj)
{
ELM_CHECK_WIDTYPE(obj, widtype);
not the same thing.
not same!
even if you call evas_object_del it's still in the pager's stack list and will
cause more problems later because of this.
--
Mike Blumenkrantz
Zentific: Coding in binary since '10.
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
It looks, when content is pushed, it adds _content_del callback for
EVAS_CALLBACK_DEL.
and it removed from the stack in _content_del
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: ChunEon Parklt;her...@naver.comgt;
Cc: Enlightenment develolt;enlightenment-devel@lists.sourceforge.netgt;
Sent: 11-10-12(수) 17:15:10
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 17:02:33 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
Yes. it's the convenient API for users.
But they can call the evas_object_del to delete the content,
or if it's a top item, they can call pager_content_pop API.
That's all.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: ChunEon Parklt;her...@naver.comgt;
Cc: Enlightenment develolt;enlightenment-devel@lists.sourceforge.netgt;
Sent: 11-10-12(수) 16:18:22
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 16:06:19 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
same.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: Enlightenment developer
listlt;enlightenment-devel@lists.sourceforge.netgt; Cc: her...@naver.com
Sent: 11-10-12(수) 14:59:03
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 14:50:44 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
they can call evas_object_del and content_pop for subobj.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-12(수) 06:06:59
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add elm_pager_content_del() for deleting arbitrary pages from a pager
Author: discomfitor
Date: 2011-10-11 14:06:59 -0700 (Tue, 11 Oct 2011)
New Revision: 63993
Trac: http://trac.enlightenment.org/e/changeset/63993
Modified:
trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_pager.c Modified:
trunk/elementary/src/lib/Elementary.h.in
=== ---
trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:05:32 UTC (rev
63992) +++ trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:06:59
UTC (rev 63993) @@ -19692,6 +19692,14 @@ */
EAPI void elm_pager_content_push(Evas_Object *obj, Evas_Object *content)
EINA_ARG_NONNULL(1); /**
+ * @brief Delete an arbitrary page from the stack
+ * @param obj The pager object
+ * @param subobj The content object to remove
+ * This removes a content item from the pager stack. If necessary,
elm_pager_content_pop()
+ * will be called to animate a change.
+ */
+ EAPI void elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
EINA_ARG_NONNULL(1, 2);
+ /**
* @brief Pop the object that is on top of the stack
*
* @param obj The pager object
Modified: trunk/elementary/src/lib/elm_pager.c
===
--- trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:05:32 UTC (rev
63992) +++ trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:06:59 UTC
(rev 63993) @@ -372,6 +372,21 @@
}
EAPI void
+elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype);
+ Widget_Data *wd = elm_widget_data_get(obj);
+ if (!subobj) return;
+ if (!wd) return;
+ if (!wd-stack) return;
+
+ if (subobj == wd-top-content)
+ elm_pager_content_pop(obj);
+ else
+ _content_del(obj, NULL, subobj, NULL);
+}
+
+EAPI void
elm_pager_content_pop(Evas_Object *obj)
{
ELM_CHECK_WIDTYPE(obj, widtype);
not the same thing.
not same!
even if you call evas_object_del it's still in the pager's stack list and will
cause more problems later because of this.
--
Mike Blumenkrantz
Zentific: Coding in binary since '10.
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 17:37:26 +0900
ChunEon Parkher...@naver.com wrote:
It looks, when content is pushed, it adds _content_del callback for
EVAS_CALLBACK_DEL. and it removed from the stack in _content_del
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: ChunEon Parklt;her...@naver.comgt;
Cc: Enlightenment develolt;enlightenment-devel@lists.sourceforge.netgt;
Sent: 11-10-12(수) 17:15:10
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 17:02:33 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
Yes. it's the convenient API for users.
But they can call the evas_object_del to delete the content,
or if it's a top item, they can call pager_content_pop API.
That's all.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: ChunEon Parklt;her...@naver.comgt;
Cc: Enlightenment develolt;enlightenment-devel@lists.sourceforge.netgt;
Sent: 11-10-12(수) 16:18:22
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 16:06:19 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
same.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Mike Blumenkrantzlt;m...@zentific.comgt;
To: Enlightenment developer
listlt;enlightenment-devel@lists.sourceforge.netgt; Cc:
her...@naver.com Sent: 11-10-12(수) 14:59:03
Subject: Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 12 Oct 2011 14:50:44 +0900
ChunEon Parklt;her...@naver.comgt; wrote:
they can call evas_object_del and content_pop for subobj.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-12(수) 06:06:59
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add elm_pager_content_del() for deleting arbitrary pages from a pager
Author: discomfitor
Date: 2011-10-11 14:06:59 -0700 (Tue, 11 Oct 2011)
New Revision: 63993
Trac: http://trac.enlightenment.org/e/changeset/63993
Modified:
trunk/elementary/src/lib/Elementary.h.in
trunk/elementary/src/lib/elm_pager.c Modified:
trunk/elementary/src/lib/Elementary.h.in
=== ---
trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:05:32 UTC (rev
63992) +++ trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:06:59
UTC (rev 63993) @@ -19692,6 +19692,14 @@ */
EAPI void elm_pager_content_push(Evas_Object *obj, Evas_Object *content)
EINA_ARG_NONNULL(1); /**
+ * @brief Delete an arbitrary page from the stack
+ * @param obj The pager object
+ * @param subobj The content object to remove
+ * This removes a content item from the pager stack. If necessary,
elm_pager_content_pop()
+ * will be called to animate a change.
+ */
+ EAPI void elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
EINA_ARG_NONNULL(1, 2);
+ /**
* @brief Pop the object that is on top of the stack
*
* @param obj The pager object
Modified: trunk/elementary/src/lib/elm_pager.c
===
--- trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:05:32 UTC (rev
63992) +++ trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:06:59 UTC
(rev 63993) @@ -372,6 +372,21 @@
}
EAPI void
+elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype);
+ Widget_Data *wd = elm_widget_data_get(obj);
+ if (!subobj) return;
+ if (!wd) return;
+ if (!wd-stack) return;
+
+ if (subobj == wd-top-content)
+ elm_pager_content_pop(obj);
+ else
+ _content_del(obj, NULL, subobj, NULL);
+}
+
+EAPI void
elm_pager_content_pop(Evas_Object *obj)
{
ELM_CHECK_WIDTYPE(obj, widtype);
not the same thing.
not same!
even if you call evas_object_del it's still in the pager's stack list and will
cause more problems later because of this.
well swizzle me fizzwidgets
--
Mike Blumenkrantz
Zentific: Coding in binary since '10.
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
they can call evas_object_del and content_pop for subobj.
Let's run together for the best moment!
-Regards, Hermet-
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
To: enlightenment-...@lists.sourceforge.net
Cc:
Sent: 11-10-12(수) 06:06:59
Subject: E SVN: discomfitor trunk/elementary/src/lib
Log:
add elm_pager_content_del() for deleting arbitrary pages from a pager
Author: discomfitor
Date: 2011-10-11 14:06:59 -0700 (Tue, 11 Oct 2011)
New Revision: 63993
Trac: http://trac.enlightenment.org/e/changeset/63993
Modified:
trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_pager.c
Modified: trunk/elementary/src/lib/Elementary.h.in
===
--- trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/Elementary.h.in 2011-10-11 21:06:59 UTC (rev 63993)
@@ -19692,6 +19692,14 @@
*/
EAPI void elm_pager_content_push(Evas_Object *obj, Evas_Object *content)
EINA_ARG_NONNULL(1);
/**
+ * @brief Delete an arbitrary page from the stack
+ * @param obj The pager object
+ * @param subobj The content object to remove
+ * This removes a content item from the pager stack. If necessary,
elm_pager_content_pop()
+ * will be called to animate a change.
+ */
+ EAPI void elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
EINA_ARG_NONNULL(1, 2);
+ /**
* @brief Pop the object that is on top of the stack
*
* @param obj The pager object
Modified: trunk/elementary/src/lib/elm_pager.c
===
--- trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:05:32 UTC (rev 63992)
+++ trunk/elementary/src/lib/elm_pager.c 2011-10-11 21:06:59 UTC (rev 63993)
@@ -372,6 +372,21 @@
}
EAPI void
+elm_pager_content_del(Evas_Object *obj, Evas_Object *subobj)
+{
+ ELM_CHECK_WIDTYPE(obj, widtype);
+ Widget_Data *wd = elm_widget_data_get(obj);
+ if (!subobj) return;
+ if (!wd) return;
+ if (!wd-stack) return;
+
+ if (subobj == wd-top-content)
+ elm_pager_content_pop(obj);
+ else
+ _content_del(obj, NULL, subobj, NULL);
+}
+
+EAPI void
elm_pager_content_pop(Evas_Object *obj)
{
ELM_CHECK_WIDTYPE(obj, widtype);
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
i noticed it but forgot to tell you. i was on the bus at that time. so not nobody :p Daniel Juyung Seo (SeoZ) On Sep 30, 2011 5:28 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: apparently I forgot to add this in my earlier toolbar commit and nobody noticed Author: discomfitor Date: 2011-09-29 13:27:05 -0700 (Thu, 29 Sep 2011) New Revision: 63674 Trac: http://trac.enlightenment.org/e/changeset/63674 Modified: trunk/elementary/src/lib/Elementary.h.in Modified: trunk/elementary/src/lib/Elementary.h.in === --- trunk/elementary/src/lib/Elementary.h.in 2011-09-29 20:18:58 UTC (rev 63673) +++ trunk/elementary/src/lib/Elementary.h.in 2011-09-29 20:27:05 UTC (rev 63674) @@ -13694,6 +13694,18 @@ EAPI const char *elm_toolbar_item_icon_get(const Elm_Toolbar_Item *item) EINA_ARG_NONNULL(1); /** + * Get the icon object of @p item. + * + * @param item The toolbar item. + * @return The icon object + * + * @see elm_toolbar_item_icon_set() or elm_toolbar_item_icon_memfile_set() for details. + * + * @ingroup Toolbar + */ + EAPI Evas_Object *elm_toolbar_item_icon_object_get(Elm_Toolbar_Item *item) EINA_ARG_NONNULL(1); + + /** * Set the icon associated with @p item to an image in a binary buffer. * * @param item The toolbar item. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
I love this commit!
This will be so helpful to application programmers.
Thanks stu!
Daniel Juyung Seo (SeoZ)
On Mon, Sep 12, 2011 at 11:06 AM, Enlightenment SVN
no-re...@enlightenment.org wrote:
Log:
make ELM_CHECK_WIDTYPE co macros useful. would you believe this macro came
from my first ever code patch :D
Author: discomfitor
Date: 2011-09-11 19:06:27 -0700 (Sun, 11 Sep 2011)
New Revision: 63334
Trac: http://trac.enlightenment.org/e/changeset/63334
Modified:
trunk/elementary/src/lib/elm_transit.c trunk/elementary/src/lib/elm_widget.c
trunk/elementary/src/lib/elm_widget.h
Modified: trunk/elementary/src/lib/elm_transit.c
===
--- trunk/elementary/src/lib/elm_transit.c 2011-09-12 02:05:30 UTC (rev
6)
+++ trunk/elementary/src/lib/elm_transit.c 2011-09-12 02:06:27 UTC (rev
63334)
@@ -2212,7 +2212,7 @@
EINA_LIST_FOREACH(transit-objs, elist, obj)
{
- if (elm_widget_type_check(obj, type))
+ if (elm_widget_type_check(obj, type, __func__))
elm_icon_file_set(obj,
eina_list_nth(image_animation-images, count),
NULL);
}
Modified: trunk/elementary/src/lib/elm_widget.c
===
--- trunk/elementary/src/lib/elm_widget.c 2011-09-12 02:05:30 UTC (rev
6)
+++ trunk/elementary/src/lib/elm_widget.c 2011-09-12 02:06:27 UTC (rev
63334)
@@ -2447,7 +2447,8 @@
EAPI Eina_Bool
elm_widget_type_check(const Evas_Object *obj,
- const char *type)
+ const char *type,
+ const char *func)
{
const char *provided, *expected = (unknown);
static int abort_on_warn = -1;
@@ -2460,7 +2461,7 @@
if ((!provided) || (!provided[0]))
provided = (unknown);
}
- ERR(Passing Object: %p, of type: '%s' when expecting type: '%s', obj,
provided, expected);
+ ERR(Passing Object: %p in function: %s, of type: '%s' when expecting
type: '%s', obj, func, provided, expected);
if (abort_on_warn == -1)
{
if (getenv(ELM_ERROR_ABORT)) abort_on_warn = 1;
Modified: trunk/elementary/src/lib/elm_widget.h
===
--- trunk/elementary/src/lib/elm_widget.h 2011-09-12 02:05:30 UTC (rev
6)
+++ trunk/elementary/src/lib/elm_widget.h 2011-09-12 02:06:27 UTC (rev
63334)
@@ -401,7 +401,7 @@
EAPI void elm_widget_type_register(const char **ptr);
EAPI void elm_widget_type_unregister(const char **ptr);
EAPI Eina_Bool elm_widget_is_check(const Evas_Object *obj);
-EAPI Eina_Bool elm_widget_type_check(const Evas_Object *obj, const
char *type);
+EAPI Eina_Bool elm_widget_type_check(const Evas_Object *obj, const
char *type, const char *func);
EAPI Eina_List *elm_widget_stringlist_get(const char *str);
EAPI void elm_widget_stringlist_free(Eina_List *list);
EAPI void elm_widget_focus_hide_handle(Evas_Object *obj);
@@ -676,7 +676,7 @@
if (!elm_widget_is_check(obj)) return
#define ELM_CHECK_WIDTYPE(obj, widtype) \
- if (!elm_widget_type_check((obj), (widtype))) return
+ if (!elm_widget_type_check((obj), (widtype), __func__)) return
#define ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it, ...) \
ELM_WIDGET_ITEM_CHECK_OR_RETURN((Elm_Widget_Item *)it, __VA_ARGS__); \
@@ -684,7 +684,7 @@
#define ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_GOTO(it, label) \
ELM_WIDGET_ITEM_CHECK_OR_GOTO((Elm_Widget_Item *)it, label); \
- if (!elm_widget_type_check((it-base.widget), (widtype))) goto label;
+ if (!elm_widget_type_check((it-base.widget), (widtype), __func__)) goto
label;
#define ELM_WIDGET_STANDARD_SETUP(wdat, wdtype, par, evas, ob, ret) \
do { \
--
Doing More with Less: The Next Generation Virtual Desktop
What are the key obstacles that have prevented many mid-market businesses
from deploying virtual desktops? How do next-generation virtual desktops
provide companies an easier-to-deploy, easier-to-manage and more affordable
virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage
and backup environments for virtualization.
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Thu, 25 Aug 2011 19:43:48 -0700 Enlightenment SVN no-re...@enlightenment.org wrote: Log: also fix text_converter I guess Author: discomfitor Date: 2011-08-25 19:43:48 -0700 (Thu, 25 Aug 2011) New Revision: 62849 Trac: http://trac.enlightenment.org/e/changeset/62849 Modified: trunk/elementary/src/lib/elm_cnp_helper.c this series of commits fixes the case where you attempt ecore_x_selection_clipboard_set while using elm. previously it crashed you immediately, now it just makes your life hell if you try and copy a string that's as long as sizeof(int). -- Mike Blumenkrantz Zentific: Coding in binary since '10. -- EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Fri, 29 Jul 2011 08:08:56 -0700 Enlightenment SVN no-re...@enlightenment.org wrote: Log: unbreak elm_menu_item api the following functions are now DEPRECATED and will be removed on 5 AUG 2011: elm_menu_item_object_icon_get - elm_menu_item_object_content_get elm_menu_item_icon_get - elm_menu_item_object_icon_name_get elm_menu_item_icon_set - elm_menu_item_object_icon_name_set added the following NEW functions: elm_menu_item_object_content_set elm_menu_item_menu_get (this will probably be replaced by an eventual elm_object_item_owner_get() or whatever it gets named) Author: discomfitor Date: 2011-07-29 08:08:56 -0700 (Fri, 29 Jul 2011) New Revision: 61899 Trac: http://trac.enlightenment.org/e/changeset/61899 Modified: trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_menu.c I was feeling benevolent this time, so I marked functions slated for removal as deprecated instead of just deleting them outright. Migrate your code quickly, as I intend to be very punctual with my deletions. On other matters, is Elm_Widget_Item stable enough to create an elm_object_item api yet? I think it would be nice to consolidate a lot of the genlist_item/gengrid_item/list_item/menu_item/etc apis... -- Mike Blumenkrantz Zentific: Coding in binary since '10. -- Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Wed, 27 Jul 2011 00:12:29 -0700 Enlightenment SVN no-re...@enlightenment.org wrote: Log: significantly improve tooltip orientation calculations Author: discomfitor Date: 2011-07-27 00:12:28 -0700 (Wed, 27 Jul 2011) New Revision: 61795 Trac: http://trac.enlightenment.org/e/changeset/61795 Modified: trunk/elementary/src/lib/els_tooltip.c this is probably as good as it's gonna get -- Mike Blumenkrantz Zentific: Coding in binary since '10. -- Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib
On Fri, 22 Jul 2011 16:03:46 -0700 Enlightenment SVN no-re...@enlightenment.org wrote: Log: +elm_icon_memfile_set Author: discomfitor Date: 2011-07-22 16:03:46 -0700 (Fri, 22 Jul 2011) New Revision: 61603 Trac: http://trac.enlightenment.org/e/changeset/61603 Modified: trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_icon.c trunk/elementary/src/lib/els_icon.c trunk/elementary/src/lib/els_icon.h In the process of this, I noticed that evas_object_image_memfile_set does not have const properly set on any of its params. -- Mike Blumenkrantz Zentific: Coding in binary since '10. -- 10 Tips for Better Web Security Learn 10 ways to better secure your business today. Topics covered include: Web security, SSL, hacker attacks Denial of Service (DoS), private keys, security Microsoft Exchange, secure Instant Messaging, and much more. http://www.accelacomm.com/jaw/sfnl/114/51426210/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
