Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Jose Souza]

Good catch, I will write a EDBus_Connection_Event_Type for Disconnection.

On Sun, Nov 11, 2012 at 6:59 PM, Enlightenment SVN
 wrote:
> Log:
> efreet: shutdown on error and disconnect
>
>   When bus stops it send Disconnect signal. Trap and die.
>
> Author:   englebass
> Date: 2012-11-11 12:59:03 -0800 (Sun, 11 Nov 2012)
> New Revision: 79122
> Trac: http://trac.enlightenment.org/e/changeset/79122
>
> Modified:
>   trunk/efreet/src/bin/efreetd_dbus.c
>
> Modified: trunk/efreet/src/bin/efreetd_dbus.c
> ===
> --- trunk/efreet/src/bin/efreetd_dbus.c 2012-11-11 20:58:38 UTC (rev 79121)
> +++ trunk/efreet/src/bin/efreetd_dbus.c 2012-11-11 20:59:03 UTC (rev 79122)
> @@ -11,6 +11,9 @@
>  #define BUS "org.enlightenment.Efreet"
>  #define PATH "/org/enlightenment/Efreet"
>  #define INTERFACE "org.enlightenment.Efreet"
> +/* TODO: Get from dbus include */
> +#define DBUS_PATH_LOCAL "/org/freedesktop/DBus/Local"
> +#define DBUS_INTERFACE_LOCAL "org.freedesktop.DBus.Local"
>
>  /* internal */
>  enum
> @@ -32,6 +35,13 @@
> return ECORE_CALLBACK_CANCEL;
>  }
>
> +static void
> +disconnected(void *context __UNUSED__, const EDBus_Message *msg __UNUSED__)
> +{
> +   INF("disconnected");
> +   quit();
> +}
> +
>  static EDBus_Message *
>  do_register(const EDBus_Service_Interface *ifc __UNUSED__, const 
> EDBus_Message *message)
>  {
> @@ -166,25 +176,29 @@
>  static void
>  on_name_request(void *data __UNUSED__, const EDBus_Message *msg, 
> EDBus_Pending *pending __UNUSED__)
>  {
> -   unsigned int flag;
> +   unsigned int reply;
>
> if (edbus_message_error_get(msg, NULL, NULL))
>   {
>  ERR("error on on_name_request");
> +quit();
>  return;
>   }
>
> -   if (!edbus_message_arguments_get(msg, "u", &flag))
> +   if (!edbus_message_arguments_get(msg, "u", &reply))
>   {
>  ERR("error getting arguments on on_name_request");
> +quit();
>  return;
>   }
>
> -   if (!(flag & EDBUS_NAME_REQUEST_REPLY_PRIMARY_OWNER))
> +   if (reply != EDBUS_NAME_REQUEST_REPLY_PRIMARY_OWNER)
>   {
>  ERR("error name already in use");
> +quit();
>  return;
>   }
> +   INF("name requested");
>  }
>
>  /* external */
> @@ -208,6 +222,7 @@
> conn = edbus_connection_get(EDBUS_CONNECTION_TYPE_SESSION);
> if (!conn) goto conn_error;
>
> +   edbus_signal_handler_add(conn, NULL, DBUS_PATH_LOCAL, 
> DBUS_INTERFACE_LOCAL, "Disconnected", disconnected, NULL);
> iface = edbus_service_interface_register(conn, PATH, &desc);
> edbus_name_request(conn, BUS, EDBUS_NAME_REQUEST_FLAG_DO_NOT_QUEUE,
>on_name_request, NULL);
>
>
> --
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_nov
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[sd]

>
>
> On Wed, 16 Mar 2011, Sebastian Dransfeld wrote:
>
>> On 03/15/2011 11:55 PM, Vincent Torri wrote:
>>>
>>>
>>> On Tue, 15 Mar 2011, Enlightenment SVN wrote:
>>>
 Log:
 Efreet: And revert logging, no longer needed
>>>
>>> eina_log support is enabled, but it seems that it is disabled in
>>> efreet.
>>> See efreet_private.h lines 72 and after and efreet.c line 36. On the
>>> other
>>> hand, it's enabled in efreet_mime (see efreet_mime.c line 46).
>>
>> I know. And if I get time, I will fix all of efreet to use eina_log. But
>> right now I don't even have time to fix real problems. So please stop
>> telling me about eina_log in efreet.
>
> ok. I thought that efreet didn't have eina_log and i wanted to write a
> patch to add it. I think twice before helping, now...

Sorry, but this is unfair. I would appreciate it very much if you would
write a patch to convert printf's to eina_log in efreet.

The reason I reacted the way I did, is that we have had this discussion
some weeks (or months?) ago when I also added some printf's.

S.


--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Vincent Torri]

On Wed, 16 Mar 2011, Sebastian Dransfeld wrote:

> On 03/15/2011 11:55 PM, Vincent Torri wrote:
>>
>>
>> On Tue, 15 Mar 2011, Enlightenment SVN wrote:
>>
>>> Log:
>>> Efreet: And revert logging, no longer needed
>>
>> eina_log support is enabled, but it seems that it is disabled in efreet.
>> See efreet_private.h lines 72 and after and efreet.c line 36. On the other
>> hand, it's enabled in efreet_mime (see efreet_mime.c line 46).
>
> I know. And if I get time, I will fix all of efreet to use eina_log. But
> right now I don't even have time to fix real problems. So please stop
> telling me about eina_log in efreet.

ok. I thought that efreet didn't have eina_log and i wanted to write a 
patch to add it. I think twice before helping, now...

Vincent

--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

On 03/15/2011 11:55 PM, Vincent Torri wrote:
>
>
> On Tue, 15 Mar 2011, Enlightenment SVN wrote:
>
>> Log:
>> Efreet: And revert logging, no longer needed
>
> eina_log support is enabled, but it seems that it is disabled in efreet.
> See efreet_private.h lines 72 and after and efreet.c line 36. On the other
> hand, it's enabled in efreet_mime (see efreet_mime.c line 46).

I know. And if I get time, I will fix all of efreet to use eina_log. But 
right now I don't even have time to fix real problems. So please stop 
telling me about eina_log in efreet.

S.

--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[The Rasterman]

On Wed, 16 Mar 2011 00:08:28 +0200 Tom Hacohen  said:

i don't see a problem with quick and dirty printfs in trunk when working on an
issue. if you want more permanent logging abilities - eina_log is probably good
as u can turn it on and off at will.

> :)))
> 
> discomfitor: no one is fighting (or at least I wasn't).
> 
> On Tue, Mar 15, 2011 at 8:51 PM, Sebastian Dransfeld
> wrote:
> 
> > Code gone, I'll never do it again.
> >
> > S.
> >
> > On 03/15/2011 07:32 PM, Tom Hacohen wrote:
> > > "Because I don't do the testing, someone else is. And that person is no
> > > coder." -
> > > What's wrong with a patch?
> > >
> > > Maybe it's just me, but I don't think debugging should happen through
> > > SVN. :)
> > >
> > > --
> > > Tom.
> > >
> > > On Tue, Mar 15, 2011 at 8:24 PM, Sebastian Dransfeld  > > > wrote:
> > >
> > > On 03/15/2011 07:15 PM, Tom Hacohen wrote:
> > >  > On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld
> > > mailto:s...@tango.flipp.net>
> > >  > >> wrote:
> > >  >
> > >  > Because I needed quick and dirty logging to track down the
> > > Mac OS X
> > >  > issue, and eina logging is still not enabled here which is
> > > the same
> > >  > reason as last time.
> > >  >
> > >  > Do you have an auto script to check for added printf's?
> > >  >
> > >  >
> > >  > Maybe I misunderstood you, but if you need a quick and dirty
> > > logging to
> > >  > track down
> > >  > a Mac OS X issue, why did you commit it in to SVN?
> > >
> > > Because I don't do the testing, someone else is. And that person is
> > no
> > > coder.
> > >
> > >  > And if eina logging is "disabled" why don't you add it (or ask as
> > >  > someone else to)?
> > >
> > > No time, and feel free to fix.
> > >
> > >  > This is not an excuse for adding ugliness to svn.
> > >
> > > I have a good excuse, look above.
> > >
> > >  >
> > >  > That's at least what I think.
> > >
> > > Thinking is good, but patches are better :)
> > >
> > > S.
> > >
> > >
> > --
> > > Colocation vs. Managed Hosting
> > > A question and answer guide to determining the best fit
> > > for your organization - today and in the future.
> > > http://p.sf.net/sfu/internap-sfd2d
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > 
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> > >
> > >
> > >
> > > --
> > > Tom.
> >
> >
> >
> > --
> > Colocation vs. Managed Hosting
> > A question and answer guide to determining the best fit
> > for your organization - today and in the future.
> > http://p.sf.net/sfu/internap-sfd2d
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> 
> 
> 
> -- 
> Tom.
> --
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Vincent Torri]

On Tue, 15 Mar 2011, Enlightenment SVN wrote:

> Log:
> Efreet: And revert logging, no longer needed

eina_log support is enabled, but it seems that it is disabled in efreet. 
See efreet_private.h lines 72 and after and efreet.c line 36. On the other 
hand, it's enabled in efreet_mime (see efreet_mime.c line 46).

Vincent

>
> Author:   englebass
> Date: 2011-03-15 11:49:49 -0700 (Tue, 15 Mar 2011)
> New Revision: 57772
> Trac: http://trac.enlightenment.org/e/changeset/57772
>
> Modified:
>  trunk/efreet/src/bin/efreet_icon_cache_create.c
>
> Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c
> ===
> --- trunk/efreet/src/bin/efreet_icon_cache_create.c   2011-03-15 17:20:58 UTC 
> (rev 57771)
> +++ trunk/efreet/src/bin/efreet_icon_cache_create.c   2011-03-15 18:49:49 UTC 
> (rev 57772)
> @@ -743,7 +743,6 @@
>
> icon_themes = 
> eina_hash_string_superfast_new(EINA_FREE_CB(icon_theme_free));
>
> -if (verbose) printf("opening theme cache\n");
> /* open theme file */
> theme_ef = eet_open(efreet_icon_theme_cache_file(), 
> EET_FILE_MODE_READ_WRITE);
> if (!theme_ef) goto on_error_efreet;
> @@ -779,7 +778,6 @@
> free(keys);
> }
>
> -if (verbose) printf("scan for themes\n");
> /* scan themes */
> cache_theme_scan(efreet_icon_deprecated_user_dir_get());
> cache_theme_scan(efreet_icon_user_dir_get());
> @@ -811,12 +809,10 @@
> #ifndef STRICT_SPEC
> if (!theme->theme.name.name) continue;
> #endif
> -if (verbose) printf("scan theme %s\n", theme->theme.name.name);
>
> changed = EINA_FALSE;
> themes = eina_hash_string_superfast_new(NULL);
>
> -if (verbose) printf("open icon file\n");
> /* open icon file */
> icon_ef = 
> eet_open(efreet_icon_cache_file(theme->theme.name.internal), 
> EET_FILE_MODE_READ_WRITE);
> if (!icon_ef) goto on_error_efreet;
> @@ -866,7 +862,6 @@
> if (!theme->dirs)
> theme->dirs = eina_hash_string_superfast_new(NULL);
>
> -if (verbose) printf("scan icons\n");
> if (cache_scan(&(theme->theme), themes, icons, theme->dirs, &changed))
> {
> if (verbose)
> @@ -906,7 +901,6 @@
>
> changed = EINA_FALSE;
>
> -if (verbose) printf("open fallback file\n");
> /* open icon file */
> icon_ef = eet_open(efreet_icon_cache_file(EFREET_CACHE_ICON_FALLBACK), 
> EET_FILE_MODE_READ_WRITE);
> if (!icon_ef) goto on_error_efreet;
> @@ -956,7 +950,6 @@
> if (!theme->dirs)
> theme->dirs = eina_hash_string_superfast_new(NULL);
>
> -if (verbose) printf("scan fallback icons\n");
> /* Save fallback in the right part */
> if (cache_fallback_scan(icons, theme->dirs, &changed))
> {
> @@ -1004,7 +997,6 @@
> }
> }
>
> -if (verbose) printf("done\n");
> on_error_efreet:
> efreet_shutdown();
>
>
>
> --
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Tom Hacohen]

:)))

discomfitor: no one is fighting (or at least I wasn't).

On Tue, Mar 15, 2011 at 8:51 PM, Sebastian Dransfeld 
wrote:

> Code gone, I'll never do it again.
>
> S.
>
> On 03/15/2011 07:32 PM, Tom Hacohen wrote:
> > "Because I don't do the testing, someone else is. And that person is no
> > coder." -
> > What's wrong with a patch?
> >
> > Maybe it's just me, but I don't think debugging should happen through
> > SVN. :)
> >
> > --
> > Tom.
> >
> > On Tue, Mar 15, 2011 at 8:24 PM, Sebastian Dransfeld  > > wrote:
> >
> > On 03/15/2011 07:15 PM, Tom Hacohen wrote:
> >  > On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld
> > mailto:s...@tango.flipp.net>
> >  > >> wrote:
> >  >
> >  > Because I needed quick and dirty logging to track down the
> > Mac OS X
> >  > issue, and eina logging is still not enabled here which is
> > the same
> >  > reason as last time.
> >  >
> >  > Do you have an auto script to check for added printf's?
> >  >
> >  >
> >  > Maybe I misunderstood you, but if you need a quick and dirty
> > logging to
> >  > track down
> >  > a Mac OS X issue, why did you commit it in to SVN?
> >
> > Because I don't do the testing, someone else is. And that person is
> no
> > coder.
> >
> >  > And if eina logging is "disabled" why don't you add it (or ask as
> >  > someone else to)?
> >
> > No time, and feel free to fix.
> >
> >  > This is not an excuse for adding ugliness to svn.
> >
> > I have a good excuse, look above.
> >
> >  >
> >  > That's at least what I think.
> >
> > Thinking is good, but patches are better :)
> >
> > S.
> >
> >
> --
> > Colocation vs. Managed Hosting
> > A question and answer guide to determining the best fit
> > for your organization - today and in the future.
> > http://p.sf.net/sfu/internap-sfd2d
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > 
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
> >
> >
> > --
> > Tom.
>
>
>
> --
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>



-- 
Tom.
--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Mike Blumenkrantz]

On Tue, 15 Mar 2011 19:51:26 +0100
Sebastian Dransfeld  wrote:

> Code gone, I'll never do it again.
> 
> S.
> 
> On 03/15/2011 07:32 PM, Tom Hacohen wrote:
> > "Because I don't do the testing, someone else is. And that person is no
> > coder." -
> > What's wrong with a patch?
> >
> > Maybe it's just me, but I don't think debugging should happen through
> > SVN. :)
> >
> > --
> > Tom.
> >
> > On Tue, Mar 15, 2011 at 8:24 PM, Sebastian Dransfeld  > > wrote:
> >
> > On 03/15/2011 07:15 PM, Tom Hacohen wrote:
> >  > On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld
> > mailto:s...@tango.flipp.net>
> >  > >> wrote:
> >  >
> >  > Because I needed quick and dirty logging to track down the
> > Mac OS X
> >  > issue, and eina logging is still not enabled here which is
> > the same
> >  > reason as last time.
> >  >
> >  > Do you have an auto script to check for added printf's?
> >  >
> >  >
> >  > Maybe I misunderstood you, but if you need a quick and dirty
> > logging to
> >  > track down
> >  > a Mac OS X issue, why did you commit it in to SVN?
> >
> > Because I don't do the testing, someone else is. And that person is no
> > coder.
> >
> >  > And if eina logging is "disabled" why don't you add it (or ask as
> >  > someone else to)?
> >
> > No time, and feel free to fix.
> >
> >  > This is not an excuse for adding ugliness to svn.
> >
> > I have a good excuse, look above.
> >
> >  >
> >  > That's at least what I think.
> >
> > Thinking is good, but patches are better :)
> >
> > S.
> >
> > 
> > --
> > Colocation vs. Managed Hosting
> > A question and answer guide to determining the best fit
> > for your organization - today and in the future.
> > http://p.sf.net/sfu/internap-sfd2d
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > 
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
> >
> >
> > --
> > Tom.
> 
> 
imo it's fine and not really worth complaining/fighting over...

-- 
Mike Blumenkrantz
Zentific: NULL pointer dereferences now 50% off!

--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

Code gone, I'll never do it again.

S.

On 03/15/2011 07:32 PM, Tom Hacohen wrote:
> "Because I don't do the testing, someone else is. And that person is no
> coder." -
> What's wrong with a patch?
>
> Maybe it's just me, but I don't think debugging should happen through
> SVN. :)
>
> --
> Tom.
>
> On Tue, Mar 15, 2011 at 8:24 PM, Sebastian Dransfeld  > wrote:
>
> On 03/15/2011 07:15 PM, Tom Hacohen wrote:
>  > On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld
> mailto:s...@tango.flipp.net>
>  > >> wrote:
>  >
>  > Because I needed quick and dirty logging to track down the
> Mac OS X
>  > issue, and eina logging is still not enabled here which is
> the same
>  > reason as last time.
>  >
>  > Do you have an auto script to check for added printf's?
>  >
>  >
>  > Maybe I misunderstood you, but if you need a quick and dirty
> logging to
>  > track down
>  > a Mac OS X issue, why did you commit it in to SVN?
>
> Because I don't do the testing, someone else is. And that person is no
> coder.
>
>  > And if eina logging is "disabled" why don't you add it (or ask as
>  > someone else to)?
>
> No time, and feel free to fix.
>
>  > This is not an excuse for adding ugliness to svn.
>
> I have a good excuse, look above.
>
>  >
>  > That's at least what I think.
>
> Thinking is good, but patches are better :)
>
> S.
>
> 
> --
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> 
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
>
>
> --
> Tom.


--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Tom Hacohen]

"Because I don't do the testing, someone else is. And that person is no
coder." -
What's wrong with a patch?

Maybe it's just me, but I don't think debugging should happen through SVN.
:)

--
Tom.

On Tue, Mar 15, 2011 at 8:24 PM, Sebastian Dransfeld 
wrote:

> On 03/15/2011 07:15 PM, Tom Hacohen wrote:
> > On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld  > > wrote:
> >
> > Because I needed quick and dirty logging to track down the Mac OS X
> > issue, and eina logging is still not enabled here which is the same
> > reason as last time.
> >
> > Do you have an auto script to check for added printf's?
> >
> >
> > Maybe I misunderstood you, but if you need a quick and dirty logging to
> > track down
> > a Mac OS X issue, why did you commit it in to SVN?
>
> Because I don't do the testing, someone else is. And that person is no
> coder.
>
> > And if eina logging is "disabled" why don't you add it (or ask as
> > someone else to)?
>
> No time, and feel free to fix.
>
> > This is not an excuse for adding ugliness to svn.
>
> I have a good excuse, look above.
>
> >
> > That's at least what I think.
>
> Thinking is good, but patches are better :)
>
> S.
>
>
> --
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>



-- 
Tom.
--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

On 03/15/2011 07:15 PM, Tom Hacohen wrote:
> On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld  > wrote:
>
> Because I needed quick and dirty logging to track down the Mac OS X
> issue, and eina logging is still not enabled here which is the same
> reason as last time.
>
> Do you have an auto script to check for added printf's?
>
>
> Maybe I misunderstood you, but if you need a quick and dirty logging to
> track down
> a Mac OS X issue, why did you commit it in to SVN?

Because I don't do the testing, someone else is. And that person is no 
coder.

> And if eina logging is "disabled" why don't you add it (or ask as
> someone else to)?

No time, and feel free to fix.

> This is not an excuse for adding ugliness to svn.

I have a good excuse, look above.

>
> That's at least what I think.

Thinking is good, but patches are better :)

S.

--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Tom Hacohen]

On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld 
wrote:

>  Because I needed quick and dirty logging to track down the Mac OS X
> issue, and eina logging is still not enabled here which is the same
> reason as last time.
>
> Do you have an auto script to check for added printf's?
>
>
Maybe I misunderstood you, but if you need a quick and dirty logging to
track down
a Mac OS X issue, why did you commit it in to SVN?

And if eina logging is "disabled" why don't you add it (or ask as someone
else to)?
This is not an excuse for adding ugliness to svn.

That's at least what I think.

-- 
Tom.
--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Gustavo Sverzut Barbieri]

You dont need any enablement to use eina_log, just use the global
macros and you'll get it. Of couse it would be desirable to have one
domain for efreet

On Tuesday, March 15, 2011, Sebastian Dransfeld  wrote:
> On 03/15/2011 06:12 PM, Vincent Torri wrote:
>>
>>
>> On Tue, 15 Mar 2011, Enlightenment SVN wrote:
>>
>>> Log:
>>> Efreet: Add some logging
>>
>> why not using eina_log ?
>
> Because I needed quick and dirty logging to track down the Mac OS X
> issue, and eina logging is still not enabled here which is the same
> reason as last time.
>
> Do you have an auto script to check for added printf's?
>
> S.
>
> --
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

On 03/15/2011 06:12 PM, Vincent Torri wrote:
>
>
> On Tue, 15 Mar 2011, Enlightenment SVN wrote:
>
>> Log:
>> Efreet: Add some logging
>
> why not using eina_log ?

Because I needed quick and dirty logging to track down the Mac OS X 
issue, and eina logging is still not enabled here which is the same 
reason as last time.

Do you have an auto script to check for added printf's?

S.

--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Vincent Torri]

On Tue, 15 Mar 2011, Enlightenment SVN wrote:

> Log:
> Efreet: Add some logging

why not using eina_log ?

Vincent

>
> Author:   englebass
> Date: 2011-03-15 10:07:19 -0700 (Tue, 15 Mar 2011)
> New Revision: 57769
> Trac: http://trac.enlightenment.org/e/changeset/57769
>
> Modified:
>  trunk/efreet/src/bin/efreet_icon_cache_create.c
>
> Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c
> ===
> --- trunk/efreet/src/bin/efreet_icon_cache_create.c   2011-03-15 16:57:16 UTC 
> (rev 57768)
> +++ trunk/efreet/src/bin/efreet_icon_cache_create.c   2011-03-15 17:07:19 UTC 
> (rev 57769)
> @@ -743,6 +743,7 @@
>
> icon_themes = 
> eina_hash_string_superfast_new(EINA_FREE_CB(icon_theme_free));
>
> +if (verbose) printf("opening theme cache\n");
> /* open theme file */
> theme_ef = eet_open(efreet_icon_theme_cache_file(), 
> EET_FILE_MODE_READ_WRITE);
> if (!theme_ef) goto on_error_efreet;
> @@ -778,6 +779,7 @@
> free(keys);
> }
>
> +if (verbose) printf("scan for themes\n");
> /* scan themes */
> cache_theme_scan(efreet_icon_deprecated_user_dir_get());
> cache_theme_scan(efreet_icon_user_dir_get());
> @@ -809,10 +811,12 @@
> #ifndef STRICT_SPEC
> if (!theme->theme.name.name) continue;
> #endif
> +if (verbose) printf("scan theme %s\n", theme->theme.name.name);
>
> changed = EINA_FALSE;
> themes = eina_hash_string_superfast_new(NULL);
>
> +if (verbose) printf("open icon file\n");
> /* open icon file */
> icon_ef = 
> eet_open(efreet_icon_cache_file(theme->theme.name.internal), 
> EET_FILE_MODE_READ_WRITE);
> if (!icon_ef) goto on_error_efreet;
> @@ -862,6 +866,7 @@
> if (!theme->dirs)
> theme->dirs = eina_hash_string_superfast_new(NULL);
>
> +if (verbose) printf("scan icons\n");
> if (cache_scan(&(theme->theme), themes, icons, theme->dirs, &changed))
> {
> if (verbose)
> @@ -901,6 +906,7 @@
>
> changed = EINA_FALSE;
>
> +if (verbose) printf("open fallback file\n");
> /* open icon file */
> icon_ef = eet_open(efreet_icon_cache_file(EFREET_CACHE_ICON_FALLBACK), 
> EET_FILE_MODE_READ_WRITE);
> if (!icon_ef) goto on_error_efreet;
> @@ -950,6 +956,7 @@
> if (!theme->dirs)
> theme->dirs = eina_hash_string_superfast_new(NULL);
>
> +if (verbose) printf("scan fallback icons\n");
> /* Save fallback in the right part */
> if (cache_fallback_scan(icons, theme->dirs, &changed))
> {
> @@ -997,6 +1004,7 @@
> }
> }
>
> +if (verbose) printf("done\n");
> on_error_efreet:
> efreet_shutdown();
>
>
>
> --
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

On 02/22/2011 08:45 PM, Sebastian Dransfeld wrote:
> On 02/22/2011 04:22 PM, Atton Jonathan wrote:
>> If the problem is in e why you don't fix e instead of revert a fix in efreet
>> ?
>
> E always wants to wait for desktop cache to be updated. So we always
> need to wait there. What we need to do is to differentiate between
> "cache build done and change", and "cache build done and no change".
> Needs a bit more work.
>
> So it is better to let things work as it is now, instead of breaking E.
>
> S.

What a crappy reply. E hasn't a problem, it works as it should. Efreet 
needs a better fix.

S.

>
>>
>>
>> 2011/2/22 Enlightenment SVN
>>
>>> Log:
>>> Efreet: Reset changed before scanning fallback
>>>
>>>Changed must be EINA_FALSE before scanning fallback to not create false
>>>positive.
>>>
>>> Author:   englebass
>>> Date: 2011-02-22 04:52:58 -0800 (Tue, 22 Feb 2011)
>>> New Revision: 57240
>>> Trac: http://trac.enlightenment.org/e/changeset/57240
>>>
>>> Modified:
>>>trunk/efreet/src/bin/efreet_icon_cache_create.c
>>>
>>> Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c
>>> ===
>>> --- trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:46
>>> UTC (rev 57239)
>>> +++ trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:58
>>> UTC (rev 57240)
>>> @@ -897,6 +897,8 @@
>>>   }
>>>   eina_iterator_free(it);
>>>
>>> +changed = EINA_FALSE;
>>> +
>>>   /* open icon file */
>>>   icon_ef = eet_open(efreet_icon_cache_file(EFREET_CACHE_ICON_FALLBACK),
>>> EET_FILE_MODE_READ_WRITE);
>>>   if (!icon_ef) goto on_error_efreet;
>>>
>>>
>>>
>>> --
>>> Index, Search&   Analyze Logs and other IT data in Real-Time with Splunk
>>> Collect, index and harness all the fast moving IT data generated by your
>>> applications, servers and devices whether physical, virtual or in the
>>> cloud.
>>> Deliver compliance at lower cost and gain new business insights.
>>> Free Software Download: http://p.sf.net/sfu/splunk-dev2dev
>>> ___
>>> enlightenment-svn mailing list
>>> enlightenment-...@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>>>
>>
>>
>>
>
>
> --
> Free Software Download: Index, Search&  Analyze Logs and other IT data in
> Real-Time with Splunk. Collect, index and harness all the fast moving IT data
> generated by your applications, servers and devices whether physical, virtual
> or in the cloud. Deliver compliance at lower cost and gain new business
> insights. http://p.sf.net/sfu/splunk-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

On 02/22/2011 04:22 PM, Atton Jonathan wrote:
> If the problem is in e why you don't fix e instead of revert a fix in efreet
> ?

E always wants to wait for desktop cache to be updated. So we always 
need to wait there. What we need to do is to differentiate between 
"cache build done and change", and "cache build done and no change". 
Needs a bit more work.

So it is better to let things work as it is now, instead of breaking E.

S.

>
>
> 2011/2/22 Enlightenment SVN
>
>> Log:
>> Efreet: Reset changed before scanning fallback
>>
>>   Changed must be EINA_FALSE before scanning fallback to not create false
>>   positive.
>>
>> Author:   englebass
>> Date: 2011-02-22 04:52:58 -0800 (Tue, 22 Feb 2011)
>> New Revision: 57240
>> Trac: http://trac.enlightenment.org/e/changeset/57240
>>
>> Modified:
>>   trunk/efreet/src/bin/efreet_icon_cache_create.c
>>
>> Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c
>> ===
>> --- trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:46
>> UTC (rev 57239)
>> +++ trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:58
>> UTC (rev 57240)
>> @@ -897,6 +897,8 @@
>>  }
>>  eina_iterator_free(it);
>>
>> +changed = EINA_FALSE;
>> +
>>  /* open icon file */
>>  icon_ef = eet_open(efreet_icon_cache_file(EFREET_CACHE_ICON_FALLBACK),
>> EET_FILE_MODE_READ_WRITE);
>>  if (!icon_ef) goto on_error_efreet;
>>
>>
>>
>> --
>> Index, Search&  Analyze Logs and other IT data in Real-Time with Splunk
>> Collect, index and harness all the fast moving IT data generated by your
>> applications, servers and devices whether physical, virtual or in the
>> cloud.
>> Deliver compliance at lower cost and gain new business insights.
>> Free Software Download: http://p.sf.net/sfu/splunk-dev2dev
>> ___
>> enlightenment-svn mailing list
>> enlightenment-...@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>>
>
>
>


--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Atton Jonathan]

If the problem is in e why you don't fix e instead of revert a fix in efreet
?


2011/2/22 Enlightenment SVN 

> Log:
> Efreet: Reset changed before scanning fallback
>
>  Changed must be EINA_FALSE before scanning fallback to not create false
>  positive.
>
> Author:   englebass
> Date: 2011-02-22 04:52:58 -0800 (Tue, 22 Feb 2011)
> New Revision: 57240
> Trac: http://trac.enlightenment.org/e/changeset/57240
>
> Modified:
>  trunk/efreet/src/bin/efreet_icon_cache_create.c
>
> Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c
> ===
> --- trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:46
> UTC (rev 57239)
> +++ trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:58
> UTC (rev 57240)
> @@ -897,6 +897,8 @@
> }
> eina_iterator_free(it);
>
> +changed = EINA_FALSE;
> +
> /* open icon file */
> icon_ef = eet_open(efreet_icon_cache_file(EFREET_CACHE_ICON_FALLBACK),
> EET_FILE_MODE_READ_WRITE);
> if (!icon_ef) goto on_error_efreet;
>
>
>
> --
> Index, Search & Analyze Logs and other IT data in Real-Time with Splunk
> Collect, index and harness all the fast moving IT data generated by your
> applications, servers and devices whether physical, virtual or in the
> cloud.
> Deliver compliance at lower cost and gain new business insights.
> Free Software Download: http://p.sf.net/sfu/splunk-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>



-- 
Regards.
--
Index, Search & Analyze Logs and other IT data in Real-Time with Splunk 
Collect, index and harness all the fast moving IT data generated by your 
applications, servers and devices whether physical, virtual or in the cloud.
Deliver compliance at lower cost and gain new business insights. 
Free Software Download: http://p.sf.net/sfu/splunk-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

On 02/19/2011 10:01 PM, Vincent Torri wrote:
>
>
> On Sat, 19 Feb 2011, Enlightenment SVN wrote:
>
>> Log:
>> Only print if verbose and TODO++
>
> why using fprintf(stder ***) and not eina_log ?

Ask cedric, he wrote it.

A lot of other printf's are older than eina, and I haven't bothered 
fixing them. And with the current TODO list, using eina_log isn't high 
on the list.

S.

--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Vincent Torri]

On Sat, 19 Feb 2011, Enlightenment SVN wrote:

> Log:
> Only print if verbose and TODO++

why using fprintf(stder ***) and not eina_log ?

Vincent

>
> Author:   englebass
> Date: 2011-02-19 12:54:03 -0800 (Sat, 19 Feb 2011)
> New Revision: 57175
> Trac: http://trac.enlightenment.org/e/changeset/57175
>
> Modified:
>  trunk/efreet/src/bin/efreet_icon_cache_create.c
>
> Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c
> ===
> --- trunk/efreet/src/bin/efreet_icon_cache_create.c   2011-02-19 20:53:16 UTC 
> (rev 57174)
> +++ trunk/efreet/src/bin/efreet_icon_cache_create.c   2011-02-19 20:54:03 UTC 
> (rev 57175)
> @@ -26,6 +26,8 @@
>  * - Need to cache all exts searched and extra_dirs, so we know if we
>  *   need to rescan dirs. Then re-enable cache_directory_find().
>  * - Need to check if files has disappeared, as we only add new.
> + * - Base dir is touched on icon theme update, no need to scan all.
> + * - There is something weird going on with inheritance when adding 
> extensions
>  */
>
> static Eina_Array *exts = NULL;
> @@ -303,8 +305,9 @@
> Efreet_Icon_Theme *inherit;
>
> inherit = eina_hash_find(icon_themes, name);
> -if (!inherit) fprintf(stderr, "Theme `%s` not found for `%s`.\n",
> -  name, theme->name.internal);
> +if (!inherit && verbose)
> +fprintf(stderr, "Theme `%s` not found for `%s`.\n",
> +name, theme->name.internal);
> if (!cache_scan(inherit, themes, icons, dirs, changed)) return 
> EINA_FALSE;
> }
> }
> @@ -333,8 +336,9 @@
> Efreet_Cache_Icon_Theme *inherit;
>
> inherit = eina_hash_find(icon_themes, name);
> -if (!inherit) fprintf(stderr, "Theme `%s` not found for `%s`.\n",
> -  name, theme->theme.name.internal);
> +if (!inherit && verbose)
> +fprintf(stderr, "Theme `%s` not found for `%s`.\n",
> +name, theme->theme.name.internal);
> if (check_changed(inherit)) return EINA_TRUE;
> }
> }
> @@ -858,10 +862,11 @@
>
> if (cache_scan(&(theme->theme), themes, icons, theme->dirs, &changed))
> {
> -fprintf(stderr, "generated: '%s' %i (%i)\n",
> -theme->theme.name.internal,
> -changed,
> -eina_hash_population(icons));
> +if (verbose)
> +fprintf(stderr, "generated: '%s' %i (%i)\n",
> +theme->theme.name.internal,
> +changed,
> +eina_hash_population(icons));
> if (changed)
> {
> Eina_Iterator *icons_it;
> @@ -879,7 +884,7 @@
>
> if (theme->changed || changed)
> {
> -if (theme->changed)
> +if (theme->changed && verbose)
> fprintf(stderr, "theme change: %s %lld\n", 
> theme->theme.name.internal, theme->last_cache_check);
> eet_data_write(theme_ef, theme_edd, theme->theme.name.internal, 
> theme, 1);
> }
> @@ -944,7 +949,8 @@
> /* Save fallback in the right part */
> if (cache_fallback_scan(icons, theme->dirs, &changed))
> {
> -fprintf(stderr, "generated: fallback %i (%i)\n", changed, 
> eina_hash_population(icons));
> +if (verbose)
> +fprintf(stderr, "generated: fallback %i (%i)\n", changed, 
> eina_hash_population(icons));
> if (changed)
> {
> Eina_Iterator *icons_it;
>
>
> --
> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
> Pinpoint memory and threading errors before they happen.
> Find and fix more than 250 security defects in the development cycle.
> Locate bottlenecks in serial and parallel code that limit performance.
> http://p.sf.net/sfu/intel-dev2devfeb
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

Vincent Torri h:
> 
> On Sun, 28 Mar 2010, Enlightenment SVN wrote:
> 
>> Log:
>>  efreet: Only read data from disk when modified
> 
> what about using file monitoring for that ?

Well, we need to build the complete cache every time the bin is 
executed. So we need all information, the patch just makes the new cache 
reuse the old cached values instead of reading all info from disk every 
time.

The reason the complete cache must be rebuilt every time is that it is 
shared between all programs which uses efreet, so we can't rewrite the 
cache. We need to write a new temp cache, delete the old and rename the 
temp cache.

And there is still a lot of TODO's, so just wait or help fix them :)

S.

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Vincent Torri]

On Sun, 28 Mar 2010, Enlightenment SVN wrote:

> Log:
>  efreet: Only read data from disk when modified

what about using file monitoring for that ?

Vincent

> Author:   englebass
> Date: 2010-03-28 12:31:37 -0700 (Sun, 28 Mar 2010)
> New Revision: 47539
>
> Modified:
>  trunk/efreet/src/bin/efreet_desktop_cache_create.c
>
> Modified: trunk/efreet/src/bin/efreet_desktop_cache_create.c
> ===
> --- trunk/efreet/src/bin/efreet_desktop_cache_create.c2010-03-28 
> 19:31:26 UTC (rev 47538)
> +++ trunk/efreet/src/bin/efreet_desktop_cache_create.c2010-03-28 
> 19:31:37 UTC (rev 47539)
> @@ -37,15 +37,18 @@
> {
> Efreet_Desktop *desk;
> char *ext;
> +long long mtime;
>
> ext = strrchr(path, '.');
> if (!ext || (strcmp(ext, ".desktop") && strcmp(ext, ".directory"))) 
> return 1;
> -/*
> - * TODO:
> - * Get cached version first and check mtime. Only get uncached if we need
> - * to update.
> - */
> -desk = efreet_desktop_uncached_new(path);
> +desk = efreet_desktop_get(path);
> +if (!desk) return 1;
> +mtime = ecore_file_mod_time(path);
> +if (mtime != desk->load_time)
> +{
> +efreet_desktop_free(desk);
> +desk = efreet_desktop_uncached_new(path);
> +}
>
> if (!desk || (desk->type != EFREET_DESKTOP_TYPE_APPLICATION &&
>   desk->type != EFREET_DESKTOP_TYPE_DIRECTORY))
>
>
> --
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Gustavo Sverzut Barbieri]

On Thu, Mar 11, 2010 at 3:33 PM, Sebastian Dransfeld
 wrote:
>>>  static int
>>> +strcmplen(const void *data1, const void *data2)
>>> +{
>>> +    return strncmp(data1, data2, strlen(data2));
>>> +}
>>
>> If you used stringshare, you could use much faster eina_stringshare_len() 
>> here.
>
> Well, since one of the parameters isn't stringshared, it can't be done.

You can/should have all parameters stringshared. If you can
stringshare add, then query, then unref if required.


>>> +            unsigned int size = *(unsigned int *)p;
>>> +            p += sizeof(unsigned int);
>>> +            user_dirs = eina_list_append(user_dirs, strdup(p));
>>
>> by using eina_stringshare_add_length() here, you could avoid implicit
>> strlen() inside strdup(), and also get the length for almost 0 cost at
>> strcmplen...
>
> Same problem as above.
>
>>
>>
>>> +        if (ftruncate(dirsfd, 0) < 0) goto error;
>>
>> I'd not truncate it, never... truncation is basically useless, and
>> dangerous for mmaped resources.
>>
>
> It is unmapped before the truncate. And how to I clear the content of a
> file without truncate?

unlink()? :-)


-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

>>  static int
>> +strcmplen(const void *data1, const void *data2)
>> +{
>> +return strncmp(data1, data2, strlen(data2));
>> +}
> 
> If you used stringshare, you could use much faster eina_stringshare_len() 
> here.

Well, since one of the parameters isn't stringshared, it can't be done.

> 
>> +unsigned int size = *(unsigned int *)p;
>> +p += sizeof(unsigned int);
>> +user_dirs = eina_list_append(user_dirs, strdup(p));
> 
> by using eina_stringshare_add_length() here, you could avoid implicit
> strlen() inside strdup(), and also get the length for almost 0 cost at
> strcmplen...

Same problem as above.

> 
> 
>> +if (ftruncate(dirsfd, 0) < 0) goto error;
> 
> I'd not truncate it, never... truncation is basically useless, and
> dangerous for mmaped resources.
> 

It is unmapped before the truncate. And how to I clear the content of a 
file without truncate?

Sebastian

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Gustavo Sverzut Barbieri]

On Wed, Mar 10, 2010 at 6:33 PM, Enlightenment SVN
 wrote:
> Log:
>  read user dir cache
> Author:       englebass
> Date:         2010-03-10 13:33:43 -0800 (Wed, 10 Mar 2010)
> New Revision: 47120
>
> Modified:
>  trunk/efreet/src/bin/efreet_desktop_cache_create.c
>
> Modified: trunk/efreet/src/bin/efreet_desktop_cache_create.c
> ===
> --- trunk/efreet/src/bin/efreet_desktop_cache_create.c  2010-03-10 20:57:06 
> UTC (rev 47119)
> +++ trunk/efreet/src/bin/efreet_desktop_cache_create.c  2010-03-10 21:33:43 
> UTC (rev 47120)
> @@ -8,6 +8,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -26,6 +27,12 @@
>  static Eina_Hash *paths = NULL;
>
>  static int
> +strcmplen(const void *data1, const void *data2)
> +{
> +    return strncmp(data1, data2, strlen(data2));
> +}

If you used stringshare, you could use much faster eina_stringshare_len() here.

> +            unsigned int size = *(unsigned int *)p;
> +            p += sizeof(unsigned int);
> +            user_dirs = eina_list_append(user_dirs, strdup(p));

by using eina_stringshare_add_length() here, you could avoid implicit
strlen() inside strdup(), and also get the length for almost 0 cost at
strcmplen...


> +        if (ftruncate(dirsfd, 0) < 0) goto error;

I'd not truncate it, never... truncation is basically useless, and
dangerous for mmaped resources.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[The Rasterman]

On Tue, 02 Mar 2010 10:09:30 +0100 Sebastian Dransfeld
 said:

> Gustavo Sverzut Barbieri wrote:
> > On Mon, Mar 1, 2010 at 3:42 PM, Enlightenment SVN
> >  wrote:
> >> Log:
> >>  truncate old cache so we don't read cached values
> >> Author:   englebass
> >> Date: 2010-03-01 10:42:24 -0800 (Mon, 01 Mar 2010)
> >> New Revision: 46727
> >>
> >> Modified:
> >>  trunk/efreet/src/bin/efreet_desktop_cache_create.c
> >>
> >> Modified: trunk/efreet/src/bin/efreet_desktop_cache_create.c
> >> ===
> >> --- trunk/efreet/src/bin/efreet_desktop_cache_create.c  2010-03-01
> >> 18:16:32 UTC (rev 46726) +++
> >> trunk/efreet/src/bin/efreet_desktop_cache_create.c  2010-03-01 18:42:24
> >> UTC (rev 46727) @@ -191,6 +191,10 @@ goto efreet_error;
> >> }
> >>
> >> +/* truncate old cache so that we don't read cached values */
> >> +if (truncate(efreet_desktop_cache_file(), 0) < 0) goto efreet_error;
> >> +if (truncate(efreet_util_cache_file(), 0) < 0) goto efreet_error;
> > 
> > are you sure?! truncate will cause SIGBUS on the mmap()ed processes :-/
> > 
> 
> Not sure at all. Will fix.
cache should be a new file existing apps are not using yet - then renamed()
across when ready. existing one people have mmaped should just be mmaped and
never changed until a new one is prepared... :)

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Sebastian Dransfeld]

Gustavo Sverzut Barbieri wrote:
> On Mon, Mar 1, 2010 at 3:42 PM, Enlightenment SVN
>  wrote:
>> Log:
>>  truncate old cache so we don't read cached values
>> Author:   englebass
>> Date: 2010-03-01 10:42:24 -0800 (Mon, 01 Mar 2010)
>> New Revision: 46727
>>
>> Modified:
>>  trunk/efreet/src/bin/efreet_desktop_cache_create.c
>>
>> Modified: trunk/efreet/src/bin/efreet_desktop_cache_create.c
>> ===
>> --- trunk/efreet/src/bin/efreet_desktop_cache_create.c  2010-03-01 18:16:32 
>> UTC (rev 46726)
>> +++ trunk/efreet/src/bin/efreet_desktop_cache_create.c  2010-03-01 18:42:24 
>> UTC (rev 46727)
>> @@ -191,6 +191,10 @@
>> goto efreet_error;
>> }
>>
>> +/* truncate old cache so that we don't read cached values */
>> +if (truncate(efreet_desktop_cache_file(), 0) < 0) goto efreet_error;
>> +if (truncate(efreet_util_cache_file(), 0) < 0) goto efreet_error;
> 
> are you sure?! truncate will cause SIGBUS on the mmap()ed processes :-/
> 

Not sure at all. Will fix.

Sebastian

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

[Gustavo Sverzut Barbieri]

On Mon, Mar 1, 2010 at 3:42 PM, Enlightenment SVN
 wrote:
> Log:
>  truncate old cache so we don't read cached values
> Author:       englebass
> Date:         2010-03-01 10:42:24 -0800 (Mon, 01 Mar 2010)
> New Revision: 46727
>
> Modified:
>  trunk/efreet/src/bin/efreet_desktop_cache_create.c
>
> Modified: trunk/efreet/src/bin/efreet_desktop_cache_create.c
> ===
> --- trunk/efreet/src/bin/efreet_desktop_cache_create.c  2010-03-01 18:16:32 
> UTC (rev 46726)
> +++ trunk/efreet/src/bin/efreet_desktop_cache_create.c  2010-03-01 18:42:24 
> UTC (rev 46727)
> @@ -191,6 +191,10 @@
>         goto efreet_error;
>     }
>
> +    /* truncate old cache so that we don't read cached values */
> +    if (truncate(efreet_desktop_cache_file(), 0) < 0) goto efreet_error;
> +    if (truncate(efreet_util_cache_file(), 0) < 0) goto efreet_error;

are you sure?! truncate will cause SIGBUS on the mmap()ed processes :-/

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel