Re: [E-devel] E SVN: tasn IN trunk/efl: . cmakeconfig

2013-02-07 Thread thomasg 
On Wed, Feb 6, 2013 at 11:14 AM, Tom Hacohen tom.haco...@samsung.com wrote:
 On 05/02/13 20:56, thomasg wrote:

 On Tue, Feb 5, 2013 at 5:19 PM, Enlightenment SVN
 no-re...@enlightenment.org wrote:

 Log:
 Efl: Ship cmake configs (like pkg-config).

This should make it easier for applications to use efl with cmake.
It seems to work with my tests. It's ugly and redundant but it's the
 first
step. Not all the components are supported at the moment.

 Author:   tasn
 Date: 2013-02-05 08:19:37 -0800 (Tue, 05 Feb 2013)
 New Revision: 83637
 Trac: http://trac.enlightenment.org/e/changeset/83637


 Hi Tom,

 may I ask what the point of this is?
 Cmake has pkgconfig-support via FindPkgConfig, and it works fine for me.
 Also it seems to be simpler to use than this, e.g.:
 INCLUDE(FindPkgConfig)
 pkg_check_modules(EINA REQUIRED eina)
 include_directories(${EINA_INCLUDE_DIRS}


 Yes. As I've said, at the moment it's quite horrible and uses pkg config, in
 the future it may not.

 Using cmake config files is cleaner for cmake users and also will be
 available on platforms that don't have pkg-config (once I fix it
 internally). At the moment it's just a convenience that saves unneeded
 duplication.

 I don't quite understand what you meant by: Also it seems to be simpler to
 use than this, 

 --
 Tom.


This wasn't meant as an offense, I was just familiar with your
previous work and all the FindE*.cmake files that seemed necessary,
and was wondering why the complexity was needed.
I can see now, that you really overhauled all this and now the cmake
files are not copy'n'pasted per project but shipped by the upstream
library instead, and that this fully replaces pkg-config, thus my
criticism isn't valid anymore.

Thanks,
--
thomasg

--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: tasn IN trunk/efl: . cmakeconfig

2013-02-07 Thread Tom Hacohen 
No worries. :)

Yeah, what I did before was quite horrible, but I was just playing around
so I wanted it contained. Now I'm playing around a bit more and would like
people to possibly start using them as well. :)

--
Tom.


On Thu, Feb 7, 2013 at 7:25 PM, thomasg tho...@gstaedtner.net wrote:

 On Wed, Feb 6, 2013 at 11:14 AM, Tom Hacohen tom.haco...@samsung.com
 wrote:
  On 05/02/13 20:56, thomasg wrote:
 
  On Tue, Feb 5, 2013 at 5:19 PM, Enlightenment SVN
  no-re...@enlightenment.org wrote:
 
  Log:
  Efl: Ship cmake configs (like pkg-config).
 
 This should make it easier for applications to use efl with cmake.
 It seems to work with my tests. It's ugly and redundant but it's the
  first
 step. Not all the components are supported at the moment.
 
  Author:   tasn
  Date: 2013-02-05 08:19:37 -0800 (Tue, 05 Feb 2013)
  New Revision: 83637
  Trac: http://trac.enlightenment.org/e/changeset/83637
 
 
  Hi Tom,
 
  may I ask what the point of this is?
  Cmake has pkgconfig-support via FindPkgConfig, and it works fine for me.
  Also it seems to be simpler to use than this, e.g.:
  INCLUDE(FindPkgConfig)
  pkg_check_modules(EINA REQUIRED eina)
  include_directories(${EINA_INCLUDE_DIRS}
 
 
  Yes. As I've said, at the moment it's quite horrible and uses pkg
 config, in
  the future it may not.
 
  Using cmake config files is cleaner for cmake users and also will be
  available on platforms that don't have pkg-config (once I fix it
  internally). At the moment it's just a convenience that saves unneeded
  duplication.
 
  I don't quite understand what you meant by: Also it seems to be simpler
 to
  use than this, 
 
  --
  Tom.
 

 This wasn't meant as an offense, I was just familiar with your
 previous work and all the FindE*.cmake files that seemed necessary,
 and was wondering why the complexity was needed.
 I can see now, that you really overhauled all this and now the cmake
 files are not copy'n'pasted per project but shipped by the upstream
 library instead, and that this fully replaces pkg-config, thus my
 criticism isn't valid anymore.

 Thanks,
 --
 thomasg


 --
 Free Next-Gen Firewall Hardware Offer
 Buy your Sophos next-gen firewall before the end March 2013
 and get the hardware for free! Learn more.
 http://p.sf.net/sfu/sophos-d2d-feb
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel




-- 
Tom.
--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: tasn IN trunk/efl: . cmakeconfig

2013-02-06 Thread Tom Hacohen 
On 05/02/13 20:56, thomasg wrote:
 On Tue, Feb 5, 2013 at 5:19 PM, Enlightenment SVN
 no-re...@enlightenment.org wrote:
 Log:
 Efl: Ship cmake configs (like pkg-config).

This should make it easier for applications to use efl with cmake.
It seems to work with my tests. It's ugly and redundant but it's the first
step. Not all the components are supported at the moment.

 Author:   tasn
 Date: 2013-02-05 08:19:37 -0800 (Tue, 05 Feb 2013)
 New Revision: 83637
 Trac: http://trac.enlightenment.org/e/changeset/83637


 Hi Tom,

 may I ask what the point of this is?
 Cmake has pkgconfig-support via FindPkgConfig, and it works fine for me.
 Also it seems to be simpler to use than this, e.g.:
 INCLUDE(FindPkgConfig)
 pkg_check_modules(EINA REQUIRED eina)
 include_directories(${EINA_INCLUDE_DIRS}


Yes. As I've said, at the moment it's quite horrible and uses pkg 
config, in the future it may not.

Using cmake config files is cleaner for cmake users and also will be 
available on platforms that don't have pkg-config (once I fix it 
internally). At the moment it's just a convenience that saves unneeded 
duplication.

I don't quite understand what you meant by: Also it seems to be simpler 
to use than this, 

--
Tom.


--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: tasn IN trunk/efl: . cmakeconfig

2013-02-05 Thread thomasg 
On Tue, Feb 5, 2013 at 5:19 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
 Log:
 Efl: Ship cmake configs (like pkg-config).

   This should make it easier for applications to use efl with cmake.
   It seems to work with my tests. It's ugly and redundant but it's the first
   step. Not all the components are supported at the moment.

 Author:   tasn
 Date: 2013-02-05 08:19:37 -0800 (Tue, 05 Feb 2013)
 New Revision: 83637
 Trac: http://trac.enlightenment.org/e/changeset/83637


Hi Tom,

may I ask what the point of this is?
Cmake has pkgconfig-support via FindPkgConfig, and it works fine for me.
Also it seems to be simpler to use than this, e.g.:
INCLUDE(FindPkgConfig)
pkg_check_modules(EINA REQUIRED eina)
include_directories(${EINA_INCLUDE_DIRS}

Regards,
--
thomasg

--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel