Re: [E-devel] Patch valgrind deprecated macro

2008-05-18 Thread The Rasterman
On Sun, 27 Apr 2008 14:18:24 +0200 Charles Clément [EMAIL PROTECTED] babbled:

hooray! new macros. ok - i did it in a more robust way - but adapted to new
macros if they exist :)

 Hello,
 
 When compiling ecore on a system that has valgrind installed it failed
 because of a deprecated macro call: VALGRIND_MAKE_READABLE in the evas
 library.
 
 In the NEWS file distributed with valgrind, in the changes for the 3.2.0
 version is stated:
 - There are some changes to Memcheck's client requests.  Some of them
   have changed names:
 
   MAKE_NOACCESS  -- MAKE_MEM_NOACCESS
   MAKE_WRITABLE  -- MAKE_MEM_UNDEFINED
   MAKE_READABLE  -- MAKE_MEM_DEFINED
 
   CHECK_WRITABLE -- CHECK_MEM_IS_ADDRESSABLE
   CHECK_READABLE -- CHECK_MEM_IS_DEFINED
   CHECK_DEFINED  -- CHECK_VALUE_IS_DEFINED
 
 These deprecated calls have been removed in the
 Release 3.3.0 (7 December 2007)
 
 A patch follows.
 -- 
 Charles Clément.
 
 Index: evas/src/lib/engines/common/evas_image_main.c
 ===
 --- evas.orig/src/lib/engines/common/evas_image_main.c
 +++ evas/src/lib/engines/common/evas_image_main.c
 @@ -157,7 +157,7 @@ _evas_common_rgba_image_surface_alloc(Im
 if (im-image.data == NULL) return -1;
  
  #ifdef HAVE_VALGRIND
 -   VALGRIND_MAKE_READABLE(im-image.data, siz);
 +   VALGRIND_MAKE_MEM_DEFINED(im-image.data, siz);
  #endif
  
 return 0;
 
 -
 This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
 Don't miss this year's exciting event. There's still time to save $100. 
 Use priority code J8TL2D2. 
 http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 


-- 
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)[EMAIL PROTECTED]


-
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] Patch valgrind deprecated macro

2008-04-27 Thread Charles Clément
Hello,

When compiling ecore on a system that has valgrind installed it failed
because of a deprecated macro call: VALGRIND_MAKE_READABLE in the evas
library.

In the NEWS file distributed with valgrind, in the changes for the 3.2.0
version is stated:
- There are some changes to Memcheck's client requests.  Some of them
  have changed names:

  MAKE_NOACCESS  -- MAKE_MEM_NOACCESS
  MAKE_WRITABLE  -- MAKE_MEM_UNDEFINED
  MAKE_READABLE  -- MAKE_MEM_DEFINED

  CHECK_WRITABLE -- CHECK_MEM_IS_ADDRESSABLE
  CHECK_READABLE -- CHECK_MEM_IS_DEFINED
  CHECK_DEFINED  -- CHECK_VALUE_IS_DEFINED

These deprecated calls have been removed in the
Release 3.3.0 (7 December 2007)

A patch follows.
-- 
Charles Clément.

Index: evas/src/lib/engines/common/evas_image_main.c
===
--- evas.orig/src/lib/engines/common/evas_image_main.c
+++ evas/src/lib/engines/common/evas_image_main.c
@@ -157,7 +157,7 @@ _evas_common_rgba_image_surface_alloc(Im
if (im-image.data == NULL) return -1;
 
 #ifdef HAVE_VALGRIND
-   VALGRIND_MAKE_READABLE(im-image.data, siz);
+   VALGRIND_MAKE_MEM_DEFINED(im-image.data, siz);
 #endif
 
return 0;

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel