Re: [E-devel] Phabricator auto-closes tickets from non-master branches

2015-08-20 Thread Tom Hacohen
On 20/08/15 09:34, Tom Hacohen wrote:
 On 20/08/15 06:59, Daniel Hirt wrote:
 Hey all,

 Yesterday I had a little mishap with a phabricator ticket: it seems that
 pushing fixes to branches (e.g. devs/herdsman/my_branch) is triggering
 an auto-close to the ticket that's referenced there (e.g. Fixes
 T1234). I expect that it should do that only if I push to master.
 Can someone look into the auto-close configuration and see if this can
 be avoided?

 I couldn't find anything at the time.

It's there, and it even supports regex! Will add a new rule now.

--
Tom.


--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] Phabricator auto-closes tickets from non-master branches

2015-08-20 Thread Daniel Hirt
Hey all,

Yesterday I had a little mishap with a phabricator ticket: it seems that
pushing fixes to branches (e.g. devs/herdsman/my_branch) is triggering
an auto-close to the ticket that's referenced there (e.g. Fixes
T1234). I expect that it should do that only if I push to master.
Can someone look into the auto-close configuration and see if this can
be avoided?

Thanks in advance.

  Danny (herdsman)

--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Phabricator auto-closes tickets from non-master branches

2015-08-20 Thread Daniel Hirt
On 08/20/2015 11:44 AM, Tom Hacohen wrote:
 On 20/08/15 09:34, Tom Hacohen wrote:
 On 20/08/15 06:59, Daniel Hirt wrote:
 Hey all,

 Yesterday I had a little mishap with a phabricator ticket: it seems that
 pushing fixes to branches (e.g. devs/herdsman/my_branch) is triggering
 an auto-close to the ticket that's referenced there (e.g. Fixes
 T1234). I expect that it should do that only if I push to master.
 Can someone look into the auto-close configuration and see if this can
 be avoided?

 I couldn't find anything at the time.
 
 It's there, and it even supports regex! Will add a new rule now.

Awesome!
Thanks for addressing this (and very quickly!)


--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Phabricator auto-closes tickets from non-master branches

2015-08-20 Thread Tom Hacohen
On 20/08/15 06:59, Daniel Hirt wrote:
 Hey all,

 Yesterday I had a little mishap with a phabricator ticket: it seems that
 pushing fixes to branches (e.g. devs/herdsman/my_branch) is triggering
 an auto-close to the ticket that's referenced there (e.g. Fixes
 T1234). I expect that it should do that only if I push to master.
 Can someone look into the auto-close configuration and see if this can
 be avoided?

I couldn't find anything at the time.

--
Tom.


--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel