Re: [E-devel] [EGIT] [core/efl] master 01/01: elementary: atspi accepts UTF-8 text

[Kim Shinwoo]

Hello.
The plain_text returned by evas_textblock_text_markup_to_utf8 was not used
yet all. Issue is that...
If an widget has name "on", then the plain_text will be "on". That is
one of problem.

Sincerely,
Shinwoo Kim

2016. 12. 8. 오후 11:27에 "Tom Hacohen" 님이 작성:

Based on your commit message, your change looks wrong. Atspi accepts
utf-8 not markup, it should be passed utf-8 without the markup.

I think the code that was there was correct, but furthermore, this code
was just recently put there to fix an issue, so please speak to whoever
added it.

Also, please elaborate more in the commit message, it's lacking.

Thanks!

--
Tom

On 08/12/16 14:22, Shinwoo Kim wrote:
> kimcinoo pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=
4a8d37195f19c8435c33721fb3fd994783b6a351
>
> commit 4a8d37195f19c8435c33721fb3fd994783b6a351
> Author: Shinwoo Kim 
> Date:   Thu Dec 8 23:21:35 2016 +0900
>
> elementary: atspi accepts UTF-8 text
> ---
>  src/lib/elementary/elm_atspi_bridge.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/lib/elementary/elm_atspi_bridge.c
b/src/lib/elementary/elm_atspi_bridge.c
> index 237b47c..7d004cd 100644
> --- a/src/lib/elementary/elm_atspi_bridge.c
> +++ b/src/lib/elementary/elm_atspi_bridge.c
> @@ -2078,9 +2078,7 @@ _accessible_property_get(const
Eldbus_Service_Interface *interface, const char *
>  ret = elm_interface_atspi_accessible_name_get(obj);
>  if (!ret)
>ret = "";
> -char *plain_text = evas_textblock_text_markup_to_utf8(NULL, ret);
>  eldbus_message_iter_basic_append(iter, 's', ret);
> -free(plain_text);
>  return EINA_TRUE;
>   }
> else if (!strcmp(property, "Description"))
>



--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: elementary: atspi accepts UTF-8 text

[Tom Hacohen]

Based on your commit message, your change looks wrong. Atspi accepts 
utf-8 not markup, it should be passed utf-8 without the markup.

I think the code that was there was correct, but furthermore, this code 
was just recently put there to fix an issue, so please speak to whoever 
added it.

Also, please elaborate more in the commit message, it's lacking.

Thanks!

--
Tom

On 08/12/16 14:22, Shinwoo Kim wrote:
> kimcinoo pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=4a8d37195f19c8435c33721fb3fd994783b6a351
>
> commit 4a8d37195f19c8435c33721fb3fd994783b6a351
> Author: Shinwoo Kim 
> Date:   Thu Dec 8 23:21:35 2016 +0900
>
> elementary: atspi accepts UTF-8 text
> ---
>  src/lib/elementary/elm_atspi_bridge.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/lib/elementary/elm_atspi_bridge.c 
> b/src/lib/elementary/elm_atspi_bridge.c
> index 237b47c..7d004cd 100644
> --- a/src/lib/elementary/elm_atspi_bridge.c
> +++ b/src/lib/elementary/elm_atspi_bridge.c
> @@ -2078,9 +2078,7 @@ _accessible_property_get(const Eldbus_Service_Interface 
> *interface, const char *
>  ret = elm_interface_atspi_accessible_name_get(obj);
>  if (!ret)
>ret = "";
> -char *plain_text = evas_textblock_text_markup_to_utf8(NULL, ret);
>  eldbus_message_iter_basic_append(iter, 's', ret);
> -free(plain_text);
>  return EINA_TRUE;
>   }
> else if (!strcmp(property, "Description"))
>


--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: elementary: atspi accepts UTF-8 text

[Shinwoo Kim]

kimcinoo pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=4a8d37195f19c8435c33721fb3fd994783b6a351

commit 4a8d37195f19c8435c33721fb3fd994783b6a351
Author: Shinwoo Kim 
Date:   Thu Dec 8 23:21:35 2016 +0900

elementary: atspi accepts UTF-8 text
---
 src/lib/elementary/elm_atspi_bridge.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/lib/elementary/elm_atspi_bridge.c 
b/src/lib/elementary/elm_atspi_bridge.c
index 237b47c..7d004cd 100644
--- a/src/lib/elementary/elm_atspi_bridge.c
+++ b/src/lib/elementary/elm_atspi_bridge.c
@@ -2078,9 +2078,7 @@ _accessible_property_get(const Eldbus_Service_Interface 
*interface, const char *
 ret = elm_interface_atspi_accessible_name_get(obj);
 if (!ret)
   ret = "";
-char *plain_text = evas_textblock_text_markup_to_utf8(NULL, ret);
 eldbus_message_iter_basic_append(iter, 's', ret);
-free(plain_text);
 return EINA_TRUE;
  }
else if (!strcmp(property, "Description"))

--