[EGIT] [core/efl] master 02/04: edje: svg_loader: make sure we check the return from all _parser_number calls

[Stefan Schmidt]

stefan pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=6cf11650c451a93fd6fbd8c3424d2f724791109d

commit 6cf11650c451a93fd6fbd8c3424d2f724791109d
Author: Stefan Schmidt <ste...@osg.samsung.com>
Date:   Mon Dec 5 16:30:22 2016 +0100

    edje: svg_loader: make sure we check the return from all _parser_number 
calls
    
    Instead of nesting this make a bit more sense (at least to me). Also return 
in
    case one of these is not a number.
    
    CID: 1356610
---
 src/bin/edje/edje_svg_loader.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/bin/edje/edje_svg_loader.c b/src/bin/edje/edje_svg_loader.c
index 781f141..c9b4165 100644
--- a/src/bin/edje/edje_svg_loader.c
+++ b/src/bin/edje/edje_svg_loader.c
@@ -680,10 +680,12 @@ _attr_parse_svg_node(void *data, const char *key, const 
char *value)
      }
    else if (!strcmp(key, "viewBox"))
      {
-        if (_parse_number(&value, &doc->vx))
-          if (_parse_number(&value, &doc->vy))
-            if (_parse_number(&value, &doc->vw))
-              _parse_number(&value, &doc->vh);
+
+        if (!_parse_number(&value, &doc->vx) && !_parse_number(&value, 
&doc->vy) &&
+            !_parse_number(&value, &doc->vw) && !_parse_number(&value, 
&doc->vh))
+          {
+             return EINA_FALSE;
+         }
      }
    else if (!strcmp(key, "style"))
      {

--