[EGIT] [core/efl] master 04/04: elm: config: check return value of eina_value_get instead of returning always TRUE

[Stefan Schmidt]

stefan pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=74914c05159742d9228ecda2228726e341cf8ac6

commit 74914c05159742d9228ecda2228726e341cf8ac6
Author: Stefan Schmidt <ste...@osg.samsung.com>
Date:   Mon Dec 5 17:00:56 2016 +0100

    elm: config: check return value of eina_value_get instead of returning 
always TRUE
    
    There is always a chance that eina_value_get will not return EINA_TRUE here 
so
    better check it and use it as return value directly.
    
    CID: 1357138
---
 src/lib/elementary/elm_config.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/lib/elementary/elm_config.c b/src/lib/elementary/elm_config.c
index bd496ee..0af9d58 100644
--- a/src/lib/elementary/elm_config.c
+++ b/src/lib/elementary/elm_config.c
@@ -4348,8 +4348,7 @@ _eina_value_to_int(const Eina_Value *val, int *i)
 
    if (eina_value_type_get(val) == EINA_VALUE_TYPE_INT)
      {
-        eina_value_get(val, i);
-        return EINA_TRUE;
+        return eina_value_get(val, i);
      }
 
    ival = eina_value_new(EINA_VALUE_TYPE_INT);

--