Re: [E-devel] [EGIT] [core/elementary] master 01/01: entry - fix autosave timer del on shutdown

2013-11-16 Thread Daniel Juyung Seo 
Daniel Juyung Seo (SeoZ)
On Nov 16, 2013 4:21 PM, Carsten Haitzler ras...@rasterman.com wrote:

 On Sat, 16 Nov 2013 13:44:41 +0900 Daniel Juyung Seo seojuyu...@gmail.com

 said:

  Is there any reason that you want to set it to null? As far as I know
some
  people avoid setting variables to null on smart del.

 just in case a function during del calls something that calls a callback
that
 tries to do something that accesses the timer. only if the functions
called
 wouldnt release control from the del code would it be fine to assume its
not
 accessed. :) being paranoid.


Ok. Same as me :)
That is needed in some cases.
Thanks.

  Daniel Juyung Seo (SeoZ)
  On Nov 16, 2013 1:23 PM, Carsten Haitzler ras...@rasterman.com
wrote:
 
   raster pushed a commit to branch master.
  
  
  
http://git.enlightenment.org/core/elementary.git/commit/?id=a407689372b2cd085c4220cdc3b82fb811b87307
  
   commit a407689372b2cd085c4220cdc3b82fb811b87307
   Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
   Date:   Sat Nov 16 13:21:36 2013 +0900
  
   entry - fix autosave timer del on shutdown
  
   this fixes T509
   ---
src/lib/elm_entry.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
  
   diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
   index 0203bd2..143a5d0 100644
   --- a/src/lib/elm_entry.c
   +++ b/src/lib/elm_entry.c
   @@ -3340,7 +3340,7 @@ _elm_entry_smart_del(Eo *obj, void *_pd, va_list
   *list EINA_UNUSED)
  
   if (sd-delay_write)
 {
   -if (sd-delay_write) ecore_timer_del(sd-delay_write);
   +ELM_SAFE_FREE(sd-delay_write, ecore_timer_del);
if (sd-auto_save) _save_do(obj);
 }
  
   @@ -3393,7 +3393,7 @@ _elm_entry_smart_del(Eo *obj, void *_pd, va_list
   *list EINA_UNUSED)
 {
_filter_free(tf);
 }
   -   if (sd-delay_write) ecore_timer_del(sd-delay_write);
   +   ELM_SAFE_FREE(sd-delay_write, ecore_timer_del);
   if (sd-input_panel_imdata) free(sd-input_panel_imdata);
   if (sd-anchor_hover.hover_style)
   eina_stringshare_del(sd-anchor_hover.hover_style);
  
  
   --
  
  
  
 
--
  DreamFactory - Open Source REST  JSON Services for HTML5  Native Apps
  OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
  Free app hosting. Or install the open source package on any LAMP server.
  Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
 
http://pubads.g.doubleclick.net/gampad/clk?id=63469471iu=/4140/ostg.clktrk
  ___
  enlightenment-devel mailing list
  enlightenment-devel@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 


 --
 - Codito, ergo sum - I code, therefore I am --
 The Rasterman (Carsten Haitzler)ras...@rasterman.com

--
DreamFactory - Open Source REST  JSON Services for HTML5  Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/elementary] master 01/01: entry - fix autosave timer del on shutdown

2013-11-15 Thread Rasterman 
raster pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=a407689372b2cd085c4220cdc3b82fb811b87307

commit a407689372b2cd085c4220cdc3b82fb811b87307
Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
Date:   Sat Nov 16 13:21:36 2013 +0900

entry - fix autosave timer del on shutdown

this fixes T509
---
 src/lib/elm_entry.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
index 0203bd2..143a5d0 100644
--- a/src/lib/elm_entry.c
+++ b/src/lib/elm_entry.c
@@ -3340,7 +3340,7 @@ _elm_entry_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
 
if (sd-delay_write)
  {
-if (sd-delay_write) ecore_timer_del(sd-delay_write);
+ELM_SAFE_FREE(sd-delay_write, ecore_timer_del);
 if (sd-auto_save) _save_do(obj);
  }
 
@@ -3393,7 +3393,7 @@ _elm_entry_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
  {
 _filter_free(tf);
  }
-   if (sd-delay_write) ecore_timer_del(sd-delay_write);
+   ELM_SAFE_FREE(sd-delay_write, ecore_timer_del);
if (sd-input_panel_imdata) free(sd-input_panel_imdata);
if (sd-anchor_hover.hover_style) 
eina_stringshare_del(sd-anchor_hover.hover_style);
 

--

Re: [E-devel] [EGIT] [core/elementary] master 01/01: entry - fix autosave timer del on shutdown

2013-11-15 Thread Daniel Juyung Seo 
Is there any reason that you want to set it to null? As far as I know some
people avoid setting variables to null on smart del.

Daniel Juyung Seo (SeoZ)
On Nov 16, 2013 1:23 PM, Carsten Haitzler ras...@rasterman.com wrote:

 raster pushed a commit to branch master.


 http://git.enlightenment.org/core/elementary.git/commit/?id=a407689372b2cd085c4220cdc3b82fb811b87307

 commit a407689372b2cd085c4220cdc3b82fb811b87307
 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
 Date:   Sat Nov 16 13:21:36 2013 +0900

 entry - fix autosave timer del on shutdown

 this fixes T509
 ---
  src/lib/elm_entry.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
 index 0203bd2..143a5d0 100644
 --- a/src/lib/elm_entry.c
 +++ b/src/lib/elm_entry.c
 @@ -3340,7 +3340,7 @@ _elm_entry_smart_del(Eo *obj, void *_pd, va_list
 *list EINA_UNUSED)

 if (sd-delay_write)
   {
 -if (sd-delay_write) ecore_timer_del(sd-delay_write);
 +ELM_SAFE_FREE(sd-delay_write, ecore_timer_del);
  if (sd-auto_save) _save_do(obj);
   }

 @@ -3393,7 +3393,7 @@ _elm_entry_smart_del(Eo *obj, void *_pd, va_list
 *list EINA_UNUSED)
   {
  _filter_free(tf);
   }
 -   if (sd-delay_write) ecore_timer_del(sd-delay_write);
 +   ELM_SAFE_FREE(sd-delay_write, ecore_timer_del);
 if (sd-input_panel_imdata) free(sd-input_panel_imdata);
 if (sd-anchor_hover.hover_style)
 eina_stringshare_del(sd-anchor_hover.hover_style);


 --



--
DreamFactory - Open Source REST  JSON Services for HTML5  Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/elementary] master 01/01: entry - fix autosave timer del on shutdown

2013-11-15 Thread The Rasterman 
On Sat, 16 Nov 2013 13:44:41 +0900 Daniel Juyung Seo seojuyu...@gmail.com
said:

 Is there any reason that you want to set it to null? As far as I know some
 people avoid setting variables to null on smart del.

just in case a function during del calls something that calls a callback that
tries to do something that accesses the timer. only if the functions called
wouldnt release control from the del code would it be fine to assume its not
accessed. :) being paranoid.

 Daniel Juyung Seo (SeoZ)
 On Nov 16, 2013 1:23 PM, Carsten Haitzler ras...@rasterman.com wrote:
 
  raster pushed a commit to branch master.
 
 
  http://git.enlightenment.org/core/elementary.git/commit/?id=a407689372b2cd085c4220cdc3b82fb811b87307
 
  commit a407689372b2cd085c4220cdc3b82fb811b87307
  Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
  Date:   Sat Nov 16 13:21:36 2013 +0900
 
  entry - fix autosave timer del on shutdown
 
  this fixes T509
  ---
   src/lib/elm_entry.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
 
  diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
  index 0203bd2..143a5d0 100644
  --- a/src/lib/elm_entry.c
  +++ b/src/lib/elm_entry.c
  @@ -3340,7 +3340,7 @@ _elm_entry_smart_del(Eo *obj, void *_pd, va_list
  *list EINA_UNUSED)
 
  if (sd-delay_write)
{
  -if (sd-delay_write) ecore_timer_del(sd-delay_write);
  +ELM_SAFE_FREE(sd-delay_write, ecore_timer_del);
   if (sd-auto_save) _save_do(obj);
}
 
  @@ -3393,7 +3393,7 @@ _elm_entry_smart_del(Eo *obj, void *_pd, va_list
  *list EINA_UNUSED)
{
   _filter_free(tf);
}
  -   if (sd-delay_write) ecore_timer_del(sd-delay_write);
  +   ELM_SAFE_FREE(sd-delay_write, ecore_timer_del);
  if (sd-input_panel_imdata) free(sd-input_panel_imdata);
  if (sd-anchor_hover.hover_style)
  eina_stringshare_del(sd-anchor_hover.hover_style);
 
 
  --
 
 
 
 --
 DreamFactory - Open Source REST  JSON Services for HTML5  Native Apps
 OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
 Free app hosting. Or install the open source package on any LAMP server.
 Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
 http://pubads.g.doubleclick.net/gampad/clk?id=63469471iu=/4140/ostg.clktrk
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 


-- 
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
DreamFactory - Open Source REST  JSON Services for HTML5  Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel