Re: [E-devel] [EGIT] [apps/terminology] master 01/01: fix CID 1106345 - missing parentheses
Hello. On 10/15/2013 08:59 AM, Boris Faure wrote: > On 13-10-15 08:23, Stefan Schmidt wrote: >> Hello. >> >> On 10/14/2013 10:25 PM, Boris Faure wrote: >>> billiob pushed a commit to branch master. >>> >>> > http://git.enlightenment.org/apps/terminology.git/commit/?id=c4366ed2b57c6 > 85cb9130ff7c5b4105692cfa207 >>> >>> commit c4366ed2b57c685cb9130ff7c5b4105692cfa207 >>> Author: Boris Faure >>> Date: Mon Oct 14 23:22:19 2013 +0200 >>> >>> fix CID 1106345 - missing parentheses >> >> This does not match the change. At least a ! is no ) or ( in my font. :) > > This was the name of the issue in coverity. I could have written > something better. Oh wow. /me spanks coverity for a really bad description. What I always try is to set the problem into a real context and describe that. Maybe adding the descprition from coverity. The only that thats important from there is the CID though. We are not bound to their description especially if they are so bad. :) regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [apps/terminology] master 01/01: fix CID 1106345 - missing parentheses
On 13-10-15 08:23, Stefan Schmidt wrote: > Hello. > > On 10/14/2013 10:25 PM, Boris Faure wrote: > > billiob pushed a commit to branch master. > > > > http://git.enlightenment.org/apps/terminology.git/commit/?id=c4366ed2b57c685cb9130ff7c5b4105692cfa207 > > > > commit c4366ed2b57c685cb9130ff7c5b4105692cfa207 > > Author: Boris Faure > > Date: Mon Oct 14 23:22:19 2013 +0200 > > > > fix CID 1106345 - missing parentheses > > This does not match the change. At least a ! is no ) or ( in my font. :) This was the name of the issue in coverity. I could have written something better. > > -if ((config) && (!file[0] != '.') && > > +if ((config) && (file[0] != '.') && -- Boris Faure Pointer Arithmetician -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [apps/terminology] master 01/01: fix CID 1106345 - missing parentheses
Hello.
On 10/14/2013 10:25 PM, Boris Faure wrote:
> billiob pushed a commit to branch master.
>
> http://git.enlightenment.org/apps/terminology.git/commit/?id=c4366ed2b57c685cb9130ff7c5b4105692cfa207
>
> commit c4366ed2b57c685cb9130ff7c5b4105692cfa207
> Author: Boris Faure
> Date: Mon Oct 14 23:22:19 2013 +0200
>
> fix CID 1106345 - missing parentheses
This does not match the change. At least a ! is no ) or ( in my font. :)
> src/bin/options_theme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bin/options_theme.c b/src/bin/options_theme.c
> index 84e06e9..79d6e7c 100644
> --- a/src/bin/options_theme.c
> +++ b/src/bin/options_theme.c
> @@ -126,7 +126,7 @@ options_theme(Evas_Object *opbox, Evas_Object *term)
> {
> const char *ext = strchr(file, '.');
>
> -if ((config) && (!file[0] != '.') &&
> +if ((config) && (file[0] != '.') &&
> ((ext) && (!strcasecmp(".edj", ext
>{
> t = calloc(1, sizeof(Theme));
>
regards
Stefan Schmidt
--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
