Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore_drm2: Fix mouse pointer when using absolute coords

2016-07-08 Thread The Rasterman 
On Fri, 8 Jul 2016 06:57:12 -0400 Christopher Michael
 said:

> On 07/08/2016 05:05 AM, Stefan Schmidt wrote:
> > Hello.
> >
> >
> > On 07/07/16 23:00, Michael Blumenkrantz wrote:
> >> On Thu, 7 Jul 2016 14:33:20 -0400
> >> Christopher Michael  wrote:
> >>
> >>> On 07/07/2016 03:15 AM, Jean-Philippe ANDRÉ wrote:
>  jpeg pushed a commit to branch master.
> 
>  http://git.enlightenment.org/core/efl.git/commit/?id=570a398e290d93e2b6ef998b263004281f45097d
> 
>  commit 570a398e290d93e2b6ef998b263004281f45097d
>  Author: Jean-Philippe Andre 
>  Date:   Thu Jul 7 16:01:58 2016 +0900
> 
>   ecore_drm2: Fix mouse pointer when using absolute coords
> 
> 
> >>> 
> >>>
>  +static Eina_Bool
>  +_cb_device_change(void *data, int type EINA_UNUSED, void *event)
>  +{
>  +   Elput_Event_Device_Change *ev = event;
>  +   Ecore_Drm2_Device *device = data;
>  +
>  +   if (ev->type == ELPUT_DEVICE_ADDED)
>  + {
>  +Ecore_Drm2_Output *output;
>  +
>  +/* FIXME: not sure which output to use to calibrate */
>  +output = eina_list_data_get(device->outputs);
>  +if (output)
>  +  ecore_drm2_device_calibrate(device, output->w, output->h);
>  + }
>  +
>  +   return ECORE_CALLBACK_RENEW;
>  +}
> >>> I have a patch for this FIXME here, but cannot push until after the
> >>> freeze.
> >>>
> >>> Cheers,
> >>> dh
> >>>
> >> What freeze?
> >
> > When I did the first snapshot I asked everybody to stop putting in new
> > features besides the bunch of interface stuff which was left. This is
> > what Chris refers to here.
> >
> 
> Correct.
> 
> > He was a nice guy and did not try top sneak in more, compared to other
> > people who did not care and kept going.
> >
> 
> Me a nice guy ?? You're going to ruin my reputation ;)
> 
> > If there is a fix for the FIXME above I see no reason to not put it in.
> > Fixes are always welcome.
> >
> > If the "fix" here refers to a complete rewrite as ecore_drm3 that would
> > be a different thing :)
> >
> 
> Nothing as drastic :) Just need to push one new API function to Elput in 
> order to fix this.
> 
> > The only thing I heard from Chris that he has pending is the drm planes
> > support. When we talked about it he was ok with not pushing it until
> > 1.19 opens as it was not fully ready either.
> > If this changed and it is ready now and needed by other parts it can go
> > in within the next week. Just make sure it will not expose one of the
> > last show stopper bugs which block the release so I have to come after
> > you :P
> >
> 
> Yes, I was going to speak to you today about pushing the API needed to 
> address the FIXME in the above commit.

you need to add api to fix a bug - then add it. a freeze is about fixing
things. it's not a bureaucratic "how dare you add ANY api even if its a fix!".
use common sense here. :)

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Attend Shape: An AT Tech Expo July 15-16. Meet us at AT Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore_drm2: Fix mouse pointer when using absolute coords

2016-07-08 Thread Christopher Michael 
On 07/08/2016 05:05 AM, Stefan Schmidt wrote:
> Hello.
>
>
> On 07/07/16 23:00, Michael Blumenkrantz wrote:
>> On Thu, 7 Jul 2016 14:33:20 -0400
>> Christopher Michael  wrote:
>>
>>> On 07/07/2016 03:15 AM, Jean-Philippe ANDRÉ wrote:
 jpeg pushed a commit to branch master.

 http://git.enlightenment.org/core/efl.git/commit/?id=570a398e290d93e2b6ef998b263004281f45097d

 commit 570a398e290d93e2b6ef998b263004281f45097d
 Author: Jean-Philippe Andre 
 Date:   Thu Jul 7 16:01:58 2016 +0900

  ecore_drm2: Fix mouse pointer when using absolute coords


>>> 
>>>
 +static Eina_Bool
 +_cb_device_change(void *data, int type EINA_UNUSED, void *event)
 +{
 +   Elput_Event_Device_Change *ev = event;
 +   Ecore_Drm2_Device *device = data;
 +
 +   if (ev->type == ELPUT_DEVICE_ADDED)
 + {
 +Ecore_Drm2_Output *output;
 +
 +/* FIXME: not sure which output to use to calibrate */
 +output = eina_list_data_get(device->outputs);
 +if (output)
 +  ecore_drm2_device_calibrate(device, output->w, output->h);
 + }
 +
 +   return ECORE_CALLBACK_RENEW;
 +}
>>> I have a patch for this FIXME here, but cannot push until after the freeze.
>>>
>>> Cheers,
>>> dh
>>>
>> What freeze?
>
> When I did the first snapshot I asked everybody to stop putting in new
> features besides the bunch of interface stuff which was left. This is
> what Chris refers to here.
>

Correct.

> He was a nice guy and did not try top sneak in more, compared to other
> people who did not care and kept going.
>

Me a nice guy ?? You're going to ruin my reputation ;)

> If there is a fix for the FIXME above I see no reason to not put it in.
> Fixes are always welcome.
>
> If the "fix" here refers to a complete rewrite as ecore_drm3 that would
> be a different thing :)
>

Nothing as drastic :) Just need to push one new API function to Elput in 
order to fix this.

> The only thing I heard from Chris that he has pending is the drm planes
> support. When we talked about it he was ok with not pushing it until
> 1.19 opens as it was not fully ready either.
> If this changed and it is ready now and needed by other parts it can go
> in within the next week. Just make sure it will not expose one of the
> last show stopper bugs which block the release so I have to come after
> you :P
>

Yes, I was going to speak to you today about pushing the API needed to 
address the FIXME in the above commit.

> regards
> Stefan Schmidt

Cheers,
Chris


--
Attend Shape: An AT Tech Expo July 15-16. Meet us at AT Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore_drm2: Fix mouse pointer when using absolute coords

2016-07-08 Thread Stefan Schmidt 
Hello.


On 07/07/16 23:00, Michael Blumenkrantz wrote:
> On Thu, 7 Jul 2016 14:33:20 -0400
> Christopher Michael  wrote:
>
>> On 07/07/2016 03:15 AM, Jean-Philippe ANDRÉ wrote:
>>> jpeg pushed a commit to branch master.
>>>
>>> http://git.enlightenment.org/core/efl.git/commit/?id=570a398e290d93e2b6ef998b263004281f45097d
>>>
>>> commit 570a398e290d93e2b6ef998b263004281f45097d
>>> Author: Jean-Philippe Andre 
>>> Date:   Thu Jul 7 16:01:58 2016 +0900
>>>
>>>  ecore_drm2: Fix mouse pointer when using absolute coords
>>>
>>>   
>> 
>>
>>> +static Eina_Bool
>>> +_cb_device_change(void *data, int type EINA_UNUSED, void *event)
>>> +{
>>> +   Elput_Event_Device_Change *ev = event;
>>> +   Ecore_Drm2_Device *device = data;
>>> +
>>> +   if (ev->type == ELPUT_DEVICE_ADDED)
>>> + {
>>> +Ecore_Drm2_Output *output;
>>> +
>>> +/* FIXME: not sure which output to use to calibrate */
>>> +output = eina_list_data_get(device->outputs);
>>> +if (output)
>>> +  ecore_drm2_device_calibrate(device, output->w, output->h);
>>> + }
>>> +
>>> +   return ECORE_CALLBACK_RENEW;
>>> +}
>> I have a patch for this FIXME here, but cannot push until after the freeze.
>>
>> Cheers,
>> dh
>>
> What freeze?

When I did the first snapshot I asked everybody to stop putting in new 
features besides the bunch of interface stuff which was left. This is 
what Chris refers to here.

He was a nice guy and did not try top sneak in more, compared to other 
people who did not care and kept going.

If there is a fix for the FIXME above I see no reason to not put it in. 
Fixes are always welcome.

If the "fix" here refers to a complete rewrite as ecore_drm3 that would 
be a different thing :)

The only thing I heard from Chris that he has pending is the drm planes 
support. When we talked about it he was ok with not pushing it until 
1.19 opens as it was not fully ready either.
If this changed and it is ready now and needed by other parts it can go 
in within the next week. Just make sure it will not expose one of the 
last show stopper bugs which block the release so I have to come after 
you :P

regards
Stefan Schmidt

--
Attend Shape: An AT Tech Expo July 15-16. Meet us at AT Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore_drm2: Fix mouse pointer when using absolute coords

2016-07-07 Thread Michael Blumenkrantz 
On Thu, 7 Jul 2016 14:33:20 -0400
Christopher Michael  wrote:

> On 07/07/2016 03:15 AM, Jean-Philippe ANDRÉ wrote:
> > jpeg pushed a commit to branch master.
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=570a398e290d93e2b6ef998b263004281f45097d
> >
> > commit 570a398e290d93e2b6ef998b263004281f45097d
> > Author: Jean-Philippe Andre 
> > Date:   Thu Jul 7 16:01:58 2016 +0900
> >
> > ecore_drm2: Fix mouse pointer when using absolute coords
> >
> >  
> 
> 
> 
> > +static Eina_Bool
> > +_cb_device_change(void *data, int type EINA_UNUSED, void *event)
> > +{
> > +   Elput_Event_Device_Change *ev = event;
> > +   Ecore_Drm2_Device *device = data;
> > +
> > +   if (ev->type == ELPUT_DEVICE_ADDED)
> > + {
> > +Ecore_Drm2_Output *output;
> > +
> > +/* FIXME: not sure which output to use to calibrate */
> > +output = eina_list_data_get(device->outputs);
> > +if (output)
> > +  ecore_drm2_device_calibrate(device, output->w, output->h);
> > + }
> > +
> > +   return ECORE_CALLBACK_RENEW;
> > +}  
> 
> I have a patch for this FIXME here, but cannot push until after the freeze.
> 
> Cheers,
> dh
> 

What freeze?

--
Attend Shape: An AT Tech Expo July 15-16. Meet us at AT Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore_drm2: Fix mouse pointer when using absolute coords

2016-07-07 Thread Christopher Michael 
On 07/07/2016 03:15 AM, Jean-Philippe ANDRÉ wrote:
> jpeg pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=570a398e290d93e2b6ef998b263004281f45097d
>
> commit 570a398e290d93e2b6ef998b263004281f45097d
> Author: Jean-Philippe Andre 
> Date:   Thu Jul 7 16:01:58 2016 +0900
>
> ecore_drm2: Fix mouse pointer when using absolute coords
>
>



> +static Eina_Bool
> +_cb_device_change(void *data, int type EINA_UNUSED, void *event)
> +{
> +   Elput_Event_Device_Change *ev = event;
> +   Ecore_Drm2_Device *device = data;
> +
> +   if (ev->type == ELPUT_DEVICE_ADDED)
> + {
> +Ecore_Drm2_Output *output;
> +
> +/* FIXME: not sure which output to use to calibrate */
> +output = eina_list_data_get(device->outputs);
> +if (output)
> +  ecore_drm2_device_calibrate(device, output->w, output->h);
> + }
> +
> +   return ECORE_CALLBACK_RENEW;
> +}

I have a patch for this FIXME here, but cannot push until after the freeze.

Cheers,
dh


--
Attend Shape: An AT Tech Expo July 15-16. Meet us at AT Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel