Re: [E-devel] [EGIT] [core/efl] master 06/06: edje: unamed part are completely legit as long as no program try to interact with them.

2016-06-13 Thread The Rasterman 
On Thu, 9 Jun 2016 08:29:51 -0700 Cedric BAIL  said:

> On Jun 9, 2016 5:02 AM, "Viacheslav Reutskiy" 
> wrote:
> >
> > Hello,
> >
> > Cedric, you broke the edje_edit. Edje_edit cann't work with unnamed parts.
> 
> Ah, dang ! Problem is that this was legit in the past and application are
> using it (which is why I removed it).it also means that edje edit is not
> robust on valid older input.Would it be possible to patch edje edit, so
> that on open, it patches the edj and generate name as needed ? This way old
> flee could be opened by edje edit property.

this is probably best - just refuse to edit data without names per part. we
have to keep allowing non-names on parts as it was valid before.

> Cedric
> 
> > Please revert this patch.
> >
> >
> > On 06/09/16 01:07, Cedric BAIL wrote:
> > > cedric pushed a commit to branch master.
> > >
> > >
> http://git.enlightenment.org/core/efl.git/commit/?id=088043e77af158941d9240a14f3463387f8eabfb
> > >
> > > commit 088043e77af158941d9240a14f3463387f8eabfb
> > > Author: Cedric BAIL 
> > > Date:   Wed Jun 8 15:00:30 2016 -0700
> > >
> > >  edje: unamed part are completely legit as long as no program try
> to interact with them.
> > > ---
> > >   src/bin/edje/edje_cc_handlers.c | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/src/bin/edje/edje_cc_handlers.c
> b/src/bin/edje/edje_cc_handlers.c
> > > index 0435713..0bbdb13 100644
> > > --- a/src/bin/edje/edje_cc_handlers.c
> > > +++ b/src/bin/edje/edje_cc_handlers.c
> > > @@ -15079,9 +15079,8 @@ edje_cc_handlers_hierarchy_pop(void)
> > >
> > >   if (!current_part->name)
> > > {
> > > - ERR("Parse error near %s:%i. Unnamed part exists in Group
> \"%s\" - Pausing for a bit so you notice and remember to fix this.",
> > > + WRN("Parse error near %s:%i. Unnamed part exists in Group
> \"%s\".",
> > >file_in, line - 1, current_de->entry);
> > > - sleep(10);
> > > }
> > >
> > >   for (i = 0; i < current_part->other.desc_count; i++)
> > >
> >
> > --
> > Viacheslav Reutskiy (rimmed)
> >
> >
> --
> > What NetFlow Analyzer can do for you? Monitors network bandwidth and
> traffic
> > patterns at an interface-level. Reveals which users, apps, and protocols
> are
> > consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> > J-Flow, sFlow and other flows. Make informed decisions using capacity
> > planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> --
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are 
> consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
> J-Flow, sFlow and other flows. Make informed decisions using capacity 
> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 06/06: edje: unamed part are completely legit as long as no program try to interact with them.

2016-06-13 Thread Simon Lees 


On 06/13/2016 03:18 PM, Viacheslav Reutskiy wrote:
> Hello,
> 
> Sorry for delay.
> 
> On 06/09/16 18:29, Cedric BAIL wrote:
>> On Jun 9, 2016 5:02 AM, "Viacheslav Reutskiy" 
>> wrote:
>>> Hello,
>>>
>>> Cedric, you broke the edje_edit. Edje_edit cann't work with unnamed parts.
>> Ah, dang ! Problem is that this was legit in the past and application are
>> using it (which is why I removed it).it also means that edje edit is not
>> robust on valid older input.Would it be possible to patch edje edit, so
>> that on open, it patches the edj and generate name as needed ? This way old
>> flee could be opened by edje edit property.
>>
>> Cedric
> 
> I can set generated name for unnamed parts, but it's wrong. As you said me:
> "It's broke ABI".
> Maybe pospone this changes to EFL 2.0? For EFL 2.0 we can rework the Edje 
> Edit to
> manage all items (parts, programs, items etc) by index for solve all issues.
> 
Unfortunately not allowing unnamed parts is a break of theme API meaning
it also can't be done till EFL 2.0.

> ---
> Viacheslav Reutskiy (rimmed)
> 
>>> Please revert this patch.
>>>
>>>
>>> On 06/09/16 01:07, Cedric BAIL wrote:
 cedric pushed a commit to branch master.


>> http://git.enlightenment.org/core/efl.git/commit/?id=088043e77af158941d9240a14f3463387f8eabfb
 commit 088043e77af158941d9240a14f3463387f8eabfb
 Author: Cedric BAIL 
 Date:   Wed Jun 8 15:00:30 2016 -0700

   edje: unamed part are completely legit as long as no program try
>> to interact with them.
 ---
src/bin/edje/edje_cc_handlers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

 diff --git a/src/bin/edje/edje_cc_handlers.c
>> b/src/bin/edje/edje_cc_handlers.c
 index 0435713..0bbdb13 100644
 --- a/src/bin/edje/edje_cc_handlers.c
 +++ b/src/bin/edje/edje_cc_handlers.c
 @@ -15079,9 +15079,8 @@ edje_cc_handlers_hierarchy_pop(void)

if (!current_part->name)
  {
 - ERR("Parse error near %s:%i. Unnamed part exists in Group
>> \"%s\" - Pausing for a bit so you notice and remember to fix this.",
 + WRN("Parse error near %s:%i. Unnamed part exists in Group
>> \"%s\".",
 file_in, line - 1, current_de->entry);
 - sleep(10);
  }

for (i = 0; i < current_part->other.desc_count; i++)

>>> --
>>> Viacheslav Reutskiy (rimmed)
>>>
>>>
>> --
>>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
>> traffic
>>> patterns at an interface-level. Reveals which users, apps, and protocols
>> are
>>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>>> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
>>> ___
>>> enlightenment-devel mailing list
>>> enlightenment-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>>
>> --
>> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
>> patterns at an interface-level. Reveals which users, apps, and protocols are
>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 

-- 

Simon Lees (Simotek)http://simotek.net

Emergency Update Team   keybase.io/simotek
SUSE LinuxAdeliade Australia, UTC+9:30
GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B



signature.asc
Description: OpenPGP digital signature
--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 06/06: edje: unamed part are completely legit as long as no program try to interact with them.

2016-06-12 Thread Viacheslav Reutskiy 
Hello,

Sorry for delay.

On 06/09/16 18:29, Cedric BAIL wrote:
> On Jun 9, 2016 5:02 AM, "Viacheslav Reutskiy" 
> wrote:
>> Hello,
>>
>> Cedric, you broke the edje_edit. Edje_edit cann't work with unnamed parts.
> Ah, dang ! Problem is that this was legit in the past and application are
> using it (which is why I removed it).it also means that edje edit is not
> robust on valid older input.Would it be possible to patch edje edit, so
> that on open, it patches the edj and generate name as needed ? This way old
> flee could be opened by edje edit property.
>
> Cedric

I can set generated name for unnamed parts, but it's wrong. As you said me:
"It's broke ABI".
Maybe pospone this changes to EFL 2.0? For EFL 2.0 we can rework the Edje Edit 
to
manage all items (parts, programs, items etc) by index for solve all issues.

---
Viacheslav Reutskiy (rimmed)

>> Please revert this patch.
>>
>>
>> On 06/09/16 01:07, Cedric BAIL wrote:
>>> cedric pushed a commit to branch master.
>>>
>>>
> http://git.enlightenment.org/core/efl.git/commit/?id=088043e77af158941d9240a14f3463387f8eabfb
>>> commit 088043e77af158941d9240a14f3463387f8eabfb
>>> Author: Cedric BAIL 
>>> Date:   Wed Jun 8 15:00:30 2016 -0700
>>>
>>>   edje: unamed part are completely legit as long as no program try
> to interact with them.
>>> ---
>>>src/bin/edje/edje_cc_handlers.c | 3 +--
>>>1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/src/bin/edje/edje_cc_handlers.c
> b/src/bin/edje/edje_cc_handlers.c
>>> index 0435713..0bbdb13 100644
>>> --- a/src/bin/edje/edje_cc_handlers.c
>>> +++ b/src/bin/edje/edje_cc_handlers.c
>>> @@ -15079,9 +15079,8 @@ edje_cc_handlers_hierarchy_pop(void)
>>>
>>>if (!current_part->name)
>>>  {
>>> - ERR("Parse error near %s:%i. Unnamed part exists in Group
> \"%s\" - Pausing for a bit so you notice and remember to fix this.",
>>> + WRN("Parse error near %s:%i. Unnamed part exists in Group
> \"%s\".",
>>> file_in, line - 1, current_de->entry);
>>> - sleep(10);
>>>  }
>>>
>>>for (i = 0; i < current_part->other.desc_count; i++)
>>>
>> --
>> Viacheslav Reutskiy (rimmed)
>>
>>
> --
>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
> traffic
>> patterns at an interface-level. Reveals which users, apps, and protocols
> are
>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
> --
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are
> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> J-Flow, sFlow and other flows. Make informed decisions using capacity
> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

-- 
Viacheslav Reutskiy (rimmed)

--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 06/06: edje: unamed part are completely legit as long as no program try to interact with them.

2016-06-09 Thread Cedric BAIL 
On Jun 9, 2016 5:02 AM, "Viacheslav Reutskiy" 
wrote:
>
> Hello,
>
> Cedric, you broke the edje_edit. Edje_edit cann't work with unnamed parts.

Ah, dang ! Problem is that this was legit in the past and application are
using it (which is why I removed it).it also means that edje edit is not
robust on valid older input.Would it be possible to patch edje edit, so
that on open, it patches the edj and generate name as needed ? This way old
flee could be opened by edje edit property.

Cedric

> Please revert this patch.
>
>
> On 06/09/16 01:07, Cedric BAIL wrote:
> > cedric pushed a commit to branch master.
> >
> >
http://git.enlightenment.org/core/efl.git/commit/?id=088043e77af158941d9240a14f3463387f8eabfb
> >
> > commit 088043e77af158941d9240a14f3463387f8eabfb
> > Author: Cedric BAIL 
> > Date:   Wed Jun 8 15:00:30 2016 -0700
> >
> >  edje: unamed part are completely legit as long as no program try
to interact with them.
> > ---
> >   src/bin/edje/edje_cc_handlers.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/src/bin/edje/edje_cc_handlers.c
b/src/bin/edje/edje_cc_handlers.c
> > index 0435713..0bbdb13 100644
> > --- a/src/bin/edje/edje_cc_handlers.c
> > +++ b/src/bin/edje/edje_cc_handlers.c
> > @@ -15079,9 +15079,8 @@ edje_cc_handlers_hierarchy_pop(void)
> >
> >   if (!current_part->name)
> > {
> > - ERR("Parse error near %s:%i. Unnamed part exists in Group
\"%s\" - Pausing for a bit so you notice and remember to fix this.",
> > + WRN("Parse error near %s:%i. Unnamed part exists in Group
\"%s\".",
> >file_in, line - 1, current_de->entry);
> > - sleep(10);
> > }
> >
> >   for (i = 0; i < current_part->other.desc_count; i++)
> >
>
> --
> Viacheslav Reutskiy (rimmed)
>
>
--
> What NetFlow Analyzer can do for you? Monitors network bandwidth and
traffic
> patterns at an interface-level. Reveals which users, apps, and protocols
are
> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> J-Flow, sFlow and other flows. Make informed decisions using capacity
> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 06/06: edje: unamed part are completely legit as long as no program try to interact with them.

2016-06-09 Thread Viacheslav Reutskiy 
Hello,

Cedric, you broke the edje_edit. Edje_edit cann't work with unnamed parts.

Please revert this patch.


On 06/09/16 01:07, Cedric BAIL wrote:
> cedric pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=088043e77af158941d9240a14f3463387f8eabfb
>
> commit 088043e77af158941d9240a14f3463387f8eabfb
> Author: Cedric BAIL 
> Date:   Wed Jun 8 15:00:30 2016 -0700
>
>  edje: unamed part are completely legit as long as no program try to 
> interact with them.
> ---
>   src/bin/edje/edje_cc_handlers.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/bin/edje/edje_cc_handlers.c b/src/bin/edje/edje_cc_handlers.c
> index 0435713..0bbdb13 100644
> --- a/src/bin/edje/edje_cc_handlers.c
> +++ b/src/bin/edje/edje_cc_handlers.c
> @@ -15079,9 +15079,8 @@ edje_cc_handlers_hierarchy_pop(void)
>   
>   if (!current_part->name)
> {
> - ERR("Parse error near %s:%i. Unnamed part exists in Group 
> \"%s\" - Pausing for a bit so you notice and remember to fix this.",
> + WRN("Parse error near %s:%i. Unnamed part exists in Group 
> \"%s\".",
>file_in, line - 1, current_de->entry);
> - sleep(10);
> }
>   
>   for (i = 0; i < current_part->other.desc_count; i++)
>

-- 
Viacheslav Reutskiy (rimmed)

--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel