Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
On Mon, Nov 4, 2013 at 7:05 PM, ChunEon Park her...@naver.com wrote: It says in popup doc. * The popup widget displays its content with a particular orientation in * the parent area. I already read that but that does not mean we can not add this api. Notify already has align_set which we can position notify wherever we want. Popup is a wrapper of notify and utility widget for convenience. It should be convenicent and easy to use. Absulte coordinates would break this action. People hardly understand if they use that kind of API. If they call elm_popup_move(100, 100); then popup should be (100, 100) position. But in some case if the parent is moved to 200, 200, then will you keep the popup position (100, 100)? You're right. elm_popup_move() should be changed to be relative to its parent. I missed that part. It should keep using coordinate but relative to its parent. The patch needs to be revised. if the popup is moved to 200, 200, then user may understand this behavior is bug. Relative value is simple and easy to understand in this case. But in a real life case, especially a product, we use pixel more than relative values. So without elm_popup_move, applications should track the parent geometry change and calculate parent geometry and itself all the time to give a relative paramters to elm_popup_align_set. I can easily imagine troubles already. Anyhow, there is no rush on this patch. We can just create and use elm_popup_align_set() and do all the calculations in the application side which will be so redundant among many apps. Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyu...@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: g...@lists.enlightenment.org; Sent: 2013-11-04 (월) 18:19:16 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 5:14 PM, ChunEon Park hermet@naver.com wrote: Regardless of the API useful, I don't agree pushing the API at this moment. It wil break popup concept. otherwise, similiar behavior of move() and align() will be conflicted. How does that break popup concept? That's interesting. Where is it described? Daniel Juyung Seo (SeoZ) if you agree align_set() can cover the popup_move() please just keep the align_set() only. -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 16:29:02 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:42 PM, ChunEon Park hermet@naver.com wrote: Abosulte position for the popup is insane if the parent position is changed. And totally popup is depends on the notify, it should follow the notify concept. Agreed. I also suggested to create elm_popup_align_set() instead of this. And he suggested elm_popup_move() to use pixel which I found it useful. Because the author of this commit is away, I will fix it before the today's feature freeze: 1. adding elm_popup_align_set() 2. fixing elm_popup_move() to depend on its parent position. 3. (optional) adding elm_notify_move() to use pixel Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 14:37:54 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park hermet@naver.com wrote: Eek! How about keeping the API name with notify? elm_notify_align_set()? Thanks for the interest and comments but the concept is different from align_set. elm_notify_align_set() gets relative position as a parameter but elm_popup_move() gets absolute pixel information just like elm_menu_move(). So elm_popup_move() is correct. EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_menu_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y); EAPI void elm_popup_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y); Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Abhinandan Aryadiptaa.aryadipta@samsung.com To: git@lists.enlightenment.org
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
Convenient ok. but convenient API even should not break the concept. The api sound like it does not care the scalability and popup concept. If you really intended that popup does not care the scalability, then ie, elm_popup_fixed_pos_set() will be nicer to me. or not, then align_set() should be there. If more other people agree on the API addition, then I will not care this anymore. Thanks. -Original Message- From: Daniel Juyung Seoseojuyu...@gmail.com To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net; Cc: g...@lists.enlightenment.org; Sent: 2013-11-08 (금) 09:06:45 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 7:05 PM, ChunEon Park hermet@naver.com wrote: It says in popup doc. * The popup widget displays its content with a particular orientation in * the parent area. I already read that but that does not mean we can not add this api. Notify already has align_set which we can position notify wherever we want. Popup is a wrapper of notify and utility widget for convenience. It should be convenicent and easy to use. Absulte coordinates would break this action. People hardly understand if they use that kind of API. If they call elm_popup_move(100, 100); then popup should be (100, 100) position. But in some case if the parent is moved to 200, 200, then will you keep the popup position (100, 100)? You're right. elm_popup_move() should be changed to be relative to its parent. I missed that part. It should keep using coordinate but relative to its parent. The patch needs to be revised. if the popup is moved to 200, 200, then user may understand this behavior is bug. Relative value is simple and easy to understand in this case. But in a real life case, especially a product, we use pixel more than relative values. So without elm_popup_move, applications should track the parent geometry change and calculate parent geometry and itself all the time to give a relative paramters to elm_popup_align_set. I can easily imagine troubles already. Anyhow, there is no rush on this patch. We can just create and use elm_popup_align_set() and do all the calculations in the application side which will be so redundant among many apps. Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 18:19:16 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 5:14 PM, ChunEon Park hermet@naver.com wrote: Regardless of the API useful, I don't agree pushing the API at this moment. It wil break popup concept. otherwise, similiar behavior of move() and align() will be conflicted. How does that break popup concept? That's interesting. Where is it described? Daniel Juyung Seo (SeoZ) if you agree align_set() can cover the popup_move() please just keep the align_set() only. -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 16:29:02 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:42 PM, ChunEon Park hermet@naver.com wrote: Abosulte position for the popup is insane if the parent position is changed. And totally popup is depends on the notify, it should follow the notify concept. Agreed. I also suggested to create elm_popup_align_set() instead of this. And he suggested elm_popup_move() to use pixel which I found it useful. Because the author of this commit is away, I will fix it before the today's feature freeze: 1. adding elm_popup_align_set() 2. fixing elm_popup_move() to depend on its parent position. 3. (optional) adding elm_notify_move() to use pixel Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 14:37:54 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park hermet@naver.com wrote: Eek! How about keeping the API name with notify? elm_notify_align_set()? Thanks for the interest and comments but the concept is different from align_set
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
On Fri, Nov 8, 2013 at 1:47 PM, ChunEon Park her...@naver.com wrote: Convenient ok. but convenient API even should not break the concept. It does not break popup concept. It is still relative to its parent once the patch is revised as I mentioned earlier. The api sound like it does not care the scalability and popup concept. What do you mean by scalability here? Any example? That is nothing to do with scalability. If application uses coordinate, app will call elm_config_scale_get() * xxx. See all the APIs that use coordinate as a parameter. Thanks. Daniel Juyung Seo (SeoZ) If you really intended that popup does not care the scalability, then ie, elm_popup_fixed_pos_set() will be nicer to me. or not, then align_set() should be there. If more other people agree on the API addition, then I will not care this anymore. Thanks. -Original Message- From: Daniel Juyung Seoseojuyu...@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: g...@lists.enlightenment.org; Sent: 2013-11-08 (금) 09:06:45 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 7:05 PM, ChunEon Park hermet@naver.com wrote: It says in popup doc. * The popup widget displays its content with a particular orientation in * the parent area. I already read that but that does not mean we can not add this api. Notify already has align_set which we can position notify wherever we want. Popup is a wrapper of notify and utility widget for convenience. It should be convenicent and easy to use. Absulte coordinates would break this action. People hardly understand if they use that kind of API. If they call elm_popup_move(100, 100); then popup should be (100, 100) position. But in some case if the parent is moved to 200, 200, then will you keep the popup position (100, 100)? You're right. elm_popup_move() should be changed to be relative to its parent. I missed that part. It should keep using coordinate but relative to its parent. The patch needs to be revised. if the popup is moved to 200, 200, then user may understand this behavior is bug. Relative value is simple and easy to understand in this case. But in a real life case, especially a product, we use pixel more than relative values. So without elm_popup_move, applications should track the parent geometry change and calculate parent geometry and itself all the time to give a relative paramters to elm_popup_align_set. I can easily imagine troubles already. Anyhow, there is no rush on this patch. We can just create and use elm_popup_align_set() and do all the calculations in the application side which will be so redundant among many apps. Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 18:19:16 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 5:14 PM, ChunEon Park hermet@naver.com wrote: Regardless of the API useful, I don't agree pushing the API at this moment. It wil break popup concept. otherwise, similiar behavior of move() and align() will be conflicted. How does that break popup concept? That's interesting. Where is it described? Daniel Juyung Seo (SeoZ) if you agree align_set() can cover the popup_move() please just keep the align_set() only. -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 16:29:02 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:42 PM, ChunEon Park hermet@naver.com wrote: Abosulte position for the popup is insane if the parent position is changed. And totally popup is depends on the notify, it should follow the notify concept. Agreed. I also suggested to create elm_popup_align_set() instead of this. And he suggested elm_popup_move() to use pixel which I found it useful. Because the author of this commit is away, I will fix it before the today's feature freeze: 1. adding elm_popup_align_set() 2. fixing elm_popup_move() to depend on its parent position. 3. (optional) adding elm_notify_move() to use pixel Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
scalabiity = daynamically resized popup area. -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyu...@gmail.com To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net; Cc: g...@lists.enlightenment.org; Sent: 2013-11-08 (금) 13:58:32 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Fri, Nov 8, 2013 at 1:47 PM, ChunEon Park hermet@naver.com wrote: Convenient ok. but convenient API even should not break the concept. It does not break popup concept. It is still relative to its parent once the patch is revised as I mentioned earlier. The api sound like it does not care the scalability and popup concept. What do you mean by scalability here? Any example? That is nothing to do with scalability. If application uses coordinate, app will call elm_config_scale_get() * xxx. See all the APIs that use coordinate as a parameter. Thanks. Daniel Juyung Seo (SeoZ) If you really intended that popup does not care the scalability, then ie, elm_popup_fixed_pos_set() will be nicer to me. or not, then align_set() should be there. If more other people agree on the API addition, then I will not care this anymore. Thanks. -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-08 (금) 09:06:45 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 7:05 PM, ChunEon Park hermet@naver.com wrote: It says in popup doc. * The popup widget displays its content with a particular orientation in * the parent area. I already read that but that does not mean we can not add this api. Notify already has align_set which we can position notify wherever we want. Popup is a wrapper of notify and utility widget for convenience. It should be convenicent and easy to use. Absulte coordinates would break this action. People hardly understand if they use that kind of API. If they call elm_popup_move(100, 100); then popup should be (100, 100) position. But in some case if the parent is moved to 200, 200, then will you keep the popup position (100, 100)? You're right. elm_popup_move() should be changed to be relative to its parent. I missed that part. It should keep using coordinate but relative to its parent. The patch needs to be revised. if the popup is moved to 200, 200, then user may understand this behavior is bug. Relative value is simple and easy to understand in this case. But in a real life case, especially a product, we use pixel more than relative values. So without elm_popup_move, applications should track the parent geometry change and calculate parent geometry and itself all the time to give a relative paramters to elm_popup_align_set. I can easily imagine troubles already. Anyhow, there is no rush on this patch. We can just create and use elm_popup_align_set() and do all the calculations in the application side which will be so redundant among many apps. Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 18:19:16 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 5:14 PM, ChunEon Park hermet@naver.com wrote: Regardless of the API useful, I don't agree pushing the API at this moment. It wil break popup concept. otherwise, similiar behavior of move() and align() will be conflicted. How does that break popup concept? That's interesting. Where is it described? Daniel Juyung Seo (SeoZ) if you agree align_set() can cover the popup_move() please just keep the align_set() only. -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 16:29:02 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:42 PM, ChunEon Park hermet@naver.com wrote: Abosulte position for the popup is insane if the parent position is changed. And totally popup is depends on the notify, it should follow the notify concept. Agreed. I also suggested to create elm_popup_align_set() instead of this. And he suggested elm_popup_move() to use pixel which I
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
Regardless of the API useful, I don't agree pushing the API at this moment.
It wil break popup concept. otherwise, similiar behavior of move() and align()
will be conflicted.
if you agree align_set() can cover the popup_move()
please just keep the align_set() only.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net;
Cc: g...@lists.enlightenment.org;
Sent: 2013-11-04 (월) 16:29:02
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added
support for popup move. elm_popup_move.
On Mon, Nov 4, 2013 at 2:42 PM, ChunEon Park hermet@naver.com wrote:
Abosulte position for the popup is insane if the parent position is
changed.
And totally popup is depends on the notify, it should follow the notify
concept.
Agreed. I also suggested to create elm_popup_align_set() instead of this.
And he suggested elm_popup_move() to use pixel which I found it useful.
Because the author of this commit is away, I will fix it before the today's
feature freeze:
1. adding elm_popup_align_set()
2. fixing elm_popup_move() to depend on its parent position.
3. (optional) adding elm_notify_move() to use pixel
Thanks.
Daniel Juyung Seo (SeoZ)
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyung2@gmail.com
To: Enlightenment developer list
enlightenment-devel@lists.sourceforge.net;
Cc: git@lists.enlightenment.org;
Sent: 2013-11-04 (월) 14:37:54
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added
support for popup move. elm_popup_move.
On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park hermet@naver.com wrote:
Eek!
How about keeping the API name with notify?
elm_notify_align_set()?
Thanks for the interest and comments but the concept is different from
align_set.
elm_notify_align_set() gets relative position as a parameter but
elm_popup_move() gets absolute pixel information just like elm_menu_move().
So elm_popup_move() is correct.
EAPI void elm_notify_align_set(Evas_Object *obj,
double horizontal, double vertical);
EAPI void elm_menu_move(Evas_Object *obj,
Evas_Coord x, Evas_Coord y);
EAPI void elm_popup_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y);
Thanks.
Daniel Juyung Seo (SeoZ)
-Regards, Hermet-
-Original Message-
From: Abhinandan Aryadiptaa.aryadipta@samsung.com
To: git@lists.enlightenment.org;
Cc:
Sent: 2013-11-03 (일) 23:29:06
Subject: [EGIT] [core/elementary] master 01/01: popup: Added support for
popup move. elm_popup_move.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
Author: Abhinandan Aryadipta a.aryadipta@samsung.com
Date: Sun Nov 3 23:01:19 2013 +0900
popup: Added support for popup move. elm_popup_move.
Summary: Added support for popup move
Test Plan: elm_popup_move
Reviewers: seoz, singh.amitesh, tasn, Hermet
CC: raster
Differential Revision: https://phab.enlightenment.org/D247
---
ChangeLog4
NEWS 1 +
src/bin/test_popup.c58
++
src/lib/elc_popup.c 41
src/lib/elc_popup_eo.h 14 +++
src/lib/elc_popup_legacy.h 15
6 files changed, 133 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 66e4536..434f65f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1741,3 +1741,7 @@
* genlist , gengrid: Add
ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL.
It disallow multiple selection when clicked without control
pressed although
multiple selection is enabled.
+
+2013-10-03 Abhinandan Aryadipta (aryarockstar)
+
+* Popup - Added elm_popup_move() api.
diff --git a/NEWS b/NEWS
index 4ba58bf..fece1e7 100644
--- a/NEWS
+++ b/NEWS
@@ -102,6 +102,7 @@ Additions:
* Add virtualkeypad,size,changed callback on virtualkeypad min size
change for conformant.
* Add elm_slider_step_get(), elm_slider_step_set() for slider.
* Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL select mode for
genlist/gengrid.
+ * Add support elm_popup_move() for popup.
Improvements:
diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
index fa2d06e..945c3df 100644
--- a/src/bin/test_popup.c
+++ b/src/bin/test_popup.c
@@ -22,6 +22,35 @@ _popup_close_cb(void *data, Evas_Object *obj
EINA_UNUSED,
}
static void
+_popup_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ static int
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
On Mon, Nov 4, 2013 at 5:14 PM, ChunEon Park her...@naver.com wrote: Regardless of the API useful, I don't agree pushing the API at this moment. It wil break popup concept. otherwise, similiar behavior of move() and align() will be conflicted. How does that break popup concept? That's interesting. Where is it described? Daniel Juyung Seo (SeoZ) if you agree align_set() can cover the popup_move() please just keep the align_set() only. -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyu...@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: g...@lists.enlightenment.org; Sent: 2013-11-04 (월) 16:29:02 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:42 PM, ChunEon Park hermet@naver.com wrote: Abosulte position for the popup is insane if the parent position is changed. And totally popup is depends on the notify, it should follow the notify concept. Agreed. I also suggested to create elm_popup_align_set() instead of this. And he suggested elm_popup_move() to use pixel which I found it useful. Because the author of this commit is away, I will fix it before the today's feature freeze: 1. adding elm_popup_align_set() 2. fixing elm_popup_move() to depend on its parent position. 3. (optional) adding elm_notify_move() to use pixel Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 14:37:54 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park hermet@naver.com wrote: Eek! How about keeping the API name with notify? elm_notify_align_set()? Thanks for the interest and comments but the concept is different from align_set. elm_notify_align_set() gets relative position as a parameter but elm_popup_move() gets absolute pixel information just like elm_menu_move(). So elm_popup_move() is correct. EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_menu_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y); EAPI void elm_popup_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y); Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Abhinandan Aryadiptaa.aryadipta@samsung.com To: git@lists.enlightenment.org; Cc: Sent: 2013-11-03 (일) 23:29:06 Subject: [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e Author: Abhinandan Aryadipta a.aryadipta@samsung.com Date: Sun Nov 3 23:01:19 2013 +0900 popup: Added support for popup move. elm_popup_move. Summary: Added support for popup move Test Plan: elm_popup_move Reviewers: seoz, singh.amitesh, tasn, Hermet CC: raster Differential Revision: https://phab.enlightenment.org/D247 --- ChangeLog4 NEWS 1 + src/bin/test_popup.c58 ++ src/lib/elc_popup.c 41 src/lib/elc_popup_eo.h 14 +++ src/lib/elc_popup_legacy.h 15 6 files changed, 133 insertions(+) diff --git a/ChangeLog b/ChangeLog index 66e4536..434f65f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1741,3 +1741,7 @@ * genlist , gengrid: Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL. It disallow multiple selection when clicked without control pressed although multiple selection is enabled. + +2013-10-03 Abhinandan Aryadipta (aryarockstar) + +* Popup - Added elm_popup_move() api. diff --git a/NEWS b/NEWS index 4ba58bf..fece1e7 100644 --- a/NEWS +++ b/NEWS @@ -102,6 +102,7 @@ Additions: * Add virtualkeypad,size,changed callback on virtualkeypad min size change for conformant. * Add elm_slider_step_get(), elm_slider_step_set() for slider. * Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL select mode for genlist/gengrid. + * Add support elm_popup_move() for popup. Improvements: diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
It says in popup doc. * The popup widget displays its content with a particular orientation in * the parent area. Absulte coordinates would break this action. People hardly understand if they use that kind of API. If they call elm_popup_move(100, 100); then popup should be (100, 100) position. But in some case if the parent is moved to 200, 200, then will you keep the popup position (100, 100)? if the popup is moved to 200, 200, then user may understand this behavior is bug. Relative value is simple and easy to understand in this case. -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyu...@gmail.com To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net; Cc: g...@lists.enlightenment.org; Sent: 2013-11-04 (월) 18:19:16 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 5:14 PM, ChunEon Park hermet@naver.com wrote: Regardless of the API useful, I don't agree pushing the API at this moment. It wil break popup concept. otherwise, similiar behavior of move() and align() will be conflicted. How does that break popup concept? That's interesting. Where is it described? Daniel Juyung Seo (SeoZ) if you agree align_set() can cover the popup_move() please just keep the align_set() only. -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 16:29:02 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:42 PM, ChunEon Park hermet@naver.com wrote: Abosulte position for the popup is insane if the parent position is changed. And totally popup is depends on the notify, it should follow the notify concept. Agreed. I also suggested to create elm_popup_align_set() instead of this. And he suggested elm_popup_move() to use pixel which I found it useful. Because the author of this commit is away, I will fix it before the today's feature freeze: 1. adding elm_popup_align_set() 2. fixing elm_popup_move() to depend on its parent position. 3. (optional) adding elm_notify_move() to use pixel Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Daniel Juyung Seoseojuyung2@gmail.com To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net; Cc: git@lists.enlightenment.org; Sent: 2013-11-04 (월) 14:37:54 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park hermet@naver.com wrote: Eek! How about keeping the API name with notify? elm_notify_align_set()? Thanks for the interest and comments but the concept is different from align_set. elm_notify_align_set() gets relative position as a parameter but elm_popup_move() gets absolute pixel information just like elm_menu_move(). So elm_popup_move() is correct. EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_menu_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y); EAPI void elm_popup_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y); Thanks. Daniel Juyung Seo (SeoZ) -Regards, Hermet- -Original Message- From: Abhinandan Aryadiptaa.aryadipta@samsung.com To: git@lists.enlightenment.org; Cc: Sent: 2013-11-03 (일) 23:29:06 Subject: [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move. seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e Author: Abhinandan Aryadipta a.aryadipta@samsung.com Date: Sun Nov 3 23:01:19 2013 +0900 popup: Added support for popup move. elm_popup_move. Summary: Added support for popup move Test Plan: elm_popup_move Reviewers: seoz, singh.amitesh, tasn, Hermet CC: raster Differential Revision: https://phab.enlightenment.org/D247 --- ChangeLog4 NEWS 1 + src/bin/test_popup.c58 ++ src/lib/elc_popup.c 41 src/lib/elc_popup_eo.h 14 +++ src/lib/elc_popup_legacy.h 15 6 files changed, 133 insertions(+) diff --git a/ChangeLog b/ChangeLog index
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
Eek!
How about keeping the API name with notify?
elm_notify_align_set()?
-Regards, Hermet-
-Original Message-
From: Abhinandan Aryadiptaa.aryadi...@samsung.com
To: g...@lists.enlightenment.org;
Cc:
Sent: 2013-11-03 (일) 23:29:06
Subject: [EGIT] [core/elementary] master 01/01: popup: Added support for popup
move. elm_popup_move.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
Author: Abhinandan Aryadipta a.aryadipta@samsung.com
Date: Sun Nov 3 23:01:19 2013 +0900
popup: Added support for popup move. elm_popup_move.
Summary: Added support for popup move
Test Plan: elm_popup_move
Reviewers: seoz, singh.amitesh, tasn, Hermet
CC: raster
Differential Revision: https://phab.enlightenment.org/D247
---
ChangeLog4
NEWS 1 +
src/bin/test_popup.c58 ++
src/lib/elc_popup.c 41
src/lib/elc_popup_eo.h 14 +++
src/lib/elc_popup_legacy.h 15
6 files changed, 133 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 66e4536..434f65f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1741,3 +1741,7 @@
* genlist , gengrid: Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL.
It disallow multiple selection when clicked without control pressed
although
multiple selection is enabled.
+
+2013-10-03 Abhinandan Aryadipta (aryarockstar)
+
+* Popup - Added elm_popup_move() api.
diff --git a/NEWS b/NEWS
index 4ba58bf..fece1e7 100644
--- a/NEWS
+++ b/NEWS
@@ -102,6 +102,7 @@ Additions:
* Add virtualkeypad,size,changed callback on virtualkeypad min size
change for conformant.
* Add elm_slider_step_get(), elm_slider_step_set() for slider.
* Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL select mode for
genlist/gengrid.
+ * Add support elm_popup_move() for popup.
Improvements:
diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
index fa2d06e..945c3df 100644
--- a/src/bin/test_popup.c
+++ b/src/bin/test_popup.c
@@ -22,6 +22,35 @@ _popup_close_cb(void *data, Evas_Object *obj EINA_UNUSED,
}
static void
+_popup_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ static int k=0;
+
+ if (k == 0)
+ elm_popup_move(data, -10, 50);//negative x
+ else if (k == 1)
+ elm_popup_move(data, 40, -100);//negative y
+ else if (k == 2)
+ elm_popup_move(data, 0, 0);//zero x zero y
+ else if (k == 3)
+ elm_popup_move(data, 40, 50);
+ else if (k == 4)
+ elm_popup_move(data, 80, 100);
+ else if (k == 5)
+ elm_popup_move(data, 120, 150);
+ else if (k == 6)
+ elm_popup_move(data, 160, 200);
+ else if (k == 7)
+ elm_popup_move(data, 500, );//excess y
+ else
+ elm_popup_move(data, , 500);//excess x
+ k++;
+ if (k 8)
+ k = 0;
+}
+
+static void
_g_popup_response_cb(void *data, Evas_Object *obj EINA_UNUSED,
void *event_info EINA_UNUSED)
{
@@ -467,6 +496,33 @@ _popup_transparent_cb(void *data, Evas_Object *obj
EINA_UNUSED,
}
static void
+_popup_transparent_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ Evas_Object *popup;
+ Evas_Object *btn, *btn1;
+
+ popup = elm_popup_add(data);
+ elm_object_style_set(popup, transparent);
+ elm_object_text_set(popup, This Popup has transparent background);
+
+ // popup buttons
+ btn = elm_button_add(popup);
+ elm_object_text_set(btn, Move);
+ elm_object_part_content_set(popup, button1, btn);
+ evas_object_smart_callback_add(btn, clicked, _popup_move_cb, popup);
+
+ btn1 = elm_button_add(popup);
+ elm_object_text_set(btn1, Close);
+ elm_object_part_content_set(popup, button2, btn1);
+ evas_object_smart_callback_add(btn1, clicked, _popup_close_cb, popup);
+
+ // popup show should be called after adding all the contents and the buttons
+ // of popup to set the focus into popup's contents correctly.
+ evas_object_show(popup);
+}
+
+static void
_list_cb(void *data, Evas_Object *obj EINA_UNUSED, void *event_info
EINA_UNUSED)
{
evas_object_del(data);
@@ -543,6 +599,8 @@ test_popup(void *data EINA_UNUSED, Evas_Object *obj
EINA_UNUSED,
_popup_center_text_3button_add_remove_button_cb, win);
elm_list_item_append(list, popup-transparent, NULL, NULL,
_popup_transparent_cb, win);
+ elm_list_item_append(list, popup-transparent-move, NULL, NULL,
+_popup_transparent_move_cb, win);
elm_list_item_append(list, popup-center-title + list content + 1 button,
NULL, NULL,
_popup_center_title_list_content_1button_cb,
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park her...@naver.com wrote:
Eek!
How about keeping the API name with notify?
elm_notify_align_set()?
Thanks for the interest and comments but the concept is different from
align_set.
elm_notify_align_set() gets relative position as a parameter but
elm_popup_move() gets absolute pixel information just like elm_menu_move().
So elm_popup_move() is correct.
EAPI void elm_notify_align_set(Evas_Object *obj,
double horizontal, double vertical);
EAPI void elm_menu_move(Evas_Object *obj,
Evas_Coord x, Evas_Coord y);
EAPI void elm_popup_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y);
Thanks.
Daniel Juyung Seo (SeoZ)
-Regards, Hermet-
-Original Message-
From: Abhinandan Aryadiptaa.aryadi...@samsung.com
To: g...@lists.enlightenment.org;
Cc:
Sent: 2013-11-03 (일) 23:29:06
Subject: [EGIT] [core/elementary] master 01/01: popup: Added support for
popup move. elm_popup_move.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
Author: Abhinandan Aryadipta a.aryadipta@samsung.com
Date: Sun Nov 3 23:01:19 2013 +0900
popup: Added support for popup move. elm_popup_move.
Summary: Added support for popup move
Test Plan: elm_popup_move
Reviewers: seoz, singh.amitesh, tasn, Hermet
CC: raster
Differential Revision: https://phab.enlightenment.org/D247
---
ChangeLog4
NEWS 1 +
src/bin/test_popup.c58
++
src/lib/elc_popup.c 41
src/lib/elc_popup_eo.h 14 +++
src/lib/elc_popup_legacy.h 15
6 files changed, 133 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 66e4536..434f65f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1741,3 +1741,7 @@
* genlist , gengrid: Add
ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL.
It disallow multiple selection when clicked without control
pressed although
multiple selection is enabled.
+
+2013-10-03 Abhinandan Aryadipta (aryarockstar)
+
+* Popup - Added elm_popup_move() api.
diff --git a/NEWS b/NEWS
index 4ba58bf..fece1e7 100644
--- a/NEWS
+++ b/NEWS
@@ -102,6 +102,7 @@ Additions:
* Add virtualkeypad,size,changed callback on virtualkeypad min size
change for conformant.
* Add elm_slider_step_get(), elm_slider_step_set() for slider.
* Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL select mode for
genlist/gengrid.
+ * Add support elm_popup_move() for popup.
Improvements:
diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
index fa2d06e..945c3df 100644
--- a/src/bin/test_popup.c
+++ b/src/bin/test_popup.c
@@ -22,6 +22,35 @@ _popup_close_cb(void *data, Evas_Object *obj
EINA_UNUSED,
}
static void
+_popup_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ static int k=0;
+
+ if (k == 0)
+ elm_popup_move(data, -10, 50);//negative x
+ else if (k == 1)
+ elm_popup_move(data, 40, -100);//negative y
+ else if (k == 2)
+ elm_popup_move(data, 0, 0);//zero x zero y
+ else if (k == 3)
+ elm_popup_move(data, 40, 50);
+ else if (k == 4)
+ elm_popup_move(data, 80, 100);
+ else if (k == 5)
+ elm_popup_move(data, 120, 150);
+ else if (k == 6)
+ elm_popup_move(data, 160, 200);
+ else if (k == 7)
+ elm_popup_move(data, 500, );//excess y
+ else
+ elm_popup_move(data, , 500);//excess x
+ k++;
+ if (k 8)
+ k = 0;
+}
+
+static void
_g_popup_response_cb(void *data, Evas_Object *obj EINA_UNUSED,
void *event_info EINA_UNUSED)
{
@@ -467,6 +496,33 @@ _popup_transparent_cb(void *data, Evas_Object *obj
EINA_UNUSED,
}
static void
+_popup_transparent_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ Evas_Object *popup;
+ Evas_Object *btn, *btn1;
+
+ popup = elm_popup_add(data);
+ elm_object_style_set(popup, transparent);
+ elm_object_text_set(popup, This Popup has transparent background);
+
+ // popup buttons
+ btn = elm_button_add(popup);
+ elm_object_text_set(btn, Move);
+ elm_object_part_content_set(popup, button1, btn);
+ evas_object_smart_callback_add(btn, clicked, _popup_move_cb, popup);
+
+ btn1 = elm_button_add(popup);
+ elm_object_text_set(btn1, Close);
+ elm_object_part_content_set(popup, button2, btn1);
+ evas_object_smart_callback_add(btn1, clicked, _popup_close_cb,
popup);
+
+ // popup show should be called after adding all the contents and the
buttons
+ // of popup to set the focus into popup's contents correctly.
+
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
align_set is proper for the popup if the popup area is depends on the parent.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net;
Cc: g...@lists.enlightenment.org;
Sent: 2013-11-04 (월) 14:37:54
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added
support for popup move. elm_popup_move.
On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park hermet@naver.com wrote:
Eek!
How about keeping the API name with notify?
elm_notify_align_set()?
Thanks for the interest and comments but the concept is different from
align_set.
elm_notify_align_set() gets relative position as a parameter but
elm_popup_move() gets absolute pixel information just like elm_menu_move().
So elm_popup_move() is correct.
EAPI void elm_notify_align_set(Evas_Object *obj,
double horizontal, double vertical);
EAPI void elm_menu_move(Evas_Object *obj,
Evas_Coord x, Evas_Coord y);
EAPI void elm_popup_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y);
Thanks.
Daniel Juyung Seo (SeoZ)
-Regards, Hermet-
-Original Message-
From: Abhinandan Aryadiptaa.aryadipta@samsung.com
To: git@lists.enlightenment.org;
Cc:
Sent: 2013-11-03 (일) 23:29:06
Subject: [EGIT] [core/elementary] master 01/01: popup: Added support for
popup move. elm_popup_move.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
Author: Abhinandan Aryadipta a.aryadipta@samsung.com
Date: Sun Nov 3 23:01:19 2013 +0900
popup: Added support for popup move. elm_popup_move.
Summary: Added support for popup move
Test Plan: elm_popup_move
Reviewers: seoz, singh.amitesh, tasn, Hermet
CC: raster
Differential Revision: https://phab.enlightenment.org/D247
---
ChangeLog4
NEWS 1 +
src/bin/test_popup.c58
++
src/lib/elc_popup.c 41
src/lib/elc_popup_eo.h 14 +++
src/lib/elc_popup_legacy.h 15
6 files changed, 133 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 66e4536..434f65f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1741,3 +1741,7 @@
* genlist , gengrid: Add
ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL.
It disallow multiple selection when clicked without control
pressed although
multiple selection is enabled.
+
+2013-10-03 Abhinandan Aryadipta (aryarockstar)
+
+* Popup - Added elm_popup_move() api.
diff --git a/NEWS b/NEWS
index 4ba58bf..fece1e7 100644
--- a/NEWS
+++ b/NEWS
@@ -102,6 +102,7 @@ Additions:
* Add virtualkeypad,size,changed callback on virtualkeypad min size
change for conformant.
* Add elm_slider_step_get(), elm_slider_step_set() for slider.
* Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL select mode for
genlist/gengrid.
+ * Add support elm_popup_move() for popup.
Improvements:
diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
index fa2d06e..945c3df 100644
--- a/src/bin/test_popup.c
+++ b/src/bin/test_popup.c
@@ -22,6 +22,35 @@ _popup_close_cb(void *data, Evas_Object *obj
EINA_UNUSED,
}
static void
+_popup_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ static int k=0;
+
+ if (k == 0)
+ elm_popup_move(data, -10, 50);//negative x
+ else if (k == 1)
+ elm_popup_move(data, 40, -100);//negative y
+ else if (k == 2)
+ elm_popup_move(data, 0, 0);//zero x zero y
+ else if (k == 3)
+ elm_popup_move(data, 40, 50);
+ else if (k == 4)
+ elm_popup_move(data, 80, 100);
+ else if (k == 5)
+ elm_popup_move(data, 120, 150);
+ else if (k == 6)
+ elm_popup_move(data, 160, 200);
+ else if (k == 7)
+ elm_popup_move(data, 500, );//excess y
+ else
+ elm_popup_move(data, , 500);//excess x
+ k++;
+ if (k 8)
+ k = 0;
+}
+
+static void
_g_popup_response_cb(void *data, Evas_Object *obj EINA_UNUSED,
void *event_info EINA_UNUSED)
{
@@ -467,6 +496,33 @@ _popup_transparent_cb(void *data, Evas_Object *obj
EINA_UNUSED,
}
static void
+_popup_transparent_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ Evas_Object *popup;
+ Evas_Object *btn, *btn1;
+
+ popup = elm_popup_add(data);
+ elm_object_style_set(popup, transparent);
+ elm_object_text_set(popup, This Popup has transparent background);
+
+ // popup buttons
+ btn = elm_button_add(popup);
+ elm_object_text_set(btn, Move
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
Abosulte position for the popup is insane if the parent position is changed.
And totally popup is depends on the notify, it should follow the notify concept.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net;
Cc: g...@lists.enlightenment.org;
Sent: 2013-11-04 (월) 14:37:54
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added
support for popup move. elm_popup_move.
On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park hermet@naver.com wrote:
Eek!
How about keeping the API name with notify?
elm_notify_align_set()?
Thanks for the interest and comments but the concept is different from
align_set.
elm_notify_align_set() gets relative position as a parameter but
elm_popup_move() gets absolute pixel information just like elm_menu_move().
So elm_popup_move() is correct.
EAPI void elm_notify_align_set(Evas_Object *obj,
double horizontal, double vertical);
EAPI void elm_menu_move(Evas_Object *obj,
Evas_Coord x, Evas_Coord y);
EAPI void elm_popup_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y);
Thanks.
Daniel Juyung Seo (SeoZ)
-Regards, Hermet-
-Original Message-
From: Abhinandan Aryadiptaa.aryadipta@samsung.com
To: git@lists.enlightenment.org;
Cc:
Sent: 2013-11-03 (일) 23:29:06
Subject: [EGIT] [core/elementary] master 01/01: popup: Added support for
popup move. elm_popup_move.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
Author: Abhinandan Aryadipta a.aryadipta@samsung.com
Date: Sun Nov 3 23:01:19 2013 +0900
popup: Added support for popup move. elm_popup_move.
Summary: Added support for popup move
Test Plan: elm_popup_move
Reviewers: seoz, singh.amitesh, tasn, Hermet
CC: raster
Differential Revision: https://phab.enlightenment.org/D247
---
ChangeLog4
NEWS 1 +
src/bin/test_popup.c58
++
src/lib/elc_popup.c 41
src/lib/elc_popup_eo.h 14 +++
src/lib/elc_popup_legacy.h 15
6 files changed, 133 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 66e4536..434f65f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1741,3 +1741,7 @@
* genlist , gengrid: Add
ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL.
It disallow multiple selection when clicked without control
pressed although
multiple selection is enabled.
+
+2013-10-03 Abhinandan Aryadipta (aryarockstar)
+
+* Popup - Added elm_popup_move() api.
diff --git a/NEWS b/NEWS
index 4ba58bf..fece1e7 100644
--- a/NEWS
+++ b/NEWS
@@ -102,6 +102,7 @@ Additions:
* Add virtualkeypad,size,changed callback on virtualkeypad min size
change for conformant.
* Add elm_slider_step_get(), elm_slider_step_set() for slider.
* Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL select mode for
genlist/gengrid.
+ * Add support elm_popup_move() for popup.
Improvements:
diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
index fa2d06e..945c3df 100644
--- a/src/bin/test_popup.c
+++ b/src/bin/test_popup.c
@@ -22,6 +22,35 @@ _popup_close_cb(void *data, Evas_Object *obj
EINA_UNUSED,
}
static void
+_popup_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ static int k=0;
+
+ if (k == 0)
+ elm_popup_move(data, -10, 50);//negative x
+ else if (k == 1)
+ elm_popup_move(data, 40, -100);//negative y
+ else if (k == 2)
+ elm_popup_move(data, 0, 0);//zero x zero y
+ else if (k == 3)
+ elm_popup_move(data, 40, 50);
+ else if (k == 4)
+ elm_popup_move(data, 80, 100);
+ else if (k == 5)
+ elm_popup_move(data, 120, 150);
+ else if (k == 6)
+ elm_popup_move(data, 160, 200);
+ else if (k == 7)
+ elm_popup_move(data, 500, );//excess y
+ else
+ elm_popup_move(data, , 500);//excess x
+ k++;
+ if (k 8)
+ k = 0;
+}
+
+static void
_g_popup_response_cb(void *data, Evas_Object *obj EINA_UNUSED,
void *event_info EINA_UNUSED)
{
@@ -467,6 +496,33 @@ _popup_transparent_cb(void *data, Evas_Object *obj
EINA_UNUSED,
}
static void
+_popup_transparent_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ Evas_Object *popup;
+ Evas_Object *btn, *btn1;
+
+ popup = elm_popup_add(data);
+ elm_object_style_set(popup, transparent);
+ elm_object_text_set(popup, This Popup has transparent background);
+
+ // popup buttons
+ btn
Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added support for popup move. elm_popup_move.
On Mon, Nov 4, 2013 at 2:42 PM, ChunEon Park her...@naver.com wrote:
Abosulte position for the popup is insane if the parent position is
changed.
And totally popup is depends on the notify, it should follow the notify
concept.
Agreed. I also suggested to create elm_popup_align_set() instead of this.
And he suggested elm_popup_move() to use pixel which I found it useful.
Because the author of this commit is away, I will fix it before the today's
feature freeze:
1. adding elm_popup_align_set()
2. fixing elm_popup_move() to depend on its parent position.
3. (optional) adding elm_notify_move() to use pixel
Thanks.
Daniel Juyung Seo (SeoZ)
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: Enlightenment developer list
enlightenment-devel@lists.sourceforge.net;
Cc: g...@lists.enlightenment.org;
Sent: 2013-11-04 (월) 14:37:54
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: popup: Added
support for popup move. elm_popup_move.
On Mon, Nov 4, 2013 at 2:31 PM, ChunEon Park hermet@naver.com wrote:
Eek!
How about keeping the API name with notify?
elm_notify_align_set()?
Thanks for the interest and comments but the concept is different from
align_set.
elm_notify_align_set() gets relative position as a parameter but
elm_popup_move() gets absolute pixel information just like elm_menu_move().
So elm_popup_move() is correct.
EAPI void elm_notify_align_set(Evas_Object *obj,
double horizontal, double vertical);
EAPI void elm_menu_move(Evas_Object *obj,
Evas_Coord x, Evas_Coord y);
EAPI void elm_popup_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y);
Thanks.
Daniel Juyung Seo (SeoZ)
-Regards, Hermet-
-Original Message-
From: Abhinandan Aryadiptaa.aryadipta@samsung.com
To: git@lists.enlightenment.org;
Cc:
Sent: 2013-11-03 (일) 23:29:06
Subject: [EGIT] [core/elementary] master 01/01: popup: Added support for
popup move. elm_popup_move.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
commit f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e
Author: Abhinandan Aryadipta a.aryadipta@samsung.com
Date: Sun Nov 3 23:01:19 2013 +0900
popup: Added support for popup move. elm_popup_move.
Summary: Added support for popup move
Test Plan: elm_popup_move
Reviewers: seoz, singh.amitesh, tasn, Hermet
CC: raster
Differential Revision: https://phab.enlightenment.org/D247
---
ChangeLog4
NEWS 1 +
src/bin/test_popup.c58
++
src/lib/elc_popup.c 41
src/lib/elc_popup_eo.h 14 +++
src/lib/elc_popup_legacy.h 15
6 files changed, 133 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 66e4536..434f65f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1741,3 +1741,7 @@
* genlist , gengrid: Add
ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL.
It disallow multiple selection when clicked without control
pressed although
multiple selection is enabled.
+
+2013-10-03 Abhinandan Aryadipta (aryarockstar)
+
+* Popup - Added elm_popup_move() api.
diff --git a/NEWS b/NEWS
index 4ba58bf..fece1e7 100644
--- a/NEWS
+++ b/NEWS
@@ -102,6 +102,7 @@ Additions:
* Add virtualkeypad,size,changed callback on virtualkeypad min size
change for conformant.
* Add elm_slider_step_get(), elm_slider_step_set() for slider.
* Add ELM_OBJECT_MULTIPLE_SELECT_MODE_WITH_CONTROL select mode for
genlist/gengrid.
+ * Add support elm_popup_move() for popup.
Improvements:
diff --git a/src/bin/test_popup.c b/src/bin/test_popup.c
index fa2d06e..945c3df 100644
--- a/src/bin/test_popup.c
+++ b/src/bin/test_popup.c
@@ -22,6 +22,35 @@ _popup_close_cb(void *data, Evas_Object *obj
EINA_UNUSED,
}
static void
+_popup_move_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+ static int k=0;
+
+ if (k == 0)
+ elm_popup_move(data, -10, 50);//negative x
+ else if (k == 1)
+ elm_popup_move(data, 40, -100);//negative y
+ else if (k == 2)
+ elm_popup_move(data, 0, 0);//zero x zero y
+ else if (k == 3)
+ elm_popup_move(data, 40, 50);
+ else if (k == 4)
+ elm_popup_move(data, 80, 100);
+ else if (k == 5)
+ elm_popup_move(data, 120, 150);
+ else if (k == 6)
+ elm_popup_move(data, 160, 200);
+ else if (k == 7)
+ elm_popup_move(data, 500, );//excess y
+ else
+ elm_popup_move(data, , 500);//excess x
+ k++;
+ if (k 8)
+ k = 0
