Re: [E-devel] E SVN: cedric trunk/e_dbus/src/lib/hal
On Tue, Nov 8, 2011 at 3:39 AM, Mike Blumenkrantz m...@zentific.com wrote: On Sun, 6 Nov 2011 02:21:57 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: e_dbus: e_hal use some e_ukit function so we should init it. Author: cedric Date: 2011-11-06 02:21:57 -0800 (Sun, 06 Nov 2011) New Revision: 64809 Trac: http://trac.enlightenment.org/e/changeset/64809 Modified: trunk/e_dbus/src/lib/hal/Makefile.am trunk/e_dbus/src/lib/hal/e_hal_main.c no. just...no. You could have fixed it correctly instead. Now we are using function in hal from ukit without initilizing it. The problem are with people that do compile with -no-undefine or disable ukit. By reverting, you don't solve anything. -- Cedric BAIL -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/e_dbus/src/lib/hal
On Tue, Nov 8, 2011 at 10:03, Cedric BAIL cedric.b...@free.fr wrote: On Tue, Nov 8, 2011 at 3:39 AM, Mike Blumenkrantz m...@zentific.com wrote: On Sun, 6 Nov 2011 02:21:57 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: e_dbus: e_hal use some e_ukit function so we should init it. Author: cedric Date: 2011-11-06 02:21:57 -0800 (Sun, 06 Nov 2011) New Revision: 64809 Trac: http://trac.enlightenment.org/e/changeset/64809 Modified: trunk/e_dbus/src/lib/hal/Makefile.am trunk/e_dbus/src/lib/hal/e_hal_main.c no. just...no. You could have fixed it correctly instead. Now we are using function in hal from ukit without initilizing it. The problem are with people that do compile with -no-undefine or disable ukit. By reverting, you don't solve anything. -- Cedric BAIL Btw, HAL is used (and fixed) on BSDs. -- Boris Faure -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/e_dbus/src/lib/hal
On Sun, 6 Nov 2011 02:21:57 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: e_dbus: e_hal use some e_ukit function so we should init it. Author: cedric Date: 2011-11-06 02:21:57 -0800 (Sun, 06 Nov 2011) New Revision: 64809 Trac: http://trac.enlightenment.org/e/changeset/64809 Modified: trunk/e_dbus/src/lib/hal/Makefile.am trunk/e_dbus/src/lib/hal/e_hal_main.c no. just...no. -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/e_dbus/src/lib/hal
On Sun, 6 Nov 2011 02:21:57 -0800
Enlightenment SVN no-re...@enlightenment.org wrote:
Log:
e_dbus: e_hal use some e_ukit function so we should init it.
Author: cedric
Date: 2011-11-06 02:21:57 -0800 (Sun, 06 Nov 2011)
New Revision: 64809
Trac: http://trac.enlightenment.org/e/changeset/64809
Modified:
trunk/e_dbus/src/lib/hal/Makefile.am trunk/e_dbus/src/lib/hal/e_hal_main.c
Modified: trunk/e_dbus/src/lib/hal/Makefile.am
===
--- trunk/e_dbus/src/lib/hal/Makefile.am 2011-11-06 10:17:03 UTC (rev
64808) +++ trunk/e_dbus/src/lib/hal/Makefile.am 2011-11-06 10:21:57
UTC (rev 64809) @@ -2,6 +2,7 @@
AM_CPPFLAGS = \
-I $(top_srcdir)/src/lib/dbus \
+-I $(top_srcdir)/src/lib/ukit \
@EDBUS_CFLAGS@
lib_LTLIBRARIES = libehal.la
Modified: trunk/e_dbus/src/lib/hal/e_hal_main.c
===
--- trunk/e_dbus/src/lib/hal/e_hal_main.c 2011-11-06 10:17:03 UTC (rev
64808) +++ trunk/e_dbus/src/lib/hal/e_hal_main.c 2011-11-06 10:21:57
UTC (rev 64809) @@ -1,4 +1,5 @@
#include E_Hal.h
+#include E_Ukit.h
#include e_hal_private.h
int _e_dbus_hal_log_dom = -1;
@@ -26,8 +27,15 @@
goto unregister_log_domain;
}
+ if (!e_ukit_init()) {
+ ERR(Could not initialize E_UKit.);
+ goto shutdown_dbus;
+ }
+
return _e_dbus_hal_init_count;
+ shutdown_dbus:
+ e_dbus_shutdown();
unregister_log_domain:
eina_log_domain_unregister(_e_dbus_hal_log_dom);
_e_dbus_hal_log_dom = -1;
@@ -43,6 +51,7 @@
if (--_e_dbus_hal_init_count != 0)
return _e_dbus_hal_init_count;
+ e_ukit_shutdown();
e_dbus_shutdown();
eina_log_domain_unregister(_e_dbus_hal_log_dom);
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
err...what?
--
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.
--
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
