Re: [E-devel] Edje documentation patch
On Fri, Feb 26, 2010 at 4:26 PM, Eduardo Felipe wrote: > There you go. The doc_move_patch.txt must be applied over the doc_patch.txt. all in svn! thanks! -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Edje documentation patch
Ok. Edje has moved forward, and so did this patch. Now it's in sync with SVN again. Thanks! Eduardo. On Wed, Feb 24, 2010 at 2:28 AM, Eduardo Felipe wrote: > Hi folks! > > Since the adding of map capabilities to Edje, it's EDC Reference > documentation has been broken due to the inclusion of tags out of > proper order. That can be easily verified by going to > http://docs.enlightenment.org/auto/edje/edcref.html and looking at the > bottom part. > > So, I created this patch that contains no code change and just changes > the already existing documentation to be in order so Doxygen is nice > and produce the desired output. I also fixed a couple of spelling > errors, and some documentation error on an internal header (There's no > need to confuse new devs) > > If anything is wrong, please feel free to change. It was created with r46394. > > Cheers, > > Eduardo Felipe. > -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Edje documentation patch
On Thu, Feb 25, 2010 at 9:08 PM, Gustavo Sverzut Barbieri
wrote:
> On Wed, Feb 24, 2010 at 2:28 AM, Eduardo Felipe
> wrote:
>> Hi folks!
>>
>> Since the adding of map capabilities to Edje, it's EDC Reference
>> documentation has been broken due to the inclusion of tags out of
>> proper order. That can be easily verified by going to
>> http://docs.enlightenment.org/auto/edje/edcref.html and looking at the
>> bottom part.
>>
>> So, I created this patch that contains no code change and just changes
>> the already existing documentation to be in order so Doxygen is nice
>> and produce the desired output. I also fixed a couple of spelling
>> errors, and some documentation error on an internal header (There's no
>> need to confuse new devs)
>
> well this fails in "no code change":
>
>
> static void
> -st_collections_group_parts_part_description_map_rotation_center(void)
> +st_collections_group_parts_part_description_map_on(void)
> {
> Edje_Part_Collection *pc;
> Edje_Part *ep;
> @@ -5805,37 +5801,24 @@
>
> ed = ep->default_desc;
> if (ep->other_desc) ed =
> eina_list_data_get(eina_list_last(ep->other_desc));
> - {
> - char *name;
> -
> - name = parse_str(0);
> - data_queue_part_lookup(pc, name, &(ed->map.rot.id_center));
> - free(name);
> - }
> + ed->map.on = parse_bool(0);
> }
Unfortunately diffs do not track part moves. I changed a few functions
around so that the documentation could be built in the correct order.
The type of table based docs that EDC uses cares about order, so
that's why I changed it. If you apply the patch and view under a diff
tool you'll notice the move.
Should I not change the order of the functions, then the documentation
will be broken again as tags will appear under the wrong descriptor.
What do you suggest?
[]s
Eduardo Felipe.
>
> Please do a new patch with just documentation. The current version is
> quite confusing with things like that :-(
>
>
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --
> MSN: barbi...@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Edje documentation patch
On Fri, Feb 26, 2010 at 1:07 AM, Eduardo Felipe
wrote:
> On Thu, Feb 25, 2010 at 9:08 PM, Gustavo Sverzut Barbieri
> wrote:
>> On Wed, Feb 24, 2010 at 2:28 AM, Eduardo Felipe
>> wrote:
>>> Hi folks!
>>>
>>> Since the adding of map capabilities to Edje, it's EDC Reference
>>> documentation has been broken due to the inclusion of tags out of
>>> proper order. That can be easily verified by going to
>>> http://docs.enlightenment.org/auto/edje/edcref.html and looking at the
>>> bottom part.
>>>
>>> So, I created this patch that contains no code change and just changes
>>> the already existing documentation to be in order so Doxygen is nice
>>> and produce the desired output. I also fixed a couple of spelling
>>> errors, and some documentation error on an internal header (There's no
>>> need to confuse new devs)
>>
>> well this fails in "no code change":
>>
>>
>> static void
>> -st_collections_group_parts_part_description_map_rotation_center(void)
>> +st_collections_group_parts_part_description_map_on(void)
>> {
>> Edje_Part_Collection *pc;
>> Edje_Part *ep;
>> @@ -5805,37 +5801,24 @@
>>
>> ed = ep->default_desc;
>> if (ep->other_desc) ed =
>> eina_list_data_get(eina_list_last(ep->other_desc));
>> - {
>> - char *name;
>> -
>> - name = parse_str(0);
>> - data_queue_part_lookup(pc, name, &(ed->map.rot.id_center));
>> - free(name);
>> - }
>> + ed->map.on = parse_bool(0);
>> }
>
> Unfortunately diffs do not track part moves. I changed a few functions
> around so that the documentation could be built in the correct order.
> The type of table based docs that EDC uses cares about order, so
> that's why I changed it. If you apply the patch and view under a diff
> tool you'll notice the move.
>
> Should I not change the order of the functions, then the documentation
> will be broken again as tags will appear under the wrong descriptor.
>
> What do you suggest?
2 patches, one adding/fixing the docs, another one moving.
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Edje documentation patch
On Wed, Feb 24, 2010 at 2:28 AM, Eduardo Felipe
wrote:
> Hi folks!
>
> Since the adding of map capabilities to Edje, it's EDC Reference
> documentation has been broken due to the inclusion of tags out of
> proper order. That can be easily verified by going to
> http://docs.enlightenment.org/auto/edje/edcref.html and looking at the
> bottom part.
>
> So, I created this patch that contains no code change and just changes
> the already existing documentation to be in order so Doxygen is nice
> and produce the desired output. I also fixed a couple of spelling
> errors, and some documentation error on an internal header (There's no
> need to confuse new devs)
well this fails in "no code change":
static void
-st_collections_group_parts_part_description_map_rotation_center(void)
+st_collections_group_parts_part_description_map_on(void)
{
Edje_Part_Collection *pc;
Edje_Part *ep;
@@ -5805,37 +5801,24 @@
ed = ep->default_desc;
if (ep->other_desc) ed = eina_list_data_get(eina_list_last(ep->other_desc));
- {
- char *name;
-
- name = parse_str(0);
- data_queue_part_lookup(pc, name, &(ed->map.rot.id_center));
- free(name);
- }
+ ed->map.on = parse_bool(0);
}
Please do a new patch with just documentation. The current version is
quite confusing with things like that :-(
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
