Re: [E-devel] Eterm Tiling on AMD64 problem

2004-10-12 Thread Nicholas Jones
 I've been experiencing a tiling problem for the Eterm backgrounds on 
 my AMD64 box.

Yeah... it was getting on my nerves too.

I hacked in some debug, and looking at it I saw that in
parse_pixmap_ops() the tiled token isn't present. I played
around a little, and it works if you force OP_TOKEN to be
or'd with the return value.

So it seems there is a parsing, comparison, or some other
problem in calling or setting up for the pixmap ops.

Might be useful to know if any other 64bit arches have this
issue.

I'll play with it more as time permits, unless someone posts
a patch first. :)

--NJ




pgpqt0yIn2v5G.pgp
Description: PGP signature


Re: [E-devel] Eterm Tiling on AMD64 problem

2004-09-14 Thread Nicholas Jones
 This was fixed back in November of '02.  Here's the patch:

Thank you. Pardon the assumption that the source was current.

--NJ



---
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. 
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
___
enlightenment-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Eterm Tiling on AMD64 problem

2004-09-14 Thread Mike Frysinger
On Tuesday 14 September 2004 10:43 am, Nicholas Jones wrote:
  This was fixed back in November of '02.  Here's the patch:

 Thank you. Pardon the assumption that the source was current.

the ebuild is current ... as current as the last release that is :P

i dont normally follow cvs trees and back port fixes to the current ebuild 
unless it affects users (and they report it) ... if i wanted to do that, i'd 
go work for Red Hat :P

i'll update the ebuild in portage with this patch
-mike


---
This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
Camcorder. More prizes in the weekly Lunch Hour Challenge.
Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
___
enlightenment-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] Eterm Tiling on AMD64 problem

2004-09-13 Thread Nicholas Jones

First post of this one got moderated. Hopefully there won't be a dupe.

 I've been experiencing a tiling problem for the Eterm backgrounds on 
 my AMD64 box.

Yeah... it was getting on my nerves too.

I hacked in some debug, and looking at it I saw that in
parse_pixmap_ops() the tiled token isn't present. I played
around a little, and it works if you force OP_TOKEN to be
or'd with the return value.

So it seems there is a parsing, comparison, or some other
problem in calling or setting up for the pixmap ops.

Might be useful to know if any other 64bit arches have this
issue.

I'll play with it more as time permits, unless someone posts
a patch first. :)

--NJ



pgp6B63UC4UtX.pgp
Description: PGP signature


Re: [E-devel] Eterm Tiling on AMD64 problem

2004-09-13 Thread Michael Jennings
On Monday, 13 September 2004, at 16:23:07 (-0400),
Nicholas Jones wrote:

 A bit more information... The filename being passed to load_image
 has 'tile' not 'tiled' as the token for the geometry setting.
 
 On my x86 box, tiled backgrounds work with the same default
 menu.cfg for Eterm, but on the opteron it fails.
 
 The config has a parameter of ':tile', but the comparison in
 parse_pixmap_ops() is on 'tiled' using the BEG_STRCASECMP
 function/macro that I cannot find the definition of.
 
 Adding another else if below the initial tiled check, I get the
 operation I expect. Checking 'tile' in that macro works.

This was fixed back in November of '02.  Here's the patch:

Index: Eterm/src/pixmap.c
===
RCS file: /cvsroot/enlightenment/eterm/Eterm/src/pixmap.c,v
retrieving revision 1.90
retrieving revision 1.91
diff -u -r1.90 -r1.91
--- Eterm/src/pixmap.c  13 Oct 2002 05:28:36 -  1.90
+++ Eterm/src/pixmap.c  27 Nov 2002 20:18:23 -  1.91
@@ -21,7 +21,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-static const char cvs_ident[] = $Id: pixmap.c,v 1.90 2002/10/13 05:28:36 mej Exp $;
+static const char cvs_ident[] = $Id: pixmap.c,v 1.91 2002/11/27 20:18:23 mej Exp $;
 
 #include config.h
 #include feature.h
@@ -222,15 +222,15 @@
 D_PIXMAP((parse_pixmap_ops(str [%s]) called.\n, str));
 
 for (; (token = (char *) strsep(str, :));) {
-if (!BEG_STRCASECMP(tiled, token)) {
+if (!BEG_STRCASECMP(token, tile)) {
 op |= OP_TILE;
-} else if (!BEG_STRCASECMP(hscaled, token)) {
+} else if (!BEG_STRCASECMP(token, hscale)) {
 op |= OP_HSCALE;
-} else if (!BEG_STRCASECMP(vscaled, token)) {
+} else if (!BEG_STRCASECMP(token, vscale)) {
 op |= OP_VSCALE;
-} else if (!BEG_STRCASECMP(scaled, token)) {
+} else if (!BEG_STRCASECMP(token, scale)) {
 op |= OP_SCALE;
-} else if (!BEG_STRCASECMP(propscaled, token)) {
+} else if (!BEG_STRCASECMP(token, propscale)) {
 op |= OP_PROPSCALE;
 }
 }


Michael

-- 
Michael Jennings (a.k.a. KainX)  http://www.kainx.org/  [EMAIL PROTECTED]
n + 1, Inc., http://www.nplus1.net/   Author, Eterm (www.eterm.org)
---
 And every time you speak her name does she know how you told me
  you'd hold me until you died?  But you're still alive.
  -- Alanis Morrissette, You Oughta Know


---
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. 
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
___
enlightenment-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel