[E-devel] e17 thumb patch for memory leaks
Heya
I now the current E thumbnailing system is going to rewritten.
Anyway, for the moment, here is a patch to fix some memory leaks.
laurent 'kiwi'--- e_thumb.c 2006-07-07 19:00:06.613161672 +0200
+++ NEWe_thumb.c 2006-07-07 19:01:10.363470152 +0200
@@ -1,6 +1,6 @@
/*
-* vim:ts=8:sw=3:sts=8:noexpandtab:cino=>5n-3f0^-2{2
-*/
+ * vim:ts=8:sw=3:sts=8:noexpandtab:cino=>5n-3f0^-2{2
+ */
#include "e.h"
@@ -49,22 +49,31 @@
else return 0;
event_handlers =
- evas_list_append(event_handlers,
- ecore_event_handler_add(ECORE_EXE_EVENT_DEL,
- _e_thumb_cb_exe_exit,
- NULL));
+ evas_list_append(event_handlers,
+ ecore_event_handler_add(ECORE_EXE_EVENT_DEL,
+ _e_thumb_cb_exe_exit,
+ NULL));
return 1;
}
EAPI int
e_thumb_shutdown(void)
{
+ Evas_List *l;
+
E_FREE(thumb_path);
while (event_handlers)
{
ecore_event_handler_del(event_handlers->data);
event_handlers = evas_list_remove_list(event_handlers, event_handlers);
}
+
+ for (l=thumb_files; l; l=evas_list_next(l))
+ {
+E_Thumb_Item *t;
+t = evas_list_data(l);
+free(t);
+ }
evas_list_free(thumb_files);
if (pid != -1)
@@ -120,10 +129,11 @@
{
t = l->data;
if(!strcmp(path, t->path))
- {
- thumb_files = evas_list_remove_list(thumb_files, l);
- break;
- }
+ {
+ thumb_files = evas_list_remove_list(thumb_files, l);
+ free(t);
+ break;
+ }
}
}
@@ -208,6 +218,7 @@
free(thumb);
return 1;
}
+ free(thumb);
return 0;
}
@@ -520,10 +531,10 @@
{
chars[256], *sp;
const char *chmap =
- "0123456789abcdef"
- "ghijklmnopqrstuv"
- "[EMAIL PROTECTED]&*()"
- "[];',.{}<>?-=_+|";
+ "0123456789abcdef"
+ "ghijklmnopqrstuv"
+ "[EMAIL PROTECTED]&*()"
+ "[];',.{}<>?-=_+|";
unsigned intid[4], i;
struct stat st;
@@ -621,7 +632,7 @@
evas_object_del(tmp);
if(t->cb)
t->cb(t->obj, t->data);
- free(t);
+ free(t);
}
}
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] mail module new mail updating bug
This is my first email to this list, so I hope this is the right place and/or I don't ruffle to many feathers by posting this. I have been waiting a while to see if this bug was ironed out, but there seems to be no activity lately on the mail module. Great work! I believe there is a bug regarding updating of the checking procedure. I know (from reading cvs updates) that devilhorns seems to maintain this module, and also cannot test the imap component. It seems (at least for imap) that the checking works great but only for the initial imap account check. If new mail arrives the mail module never sees it. restarting enlightenment will allow the new mail to be found. Keep up the great work guys! Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] e_modules/mail devilhorns
I have been waiting a while to see if this bug was ironed out, but there seems to be no activity lately on the mail module. Great work! I believe there is a bug regarding updating of the checking procedure. I know (from reading cvs updates) that devilhorns seems to maintain this module, and also cannot test the imap component. It seems (at least for imap) that the checking works great but only for the initial imap account check. If new mail arrives the mail module never sees it. Restarting enlightenment will allow the new mail to be found. Keep up the great work guys! Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e17 thumb patch for memory leaks
On Fri, 7 Jul 2006 19:05:35 +0200 Laurent Ghigonis <[EMAIL PROTECTED]> babbled: > Heya > > I now the current E thumbnailing system is going to rewritten. > Anyway, for the moment, here is a patch to fix some memory leaks. unfortunately as u patched this.. i was busy rewriting it. i'm actually done now... :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
