Re: [E-devel] E SVN: hermet trunk/elementary/src/lib

2011-05-20 Thread Vincent Torri


On Thu, 19 May 2011, Enlightenment SVN wrote:

> Log:
> elementary / transit - removed unused variables.

if you want to clean elm, i would suggest that you compile it with:

-Wall -Wextra -Wshadow

there is a bunch of warnings to clean up. Especially shadow variables.

Of course, this is also valid for the other lib :p

Vincent

>
>
>
> Author:   hermet
> Date: 2011-05-19 23:56:31 -0700 (Thu, 19 May 2011)
> New Revision: 59551
> Trac: http://trac.enlightenment.org/e/changeset/59551
>
> Modified:
>  trunk/elementary/src/lib/elm_transit.c
>
> Modified: trunk/elementary/src/lib/elm_transit.c
> ===
> --- trunk/elementary/src/lib/elm_transit.c2011-05-20 06:51:05 UTC (rev 
> 59550)
> +++ trunk/elementary/src/lib/elm_transit.c2011-05-20 06:56:31 UTC (rev 
> 59551)
> @@ -620,13 +620,10 @@
> {
>ELM_TRANSIT_CHECK_OR_RETURN(transit);
>Evas_Object *obj;
> -   Eina_List *elist;
>Elm_Obj_Data *obj_data;
>
>if (transit->event_enabled == enabled) return;
> -
>transit->event_enabled = !!enabled;
> -
>eina_hash_foreach(transit->objs_data_hash, _hash_foreach_pass_events_set, 
> transit);
> }
>
> @@ -985,7 +982,6 @@
> EAPI void
> elm_transit_objects_final_state_keep_set(Elm_Transit *transit, Eina_Bool 
> state_keep)
> {
> -   Eina_List *list;
>Evas_Object *obj;
>Elm_Obj_Data *obj_data;
>
>
>
> --
> What Every C/C++ and Fortran developer Should Know!
> Read this article and learn how Intel has extended the reach of its
> next-generation tools to help Windows* and Linux* C/C++ and Fortran
> developers boost performance applications - including clusters.
> http://p.sf.net/sfu/intel-dev2devmay
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: hermet trunk/elementary/src/lib

2011-05-20 Thread ChunEon Park
 
Oh! Thanks Vincent!
I will try it next time :)
 
 

Let's run together for the best moment!
-Regards, Hermet-
 
-Original Message-
From: "Vincent Torri" 
To: enlightenment-devel@lists.sourceforge.net
Cc: 
Sent: 11-05-20(금) 16:02:12
Subject: Re: [E-devel] E SVN: hermet trunk/elementary/src/lib
On Thu, 19 May 2011, Enlightenment SVN wrote:
> Log:
> elementary / transit - removed unused variables.
if you want to clean elm, i would suggest that you compile it with:
-Wall -Wextra -Wshadow
there is a bunch of warnings to clean up. Especially shadow variables.
Of course, this is also valid for the other lib :p
Vincent
>
>
>
> Author: hermet
> Date: 2011-05-19 23:56:31 -0700 (Thu, 19 May 2011)
> New Revision: 59551
> Trac: http://trac.enlightenment.org/e/changeset/59551
>
> Modified:
> trunk/elementary/src/lib/elm_transit.c
>
> Modified: trunk/elementary/src/lib/elm_transit.c
> ===
> --- trunk/elementary/src/lib/elm_transit.c 2011-05-20 06:51:05 UTC (rev 59550)
> +++ trunk/elementary/src/lib/elm_transit.c 2011-05-20 06:56:31 UTC (rev 59551)
> @@ -620,13 +620,10 @@
> {
> ELM_TRANSIT_CHECK_OR_RETURN(transit);
> Evas_Object *obj;
> - Eina_List *elist;
> Elm_Obj_Data *obj_data;
>
> if (transit->event_enabled == enabled) return;
> -
> transit->event_enabled = !!enabled;
> -
> eina_hash_foreach(transit->objs_data_hash, _hash_foreach_pass_events_set, 
> transit);
> }
>
> @@ -985,7 +982,6 @@
> EAPI void
> elm_transit_objects_final_state_keep_set(Elm_Transit *transit, Eina_Bool 
> state_keep)
> {
> - Eina_List *list;
> Evas_Object *obj;
> Elm_Obj_Data *obj_data;
>
>
>
> --
> What Every C/C++ and Fortran developer Should Know!
> Read this article and learn how Intel has extended the reach of its
> next-generation tools to help Windows* and Linux* C/C++ and Fortran
> developers boost performance applications - including clusters.
> http://p.sf.net/sfu/intel-dev2devmay
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>
--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: hermet trunk/elementary/src/lib

2011-05-20 Thread Daniel Juyung Seo
Wow.. This is good!
I'm maintaining elm build issues with "-W -Wall -Wextra" options everyday.
I thought that was enough but it's good to know "-Wshadow" :)
So I'm gonna maintain elementary with that option to make it warning proof !!

Thanks.
Daniel Juyung Seo (SeoZ)

On Fri, May 20, 2011 at 4:02 PM, Vincent Torri  wrote:
>
>
> On Thu, 19 May 2011, Enlightenment SVN wrote:
>
>> Log:
>> elementary / transit - removed unused variables.
>
> if you want to clean elm, i would suggest that you compile it with:
>
> -Wall -Wextra -Wshadow
>
> there is a bunch of warnings to clean up. Especially shadow variables.
>
> Of course, this is also valid for the other lib :p
>
> Vincent
>
>>
>>
>>
>> Author:       hermet
>> Date:         2011-05-19 23:56:31 -0700 (Thu, 19 May 2011)
>> New Revision: 59551
>> Trac:         http://trac.enlightenment.org/e/changeset/59551
>>
>> Modified:
>>  trunk/elementary/src/lib/elm_transit.c
>>
>> Modified: trunk/elementary/src/lib/elm_transit.c
>> ===
>> --- trunk/elementary/src/lib/elm_transit.c    2011-05-20 06:51:05 UTC (rev 
>> 59550)
>> +++ trunk/elementary/src/lib/elm_transit.c    2011-05-20 06:56:31 UTC (rev 
>> 59551)
>> @@ -620,13 +620,10 @@
>> {
>>    ELM_TRANSIT_CHECK_OR_RETURN(transit);
>>    Evas_Object *obj;
>> -   Eina_List *elist;
>>    Elm_Obj_Data *obj_data;
>>
>>    if (transit->event_enabled == enabled) return;
>> -
>>    transit->event_enabled = !!enabled;
>> -
>>    eina_hash_foreach(transit->objs_data_hash, _hash_foreach_pass_events_set, 
>> transit);
>> }
>>
>> @@ -985,7 +982,6 @@
>> EAPI void
>> elm_transit_objects_final_state_keep_set(Elm_Transit *transit, Eina_Bool 
>> state_keep)
>> {
>> -   Eina_List *list;
>>    Evas_Object *obj;
>>    Elm_Obj_Data *obj_data;
>>
>>
>>
>> --
>> What Every C/C++ and Fortran developer Should Know!
>> Read this article and learn how Intel has extended the reach of its
>> next-generation tools to help Windows* and Linux* C/C++ and Fortran
>> developers boost performance applications - including clusters.
>> http://p.sf.net/sfu/intel-dev2devmay
>> ___
>> enlightenment-svn mailing list
>> enlightenment-...@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>>
>>
>
> --
> What Every C/C++ and Fortran developer Should Know!
> Read this article and learn how Intel has extended the reach of its
> next-generation tools to help Windows* and Linux* C/C++ and Fortran
> developers boost performance applications - including clusters.
> http://p.sf.net/sfu/intel-dev2devmay
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[E-devel] [Patch] elm_genlist - added new feature : genlist reorder mode

2011-05-20 Thread Seunggyun Kim
Dear all,

I introduce a new feature "reorder mode" of genlist.
Using this feature, user can reoder genlist items dynamically.

[API]
==
- EAPI Eina_Bool   elm_genlist_item_rename_mode_get(Elm_Genlist_Item *it)
Get the rename mode state of an item. This gets the rename mode state of an
item

- EAPI void   elm_genlist_reorder_mode_set(Evas_Object *obj, Eina_Bool
reorder_mode)
Set genlist reorder mode. This enables the item is moved to another item.
==

After set this reorder api, if user press an item (long press), the item can
be moved another position.
Then if the user releases the item, the item will be reodered in genlist.
When the user releases the holding item,  Elm_Genlist_Item_Class.func.moved
callback is also called. 
If needed, the application can add some logic in that callback function.

Please review this patch.
Thanks.



genlist_reorder_mode.diff
Description: Binary data
--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch] elm_genlist - added new feature : genlist reorder mode

2011-05-20 Thread Nicolas Aguirre
2011/5/20 Seunggyun Kim 

> Dear all,
>
> I introduce a new feature "reorder mode" of genlist.
> Using this feature, user can reoder genlist items dynamically.
>
> [API]
> ==
> - EAPI Eina_Bool   elm_genlist_item_rename_mode_get(Elm_Genlist_Item *it)
> Get the rename mode state of an item. This gets the rename mode state of an
> item
>
> - EAPI void   elm_genlist_reorder_mode_set(Evas_Object *obj, Eina_Bool
> reorder_mode)
> Set genlist reorder mode. This enables the item is moved to another item.
> ==
>
> After set this reorder api, if user press an item (long press), the item
> can
> be moved another position.
> Then if the user releases the item, the item will be reodered in genlist.
> When the user releases the holding item,  Elm_Genlist_Item_Class.func.moved
> callback is also called.
> If needed, the application can add some logic in that callback function.
>
> Please review this patch.
> Thanks.
>
>
>
> --
> What Every C/C++ and Fortran developer Should Know!
> Read this article and learn how Intel has extended the reach of its
> next-generation tools to help Windows* and Linux* C/C++ and Fortran
> developers boost performance applications - including clusters.
> http://p.sf.net/sfu/intel-dev2devmay
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
Hi Kim,
This a verry cool feature !
I didn't look at the source code, but i found a problem with the odd/even
backgrounds, when the list is reordered, i think that even/odd background
order should be keeped ?

Another idea, i find that when you longpress on an item, they should be an
event to inform the user that the event is taken into account, and that it
can begin to drag the item, i guess it could be a event sent to the edje for
flashing or something like that.

Regards,

Nicolas
-- 
Nicolas Aguirre
Mail: aguirre.nico...@gmail.com
Web: http://enna.geexbox.org
Blog: http://dev.enlightenment.fr/~captainigloo/
--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch] elm_genlist - added new feature : genlist reorder mode

2011-05-20 Thread Daniel Juyung Seo
Yeah, this is a very good feature!

>> when the list is reordered, i think that even/odd background order should be 
>> keeped ?

In genlist, even/odd can be changed dynamically.
Suppose you add/remove items in the middle of genlist.
Genlist redraw items and changes even/odd looks.
even/odd are just for the GUI. They're not genlist items' property.
So I propose that even/odd need to be changed as Kim did.

>> when you longpress on an item, they should be an event to inform the user 
>> that the event is taken into account

Agree. I hope Mr. Kim will add that effect :)
Thanks.

Daniel Juyung Seo (SeoZ)


On Fri, May 20, 2011 at 9:28 PM, Nicolas Aguirre
 wrote:
> 2011/5/20 Seunggyun Kim 
>
>> Dear all,
>>
>> I introduce a new feature "reorder mode" of genlist.
>> Using this feature, user can reoder genlist items dynamically.
>>
>> [API]
>> ==
>> - EAPI Eina_Bool   elm_genlist_item_rename_mode_get(Elm_Genlist_Item *it)
>> Get the rename mode state of an item. This gets the rename mode state of an
>> item
>>
>> - EAPI void   elm_genlist_reorder_mode_set(Evas_Object *obj, Eina_Bool
>> reorder_mode)
>> Set genlist reorder mode. This enables the item is moved to another item.
>> ==
>>
>> After set this reorder api, if user press an item (long press), the item
>> can
>> be moved another position.
>> Then if the user releases the item, the item will be reodered in genlist.
>> When the user releases the holding item,  Elm_Genlist_Item_Class.func.moved
>> callback is also called.
>> If needed, the application can add some logic in that callback function.
>>
>> Please review this patch.
>> Thanks.
>>
>>
>>
>> --
>> What Every C/C++ and Fortran developer Should Know!
>> Read this article and learn how Intel has extended the reach of its
>> next-generation tools to help Windows* and Linux* C/C++ and Fortran
>> developers boost performance applications - including clusters.
>> http://p.sf.net/sfu/intel-dev2devmay
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>>
> Hi Kim,
> This a verry cool feature !
> I didn't look at the source code, but i found a problem with the odd/even
> backgrounds, when the list is reordered, i think that even/odd background
> order should be keeped ?
>
> Another idea, i find that when you longpress on an item, they should be an
> event to inform the user that the event is taken into account, and that it
> can begin to drag the item, i guess it could be a event sent to the edje for
> flashing or something like that.
>
> Regards,
>
> Nicolas
> --
> Nicolas Aguirre
> Mail: aguirre.nico...@gmail.com
> Web: http://enna.geexbox.org
> Blog: http://dev.enlightenment.fr/~captainigloo/
> --
> What Every C/C++ and Fortran developer Should Know!
> Read this article and learn how Intel has extended the reach of its
> next-generation tools to help Windows* and Linux* C/C++ and Fortran
> developers boost performance applications - including clusters.
> http://p.sf.net/sfu/intel-dev2devmay
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch] elm_genlist - added new feature : genlist reorder mode

2011-05-20 Thread Nicolas Aguirre
2011/5/20 Daniel Juyung Seo 

> Yeah, this is a very good feature!
>
> >> when the list is reordered, i think that even/odd background order
> should be keeped ?
>
> In genlist, even/odd can be changed dynamically.
> Suppose you add/remove items in the middle of genlist.
> Genlist redraw items and changes even/odd looks.
> even/odd are just for the GUI. They're not genlist items' property.
> So I propose that even/odd need to be changed as Kim did.
>
>
Yes I agree with you, you misunderstood what i want to say :). I'm pretty
sure that i had detect a bug with odd/even, but i can't reproduce it :( So
it's ok as is !

-- 
Nicolas Aguirre
Mail: aguirre.nico...@gmail.com
Web: http://enna.geexbox.org
Blog: http://dev.enlightenment.fr/~captainigloo/
--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch] elm_genlist - added new feature : genlist edit mode

2011-05-20 Thread Daniel Juyung Seo
Dear Mr. Kim.
As we discussed, can you changed the API name to
elm_genlist_items_mode_all_set()?
Btw, do this after reorder mode patch is committed to avoid the conflict :)

Raster,
I propose elm_genlist_items_mode_all_set() not
elm_genlist_items_all_mode_set() because elm_xxx_all_set() is already
there :)

Thanks.
Daniel Juyung Seo (SeoZ)


On Fri, May 13, 2011 at 4:58 PM, Carsten Haitzler  wrote:
> On Fri, 13 May 2011 10:15:34 +0900 Daniel Juyung Seo 
> said:
>
> none - i had my say. :) commitsors
>
>> Any comments on this patch?
>>
>> Daniel Juyung Seo (SeoZ)
>>
>> On Tue, May 3, 2011 at 8:00 PM, Seunggyun Kim  wrote:
>> > Thanks for your review.
>> >
>> > I attached fixed source diff code.
>> > Since I uploaded first diff code, genlist item realize function and item 
>> > edc
>> > had been changed by cedric.
>> > So I also fixed my code according to the latest genlist code.
>> > This version supports edit mode selection handling.
>> >
>> > Please review about this.
>> > Thanks.
>> >
>> > -Original Message-
>> > From: Daniel Juyung Seo [mailto:seojuyu...@gmail.com]
>> > Sent: Thursday, April 21, 2011 5:31 PM
>> > To: Seunggyun Kim
>> > Cc: enlightenment-devel@lists.sourceforge.net
>> > Subject: Re: [E-devel] [Patch] elm_genlist - added new feature : genlist
>> > edit mode
>> >
>> > Dear Seunggyun,
>> > I have some comments.
>> >
>> > 1) Formatting.
>> >    There are many wrong formatting: indentation, braces, using one line
>> > after if, alignment of function declaration, trailing whitespaces and etc.
>> >
>> > 2) Exception for selection.
>> >    There are some exception handling code for selection. Is there any 
>> > reason
>> > to do this?
>> >
>> > 3) It will be better to move _edit_mode_item_unrealize() above it->realized
>> > = EINA_FALSE;
>> >   Because after unrealizing all instances of that item, we can say the item
>> > is unrealized.
>> >
>> > @@ -1917,6 +1934,7 @@ _item_unrealize(Elm_Genlist_Item *it, Eina_Bool ca
>> >      it->states = NULL;
>> >      it->realized = EINA_FALSE;
>> >      it->want_unrealize = EINA_FALSE;
>> >  +   if (it->wd->edit_mode) _edit_mode_item_unrealize(it);
>> >   }
>> >
>> > 4) Missing braces in if statement.
>> >     Unnecessary {, } for one liner.
>> >
>> > +                       if (it->wd->edit_mode && it->itc->edit_item_style)
>> > +                         {
>> > +                            _edit_mode_item_controls(it, it->scrl_x,
>> > it->scrl_y);
>> > +                         }
>> >
>> > 5) How about 'position' or something else instead of 'controls'?
>> >     Just a suggestion, if you mind just leave it :)
>> >
>> >>> _edit_mode_item_controls()
>> >
>> > 6) Why two braces?
>> >    And it's not reasonable check wd->edit_mode inside
>> > _edit_mode_item_realize().
>> >    Because it's not possible to go that line if it's not in an edit mode.
>> >
>> >>> if ((it->wd->edit_mode))
>> >
>> > 7) Just return wd->edit_mode.
>> >
>> >>> if (wd->edit_mode) return EINA_TRUE;
>> >>> else return EINA_FALSE;
>> >
>> > 8) Use !! for Eina_Bool type parameter in EAPIs.
>> >
>> >>> wd->edit_mode = edit_mode;
>> > wd->edit_mode = !!edit_mode;
>> >
>> > This workarounds application programmer's mistake.
>> >
>> > 9) How about using elm_genlist_realized_items_get() API?
>> >
>> >>> EINA_INLIST_FOREACH(wd->blocks, itb)
>> >>>   {
>> >>>     if (itb->realized)
>> >>>       {
>> >>>         EINA_LIST_FOREACH(itb->items, l, it)
>> >>>           {
>> >>>              if (it->flags != ELM_GENLIST_ITEM_GROUP && it->realized)
>> >
>> >
>> > 10) Missing braces.
>> >
>> >>> if (it->flags != ELM_GENLIST_ITEM_GROUP && it->realized)
>> > if ((it->flags != ELM_GENLIST_ITEM_GROUP) && (it->realized))
>> >
>> > There are more of it. Please check all.
>> >
>> > 11) Use __UNUSED__ for not used parameters.
>> >
>> > 12) Space between if and (.
>> >
>> >>> if(!tit->checked)
>> >
>> > 13) Fix warnings.
>> >    If you don't have enough warnings, add "-W -Wall -Wextra" to CFLAGS.
>> >
>> > 14) Seg fault.
>> >    It's not working when I go to "Genlist Edit" menu. It's killed.
>> >
>> > Hmm I'm not sure if only I have problems with running genlist edit in
>> > elementary_test.
>> > It has a seg fault.
>> >
>> > Other e-developers, please test this.
>> >
>> > Thank you.
>> > Daniel Juyung Seo (SeoZ)
>> >
>> > On Tue, Apr 19, 2011 at 4:32 PM, Seunggyun Kim 
>> > wrote:
>> > Thanks for your review :)
>> >
>> > I attached fixed source diff code.
>> >
>> > The edit edc is like below table.
>> > -
>> > | elm.edit.icon.1 |       elm.swallow.edit.content       |  elm.edit.icon,2
>> > |
>> > -
>> >
>> > Now it is showing only edit mode set animation.
>> > If this is committed, I'll send another patch about edit mode unset
>> > animation.
>> >
>> > Thanks:)
>> >
>> >
>> > -Original Message-
>> > From: Carsten Haitzler (The Rasterman) [mailto:ras...@ras

Re: [E-devel] E SVN: billiob trunk/edje

2011-05-20 Thread Vincent Torri


On Fri, 20 May 2011, Enlightenment SVN wrote:

> Log:
> edje: add vmaj and module to edje.pc

which module ?

Vincent

>
> Author:   billiob
> Date: 2011-05-20 09:41:28 -0700 (Fri, 20 May 2011)
> New Revision: 59556
> Trac: http://trac.enlightenment.org/e/changeset/59556
>
> Modified:
>  trunk/edje/edje.pc.in
>
> Modified: trunk/edje/edje.pc.in
> ===
> --- trunk/edje/edje.pc.in 2011-05-20 16:41:16 UTC (rev 59555)
> +++ trunk/edje/edje.pc.in 2011-05-20 16:41:28 UTC (rev 59556)
> @@ -1,9 +1,11 @@
> prefix=@prefix@
> exec_prefix=@exec_prefix@
> libdir=@libdir@
> +modules=@libdir@/@PACKAGE@/modules
> includedir=@includedir@
> datarootdir=@datarootdir@
> datadir=@datadir@/edje
> +vmaj=@VMAJ@
>
> Name: edje
> Description: Enlightened graphical design and layout engine.
>
>
> --
> What Every C/C++ and Fortran developer Should Know!
> Read this article and learn how Intel has extended the reach of its
> next-generation tools to help Windows* and Linux* C/C++ and Fortran
> developers boost performance applications - including clusters.
> http://p.sf.net/sfu/intel-dev2devmay
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: billiob trunk/edje

2011-05-20 Thread Boris Faure
On Fri, May 20, 2011 at 18:48, Vincent Torri  wrote:
>
>
> On Fri, 20 May 2011, Enlightenment SVN wrote:
>
>> Log:
>> edje: add vmaj and module to edje.pc
>
> which module ?
edje external modules.

-- 
Boris Faure

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: billiob trunk/edje

2011-05-20 Thread Boris Faure
On Fri, May 20, 2011 at 18:53, Boris Faure  wrote:
> On Fri, May 20, 2011 at 18:48, Vincent Torri  wrote:
>>
>>
>> On Fri, 20 May 2011, Enlightenment SVN wrote:
>>
>>> Log:
>>> edje: add vmaj and module to edje.pc
>>
>> which module ?
> edje external modules.

The main question is whether to export the complete release version
and not only the vmaj.
-- 
Boris Faure

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: billiob trunk/edje

2011-05-20 Thread Vincent Torri


On Fri, 20 May 2011, Boris Faure wrote:

> On Fri, May 20, 2011 at 18:53, Boris Faure  wrote:
>> On Fri, May 20, 2011 at 18:48, Vincent Torri  wrote:
>>>
>>>
>>> On Fri, 20 May 2011, Enlightenment SVN wrote:
>>>
 Log:
 edje: add vmaj and module to edje.pc
>>>
>>> which module ?
>> edje external modules.
>
> The main question is whether to export the complete release version
> and not only the vmaj.

why not putting the version directly in the name of the module path ?

Vincent

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: billiob trunk/edje

2011-05-20 Thread Boris Faure
On Fri, May 20, 2011 at 20:44, Vincent Torri  wrote:
> why not putting the version directly in the name of the module path ?
>
> Vincent

I copied it from enlightenment.
-- 
Boris Faure

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] evas/e17 crash on MacOS

2011-05-20 Thread Andreas Volz
Am Tue, 17 May 2011 14:19:58 -0700 schrieb Dave Ray:

Hello Dave,

I didn't look deeper into your backtrace. And I even think there're
people who know the code better.

But may I give you some hint? Recompile the source code with
CFLAGS=-ggdb -O0" or CFLAGS=-g -O0". In the backtrace are many values
optimized out. In general a bad situation to start debugging. :-)

But I'm not sure if this helps in your special situation here...

regards
Andreas

> I'm trying to fix a crash in e17 that seems to always happen the
> first time I run it after bootup. This problem has existed for at
> least 2 years, but I'm only looking at it now, as most other bugs
> have now been fixed. 
> 
> I followed instructions on the e17 debugging page, and rebuilt all
> the libs with -g for debugging symbols. I ran e17 and captured some
> good info in gdb.
> 
> The problem only happens the first time e17 is run after bootup. It
> cycles through 3 successive "white rectangles of death" before
> disabling modules and finishing startup. After this, if I quit X11
> and restart it, no more crash. If I reboot, it crashes again.
> 
> I captured the gdb backtrace, the pastebin is here:
> http://pastebin.com/xskYpRxt
> 
> The code that crashed looks like it is related to the mmx module of
> evas. So I recompiled evas without mmx, and recompiled ecore and e. I
> tried it again. e17 crashed in the same place, but with a non-mmx
> equivalent of the same operation. The pastebin is here:
> http://pastebin.com/YDteFFzG
> 
> It's strange that it only happens the first time I run it after
> reboot. 
> 
> Any help very much appreciated!
> 
> -Dave
> 
> PS Please don't be scared off by this being on MacOS - it is
> Darwin/BSD under the hood!
> 
> --
> What Every C/C++ and Fortran developer Should Know!
> Read this article and learn how Intel has extended the reach of its 
> next-generation tools to help Windows* and Linux* C/C++ and Fortran 
> developers boost performance applications - including clusters. 
> http://p.sf.net/sfu/intel-dev2devmay
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
Technical Blog 

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: billiob trunk/edje

2011-05-20 Thread The Rasterman
On Fri, 20 May 2011 20:44:33 +0200 (CEST) Vincent Torri 
said:

> 
> 
> On Fri, 20 May 2011, Boris Faure wrote:
> 
> > On Fri, May 20, 2011 at 18:53, Boris Faure  wrote:
> >> On Fri, May 20, 2011 at 18:48, Vincent Torri  wrote:
> >>>
> >>>
> >>> On Fri, 20 May 2011, Enlightenment SVN wrote:
> >>>
>  Log:
>  edje: add vmaj and module to edje.pc
> >>>
> >>> which module ?
> >> edje external modules.
> >
> > The main question is whether to export the complete release version
> > and not only the vmaj.
> 
> why not putting the version directly in the name of the module path ?

already is. e.g. linux-gnu-i686-1.0.0 1.0.0 is the edje "major version" only
(.0.0) as it shouldnt break external api between minor or micro versions.


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch] elm_genlist - added new feature : genlist reorder mode

2011-05-20 Thread Seunggyun Kim
Thank you for your comment :)

 

I added edc effect showing whether the item is longpressed in reorder mode.

 

You can watch a sample video on youtube.

http://www.youtube.com/watch?v=ij0vAgqucjM

 

and I attached new diff code.

 

Newly added API about reorder mode is like below.

 

 [API]

==

- EAPI void  elm_genlist_reorder_mode_set(Evas_Object *obj, Eina_Bool
reorder_mode) EINA_ARG_NONNULL(1);

Set genlist reorder mode. This enables the item is moved to another item.

 

- EAPI Eina_Bool  elm_genlist_reorder_mode_get(const Evas_Object *obj)
EINA_ARG_NONNULL(1);

Get the reorder mode state of genlist. 

==

 

---

From: Nicolas Aguirre [mailto:aguirre.nico...@gmail.com] 

Sent: Saturday, May 21, 2011 12:08 AM

To: Daniel Juyung Seo

Cc: Seunggyun Kim; enlightenment-devel@lists.sourceforge.net

Subject: Re: [E-devel] [Patch] elm_genlist - added new feature : genlist
reorder mode

 

 

2011/5/20 Daniel Juyung Seo 

Yeah, this is a very good feature!

 

>> when the list is reordered, i think that even/odd background order should
be keeped ?

In genlist, even/odd can be changed dynamically.

Suppose you add/remove items in the middle of genlist.

Genlist redraw items and changes even/odd looks.

even/odd are just for the GUI. They're not genlist items' property.

So I propose that even/odd need to be changed as Kim did.

 

 

Yes I agree with you, you misunderstood what i want to say :). I'm pretty
sure that i had detect a bug with odd/even, but i can't reproduce it :( So
it's ok as is !

 

-- 

Nicolas Aguirre

Mail: aguirre.nico...@gmail.com

Web: http://enna.geexbox.org

Blog: http://dev.enlightenment.fr/~captainigloo/



genlist_reorder_mode.diff
Description: Binary data
--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch] elm_genlist - added new feature : genlist reorder mode

2011-05-20 Thread Daniel Juyung Seo
Awesome!!
I like it.

Daniel Juyung Seo (SeoZ)

On Sat, May 21, 2011 at 12:02 PM, Seunggyun Kim  wrote:
> Thank you for your comment :)
>
>
>
> I added edc effect showing whether the item is longpressed in reorder mode.
>
>
>
> You can watch a sample video on youtube.
>
> http://www.youtube.com/watch?v=ij0vAgqucjM
>
>
>
> and I attached new diff code.
>
>
>
> Newly added API about reorder mode is like below.
>
>
>
>  [API]
>
> ==
>
> - EAPI void  elm_genlist_reorder_mode_set(Evas_Object *obj, Eina_Bool
> reorder_mode) EINA_ARG_NONNULL(1);
>
> Set genlist reorder mode. This enables the item is moved to another item.
>
>
>
> - EAPI Eina_Bool  elm_genlist_reorder_mode_get(const Evas_Object *obj)
> EINA_ARG_NONNULL(1);
>
> Get the reorder mode state of genlist.
>
> ==
>
>
>
> ---
>
> From: Nicolas Aguirre [mailto:aguirre.nico...@gmail.com]
>
> Sent: Saturday, May 21, 2011 12:08 AM
>
> To: Daniel Juyung Seo
>
> Cc: Seunggyun Kim; enlightenment-devel@lists.sourceforge.net
>
> Subject: Re: [E-devel] [Patch] elm_genlist - added new feature : genlist
> reorder mode
>
>
>
>
>
> 2011/5/20 Daniel Juyung Seo 
>
> Yeah, this is a very good feature!
>
>
>
>>> when the list is reordered, i think that even/odd background order should
>>> be keeped ?
>
> In genlist, even/odd can be changed dynamically.
>
> Suppose you add/remove items in the middle of genlist.
>
> Genlist redraw items and changes even/odd looks.
>
> even/odd are just for the GUI. They're not genlist items' property.
>
> So I propose that even/odd need to be changed as Kim did.
>
>
>
>
>
> Yes I agree with you, you misunderstood what i want to say :). I'm pretty
> sure that i had detect a bug with odd/even, but i can't reproduce it :( So
> it's ok as is !
>
>
>
> --
>
> Nicolas Aguirre
>
> Mail: aguirre.nico...@gmail.com
>
> Web: http://enna.geexbox.org
>
> Blog: http://dev.enlightenment.fr/~captainigloo/

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] [Patch] elm_genlist - added new feature : genlist reorder mode

2011-05-20 Thread Daniel Juyung Seo
Yeah, that's my bad.
When bugs are reproduced, it will be fixed.
I found some but not reproducible easily.
Thanks.

Daniel Juyung Seo (SeoZ)

On Sat, May 21, 2011 at 12:08 AM, Nicolas Aguirre
 wrote:
>
>
> 2011/5/20 Daniel Juyung Seo 
>>
>> Yeah, this is a very good feature!
>>
>> >> when the list is reordered, i think that even/odd background order
>> >> should be keeped ?
>>
>> In genlist, even/odd can be changed dynamically.
>> Suppose you add/remove items in the middle of genlist.
>> Genlist redraw items and changes even/odd looks.
>> even/odd are just for the GUI. They're not genlist items' property.
>> So I propose that even/odd need to be changed as Kim did.
>>
>
> Yes I agree with you, you misunderstood what i want to say :). I'm pretty
> sure that i had detect a bug with odd/even, but i can't reproduce it :( So
> it's ok as is !
>
> --
> Nicolas Aguirre
> Mail: aguirre.nico...@gmail.com
> Web: http://enna.geexbox.org
> Blog: http://dev.enlightenment.fr/~captainigloo/
>

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: billiob trunk/edje

2011-05-20 Thread Vincent Torri


On Sat, 21 May 2011, Carsten Haitzler (The Rasterman) wrote:

> On Fri, 20 May 2011 20:44:33 +0200 (CEST) Vincent Torri 
> said:
>
>>
>>
>> On Fri, 20 May 2011, Boris Faure wrote:
>>
>>> On Fri, May 20, 2011 at 18:53, Boris Faure  wrote:
 On Fri, May 20, 2011 at 18:48, Vincent Torri  wrote:
>
>
> On Fri, 20 May 2011, Enlightenment SVN wrote:
>
>> Log:
>> edje: add vmaj and module to edje.pc
>
> which module ?
 edje external modules.
>>>
>>> The main question is whether to export the complete release version
>>> and not only the vmaj.
>>
>> why not putting the version directly in the name of the module path ?
>
> already is. e.g. linux-gnu-i686-1.0.0 1.0.0 is the edje "major version" only
> (.0.0) as it shouldnt break external api between minor or micro versions.

i'm talking about the module path in the edje.pc file

Vincent

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel