Re: [equinox-dev] config.ini and equinox aspects

2008-10-28 Thread Martin Lippert

Hi Andrew!


Just tried out the latest version of equinox aspects and am
successfully weaving against OSGi head.  That's great.


:-)


However, I am still getting an error when the equinox aspects weaver
is started at level 1.  This problem goes away if I start it instead
at level 4.


Hm, that is strange. You are getting an error when the weaving service 
is started at level 1? What error do you get?



Starting the weaving service at level 4 doesn't seem to be giving me
any problems, but you are suggesting that it is not working.  Should I
not be doing this?


I am a bit irritating since starting with level 1 works for me, starting 
at level 4 not. Why do you have the opposite behavior? Interesting... ;-)


Would be nice to have a version that works with both... Working on that...

Can you nevertheless send me the error you get starting it at level 1?
Thanks!!!

-Martin




On Mon, Oct 27, 2008 at 2:01 PM, Martin Lippert [EMAIL PROTECTED] wrote:

Hi Andrew,

I committed some major changes inside the equinox aspects hook
implementation to fix some bugs. The problem with starting the weaving
service at a higher level is not yet fixed, but I would be happy to hear if
the current HEAD of equinox aspects works for you.

Thanks for your help!
-Martin




___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev


[equinox-dev] service elements in Declaratice Services

2008-10-28 Thread Toedter, Kai
Hi All,

I currently prototype a little Equinox app that uses Declarative Services (DS). 
The DS spec 4.1 says The service element is optional. ... The service element 
must have one or more provide elements that define the service interfaces. So, 
the following XML is syntactically correct and handled well by Equinox DS:

component name=com.siemens.ct.pm.ui.views.treeView
implementation
class=com.siemens.ct.pm.ui.views.treeview.TreeView/
service
provide

interface=com.siemens.ct.pm.application.service.IViewContribution/
provide
interface=com.siemens.ct.pm.model.IPersonListener/
/service
/component

However, the following XML is incorrect with regards to the DS spec...

component name=com.siemens.ct.pm.ui.views.treeView
implementation
class=com.siemens.ct.pm.ui.views.treeview.TreeView/
service
provide

interface=com.siemens.ct.pm.application.service.IViewContribution/
/service
service
provide
interface=com.siemens.ct.pm.model.IPersonListener/
/service
/component

... but Equinox handles it exactly like the above correct XML :)

Now the question is, is this a bug or a feature?
If it is a bug, I can file it...
...but how should Equinox DS react then?

Best regards,

Kai
---


Kai Tödter

Siemens AG
Corporate Technology
Architecture
CT SE 2
Otto-Hahn-Ring 6
81739 Munich, Germany
Phone: +49 89 636-41064
Fax: +49 89 636-45450
mailto: [EMAIL PROTECTED]
Internet: www.siemens.com/corporate-technology

Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Gerhard Cromme; 
Managing Board: Peter Loescher, Chairman, President and Chief Executive 
Officer; Heinrich Hiesinger, Joe Kaeser, Rudi Lamprecht, Eduardo Montes, 
Juergen Radomski, Erich R. Reinhardt, Hermann Requardt, Uriel J. Sharef, Peter 
Y. Solmssen, Klaus Wucherer; Registered offices: Berlin and Munich; Commercial 
registries: Berlin Charlottenburg, HRB 12300, Munich, HRB 6684; WEEE-Reg.-No. 
DE 23691322



___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev


Re: [equinox-dev] service elements in Declaratice Services

2008-10-28 Thread BJ Hargrave
Looks like a bug to me. Open a bug here: 
https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Equinox

Select the Compendium component and start the summary with [ds].

The schema for the XML only permits a single service element. DS should 
reject the XML as invalid thus ignoring the component description. 
-- 

BJ Hargrave
Senior Technical Staff Member, IBM
OSGi Fellow and CTO of the OSGi Alliance
[EMAIL PROTECTED]

office: +1 386 848 1781
mobile: +1 386 848 3788





From:
Toedter, Kai [EMAIL PROTECTED]
To:
Equinox development mailing list equinox-dev@eclipse.org
Date:
2008/10/28 09:14 AM
Subject:
[equinox-dev] service elements in Declaratice Services



Hi All,

I currently prototype a little Equinox app that uses Declarative Services 
(DS). The DS spec 4.1 says The service element is optional. ... The 
service element must have one or more provide elements that define the 
service interfaces. So, the following XML is syntactically correct and 
handled well by Equinox DS:

component name=com.siemens.ct.pm.ui.views.treeView
implementation
class=com.siemens.ct.pm.ui.views.treeview.TreeView/
service
provide
 interface=com.siemens.ct.pm.application.service.IViewContribution/
provide
interface=com.siemens.ct.pm.model.IPersonListener/
/service
/component

However, the following XML is incorrect with regards to the DS spec...

component name=com.siemens.ct.pm.ui.views.treeView
implementation
class=com.siemens.ct.pm.ui.views.treeview.TreeView/
service
provide
 interface=com.siemens.ct.pm.application.service.IViewContribution/
/service
service
provide
interface=com.siemens.ct.pm.model.IPersonListener/
/service
/component

... but Equinox handles it exactly like the above correct XML :)

Now the question is, is this a bug or a feature?
If it is a bug, I can file it...
...but how should Equinox DS react then?

Best regards,

Kai
---


Kai Tödter

Siemens AG
Corporate Technology
Architecture
CT SE 2
Otto-Hahn-Ring 6
81739 Munich, Germany
Phone: +49 89 636-41064
Fax: +49 89 636-45450
mailto: [EMAIL PROTECTED]
Internet: www.siemens.com/corporate-technology

Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Gerhard 
Cromme; Managing Board: Peter Loescher, Chairman, President and Chief 
Executive Officer; Heinrich Hiesinger, Joe Kaeser, Rudi Lamprecht, Eduardo 
Montes, Juergen Radomski, Erich R. Reinhardt, Hermann Requardt, Uriel J. 
Sharef, Peter Y. Solmssen, Klaus Wucherer; Registered offices: Berlin and 
Munich; Commercial registries: Berlin Charlottenburg, HRB 12300, Munich, 
HRB 6684; WEEE-Reg.-No. DE 23691322



___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev


RE: [equinox-dev] service elements in Declaratice Services

2008-10-28 Thread Toedter, Kai
Bug 252355 https://bugs.eclipse.org/bugs/show_bug.cgi?id=252355  filed.

 

Kai

 

From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of BJ Hargrave
Sent: Dienstag, 28. Oktober 2008 14:28
To: Equinox development mailing list
Subject: Re: [equinox-dev] service elements in Declaratice Services

 


Looks like a bug to me. Open a bug here: 
https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Equinox 
https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Equinox  

Select the Compendium component and start the summary with [ds]. 

The schema for the XML only permits a single service element. DS should 
reject the XML as invalid thus ignoring the component description. 
-- 

BJ Hargrave
Senior Technical Staff Member, IBM
OSGi Fellow and CTO of the OSGi Alliance http://www.osgi.org/ 
[EMAIL PROTECTED] mailto:[EMAIL PROTECTED]  


office: +1 386 848 1781
mobile: +1 386 848 3788







From: 

Toedter, Kai [EMAIL PROTECTED] 

To: 

Equinox development mailing list equinox-dev@eclipse.org 

Date: 

2008/10/28 09:14 AM 

Subject: 

[equinox-dev] service elements in Declaratice Services

 






Hi All,

I currently prototype a little Equinox app that uses Declarative Services (DS). 
The DS spec 4.1 says The service element is optional. ... The service element 
must have one or more provide elements that define the service interfaces. So, 
the following XML is syntactically correct and handled well by Equinox DS:

component name=com.siemens.ct.pm.ui.views.treeView
   implementation
   class=com.siemens.ct.pm.ui.views.treeview.TreeView/
   service
   provide
   interface=com.siemens.ct.pm.application.service.IViewContribution/
   provide
   interface=com.siemens.ct.pm.model.IPersonListener/
   /service
/component

However, the following XML is incorrect with regards to the DS spec...

component name=com.siemens.ct.pm.ui.views.treeView
   implementation
   class=com.siemens.ct.pm.ui.views.treeview.TreeView/
   service
   provide
   interface=com.siemens.ct.pm.application.service.IViewContribution/
   /service
   service
   provide
   interface=com.siemens.ct.pm.model.IPersonListener/
   /service
/component

... but Equinox handles it exactly like the above correct XML :)

Now the question is, is this a bug or a feature?
If it is a bug, I can file it...
...but how should Equinox DS react then?

Best regards,

Kai
---


Kai Tödter

Siemens AG
Corporate Technology
Architecture
CT SE 2
Otto-Hahn-Ring 6
81739 Munich, Germany
Phone: +49 89 636-41064
Fax: +49 89 636-45450
mailto: [EMAIL PROTECTED]
Internet: www.siemens.com/corporate-technology

Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Gerhard Cromme; 
Managing Board: Peter Loescher, Chairman, President and Chief Executive 
Officer; Heinrich Hiesinger, Joe Kaeser, Rudi Lamprecht, Eduardo Montes, 
Juergen Radomski, Erich R. Reinhardt, Hermann Requardt, Uriel J. Sharef, Peter 
Y. Solmssen, Klaus Wucherer; Registered offices: Berlin and Munich; Commercial 
registries: Berlin Charlottenburg, HRB 12300, Munich, HRB 6684; WEEE-Reg.-No. 
DE 23691322



___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev 
https://dev.eclipse.org/mailman/listinfo/equinox-dev 

___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev


Re: [equinox-dev] service elements in Declaratice Services

2008-10-28 Thread Lukasz Bobowiec
Hi Kai,

I think that this is a bug. According to XML schema that defines the 
component description grammar there is:

element name=service type=scr:Tservice minOccurs=0 maxOccurs=1/

So only one occurrence is allowed.

---
Regards/Pozdrowienia,
Lukasz Bobowiec
Software Engineer
Tivoli Dynamic Content Delivery
[EMAIL PROTECTED]
tel. (+48) 12-628-98-82

IBM SWG Lab, Cracow, Poland
IBM Polska Sp. z o.o. oddział w Krakowie
ul. Armii Krajowej 18
30 -150 Kraków

NIP: 526-030-07-24
Sąd Rejonowy dla m.st. Warszawy, XIII Wydział Gospodarczy KRS
KRS 012941, Kapitał zakładowy: 3.073.600 PLN




From:
Toedter, Kai [EMAIL PROTECTED]
To:
Equinox development mailing list equinox-dev@eclipse.org
Date:
2008-10-28 14:31
Subject:
[equinox-dev] service elements in Declaratice Services



Hi All,

I currently prototype a little Equinox app that uses Declarative Services 
(DS). The DS spec 4.1 says The service element is optional. ... The 
service element must have one or more provide elements that define the 
service interfaces. So, the following XML is syntactically correct and 
handled well by Equinox DS:

component name=com.siemens.ct.pm.ui.views.treeView
implementation
class=com.siemens.ct.pm.ui.views.treeview.TreeView/
service
provide
 interface=com.siemens.ct.pm.application.service.IViewContribution/
provide
interface=com.siemens.ct.pm.model.IPersonListener/
/service
/component

However, the following XML is incorrect with regards to the DS spec...

component name=com.siemens.ct.pm.ui.views.treeView
implementation
class=com.siemens.ct.pm.ui.views.treeview.TreeView/
service
provide
 interface=com.siemens.ct.pm.application.service.IViewContribution/
/service
service
provide
interface=com.siemens.ct.pm.model.IPersonListener/
/service
/component

... but Equinox handles it exactly like the above correct XML :)

Now the question is, is this a bug or a feature?
If it is a bug, I can file it...
...but how should Equinox DS react then?

Best regards,

Kai
---


Kai Tödter

Siemens AG
Corporate Technology
Architecture
CT SE 2
Otto-Hahn-Ring 6
81739 Munich, Germany
Phone: +49 89 636-41064
Fax: +49 89 636-45450
mailto: [EMAIL PROTECTED]
Internet: www.siemens.com/corporate-technology

Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Gerhard 
Cromme; Managing Board: Peter Loescher, Chairman, President and Chief 
Executive Officer; Heinrich Hiesinger, Joe Kaeser, Rudi Lamprecht, Eduardo 
Montes, Juergen Radomski, Erich R. Reinhardt, Hermann Requardt, Uriel J. 
Sharef, Peter Y. Solmssen, Klaus Wucherer; Registered offices: Berlin and 
Munich; Commercial registries: Berlin Charlottenburg, HRB 12300, Munich, 
HRB 6684; WEEE-Reg.-No. DE 23691322



___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev


___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev


Re: [equinox-dev] config.ini and equinox aspects

2008-10-28 Thread Andrew Eisenberg
As I mentioned earlier in this thread, I think it has something to do
with the simple configurator bundle
(org.eclipse.equinox.simpleconfigurator_1.0.0.v20080604.jar) and how
it is used to bootstrap the loading of other bundles.

Here is the exception I get (the first line of the stack trace only).
As I said, this exception is thrown, but somehow, the bundle is still
able to be loaded.

org.osgi.framework.BundleException: The bundle could not be resolved.
Reason: Missing Constraint: Require-Bundle: org.aspectj.weaver;
bundle-version=0.0.0
at 
org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:305)
snip/


What happens is this (I think):

1. there is an attempt to start the weaving service at level 1
2. but this requires starting org.aspectj.weaver and org.aspectj.runtime
3. since these two bundles are not specified in the config.ini, but
rather the org.eclipse.equinox.simpleconfigurator/bundles.info file,
these two bundles cannot be located until the simple configurator
bundle is completely started.  (so an exception is thrown)
4.  Once the simple configurator bundle is started, the aspectj weaver
and runtime can now be found and the weaving service can finally be
started.

(note- this is only a conjecture based on what I know about equinox (not much))

Does this make any sense?



On Mon, Oct 27, 2008 at 11:49 PM, Martin Lippert [EMAIL PROTECTED] wrote:
 Hi Andrew!

 Just tried out the latest version of equinox aspects and am
 successfully weaving against OSGi head.  That's great.

 :-)

 However, I am still getting an error when the equinox aspects weaver
 is started at level 1.  This problem goes away if I start it instead
 at level 4.

 Hm, that is strange. You are getting an error when the weaving service is
 started at level 1? What error do you get?

 Starting the weaving service at level 4 doesn't seem to be giving me
 any problems, but you are suggesting that it is not working.  Should I
 not be doing this?

 I am a bit irritating since starting with level 1 works for me, starting at
 level 4 not. Why do you have the opposite behavior? Interesting... ;-)

 Would be nice to have a version that works with both... Working on that...

 Can you nevertheless send me the error you get starting it at level 1?
 Thanks!!!

 -Martin

___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev


Re: [equinox-dev] config.ini and equinox aspects

2008-10-28 Thread Martin Lippert

Hi Andrew,

this sounds quite reasonable. Can you try to set the start level of the 
simpleconfigurator to 1 and of the weaving service to 2 to see what happens?


-Martin


Andrew Eisenberg wrote:

As I mentioned earlier in this thread, I think it has something to do
with the simple configurator bundle
(org.eclipse.equinox.simpleconfigurator_1.0.0.v20080604.jar) and how
it is used to bootstrap the loading of other bundles.

Here is the exception I get (the first line of the stack trace only).
As I said, this exception is thrown, but somehow, the bundle is still
able to be loaded.

org.osgi.framework.BundleException: The bundle could not be resolved.
Reason: Missing Constraint: Require-Bundle: org.aspectj.weaver;
bundle-version=0.0.0
at 
org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:305)
snip/


What happens is this (I think):

1. there is an attempt to start the weaving service at level 1
2. but this requires starting org.aspectj.weaver and org.aspectj.runtime
3. since these two bundles are not specified in the config.ini, but
rather the org.eclipse.equinox.simpleconfigurator/bundles.info file,
these two bundles cannot be located until the simple configurator
bundle is completely started.  (so an exception is thrown)
4.  Once the simple configurator bundle is started, the aspectj weaver
and runtime can now be found and the weaving service can finally be
started.

(note- this is only a conjecture based on what I know about equinox (not much))

Does this make any sense?



On Mon, Oct 27, 2008 at 11:49 PM, Martin Lippert [EMAIL PROTECTED] wrote:

Hi Andrew!


Just tried out the latest version of equinox aspects and am
successfully weaving against OSGi head.  That's great.

:-)


However, I am still getting an error when the equinox aspects weaver
is started at level 1.  This problem goes away if I start it instead
at level 4.

Hm, that is strange. You are getting an error when the weaving service is
started at level 1? What error do you get?


Starting the weaving service at level 4 doesn't seem to be giving me
any problems, but you are suggesting that it is not working.  Should I
not be doing this?

I am a bit irritating since starting with level 1 works for me, starting at
level 4 not. Why do you have the opposite behavior? Interesting... ;-)

Would be nice to have a version that works with both... Working on that...

Can you nevertheless send me the error you get starting it at level 1?
Thanks!!!

-Martin





___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev