Re: [equinox-dev] config.ini and equinox aspects
Hi Andrew, this sounds quite reasonable. Can you try to set the start level of the simpleconfigurator to 1 and of the weaving service to 2 to see what happens? -Martin Andrew Eisenberg wrote: As I mentioned earlier in this thread, I think it has something to do with the simple configurator bundle (org.eclipse.equinox.simpleconfigurator_1.0.0.v20080604.jar) and how it is used to bootstrap the loading of other bundles. Here is the exception I get (the first line of the stack trace only). As I said, this exception is thrown, but somehow, the bundle is still able to be loaded. org.osgi.framework.BundleException: The bundle could not be resolved. Reason: Missing Constraint: Require-Bundle: org.aspectj.weaver; bundle-version="0.0.0" at org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:305) What happens is this (I think): 1. there is an attempt to start the weaving service at level 1 2. but this requires starting org.aspectj.weaver and org.aspectj.runtime 3. since these two bundles are not specified in the config.ini, but rather the org.eclipse.equinox.simpleconfigurator/bundles.info file, these two bundles cannot be located until the simple configurator bundle is completely started. (so an exception is thrown) 4. Once the simple configurator bundle is started, the aspectj weaver and runtime can now be found and the weaving service can finally be started. (note- this is only a conjecture based on what I know about equinox (not much)) Does this make any sense? On Mon, Oct 27, 2008 at 11:49 PM, Martin Lippert <[EMAIL PROTECTED]> wrote: Hi Andrew! Just tried out the latest version of equinox aspects and am successfully weaving against OSGi head. That's great. :-) However, I am still getting an error when the equinox aspects weaver is started at level 1. This problem goes away if I start it instead at level 4. Hm, that is strange. You are getting an error when the weaving service is started at level 1? What error do you get? Starting the weaving service at level 4 doesn't seem to be giving me any problems, but you are suggesting that it is not working. Should I not be doing this? I am a bit irritating since starting with level 1 works for me, starting at level 4 not. Why do you have the opposite behavior? Interesting... ;-) Would be nice to have a version that works with both... Working on that... Can you nevertheless send me the error you get starting it at level 1? Thanks!!! -Martin ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
Re: [equinox-dev] config.ini and equinox aspects
As I mentioned earlier in this thread, I think it has something to do with the simple configurator bundle (org.eclipse.equinox.simpleconfigurator_1.0.0.v20080604.jar) and how it is used to bootstrap the loading of other bundles. Here is the exception I get (the first line of the stack trace only). As I said, this exception is thrown, but somehow, the bundle is still able to be loaded. org.osgi.framework.BundleException: The bundle could not be resolved. Reason: Missing Constraint: Require-Bundle: org.aspectj.weaver; bundle-version="0.0.0" at org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:305) What happens is this (I think): 1. there is an attempt to start the weaving service at level 1 2. but this requires starting org.aspectj.weaver and org.aspectj.runtime 3. since these two bundles are not specified in the config.ini, but rather the org.eclipse.equinox.simpleconfigurator/bundles.info file, these two bundles cannot be located until the simple configurator bundle is completely started. (so an exception is thrown) 4. Once the simple configurator bundle is started, the aspectj weaver and runtime can now be found and the weaving service can finally be started. (note- this is only a conjecture based on what I know about equinox (not much)) Does this make any sense? On Mon, Oct 27, 2008 at 11:49 PM, Martin Lippert <[EMAIL PROTECTED]> wrote: > Hi Andrew! > >> Just tried out the latest version of equinox aspects and am >> successfully weaving against OSGi head. That's great. > > :-) > >> However, I am still getting an error when the equinox aspects weaver >> is started at level 1. This problem goes away if I start it instead >> at level 4. > > Hm, that is strange. You are getting an error when the weaving service is > started at level 1? What error do you get? > >> Starting the weaving service at level 4 doesn't seem to be giving me >> any problems, but you are suggesting that it is not working. Should I >> not be doing this? > > I am a bit irritating since starting with level 1 works for me, starting at > level 4 not. Why do you have the opposite behavior? Interesting... ;-) > > Would be nice to have a version that works with both... Working on that... > > Can you nevertheless send me the error you get starting it at level 1? > Thanks!!! > > -Martin > ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
Re: [equinox-dev] config.ini and equinox aspects
Hi Andrew! Just tried out the latest version of equinox aspects and am successfully weaving against OSGi head. That's great. :-) However, I am still getting an error when the equinox aspects weaver is started at level 1. This problem goes away if I start it instead at level 4. Hm, that is strange. You are getting an error when the weaving service is started at level 1? What error do you get? Starting the weaving service at level 4 doesn't seem to be giving me any problems, but you are suggesting that it is not working. Should I not be doing this? I am a bit irritating since starting with level 1 works for me, starting at level 4 not. Why do you have the opposite behavior? Interesting... ;-) Would be nice to have a version that works with both... Working on that... Can you nevertheless send me the error you get starting it at level 1? Thanks!!! -Martin On Mon, Oct 27, 2008 at 2:01 PM, Martin Lippert <[EMAIL PROTECTED]> wrote: Hi Andrew, I committed some major changes inside the equinox aspects hook implementation to fix some bugs. The problem with starting the weaving service at a higher level is not yet fixed, but I would be happy to hear if the current HEAD of equinox aspects works for you. Thanks for your help! -Martin ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
Re: [equinox-dev] config.ini and equinox aspects
Hi Martin, Just tried out the latest version of equinox aspects and am successfully weaving against OSGi head. That's great. However, I am still getting an error when the equinox aspects weaver is started at level 1. This problem goes away if I start it instead at level 4. Starting the weaving service at level 4 doesn't seem to be giving me any problems, but you are suggesting that it is not working. Should I not be doing this? On Mon, Oct 27, 2008 at 2:01 PM, Martin Lippert <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > I committed some major changes inside the equinox aspects hook > implementation to fix some bugs. The problem with starting the weaving > service at a higher level is not yet fixed, but I would be happy to hear if > the current HEAD of equinox aspects works for you. > > Thanks for your help! > -Martin ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
Re: [equinox-dev] config.ini and equinox aspects
Hi Andrew, I committed some major changes inside the equinox aspects hook implementation to fix some bugs. The problem with starting the weaving service at a higher level is not yet fixed, but I would be happy to hear if the current HEAD of equinox aspects works for you. Thanks for your help! -Martin Andrew Eisenberg wrote: Nice. Thanks. On Sat, Oct 25, 2008 at 1:39 PM, Martin Lippert <[EMAIL PROTECTED]> wrote: Hi Andrew, My question is, I would prefer to have the first option ([EMAIL PROTECTED]:start) are there any potential problems with this? Consider that I only want to weave a select few bundles that all have a start level of 4. We are still struggling a bit with the dynamics of the weaving service, but if I cannot figure that out until the next milestone (end of week), I will include an option to enable weaving service dynamics and disable it by default. Then you shouldn't have any problems starting the weaving service at level 4. HTH, -Martin ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
Re: [equinox-dev] config.ini and equinox aspects
Nice. Thanks. On Sat, Oct 25, 2008 at 1:39 PM, Martin Lippert <[EMAIL PROTECTED]> wrote: > Hi Andrew, > >> My question is, I would prefer to have the first option >> ([EMAIL PROTECTED]:start) are there any potential >> problems with this? Consider that I only want to weave a select few >> bundles that all have a start level of 4. > > We are still struggling a bit with the dynamics of the weaving service, but > if I cannot figure that out until the next milestone (end of week), I will > include an option to enable weaving service dynamics and disable it by > default. Then you shouldn't have any problems starting the weaving service > at level 4. > > HTH, > -Martin > > ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
Re: [equinox-dev] config.ini and equinox aspects
Hi Andrew, My question is, I would prefer to have the first option ([EMAIL PROTECTED]:start) are there any potential problems with this? Consider that I only want to weave a select few bundles that all have a start level of 4. We are still struggling a bit with the dynamics of the weaving service, but if I cannot figure that out until the next milestone (end of week), I will include an option to enable weaving service dynamics and disable it by default. Then you shouldn't have any problems starting the weaving service at level 4. HTH, -Martin ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
Re: [equinox-dev] config.ini and equinox aspects
Andrew, I have not looked at the simpleconfigurator yet. But your suggestions look very sensible. Maybe someone from the p2 team could answer this ... ? Heiko Am 24.10.2008 um 22:48 schrieb Andrew Eisenberg: This line works for me as well and avoids the error at startup: osgi .bundles = org .aspectj .runtime ,org .aspectj .weaver,[EMAIL PROTECTED]:start,reference\:file \:[EMAIL PROTECTED]:start However, I am reluctant to try this (I am trying to keep the config.ini as close to a default config.ini as possible): osgi .bundles = org .eclipse .equinox .weaving [EMAIL PROTECTED]:start,[EMAIL PROTECTED]:start because by default config.ini files for eclipse use the file\: syntax for the simple configurator bundle. I wonder if this problem has something to do with this line in my config.ini (found by default on an eclipse install): org.eclipse.equinox.simpleconfigurator.configUrl=file \:org.eclipse.equinox.simpleconfigurator/bundles.info This line essentially states that a list of bundles (plugins), their start level, and auto-start status can be found in the bundles.info file. Perhaps the OSGi framework can't find the weaver and the runtime bundles because they are only specified in the bundles.info file, and not the config.ini. --a ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
Re: [equinox-dev] config.ini and equinox aspects
This line works for me as well and avoids the error at startup: osgi.bundles=org.aspectj.runtime,org.aspectj.weaver,[EMAIL PROTECTED]:start,reference\:file\:[EMAIL PROTECTED]:start However, I am reluctant to try this (I am trying to keep the config.ini as close to a default config.ini as possible): [EMAIL PROTECTED]:start,[EMAIL PROTECTED]:start because by default config.ini files for eclipse use the file\: syntax for the simple configurator bundle. I wonder if this problem has something to do with this line in my config.ini (found by default on an eclipse install): org.eclipse.equinox.simpleconfigurator.configUrl=file\:org.eclipse.equinox.simpleconfigurator/bundles.info This line essentially states that a list of bundles (plugins), their start level, and auto-start status can be found in the bundles.info file. Perhaps the OSGi framework can't find the weaver and the runtime bundles because they are only specified in the bundles.info file, and not the config.ini. --a On Fri, Oct 24, 2008 at 10:35 AM, Heiko Seeberger <[EMAIL PROTECTED]> wrote: > Andrew, > > This looks weired, as neither org.aspectj,runtime nor ...weaver have to be > started at all. > > That might be another issue: Maybe when you add these to osgi.bundles they > are INSTALLED (and the start level is not important). Could you please try > without starting them: >> >> >> osgi.bundles=org.aspectj.runtime,org.aspectj.weaver,[EMAIL >> PROTECTED]:start,reference\:file\:[EMAIL PROTECTED]:start > > > Another point: I wonder if your syntax is correct. I never have used > reference... or the full name including the bundle version in osgi.bundles. > Could you please try: >> >> >> [EMAIL PROTECTED]:start,[EMAIL PROTECTED]:start > > Please let me know your results. > > Cheers > Heiko > > Am 24.10.2008 um 17:39 schrieb Andrew Eisenberg: > >> I am applying equinox aspects to Eclipse 3.4.1. When I add this line >> to my config.ini: >> >> >> [EMAIL PROTECTED]:start,reference\:file\:[EMAIL PROTECTED]:start >> >> I get an exception at startup: >> org.osgi.framework.BundleException: The bundle could not be resolved. >> Reason: Missing Constraint: Require-Bundle: org.aspectj.weaver; >> bundle-version="0.0.0" >> at >> org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:305) >> >> >> But when I change the start level of org.eclipse.equinox.weaving.aspectj >> to 4: >> >> >> [EMAIL PROTECTED]:start,reference\:file\:[EMAIL PROTECTED]:start >> >> or when I add the aspectj runtime and weaving bundles to have a start >> level of one as well: >> >> >> [EMAIL PROTECTED]:start,[EMAIL PROTECTED]:start,[EMAIL >> PROTECTED]:start,reference\:file\:[EMAIL PROTECTED]:start >> >> I get no exceptions at startup. >> >> My question is, I would prefer to have the first option >> ([EMAIL PROTECTED]:start) are there any potential >> problems with this? Consider that I only want to weave a select few >> bundles that all have a start level of 4. >> >> thanks again, >> --a >> ___ >> equinox-dev mailing list >> equinox-dev@eclipse.org >> https://dev.eclipse.org/mailman/listinfo/equinox-dev > > ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
Re: [equinox-dev] config.ini and equinox aspects
Andrew, This looks weired, as neither org.aspectj,runtime nor ...weaver have to be started at all. That might be another issue: Maybe when you add these to osgi.bundles they are INSTALLED (and the start level is not important). Could you please try without starting them: osgi .bundles = org .aspectj .runtime ,org .aspectj .weaver,[EMAIL PROTECTED]:start,reference\:file \:[EMAIL PROTECTED]:start Another point: I wonder if your syntax is correct. I never have used reference... or the full name including the bundle version in osgi.bundles. Could you please try: osgi .bundles = org .eclipse .equinox .weaving [EMAIL PROTECTED]:start,[EMAIL PROTECTED]:start Please let me know your results. Cheers Heiko Am 24.10.2008 um 17:39 schrieb Andrew Eisenberg: I am applying equinox aspects to Eclipse 3.4.1. When I add this line to my config.ini: [EMAIL PROTECTED]:start,reference \:file \:[EMAIL PROTECTED]:start I get an exception at startup: org.osgi.framework.BundleException: The bundle could not be resolved. Reason: Missing Constraint: Require-Bundle: org.aspectj.weaver; bundle-version="0.0.0" at org .eclipse .osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java: 305) But when I change the start level of org.eclipse.equinox.weaving.aspectj to 4: [EMAIL PROTECTED]:start,reference \:file \:[EMAIL PROTECTED]:start or when I add the aspectj runtime and weaving bundles to have a start level of one as well: osgi .bundles = org .aspectj .runtime @1 \:start ,org .aspectj .weaver @1\:start,[EMAIL PROTECTED]:start,reference \:file \:[EMAIL PROTECTED]:start I get no exceptions at startup. My question is, I would prefer to have the first option ([EMAIL PROTECTED]:start) are there any potential problems with this? Consider that I only want to weave a select few bundles that all have a start level of 4. thanks again, --a ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
[equinox-dev] config.ini and equinox aspects
I am applying equinox aspects to Eclipse 3.4.1. When I add this line to my config.ini: [EMAIL PROTECTED]:start,reference\:file\:[EMAIL PROTECTED]:start I get an exception at startup: org.osgi.framework.BundleException: The bundle could not be resolved. Reason: Missing Constraint: Require-Bundle: org.aspectj.weaver; bundle-version="0.0.0" at org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:305) But when I change the start level of org.eclipse.equinox.weaving.aspectj to 4: [EMAIL PROTECTED]:start,reference\:file\:[EMAIL PROTECTED]:start or when I add the aspectj runtime and weaving bundles to have a start level of one as well: [EMAIL PROTECTED]:start,[EMAIL PROTECTED]:start,[EMAIL PROTECTED]:start,reference\:file\:[EMAIL PROTECTED]:start I get no exceptions at startup. My question is, I would prefer to have the first option ([EMAIL PROTECTED]:start) are there any potential problems with this? Consider that I only want to weave a select few bundles that all have a start level of 4. thanks again, --a ___ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
