Re: [equinox-dev] State of Gerrit jobs

[Thomas Watson]

I met with Thahn at the hackathon last night.  We think we have a potential
solution to fixing the gerrit job.  I opened bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=430708.

Tom





From:   Thomas Watson/Austin/IBM@IBMUS
To: Equinox development mailing list ,
Date:   03/17/2014 09:10 PM
Subject:Re: [equinox-dev] State of Gerrit jobs
Sent by:equinox-dev-boun...@eclipse.org



I am subscribed to receive the gerrit notifications but others may not be.
I do try to be responsive to contributions from gerrit, but some of the
contributions I simply do not have the knowledge to handle.  For example,
native launcher changes.

I've talked to a few at eclipse con this week and it does not appear to be
an easy thing to fix at this point to make the gerrit builds work.  For the
short term we may have to disable the build verification from gerrit.  I
agree that the situation is not good for contributions.  I'm told this is
similar to the settings used by the eclipse.platform.runtime git repo by
the way.  They have similar issues getting the gerrit builds to work.  I
would love to have them work, but fear some very significant build
restructuring would have to occur in order to get it to work.

Lets be clear, right now committers in equinox (and there are not a lot)
are not using gerrit to contribute our own contributions to Equinox.  In
fact we setup our gerrit configuration such that the committers still can
commit without going through gerrit.

Tom



Inactive hide details for Mickael Istria ---03/17/2014 06:01:34 PM---On
03/17/2014 11:16 PM, Alex Blewitt wrote: > So yes, it’Mickael Istria
---03/17/2014 06:01:34 PM---On 03/17/2014 11:16 PM, Alex Blewitt wrote: >
So yes, it’s clear that the Equinox project doesn’t us

From: Mickael Istria 
To: equinox-dev@eclipse.org,
Date: 03/17/2014 06:01 PM
Subject: Re: [equinox-dev] State of Gerrit jobs
Sent by: equinox-dev-boun...@eclipse.org



On 03/17/2014 11:16 PM, Alex Blewitt wrote:
  So yes, it’s clear that the Equinox project doesn’t use Gerrit.


As a reminder, here is the page where Gerrit users can receive Gerrit
notifications to react accordingly:
https://git.eclipse.org/r/#/settings/projects
Committers should register for the project they are committers on, it's as
important as following Bugzilla notifications.

Maybe Equinox committers just forgot to do so and weren't aware of those
incoming reviews and build failures.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev
___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev


<>___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Thomas Watson]

I am subscribed to receive the gerrit notifications but others may not be.
I do try to be responsive to contributions from gerrit, but some of the
contributions I simply do not have the knowledge to handle.  For example,
native launcher changes.

I've talked to a few at eclipse con this week and it does not appear to be
an easy thing to fix at this point to make the gerrit builds work.  For the
short term we may have to disable the build verification from gerrit.  I
agree that the situation is not good for contributions.  I'm told this is
similar to the settings used by the eclipse.platform.runtime git repo by
the way.  They have similar issues getting the gerrit builds to work.  I
would love to have them work, but fear some very significant build
restructuring would have to occur in order to get it to work.

Lets be clear, right now committers in equinox (and there are not a lot)
are not using gerrit to contribute our own contributions to Equinox.  In
fact we setup our gerrit configuration such that the committers still can
commit without going through gerrit.

Tom





From:   Mickael Istria 
To: equinox-dev@eclipse.org,
Date:   03/17/2014 06:01 PM
Subject:    Re: [equinox-dev] State of Gerrit jobs
Sent by:equinox-dev-boun...@eclipse.org



On 03/17/2014 11:16 PM, Alex Blewitt wrote:
  So yes, it’s clear that the Equinox project doesn’t use Gerrit.
As a reminder, here is the page where Gerrit users can receive Gerrit
notifications to react accordingly:
https://git.eclipse.org/r/#/settings/projects
Committers should register for the project they are committers on, it's as
important as following Bugzilla notifications.

Maybe Equinox committers just forgot to do so and weren't aware of those
incoming reviews and build failures.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev
<>___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Mickael Istria]

On 03/17/2014 11:16 PM, Alex Blewitt wrote:

So yes, it’s clear that the Equinox project doesn’t use Gerrit.
As a reminder, here is the page where Gerrit users can receive Gerrit 
notifications to react accordingly: 
https://git.eclipse.org/r/#/settings/projects
Committers should register for the project they are committers on, it's 
as important as following Bugzilla notifications.


Maybe Equinox committers just forgot to do so and weren't aware of those 
incoming reviews and build failures.

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat 
My blog  - My Tweets 

___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Alex Blewitt]

On 17 Mar 2014, at 21:32, Gunnar Wagenknecht  wrote:

> On 2014-03-16 17:06:33 +, Mickael Istria said:
>> I don't think it's that much a matter of resource, it's more that you're the 
>> first one to report this issue. Did you open a bug for it?
> 
> So there were only two earlier builds:
> - one in February
> - one in December
> 
> Both were failing as well. I think that by itself is pretty good evidence 
> that the team does not use Gerrit. Why should it be thrown in the face of 
> poor contributors then? That's like being more holier than the pope.
> 
> BTM, the issue has something to do with the complicated platform build. 
> People knowing that will also understand that's a time sink. I bet it never 
> worked or only worked by accident when the Gerrit trigger was set up. Anyway, 
> the build issue - as I've been told - is not new. Thus I didn't report it as 
> a new bug.

One of those was mine, and I was concerned that it hadn’t been applied, which 
is why I asked if it was successful. 

https://git.eclipse.org/r/#/c/19484/

It turns out that the change was manually cherry picked into the Equinox 
codebase, even though the build in Gerrit was marked as failed and the bug is 
still showing as open in my bundles review:

https://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=35033c8021dde91c3dab707604ceb3df689a7d10

https://git.eclipse.org/r/#/q/is:open+owner:%22Alex+Blewitt+%253Calex.blewitt%2540gmail.com%253E%22,n,z

So yes, it’s clear that the Equinox project doesn’t use Gerrit.

Alex
___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Mickael Istria]

The error seems to give good hints:

[ERROR] Cannot resolve project dependencies:
[ERROR]   Software being installed: org.eclipse.equinox.sdk.feature.group 
3.10.0.qualifier
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140121-0337 requires 'org.eclipse.equinox.registry 
[3.5.400.v20130717-1325]' but it could not be found
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140127-1522 requires 'org.eclipse.equinox.concurrent 
[1.1.0.v20130327-1442]' but it could not be found
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140203-2153 requires 'org.eclipse.equinox.transforms.xslt 
[1.0.300.v20130327-1442]' but it could not be found
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140207-1548 requires 'org.eclipse.equinox.bidi 
[0.10.0.v20130327-1442]' but it could not be found
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140217-1923 requires 'org.eclipse.equinox.concurrent 
[1.1.0.v20130327-1442]' but it could not be found
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140224-1517 requires 'org.eclipse.equinox.security 
[1.2.0.v20130424-1801]' but it could not be found
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140225-1603 requires 'org.eclipse.equinox.bidi 
[0.10.0.v20130327-1442]' but it could not be found
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140226-1626 requires 'org.eclipse.equinox.bidi 
[0.10.0.v20130327-1442]' but it could not be found
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140305-1523 requires 'org.eclipse.equinox.common 
[3.6.200.v20130402-1505]' but it could not be found
[ERROR]   Missing requirement: org.eclipse.equinox.core.sdk.feature.group 
3.10.0.v20140310-1324 requires 'org.eclipse.equinox.bidi 
[0.10.0.v20130327-1442]' but it could not be found
[ERROR]   Cannot satisfy dependency: org.eclipse.equinox.sdk.feature.group 
3.10.0.qualifier depends on: org.eclipse.equinox.core.sdk.feature.group 0.0.0


I cannot find a reference to org.eclipse.equinox.core.sdk feature in 
repository. Where is it supposed to come from?

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat 
My blog  - My Tweets 

___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Gunnar Wagenknecht]

On 2014-03-16 17:06:33 +, Mickael Istria said:
I don't think it's that much a matter of resource, it's more that 
you're the first one to report this issue. Did you open a bug for it?


So there were only two earlier builds:
- one in February
- one in December

Both were failing as well. I think that by itself is pretty good 
evidence that the team does not use Gerrit. Why should it be thrown in 
the face of poor contributors then? That's like being more holier than 
the pope.


BTM, the issue has something to do with the complicated platform build. 
People knowing that will also understand that's a time sink. I bet it 
never worked or only worked by accident when the Gerrit trigger was set 
up. Anyway, the build issue - as I've been told - is not new. Thus I 
didn't report it as a new bug.


-Gunnar

--
Gunnar Wagenknecht
gun...@wagenknecht.org


___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Thomas Watson]

FWIW I thought we had straightened this out already.  Will look to fixing
it.

Tom





From:   Gunnar Wagenknecht 
To: equinox-dev@eclipse.org,
Date:   03/16/2014 06:00 AM
Subject:Re: [equinox-dev] State of Gerrit jobs
Sent by:equinox-dev-boun...@eclipse.org



On 2014-03-15 23:45:20 +, Doug Schaefer said:
> Turning it off guarantees it won't be kept up.‎ Verification jobs have
> saved my ass a number of times now. They are definitely worth spending
> time on.

I'm not arguing about advantages or disadvantages. I use Gerrit a lot.
Just trying to be pragmatic. It's a very frustrating experience for
contributors which may turn them away. If there are no resources to
maintain it, then you should look at reducing the efforts.

-Gunnar

--
Gunnar Wagenknecht
gun...@wagenknecht.org


___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev
<>___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Mickael Istria]

On 03/16/2014 11:59 AM, Gunnar Wagenknecht wrote:

On 2014-03-15 23:45:20 +, Doug Schaefer said:
Turning it off guarantees it won't be kept up.‎ Verification jobs 
have saved my ass a number of times now. They are definitely worth 
spending time on.


I'm not arguing about advantages or disadvantages. I use Gerrit a lot. 
Just trying to be pragmatic. It's a very frustrating experience for 
contributors which may turn them away. If there are no resources to 
maintain it, then you should look at reducing the efforts.
I don't think it's that much a matter of resource, it's more that you're 
the first one to report this issue. Did you open a bug for it?

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat 
My blog  - My Tweets 

___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Gunnar Wagenknecht]

On 2014-03-15 23:45:20 +, Doug Schaefer said:
Turning it off guarantees it won't be kept up.‎ Verification jobs have 
saved my ass a number of times now. They are definitely worth spending 
time on.


I'm not arguing about advantages or disadvantages. I use Gerrit a lot. 
Just trying to be pragmatic. It's a very frustrating experience for 
contributors which may turn them away. If there are no resources to 
maintain it, then you should look at reducing the efforts.


-Gunnar

--
Gunnar Wagenknecht
gun...@wagenknecht.org


___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Doug Schaefer]

Turning it off guarantees it won't be kept up.‎ Verification jobs have saved my 
ass a number of times now. They are definitely worth spending time on.

Sent from my BlackBerry 10 smartphone on the Rogers network.
  Original Message
From: Gunnar Wagenknecht
Sent: Saturday, March 15, 2014 7:33 PM
To: equinox-dev@eclipse.org
Reply To: Equinox development mailing list
Subject: [equinox-dev] State of Gerrit jobs


Hi Equinox Team,

I pushed a review to Gerrit today (https://git.eclipse.org/r/23434).
This triggered a build job which seems to be in an un-maintained state,
i.e. it fails with some (very long) p2 resolution problems on unrelated
bundles. I think this is a very bad situation for contributors. As a
result, the Gerrit trigger downvotes the review.

It doesn't seem to be a common practise to use Gerrit on a daily basis
by all committers. I'd like to propose to disable the job until there
is committment to keep it maintained in good shape.

-Gunnar

--
Gunnar Wagenknecht
gun...@wagenknecht.org


___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev
___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Mickael Istria]

This build error might be worth being reported to a bug. That seems to 
show that for some reason, Equinox cannot build on its own as a Maven 
module.

We could have a look at this during EclipseCon.

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat 
My blog  - My Tweets 

___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Re: [equinox-dev] State of Gerrit jobs

[Mike Milinkovich]

  
  
On 15/03/2014 9:53 AM, Gunnar
  Wagenknecht wrote:

It
  doesn't seem to be a common practise to use Gerrit on a daily
  basis by all committers. I'd like to propose to disable the job
  until there is committment to keep it maintained in good shape.


If I may, another possibility would be to start following Gerrit
best practices as outlined by Denis on his blog:
http://eclipsewebmaster.blogspot.ca/2013/11/using-gerrit-code-review-without-code.html

-- 
  Mike Milinkovich
  mike.milinkov...@eclipse.org
  +1.613.220.3223
  
   
  
  

___
equinox-dev mailing list
equinox-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev