Re: [Evolution-hackers] Error reporting changes
On Tue, 2009-12-08 at 13:13 -0500, Reid Thompson wrote: > I applied Ritesh's patch from comment 27 and compilation fails with > > ../../../../evolution/modules/mail/e-mail-shell-view-actions.c:505: > error: > implicit declaration of function ‘message_list_free_uids’ Hi, bad luck, it had been removed recently for some reason, see commit 76fbb9d. > Is/Are one/all of the previous patches required also? The first patch is for the external plugin itself, applicable to tar.gz sources of it, whereas the second patch, the ritz's one, is to have this plugin as internal code, not a plugin. These two are supposed to be independent. Bye, Milan ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Error reporting changes
On Tue, 2009-12-08 at 12:30 -0600, Jonathon Jongsma wrote: > Sorry, I missed this message originally since it got caught by my spam > filter for some reason. From a brief look, the only changes you would > need to make related to the error/alert stuff would be: > - you would need to include e-alert-dialog.h instead of e-error.h. > - instead of e_error_run(), you would use > e_alert_run_dialog_for_args() > > If you need any more help, let me know. > No problem - thanks for the response and offer. Milan pointed me to Hi, here's your bug report about the same http://bugzilla.gnome.org/show_bug.cgi?id=587011 Bye, Milan Which appears to have addressed adding remove-duplicates into modules. I've just got a build error to get through now ( just posted a few minutes ago ). reid ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Error reporting changes
On Mon, 2009-12-07 at 14:41 -0500, Reid Thompson wrote: > On Mon, 2009-12-07 at 12:37 -0600, Jonathon Jongsma wrote: > > Quick follow-up to this: I was convinced by a couple of people that > > we'd > > probably want EAlert to be a GObject, so I bit the bullet and just did > > it. In addition, I factored out the convenience dialog functionality > > and created a GtkDialog subclass called EAlertDialog. This means that > > there are a couple additional changes since I wrote this mail. The > > most > > important ones for developers and plugin authors: > > > > - e_alert_free() no longer exists. use g_object_unref() > > - to use the dialog functionality, include e-alert-dialog.h rather > > than > > just e-alert.h > > - e_alert_new_dialog() -> e_alert_dialog_new() > > > > Also, there's one little picky cleanup that I snuck in along with > > those > > changes. e_alert_newv() was renamed to e_alert_new_valist() to be > > more > > consistent with other API in glib (e.g. g_object_newv() takes an array > > and a length vs g_object_new_valist() which takes a va_list) > > > > Evolution, evolution-mapi and evolution-exchange should all be > > up-to-date with these changes in git. If you have a plugin that's > > out-of-tree, it may need to be updated. > > > > if i wished to attempt to update evolution-remove-duplicates to git head > http://www.gnome.org/~carlosg/stuff/evolution/ > > is there an up to date example for plugins > which of the current plugins would best serve as a reference > > > evolution-remove-duplicates added an item to the right click menu that > checked for duplicates within selected emails -- i.e. select a folder, > CTRL-A, right click, select remove duplicates,... Sorry, I missed this message originally since it got caught by my spam filter for some reason. From a brief look, the only changes you would need to make related to the error/alert stuff would be: - you would need to include e-alert-dialog.h instead of e-error.h. - instead of e_error_run(), you would use e_alert_run_dialog_for_args() If you need any more help, let me know. -- Jonathon Jongsma ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Error reporting changes
On Tue, 2009-12-08 at 11:21 +0100, Milan Crha wrote: > On Mon, 2009-12-07 at 14:41 -0500, Reid Thompson wrote: > > if i wished to attempt to update evolution-remove-duplicates to git > > head > > http://www.gnome.org/~carlosg/stuff/evolution/ > > Hi, > here's your bug report about the same > http://bugzilla.gnome.org/show_bug.cgi?id=587011 > Bye, > Milan I applied Ritesh's patch from comment 27 and compilation fails with ../../../../evolution/modules/mail/e-mail-shell-view-actions.c:505: error: implicit declaration of function ‘message_list_free_uids’ Is/Are one/all of the previous patches required also? ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Error reporting changes
On Tue, 2009-12-08 at 11:21 +0100, Milan Crha wrote: > On Mon, 2009-12-07 at 14:41 -0500, Reid Thompson wrote: > > if i wished to attempt to update evolution-remove-duplicates to git > > head > > http://www.gnome.org/~carlosg/stuff/evolution/ > > Hi, > here's your bug report about the same > http://bugzilla.gnome.org/show_bug.cgi?id=587011 > Bye, > Milan Thank you -- reid ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Error reporting changes
On Mon, 2009-12-07 at 14:41 -0500, Reid Thompson wrote: > if i wished to attempt to update evolution-remove-duplicates to git > head > http://www.gnome.org/~carlosg/stuff/evolution/ Hi, here's your bug report about the same http://bugzilla.gnome.org/show_bug.cgi?id=587011 Bye, Milan ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
