Re: [Evolution-hackers] Rethinking account management

2011-01-25 Thread Matthew Barnes 
On Mon, 2010-11-15 at 11:45 -0500, Matthew Barnes wrote:
> I kinda wanted to tweak the names anyway, so here's my proposal for the
> new D-Bus interface names:
> 
>   Old: org.gnome.evolution.dataserver.addressbook.BookFactory
>org.gnome.evolution.dataserver.calendar.CalFactory
>org.gnome.evolution.dataserver.addressbook.Book
>org.gnome.evolution.dataserver.calendar.Cal
> 
>   New: org.gnome.evolution.dataserver.AddressBookFactory.0
>org.gnome.evolution.dataserver.CalendarFactory.0
>org.gnome.evolution.dataserver.AddressBook.0
>org.gnome.evolution.dataserver.Calendar.0
> 
> In the future, if we have to break a D-Bus interface again we'll
> increment the digit.  Then if the user upgrades E-D-S to a version that
> implements "Calendar.1" but is still running an e-calendar-factory that
> implements "Calendar.0", then when Evolution is launched the session bus
> will have to relaunch the upgraded e-calendar-factory binary and the old
> e-calendar-factory process will lose its well-known D-Bus name (at least
> I think that's how it works... in any case, D-Bus knows what to do).
> 
> If there's no objections I'd like to get new interface names into 2.91
> now so I can increment the interface versions on my account-management
> branch and not have to worry about this anymore.

Milan reminded me about this today so I went ahead with it.

It turns out just the D-Bus service names need to be versioned, not the
interface names.  But the same rules for incrementing the version apply.

The new names are (with both versions at '0'):

   Bus Name:org.gnome.evolution.dataserver.AddressBook0
   Object Path: org/gnome/evolution/dataserver/AddressBookFactory
   Interface:   org.gnome.evolution.dataserver.AddressbookFactory

   Bus Name:org.gnome.evolution.dataserver.Calendar0
   Object Path: org/gnome/evolution/dataserver/CalendarFactory
   Interface:   org.gnome.evolution.dataserver.CalendarFactory

More details in the commit message:
http://git.gnome.org/browse/evolution-data-server/commit/?id=89b130c3d75cd0fa023af4064b0d0e3ce2147519

Matthew Barnes


___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers

Re: [Evolution-hackers] Rethinking account management

2011-01-25 Thread Milan Crha 
On Tue, 2011-01-25 at 16:54 -0500, Matthew Barnes wrote:
> The new names are (with both versions at '0'):
> 
>Bus Name:org.gnome.evolution.dataserver.AddressBook0
>Object Path: org/gnome/evolution/dataserver/AddressBookFactory
>Interface:   org.gnome.evolution.dataserver.AddressbookFactory
> 
>Bus Name:org.gnome.evolution.dataserver.Calendar0
>Object Path: org/gnome/evolution/dataserver/CalendarFactory
>Interface:   org.gnome.evolution.dataserver.CalendarFactory 

Hi,
thanks for doing this. I'm only wondering, why not a dot or dash (if
available for bus names) between the version number and the bus name
itself? Was there anything preventing it to do it that way? (I'm not
much familiar with DBus itself, so please forgive me if this is a lame
question.)
Bye,
Milan

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers

Re: [Evolution-hackers] Rethinking account management

2011-01-25 Thread Matthew Barnes 
On Wed, 2011-01-26 at 06:17 +0100, Milan Crha wrote:
> thanks for doing this. I'm only wondering, why not a dot or dash (if
> available for bus names) between the version number and the bus name
> itself? Was there anything preventing it to do it that way? (I'm not
> much familiar with DBus itself, so please forgive me if this is a lame
> question.)

I would've preferred that myself, but apparently D-Bus (or just GDBus)
doesn't like digits after dots.

g_dbus_is_name ("blah.blah.Calendar.0") -> FALSE

g_dbus_is_name ("blah.blah.Calendar0") -> TRUE

I guess next time we bump the version you can stick a dash in there if
you want.  "Calendar0" and "Calendar-0" are equally ugly to me.

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers