Re: [Evolution-hackers] vCard test suite
On Tue, 2016-04-05 at 20:44 +0200, Ángel González wrote: > On 2016-04-05 at 08:52 +0100, Philip Withnall wrote: > > I don’t think I explained clearly enough, sorry. All three options > > are > > proposing to keep vcard-test-suite as a separate project, which EDS > > depends on in some way (either as a test-time dependency, a git > > submodule, or a build-time dependency). > > I don't think it should be a build-time dependency. If the dependency > is not fulfilled, you should still be able to build and run eds > (except > for running those tests, of course). > Hi, I agree with Ángel, build time dependency is out of question. Also because soft dependencies are easy to overlook, thus one might easily not even notice the new test suit. I'm not sure how you'd like to have done the test-time dependency. If the files would not be available, will the whole test suit be skipped, or the test will fail with an error? The first option is similar to build time dependency (being it a soft dependency). The second option might be a bit limiting, no? That lefts us with a git submodule. What is the difference between the git submodule and direct inclusion in the sources? If you want to cover more than vCard tests for the evolution-data-server (like testing also other vCard parsers, from other libraries), then it seems to me that the cleanest solution would be to provide installed-tests from the git repo as you have it, just define different "targets". I mean, I miss a gain in the inclusion of the project as a git submodule in the evolution-data-server. It's possible I'm overlooking something though. Bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] vCard test suite
On 2016-04-05 at 08:52 +0100, Philip Withnall wrote: > I don’t think I explained clearly enough, sorry. All three options > are > proposing to keep vcard-test-suite as a separate project, which EDS > depends on in some way (either as a test-time dependency, a git > submodule, or a build-time dependency). I don't think it should be a build-time dependency. If the dependency is not fulfilled, you should still be able to build and run eds (except for running those tests, of course). Regards ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] vCard test suite
Hey, On Mon, 2016-04-04 at 10:08 +0200, Milan Crha wrote: > On Sun, 2016-04-03 at 22:13 +0100, Philip Withnall wrote: > > > > How would it be best to include this in the EDS test suite? The > > options > > I see are: > > • Install the vCards on the system in the installed-tests prefix, > > for > > use by unit tests installed by EDS. > > • Import them as a git submodule into EDS. > > • Keep vcard-test-suite separate and have it install its own unit > > test > > for EDS[1]. > > > > I think the first option might be the best, but I would appreciate > > others’ input. > > > Hi, > if the Collabora is fine to copy/move the data and the code in the > evolution-data-server sources, then I do not see any issue with it. I don’t think I explained clearly enough, sorry. All three options are proposing to keep vcard-test-suite as a separate project, which EDS depends on in some way (either as a test-time dependency, a git submodule, or a build-time dependency). > I would also prefer to make it part of the installed-tests for the > evolution-data-server, together with the binary which will process > all > those files (install data and do not use them looks incorrect). That seems like a good goal, regardless of which method we choose to do it. Philip signature.asc Description: This is a digitally signed message part ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
