Re: [Evolution-hackers] [Old Version 2.28] Tasks: Prevent Ctrl-X in search box to accidentally delete tasks, For what it's worth: My comprehensive set of patches for ancient 2.28
Am Montag, den 19.08.2013, 11:05 +0200 schrieb Thomas Mittelstaedt: > Am Montag, den 19.08.2013, 07:51 +0200 schrieb Milan Crha: > > On Fri, 2013-08-16 at 22:50 +0200, Thomas Mittelstaedt wrote: > > > I don't know if this works cleanly in the newest versions. But in my > > > ancient version, doing a search by entering a term in the search box, > > > selecting a piece of text of that search string and hitting Ctrl-x would > > > result in the currently selected task to be deleted. And Ctrl-v would > > > not bring it back. I inserted a little crutch in my old version to > > > simply disable the cut command and that worked. See attached diff. > > > > Hi, > > as I replied to one of your previous emails, please use bugzilla for > > issues and patches, the mailing list is not a place where these should > > be added, at least not for evolution-hackers. > > All right, Milan. I created an enhancement bug report at > https://bugzilla.gnome.org/show_bug.cgi?id=706287 And to quote from that report: For what it's worth: My comprehensive set of patches for ancient 2.28 version. (edit) Product: Evolution Component: Tasks Version: 2.28.x Status: UNCONFIRMED Priority: Normal Severity: enhancement Collapse All Comments - Expand All Comments [reply] [-] Description Thomas [reporter] 2013-08-19 09:02:07 UTC Created an attachment (id=252183) [details] Set of patches Just for completeness: I have reached a very nice level of stability and user satisfaction with this old, ancient version of evolution, which I use on an ubuntu 10.04 (Lucid Lynx) box. Over time I applied several patches, fixes of simple safety checks in response to crashes to this version and I thought, I upload it as an enhancement bug report, if somebody may be interested. I use a Software called stacked git (stg) to apply these series of patches. Naming convention of these patches is issue__... . This hints at a concrete bug report in bugzilla and should be reachable with the following url: https://bugzilla.gnome.org/show_bug.cgi?id=. I also uploaded my build script and the script I use to run the application. -- thomas ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [Old Version 2.28] Tasks: Prevent Ctrl-X in search box to accidentally delete tasks.
Am Montag, den 19.08.2013, 07:51 +0200 schrieb Milan Crha: > On Fri, 2013-08-16 at 22:50 +0200, Thomas Mittelstaedt wrote: > > I don't know if this works cleanly in the newest versions. But in my > > ancient version, doing a search by entering a term in the search box, > > selecting a piece of text of that search string and hitting Ctrl-x would > > result in the currently selected task to be deleted. And Ctrl-v would > > not bring it back. I inserted a little crutch in my old version to > > simply disable the cut command and that worked. See attached diff. > > Hi, > as I replied to one of your previous emails, please use bugzilla for > issues and patches, the mailing list is not a place where these should > be added, at least not for evolution-hackers. All right, Milan. I created an enhancement bug report at https://bugzilla.gnome.org/show_bug.cgi?id=706287 > > I tried to reproduce this in current master and the Ctrl+X doesn't > delete the selected task when pressed with focused search entry, Perfect. -- thomas ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [Old Version 2.28] Tasks: Prevent Ctrl-X in search box to accidentally delete tasks.
On Fri, 2013-08-16 at 22:50 +0200, Thomas Mittelstaedt wrote: > I don't know if this works cleanly in the newest versions. But in my > ancient version, doing a search by entering a term in the search box, > selecting a piece of text of that search string and hitting Ctrl-x would > result in the currently selected task to be deleted. And Ctrl-v would > not bring it back. I inserted a little crutch in my old version to > simply disable the cut command and that worked. See attached diff. Hi, as I replied to one of your previous emails, please use bugzilla for issues and patches, the mailing list is not a place where these should be added, at least not for evolution-hackers. >From your change, I hope you understand that the patch is not acceptable for a "production" code. It's neither applicable to anything after 2.32 (including it). I tried to reproduce this in current master and the Ctrl+X doesn't delete the selected task when pressed with focused search entry, thus this is already fixed. If I would guess, then it's this commit: https://git.gnome.org/browse/evolution/commit/?h=gnome-3-8&id=2a3580e43de Bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-hackers
[Evolution-hackers] [Old Version 2.28] Tasks: Prevent Ctrl-X in search box to accidentally delete tasks.
I don't know if this works cleanly in the newest versions. But in my
ancient version, doing a search by entering a term in the search box,
selecting a piece of text of that search string and hitting Ctrl-x would
result in the currently selected task to be deleted. And Ctrl-v would
not bring it back. I inserted a little crutch in my old version to
simply disable the cut command and that worked. See attached diff.
--
thomas
commit cf5444ce2def9c51d40ee6bf4091ad8c516f1a8b
Author: Thomas Mittelstaedt
Date: Fri Aug 16 22:21:47 2013 +0200
Just a quick fix: Disable the TasksCut command in order not accidentally
delete tasks while hitting Ctrl-x in the search text box.
diff --git a/calendar/gui/tasks-control.c b/calendar/gui/tasks-control.c
index a788931..b24b9a6 100644
--- a/calendar/gui/tasks-control.c
+++ b/calendar/gui/tasks-control.c
@@ -269,7 +269,8 @@ tasks_control_focus_changed (GtkWidget *widget,
GdkEventFocus *event, struct foc
static BonoboUIVerb verbs [] = {
BONOBO_UI_VERB ("TasksOpenTask", tasks_control_open_task_cmd),
BONOBO_UI_VERB ("TasksNewTask", tasks_control_new_task_cmd),
- BONOBO_UI_VERB ("TasksCut", tasks_control_cut_cmd),
+ /* BONOBO_UI_VERB ("TasksCut", tasks_control_cut_cmd), */
+ BONOBO_UI_VERB ("TasksCut", NULL),
BONOBO_UI_VERB ("TasksCopy", tasks_control_copy_cmd),
BONOBO_UI_VERB ("TasksPaste", tasks_control_paste_cmd),
BONOBO_UI_VERB ("TasksDelete", tasks_control_delete_cmd),
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-hackers
