[ewg] [PATCH] ofed_scripts: Do not remove slaves before stopping stack
There is no need to unenslave IPoIB interfaces before stopping the stack. This can cause a kernel crash as described in https://bugs.openfabrics.org/show_bug.cgi?id=1821 Signed-off-by: Moni Shoua mo...@voltaire.com --- diff --git a/ofed_scripts/openibd b/ofed_scripts/openibd index 8b0c3e6..2e5efee 100755 --- a/ofed_scripts/openibd +++ b/ofed_scripts/openibd @@ -1272,11 +1272,6 @@ stop() fi fi -# Down all bond interfaces - if ( which ib-bond /dev/null ) ; then - ib-bond --stop-all - fi - # Stop SRP HA daemon if running if [ -f $srp_daemon_pidfile ]; then local line p ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] [PATCH] ofed_scripts: Do not remove slaves before stopping stack
Moni Shoua wrote: There is no need to unenslave IPoIB interfaces before stopping the stack. This can cause a kernel crash as described in https://bugs.openfabrics.org/show_bug.cgi?id=1821 Signed-off-by: Moni Shoua mo...@voltaire.com --- diff --git a/ofed_scripts/openibd b/ofed_scripts/openibd index 8b0c3e6..2e5efee 100755 --- a/ofed_scripts/openibd +++ b/ofed_scripts/openibd @@ -1272,11 +1272,6 @@ stop() fi fi -# Down all bond interfaces - if ( which ib-bond /dev/null ) ; then - ib-bond --stop-all - fi - # Stop SRP HA daemon if running if [ -f $srp_daemon_pidfile ]; then local line p Applied, Regards, Vladimir ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] ofa_1_5_kernel 20091118-0200 daily build status
This email was generated automatically, please do not reply git_url: git://git.openfabrics.org/ofed_1_5/linux-2.6.git git_branch: ofed_kernel_1_5 Common build parameters: Passed: Passed on i686 with linux-2.6.18 Passed on i686 with linux-2.6.19 Passed on i686 with linux-2.6.21.1 Passed on i686 with linux-2.6.26 Passed on i686 with linux-2.6.24 Passed on i686 with linux-2.6.22 Passed on i686 with linux-2.6.27 Passed on x86_64 with linux-2.6.16.60-0.54.5-smp Passed on x86_64 with linux-2.6.16.60-0.21-smp Passed on x86_64 with linux-2.6.18 Passed on x86_64 with linux-2.6.18-128.el5 Passed on x86_64 with linux-2.6.18-164.el5 Passed on x86_64 with linux-2.6.20 Passed on x86_64 with linux-2.6.19 Passed on x86_64 with linux-2.6.18-93.el5 Passed on x86_64 with linux-2.6.21.1 Passed on x86_64 with linux-2.6.24 Passed on x86_64 with linux-2.6.22 Passed on x86_64 with linux-2.6.26 Passed on x86_64 with linux-2.6.27 Passed on x86_64 with linux-2.6.25 Passed on x86_64 with linux-2.6.27.19-5-smp Passed on x86_64 with linux-2.6.9-89.ELsmp Passed on x86_64 with linux-2.6.9-67.ELsmp Passed on x86_64 with linux-2.6.9-78.ELsmp Passed on ia64 with linux-2.6.18 Passed on ia64 with linux-2.6.19 Passed on ia64 with linux-2.6.21.1 Passed on ia64 with linux-2.6.23 Passed on ia64 with linux-2.6.24 Passed on ia64 with linux-2.6.22 Passed on ia64 with linux-2.6.26 Passed on ia64 with linux-2.6.25 Passed on ppc64 with linux-2.6.18 Passed on ppc64 with linux-2.6.19 Failed: ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] [PATCH] docs: Update to the comment of ib-bonding OS scope.
Give a better explanation to the ib-bonding OS scope Signed-off-by: Moni Shoua mo...@voltaire.com --- diff --git a/ipoib_release_notes.txt b/ipoib_release_notes.txt index f60ca7c..2d1217a 100644 --- a/ipoib_release_notes.txt +++ b/ipoib_release_notes.txt @@ -272,10 +272,13 @@ Notes: no longer supported * On RHEL4_U7, cannot set a slave interface as primary. * ib-bonding will not be compiled and installed with OFED on OS with kernel - that is = 2.6.27. The bonding driver that comes with those kernels already - supports enslaving of IPoIB interfaces. However, there still might be a issue - of OS configuration tools (like sysconfig or initscripts) that needs a fix - but such issues were not observed yet. + that is = 2.6.27 (e.g. SLES11). The bonding driver that comes with those kernels + already supports enslaving of IPoIB interfaces. In addition, an OS can come + with an older kernel but with a patched bonding driver that also doesn't + require modification (e.g. RHEL5.4). OFEED will not replace the bonding + module in such cases also. + However, there still might be a issue of OS configuration tools (like sysconfig or + initscripts) that needs a fix but such issues were not observed yet. === ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] [PATCH] docs: Update to the comment of ib-bonding OS scope.
Moni Shoua wrote: Give a better explanation to the ib-bonding OS scope Signed-off-by: Moni Shoua mo...@voltaire.com --- diff --git a/ipoib_release_notes.txt b/ipoib_release_notes.txt index f60ca7c..2d1217a 100644 --- a/ipoib_release_notes.txt +++ b/ipoib_release_notes.txt @@ -272,10 +272,13 @@ Notes: no longer supported * On RHEL4_U7, cannot set a slave interface as primary. * ib-bonding will not be compiled and installed with OFED on OS with kernel - that is = 2.6.27. The bonding driver that comes with those kernels already - supports enslaving of IPoIB interfaces. However, there still might be a issue - of OS configuration tools (like sysconfig or initscripts) that needs a fix - but such issues were not observed yet. + that is = 2.6.27 (e.g. SLES11). The bonding driver that comes with those kernels + already supports enslaving of IPoIB interfaces. In addition, an OS can come + with an older kernel but with a patched bonding driver that also doesn't + require modification (e.g. RHEL5.4). OFEED will not replace the bonding + module in such cases also. + However, there still might be a issue of OS configuration tools (like sysconfig or + initscripts) that needs a fix but such issues were not observed yet. === Applied, Regards, Vladimir ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] [PATCHv6 0/10] RDMAoE support
Eli Cohen wrote: This new series reflects changes based on feedback from the community on the previous set of patches, and is tagged v6. Previous series were posted to the openfabrics general list only. Changes from v5: 1. Bug fixes. How do you expect a reviewer to learn what were the bugs and what are the fixes and if there are bugs that are known and weren't fixed yet? is one expected to do a diff between patches? where is the listing of changes from vX for X=1,2,3,4? Or. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] [GIT PULL OFED-1.5] NFSRDMA bug fixes
Hey Vlad, Please pull from ssh://v...@sofa.openfabrics.org/home/jon/scm/ofed_kernel-1.5.git 1824 It contains the following patches: commit 8d89c86c86205b096c8db70dac5e09d814da8d80 Author: Jon Mason j...@opengridcomputing.com Date: Mon Nov 16 14:08:23 2009 -0600 Not all of the calls to send_write are properly handling the error case and unmapping the outstanding ib_dma_maps when an error is encountered. Also, send_write is not returning en error when the connection is closed while it is sleeping waiting for free slots on the send queue. This patch corrects the calls to send_write that did not cleanup after themselves and now returns an error if the connection is closed in all cases. This fixes bug 1824. Signed-off-by: Jon Mason j...@opengridcomputing.com commit 439e74ce9dc3e0666fe7513804d4642e18461ab7 Author: Jon Mason j...@opengridcomputing.com Date: Mon Nov 16 13:54:16 2009 -0600 Undo commit e692689e3b77c0cdd7594bb225c09a0767899693 The change was unneeded and provides no fix for NFSRDMA running over ConnectX. Signed-off-by: Jon Mason j...@opengridcomputing.com Thanks, Jon ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] [RFC] ofa_kernel.spec: add rpc.statd to nfsserver scripts for SLES10
On Wed, Nov 18, 2009 at 09:46:00AM +0200, Vladimir Sokolovsky wrote: Jon Mason wrote: In addition, please remove rpmbuild dependency on automake and autoconf in rnfs-utils. This part (autogen.sh) should be done in source RPM build step and not on the customers' server. I don't understand, why should the dependency be removed? It is needed to run configure when building rnfs-utils, and I don't believe I can exclude that step without breaking IA64 and PPC. The necessary packages are not included in SLES10 but are included in every other supported OFED distro. Thanks, Jon autoconf and automake are needed to create configure and Makefile.in and not to run it. nfs-utils-1.1.5.tar.bz2 already includes configure script and all required files to actually run configure. So, you can remove automake and autoconf requirement from rnfs-utils.spec. Thanks for the info. I'll remove the rpm build dep and push the new SRPM before tonights build. Thanks, Jon Regards, Vladimir ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] ofa_1_5_kernel 20091104-0200 daily build status
On Thu, 2009-11-12 at 10:37 +0200, Vladimir Sokolovsky wrote: Please try: diff --git a/ofed_scripts/get_backport_dir.sh b/ofed_scripts/get_backport_dir.sh index ed0c091..0da5c17 100755 --- a/ofed_scripts/get_backport_dir.sh +++ b/ofed_scripts/get_backport_dir.sh @@ -51,7 +51,7 @@ get_backport_dir() echo 2.6.16_sles10_sp1 else subminor=$(echo $KVERSION | cut -d - -f 2 | cut -d. -f2) -if [ $subminor -lt 49 ]; then +if [ $subminor -lt 42 ]; then echo 2.6.16_sles10_sp2 else echo 2.6.16_sles10_sp3 The patch is working because it identifies the kernel as SP3, however the result ends up looking bad for a different reason: ... Created config.mk: BACKPORT_INCLUDES=-I${CWD}/kernel_addons/backport/2.6.16_sles10_sp3/include/ Created configure.mk.kernel: # Current working directory CWD=/cache/build/BUILD/ofa_kernel-1.5 # Kernel level KVERSION=2.6.16.60-0.42.4_lustre.1.8.1.54.20091118002918-bigsmp ARCH=i686 MODULES_DIR=/lib/modules/2.6.16.60-0.42.4_lustre.1.8.1.54.20091118002918-bigsmp/updates KSRC=/cache/build/reused/usr/src/linux-2.6.16.60-0.42.4_lustre.1.8.1.54.20091118002918-obj/i386/bigsmp AUTOCONF_H=/cache/build/BUILD/ofa_kernel-1.5/include/linux/autoconf.h WITH_MAKE_PARAMS= CONFIG_MEMTRACK= CONFIG_DEBUG_INFO=y CONFIG_INFINIBAND=m CONFIG_INFINIBAND_IPOIB=m CONFIG_INFINIBAND_IPOIB_CM=y CONFIG_INFINIBAND_SDP=m CONFIG_INFINIBAND_SRP= CONFIG_INFINIBAND_SRPT= CONFIG_INFINIBAND_USER_MAD=m CONFIG_INFINIBAND_USER_ACCESS=m CONFIG_INFINIBAND_ADDR_TRANS=y CONFIG_INFINIBAND_USER_MEM=y CONFIG_INFINIBAND_MTHCA=m CONFIG_MLX4_CORE=m CONFIG_MLX4_EN=m CONFIG_MLX4_INFINIBAND=m CONFIG_MLX4_DEBUG=y CONFIG_INFINIBAND_IPOIB_DEBUG=y CONFIG_INFINIBAND_ISER= CONFIG_SCSI_ISCSI_ATTRS= CONFIG_ISCSI_TCP= CONFIG_INFINIBAND_EHCA= CONFIG_INFINIBAND_EHCA_SCALING= CONFIG_RDS=m CONFIG_RDS_RDMA=m CONFIG_RDS_TCP=m CONFIG_RDS_DEBUG= CONFIG_INFINIBAND_MADEYE=m CONFIG_INFINIBAND_QLGC_VNIC=m CONFIG_INFINIBAND_CXGB3=m CONFIG_CHELSIO_T3=m CONFIG_INFINIBAND_NES=m CONFIG_SUNRPC_XPRT_RDMA= CONFIG_SUNRPC= CONFIG_SUNRPC_GSS= CONFIG_RPCSEC_GSS_KRB5= CONFIG_RPCSEC_GSS_SPKM3= CONFIG_NFS_FS= CONFIG_NFS_V3= CONFIG_NFS_V3_ACL= CONFIG_NFS_V4= CONFIG_NFS_ACL_SUPPORT= CONFIG_NFS_DIRECTIO= CONFIG_EXPORTFS= CONFIG_LOCKD= CONFIG_LOCKD_V4= CONFIG_NFSD= CONFIG_NFSD_V2_ACL= CONFIG_NFSD_V3= CONFIG_NFSD_V3_ACL= CONFIG_NFSD_V4= CONFIG_NFSD_RDMA= CONFIG_INFINIBAND_IPOIB_DEBUG_DATA= CONFIG_INFINIBAND_SDP_SEND_ZCOPY= CONFIG_INFINIBAND_SDP_RECV_ZCOPY= CONFIG_INFINIBAND_SDP_DEBUG=y CONFIG_INFINIBAND_SDP_DEBUG_DATA= CONFIG_INFINIBAND_IPATH= CONFIG_INFINIBAND_QIB= CONFIG_INFINIBAND_MTHCA_DEBUG=y CONFIG_INFINIBAND_QLGC_VNIC_STATS= CONFIG_INFINIBAND_CXGB3_DEBUG= CONFIG_INFINIBAND_NES_DEBUG= CONFIG_INFINIBAND_AMSO1100= Created /cache/build/BUILD/ofa_kernel-1.5/include/linux/autoconf.h: #ifndef __OFED_BUILD__ #include_next linux/autoconf.h #else #undef CONFIG_MEMTRACK #undef CONFIG_DEBUG_INFO #undef CONFIG_INFINIBAND #undef CONFIG_INFINIBAND_IPOIB #undef CONFIG_INFINIBAND_IPOIB_CM #undef CONFIG_INFINIBAND_SDP #undef CONFIG_INFINIBAND_SRP #undef CONFIG_INFINIBAND_SRPT #undef CONFIG_INFINIBAND_USER_MAD #undef CONFIG_INFINIBAND_USER_ACCESS #undef CONFIG_INFINIBAND_ADDR_TRANS #undef CONFIG_INFINIBAND_USER_MEM #undef CONFIG_INFINIBAND_MTHCA #undef CONFIG_MLX4_CORE #undef CONFIG_MLX4_DEBUG #undef CONFIG_MLX4_EN #undef CONFIG_MLX4_INFINIBAND #undef CONFIG_INFINIBAND_IPOIB_DEBUG #undef CONFIG_INFINIBAND_ISER #undef CONFIG_INFINIBAND_EHCA #undef CONFIG_INFINIBAND_EHCA_SCALING #undef CONFIG_RDS #undef CONFIG_RDS_RDMA #undef CONFIG_RDS_TCP #undef CONFIG_RDS_DEBUG #undef CONFIG_INFINIBAND_MADEYE #undef CONFIG_INFINIBAND_QLGC_VNIC #undef CONFIG_INFINIBAND_QLGC_VNIC_STATS #undef CONFIG_INFINIBAND_CXGB3 #undef CONFIG_INFINIBAND_CXGB3_DEBUG #undef CONFIG_CHELSIO_T3 #undef CONFIG_INFINIBAND_NES #undef CONFIG_INFINIBAND_NES_DEBUG #undef CONFIG_SUNRPC_XPRT_RDMA #undef CONFIG_SUNRPC #undef CONFIG_SUNRPC_GSS #undef CONFIG_RPCSEC_GSS_KRB5 #undef CONFIG_RPCSEC_GSS_SPKM3 #undef CONFIG_NFS_FS #undef CONFIG_NFS_V3 #undef CONFIG_NFS_V3_ACL #undef CONFIG_NFS_V4 #undef CONFIG_NFS_ACL_SUPPORT #undef CONFIG_NFS_DIRECTIO #undef CONFIG_EXPORTFS #undef CONFIG_LOCKD #undef CONFIG_LOCKD_V4 #undef CONFIG_NFSD #undef CONFIG_NFSD_V2_ACL #undef CONFIG_NFSD_V3 #undef CONFIG_NFSD_V3_ACL #undef CONFIG_NFSD_V4 #undef CONFIG_NFSD_RDMA #undef CONFIG_INFINIBAND_IPOIB_DEBUG_DATA #undef CONFIG_INFINIBAND_SDP_SEND_ZCOPY #undef CONFIG_INFINIBAND_SDP_RECV_ZCOPY #undef CONFIG_INFINIBAND_SDP_DEBUG #undef CONFIG_INFINIBAND_SDP_DEBUG_DATA #undef CONFIG_INFINIBAND_IPATH #undef CONFIG_INFINIBAND_QIB #undef CONFIG_INFINIBAND_MTHCA_DEBUG #undef CONFIG_INFINIBAND_AMSO1100 #endif #undef CONFIG_INFINIBAND #define CONFIG_INFINIBAND 1 #undef CONFIG_INFINIBAND_IPOIB #define CONFIG_INFINIBAND_IPOIB 1
[ewg] SLES10sp2 build break
It looks like a recent commit broke the SLES10sp2 build. I am seeing: In file included from /usr/src/linux-2.6.16.60-0.21/include/linux/aio.h:5, from /usr/src/linux-2.6.16.60-0.21/include/linux/sched.h:255, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/sched.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/mm.h:4, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/mm.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/skbuff.h:26, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/skbuff.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/if_ether.h:111, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/if_ether.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/netdevice.h:29, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/netdevice.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/inetdevice.h:7, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/inetdevice.h:4, from /root/ofed_kernel-2.6.16_sles10_sp2/drivers/infiniband/core/addr.c:37: /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/workqueue.h: In function ‘backport_delayed_work_pending’: /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/workqueue.h:31: error: implicit declaration of function ‘delayed_work_pending’ make[6]: *** [/root/ofed_kernel-2.6.16_sles10_sp2/drivers/infiniband/core/addr.o] Error 1 make[5]: *** [/root/ofed_kernel-2.6.16_sles10_sp2/drivers/infiniband/core] Error 2 make[4]: *** [/root/ofed_kernel-2.6.16_sles10_sp2/drivers/infiniband] Error 2 make[3]: *** [_module_/root/ofed_kernel-2.6.16_sles10_sp2] Error 2 make[2]: *** [modules] Error 2 make[1]: *** [modules] Error 2 make: *** [kernel] Error 2 r...@demo2 ~/ofed_kernel-2.6.16_sles10_sp2 # uname -r 2.6.16.60-0.21-smp kernel_addons/backport/2.6.16_sles10_sp2/include/linux/workqueue.h was last touched in commit 4e0958d8db84ec233a75d289f7d636f974741d9d Author: Yevgeny Petrilin yevge...@mellanox.co.il Date: Tue Nov 17 18:20:22 2009 +0200 mlx4_core: Updated 'cancel_delayed_work_synch' backport Signed-off-by: Yevgeny Petrilin yevge...@mellanox.co.il In that patch, references to delayed_work_pending were added. Am I missing something? Let me know if you want me to open a bug. Thanks, Jon ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] SLES10sp2 build break
I recently upgraded to the latest released SLES10SP2 kernel (2.6.16.60-0.42.7) and I see the problem below as well. However, in addition, I see: In file included from /usr/src/linux-2.6.16.60-0.42.7/include/net/addrconf.h:51, from /var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/drivers/infiniband/core/addr.c:43: /var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/kernel_addons/backport/2.6.16_sles10_sp2/include/net/ipv6.h: At top level: /var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/kernel_addons/backport/2.6.16_sles10_sp2/include/net/ipv6.h:22: error: redefinition of 'ipv6_addr_loopback' /usr/src/linux-2.6.16.60-0.42.7/include/net/ipv6.h:361: error: previous definition of 'ipv6_addr_loopback' was here The 'ipv6_addr_loopback' was added to kernel_addons/backport/2.6.16_sles10_sp2/include/net/ipv6.h by: committer Jack Morgenstein ja...@dev.mellanox.co.il Thu, 11 Jun 2009 13:17:33 + (16:17 +0300) commit 1f462241bd18d9b5727ddea90459e7763b69e11c backports: 2.6.16_sles10_sp2: patches and add-ons based on kernel 2.6.18 backport Although this works for the base SLES10SP2 kernel (2.6.16.60-0.21), people trying to install OFED on recent SLES10SP2 kernels will have the same problem. Vlad, do you have any suggestions on how to fix this? Thanks. -jeff Jon Mason wrote: It looks like a recent commit broke the SLES10sp2 build. I am seeing: In file included from /usr/src/linux-2.6.16.60-0.21/include/linux/aio.h:5, from /usr/src/linux-2.6.16.60-0.21/include/linux/sched.h:255, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/sched.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/mm.h:4, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/mm.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/skbuff.h:26, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/skbuff.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/if_ether.h:111, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/if_ether.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/netdevice.h:29, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/netdevice.h:4, from /usr/src/linux-2.6.16.60-0.21/include/linux/inetdevice.h:7, from /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/inetdevice.h:4, from /root/ofed_kernel-2.6.16_sles10_sp2/drivers/infiniband/core/addr.c:37: /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/workqueue.h: In function ‘backport_delayed_work_pending’: /root/ofed_kernel-2.6.16_sles10_sp2/kernel_addons/backport/2.6.16_sles10_sp2/include/linux/workqueue.h:31: error: implicit declaration of function ‘delayed_work_pending’ make[6]: *** [/root/ofed_kernel-2.6.16_sles10_sp2/drivers/infiniband/core/addr.o] Error 1 make[5]: *** [/root/ofed_kernel-2.6.16_sles10_sp2/drivers/infiniband/core] Error 2 make[4]: *** [/root/ofed_kernel-2.6.16_sles10_sp2/drivers/infiniband] Error 2 make[3]: *** [_module_/root/ofed_kernel-2.6.16_sles10_sp2] Error 2 make[2]: *** [modules] Error 2 make[1]: *** [modules] Error 2 make: *** [kernel] Error 2 r...@demo2 ~/ofed_kernel-2.6.16_sles10_sp2 # uname -r 2.6.16.60-0.21-smp kernel_addons/backport/2.6.16_sles10_sp2/include/linux/workqueue.h was last touched in commit 4e0958d8db84ec233a75d289f7d636f974741d9d Author: Yevgeny Petrilin yevge...@mellanox.co.il Date: Tue Nov 17 18:20:22 2009 +0200 mlx4_core: Updated 'cancel_delayed_work_synch' backport Signed-off-by: Yevgeny Petrilin yevge...@mellanox.co.il In that patch, references to delayed_work_pending were added. Am I missing something? Let me know if you want me to open a bug. Thanks, Jon ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] [GIT PULL OFED-1.5] NFSRDMA bug fixes
Hey Vlad, I rolled in some additional changes. Please disregard my previous request, and pull from this tree: ssh://v...@sofa.openfabrics.org/home/jon/scm/ofed_kernel-1.5.git dev It contains the following patches: commit 3d459694b83b66b08e6722fbab873a7f78b66bcd Author: Jon Mason j...@opengridcomputing.com Date: Wed Nov 18 17:46:30 2009 -0600 The EADDRNOTAVAIL patch causes more problems than it solves. Remove it. Signed-off-by: Jon Mason j...@opengridcomputing.com commit e0d151154a46ce6d77ea39e3a072d621b7e6dabc Author: Jon Mason j...@opengridcomputing.com Date: Thu Jul 30 17:41:24 2009 -0500 Lustre has a requirement to use either the Native OS version of NFS or the OFED version of NFS. When disabling the OFED NFS to use the Native NFS, there are headerfile conflicts between what Lustre expects to be there and what actually is there. This patch works around this issue by relocating the NFS specific headerfiles to a unique location and only references them there if OFED NFS is selected. This patch resolves bug 1671. Signed-Off-By: Jon Mason j...@opengridcomputing.com commit f6d607f1d80de11ef9a01fc0517d2ad6e1936a06 Author: Jon Mason j...@opengridcomputing.com Date: Mon Nov 16 14:08:23 2009 -0600 Not all of the calls to send_write are properly handling the error case and unmapping the outstanding ib_dma_maps when an error is encountered. Also, send_write is not returning en error when the connection is closed while it is sleeping waiting for free slots on the send queue. This patch corrects the calls to send_write that did not cleanup after themselves and now returns an error if the connection is closed in all cases. This fixes bug 1824. Signed-off-by: Jon Mason j...@opengridcomputing.com commit 1d9c4ee11209429a009aa10f6a35b85984a80c26 Author: Jon Mason j...@opengridcomputing.com Date: Mon Nov 16 13:54:16 2009 -0600 Undo commit e692689e3b77c0cdd7594bb225c09a0767899693 The change was unneeded and provides no fix for NFSRDMA running over ConnectX. Signed-off-by: Jon Mason j...@opengridcomputing.com Thanks, Jon On Wed, Nov 18, 2009 at 11:19:29AM -0600, Jon Mason wrote: Hey Vlad, Please pull from ssh://v...@sofa.openfabrics.org/home/jon/scm/ofed_kernel-1.5.git 1824 It contains the following patches: commit 8d89c86c86205b096c8db70dac5e09d814da8d80 Author: Jon Mason j...@opengridcomputing.com Date: Mon Nov 16 14:08:23 2009 -0600 Not all of the calls to send_write are properly handling the error case and unmapping the outstanding ib_dma_maps when an error is encountered. Also, send_write is not returning en error when the connection is closed while it is sleeping waiting for free slots on the send queue. This patch corrects the calls to send_write that did not cleanup after themselves and now returns an error if the connection is closed in all cases. This fixes bug 1824. Signed-off-by: Jon Mason j...@opengridcomputing.com commit 439e74ce9dc3e0666fe7513804d4642e18461ab7 Author: Jon Mason j...@opengridcomputing.com Date: Mon Nov 16 13:54:16 2009 -0600 Undo commit e692689e3b77c0cdd7594bb225c09a0767899693 The change was unneeded and provides no fix for NFSRDMA running over ConnectX. Signed-off-by: Jon Mason j...@opengridcomputing.com Thanks, Jon ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] [GIT PULL OFED-1.5] NFSRDMA bug fixes
Jon Mason wrote: Hey Vlad, I rolled in some additional changes. Please disregard my previous request, and pull from this tree: ssh://v...@sofa.openfabrics.org/home/jon/scm/ofed_kernel-1.5.git dev Done, Regards, Vladimir ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg