Re: [ewg] OFED 4.17 latest build error on SLES15

2018-08-15 Thread Vladimir Sokolovsky 

On 08/15/2018 07:18 PM, Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC] wrote:

Hi Vlad,

Were you able to figure out what's wrong? Thanks.

-jeff


Not yet,
I have older kernel: 4.12.14-16-default vs yours 4.12.14-23-default but 
it is hard to believe that APIs were changed.
Can you send me config.log from 
/var/tmp/OFED_topdir/BUILD/compat-rdma-4.17/compat directory?

Meanwhile, I will try to get the newer kernel.

Regards,
Vladimir



*From:* ewg [ewg-boun...@lists.openfabrics.org] on behalf of Becker, 
Jeffrey C. (ARC-TN)[InuTeq, LLC] [jeffrey.c.bec...@nasa.gov]

*Sent:* Tuesday, August 14, 2018 11:57 AM
*To:* Vladimir Sokolovsky
*Cc:* ewg@lists.openfabrics.org
*Subject:* Re: [ewg] OFED 4.17 latest build error on SLES15

Hi Vlad,

PSB

*From:* Vladimir Sokolovsky [v...@dev.mellanox.co.il]
*Sent:* Tuesday, August 14, 2018 9:43 AM
*To:* Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC]
*Cc:* ewg@lists.openfabrics.org
*Subject:* Re: OFED 4.17 latest build error on SLES15

On 08/14/2018 12:18 AM, Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC] wrote:

Hi Vlad,


*From:* Vladimir Sokolovsky [v...@dev.mellanox.co.il]
*Sent:* Monday, August 13, 2018 1:33 PM
*To:* Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC]
*Cc:* ewg@lists.openfabrics.org
*Subject:* Re: OFED 4.17 latest build error on SLES15

On 08/13/2018 08:23 PM, Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC] wrote:
It seems the following backport code in 
/var/tmp/OFED_topdir/BUILD/compat-rdma-4.17/drivers/infiniband/ulp/ipoib/ipoib_main.c 
didn't work as expected:


#ifdef HAVE_INET_CONFIRM_ADDR_EXPORTED
#ifdef HAVE_INET_CONFIRM_ADDR_5_PARAMS
    ret_addr = inet_confirm_addr(net, in_dev, 0,
addr_in->sin_addr.s_addr,
 RT_SCOPE_HOST);
#else
    ret_addr = inet_confirm_addr(in_dev, 0,
addr_in->sin_addr.s_addr,
 RT_SCOPE_HOST);
#endif
#else
    ret_addr = confirm_addr_indev(in_dev, 0,
addr_in->sin_addr.s_addr,
  RT_SCOPE_HOST);
#endif


>> Hi Jeff,
>> On SLES15 (4.12.14-16-default) I have in compat/config.h:
>> #define HAVE_INET_CONFIRM_ADDR_5_PARAMS 1
>> #define HAVE_INET_CONFIRM_ADDR_EXPORTED 1
>>
>> So, it should use the topmost inet_confirm_addr and not 
confirm_addr_indev.

>> Did you run configure script?

I used install.pl in the latest.tgz top level directory. I assume 
that runs configure as a first step for compat_rdma? Thanks.


-jeff

>> Regards,
>> Vladimir


>> Hi Jeff,
>> Please attach compat-rdma.rpmbuild.log (ls -ltr 
/tmp/OFED*/compat-rdma.rpmbuild.log)


Attached. Thanks.

-jeff

>>Regards,
??Vladimir








*From:* Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC]
*Sent:* Monday, August 13, 2018 10:00 AM
*To:* Vladimir Sokolovsky ‎[v...@dev.mellanox.co.il]‎
*Cc:* ewg@lists.openfabrics.org
*Subject:* OFED 4.17 latest build error on SLES15

Hi Vlad,

I just tried to build on SLES15 and got the following error:

/var/tmp/OFED_topdir/BUILD/compat-rdma-4.17/drivers/infiniband/ulp/ipoib/ipoib_main.c: 
In function ‘ipoib_is_dev_match_addr_rcu’:
/var/tmp/OFED_topdir/BUILD/compat-rdma-4.17/drivers/infiniband/ulp/ipoib/ipoib_main.c:355:14: 
error: implicit declaration of function ‘confirm_addr_indev’ 
[-Werror=implicit-function-declaration]

   ret_addr = confirm_addr_indev(in_dev, 0,
  ^~

Is the backport for SLES15 missing something? Thanks.

-jeff







___
ewg mailing list
ewg@lists.openfabrics.org
https://lists.openfabrics.org/mailman/listinfo/ewg

Re: [ewg] OFED 4.17 latest build error on SLES15

2018-08-15 Thread Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC] 
Hi Vlad,

Were you able to figure out what's wrong? Thanks.

-jeff

From: ewg [ewg-boun...@lists.openfabrics.org] on behalf of Becker, Jeffrey C. 
(ARC-TN)[InuTeq, LLC] [jeffrey.c.bec...@nasa.gov]
Sent: Tuesday, August 14, 2018 11:57 AM
To: Vladimir Sokolovsky
Cc: ewg@lists.openfabrics.org
Subject: Re: [ewg] OFED 4.17 latest build error on SLES15

Hi Vlad,

PSB

From: Vladimir Sokolovsky [v...@dev.mellanox.co.il]
Sent: Tuesday, August 14, 2018 9:43 AM
To: Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC]
Cc: ewg@lists.openfabrics.org
Subject: Re: OFED 4.17 latest build error on SLES15

On 08/14/2018 12:18 AM, Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC] wrote:
Hi Vlad,


From: Vladimir Sokolovsky 
[v...@dev.mellanox.co.il]
Sent: Monday, August 13, 2018 1:33 PM
To: Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC]
Cc: ewg@lists.openfabrics.org
Subject: Re: OFED 4.17 latest build error on SLES15

On 08/13/2018 08:23 PM, Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC] wrote:
It seems the following backport code in  
/var/tmp/OFED_topdir/BUILD/compat-rdma-4.17/drivers/infiniband/ulp/ipoib/ipoib_main.c
 didn't work as expected:

#ifdef HAVE_INET_CONFIRM_ADDR_EXPORTED
#ifdef HAVE_INET_CONFIRM_ADDR_5_PARAMS
ret_addr = inet_confirm_addr(net, in_dev, 0,
 addr_in->sin_addr.s_addr,
 RT_SCOPE_HOST);
#else
ret_addr = inet_confirm_addr(in_dev, 0,
 addr_in->sin_addr.s_addr,
 RT_SCOPE_HOST);
#endif
#else
ret_addr = confirm_addr_indev(in_dev, 0,
  addr_in->sin_addr.s_addr,
  RT_SCOPE_HOST);
#endif

>> Hi Jeff,
>> On SLES15 (4.12.14-16-default) I have in compat/config.h:
>> #define HAVE_INET_CONFIRM_ADDR_5_PARAMS 1
>> #define HAVE_INET_CONFIRM_ADDR_EXPORTED 1
>>
>> So, it should use the topmost inet_confirm_addr and not confirm_addr_indev.
>> Did you run configure script?

I used install.pl in the latest.tgz top level directory. I assume that runs 
configure as a first step for compat_rdma? Thanks.

-jeff

>> Regards,
>> Vladimir

>> Hi Jeff,
>> Please attach compat-rdma.rpmbuild.log (ls -ltr 
>> /tmp/OFED*/compat-rdma.rpmbuild.log)

Attached. Thanks.

-jeff

>>Regards,
??Vladimir






From: Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC]
Sent: Monday, August 13, 2018 10:00 AM
To: Vladimir Sokolovsky 
‎[v...@dev.mellanox.co.il]‎
Cc: ewg@lists.openfabrics.org
Subject: OFED 4.17 latest build error on SLES15

Hi Vlad,

I just tried to build on SLES15 and got the following error:

/var/tmp/OFED_topdir/BUILD/compat-rdma-4.17/drivers/infiniband/ulp/ipoib/ipoib_main.c:
 In function ‘ipoib_is_dev_match_addr_rcu’:
/var/tmp/OFED_topdir/BUILD/compat-rdma-4.17/drivers/infiniband/ulp/ipoib/ipoib_main.c:355:14:
 error: implicit declaration of function ‘confirm_addr_indev’ 
[-Werror=implicit-function-declaration]
   ret_addr = confirm_addr_indev(in_dev, 0,
  ^~

Is the backport for SLES15 missing something? Thanks.

-jeff


___
ewg mailing list
ewg@lists.openfabrics.org
https://lists.openfabrics.org/mailman/listinfo/ewg