Re: [ewg] [PATCH] ipoib: avoid enabling napi when it's already enabled

2008-10-28 Thread Vladimir Sokolovsky 

Yossi Etigin wrote:
ipoib_open() may be called from ipoib_pkey_poll(), after napi has 
already been
enbaled, and try to enable it again. This triggers BUG_ON test in 
napi_enable().


Signed-off-by: Yossi Etigin [EMAIL PROTECTED]


Applied,

Regards,
Vladimir
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH] ipoib: avoid enabling napi when it's already enabled

2008-10-28 Thread Shirley Ma 

在 2008-10-28二的 10:47 +0200，Vladimir Sokolovsky写道：
 Yossi Etigin wrote:
  ipoib_open() may be called from ipoib_pkey_poll(), after napi has 
  already been
  enbaled, and try to enable it again. This triggers BUG_ON test in 
  napi_enable().
  
  Signed-off-by: Yossi Etigin [EMAIL PROTECTED]
 
 Applied,
 
 Regards,
 Vladimir

The same fix should submit to mainline kernel. I checked the code, same
problem there.

Thanks
Shirley

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH] ipoib: avoid enabling napi when it's already enabled

2008-10-28 Thread Roland Dreier 
thanks, applied.
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] ipoib: avoid enabling napi when it's already enabled

2008-10-27 Thread Yossi Etigin 

ipoib_open() may be called from ipoib_pkey_poll(), after napi has already been
enbaled, and try to enable it again. This triggers BUG_ON test in napi_enable().

Signed-off-by: Yossi Etigin [EMAIL PROTECTED]

Index: b/drivers/infiniband/ulp/ipoib/ipoib_main.c
===
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c 2008-10-19 16:22:09.0 
+0200
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c 2008-10-23 20:22:20.0 
+0200
@@ -106,12 +106,13 @@ int ipoib_open(struct net_device *dev)

ipoib_dbg(priv, bringing up interface\n);

-   napi_enable(priv-napi);
set_bit(IPOIB_FLAG_ADMIN_UP, priv-flags);

if (ipoib_pkey_dev_delay_open(dev))
return 0;

+   napi_enable(priv-napi);
+
if (ipoib_ib_dev_open(dev)) {
napi_disable(priv-napi);
return -EINVAL;

--
--Yossi
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH] ipoib: avoid enabling napi when it's already enabled

2008-10-27 Thread Shirley Ma 
We found the same problem during child interface test for ofed-1.4-rc3.
Please help on fixing it in ofed-1.4 daily built.

Thanks
Shirley

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg