[ewg] 2.6.32 patch has carriage returns in it that are causing rejects
I cloned ofed_1_5/linux-2.6.git and tried to do: ./ofed_scripts/ofed_patch.sh --with-backport=2.6.32 It rejected kernel_patches/backport/2.6.32/mlx4_semaphore_include.patch because the latter ends lines with carriage return and newline. I checked other patches and they only have newline. Should I submit a patch to the patch? Thanks. -jeff ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] 2.6.32 patch has carriage returns in it that are causing rejects
On 06/14/10 11:16, Jeff Becker wrote: > I cloned ofed_1_5/linux-2.6.git and tried to do: > > ./ofed_scripts/ofed_patch.sh --with-backport=2.6.32 > > It rejected > kernel_patches/backport/2.6.32/mlx4_semaphore_include.patch because > the latter ends lines with carriage return and newline. I checked > other patches and they only have newline. Should I submit a patch to > the patch? Thanks. I find the ^M's in: kernel_patches/backport/2.6.32/new_frags_interface.patch kernel_patches/backport/2.6.32/net_skb-dst_accessors.patch as well. Is there a special option I need to give to ofed_checkout.sh? Thanks. -jeff > > -jeff ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] 2.6.32 patch has carriage returns in it that are causing rejects
Some good news for SLES 11 SP1 below... On 06/14/10 12:55, Jeff Becker wrote: > On 06/14/10 11:16, Jeff Becker wrote: >> I cloned ofed_1_5/linux-2.6.git and tried to do: >> >> ./ofed_scripts/ofed_patch.sh --with-backport=2.6.32 >> >> It rejected >> kernel_patches/backport/2.6.32/mlx4_semaphore_include.patch because >> the latter ends lines with carriage return and newline. I checked >> other patches and they only have newline. Should I submit a patch to >> the patch? Thanks. > > I find the ^M's in: > > kernel_patches/backport/2.6.32/new_frags_interface.patch > kernel_patches/backport/2.6.32/net_skb-dst_accessors.patch > > as well. Is there a special option I need to give to ofed_checkout.sh? > Thanks. After fixing the ^M's and getting ofed_patch.sh to complete, a basic build: configure --with-core-mod --with-user_mad-mod --with-user_access-mod --with-addr_trans-mod --with-mlx4-mod builds fine against the SLES 11 SP1 kernel. Now to test it... -jeff > > -jeff > >> >> -jeff > ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] 2.6.32 patch has carriage returns in it that are causing rejects
Jeff Becker wrote: > Some good news for SLES 11 SP1 below... > Hi Jeff, Please send me updated patches or your git tree to pull from. Do you have quilt installed? I think that quilt knows how to handle such issues. At least, ofed_makedist.sh passed successfully on the OFA server. Thanks, Vladimir > On 06/14/10 12:55, Jeff Becker wrote: >> On 06/14/10 11:16, Jeff Becker wrote: >>> I cloned ofed_1_5/linux-2.6.git and tried to do: >>> >>> ./ofed_scripts/ofed_patch.sh --with-backport=2.6.32 >>> >>> It rejected >>> kernel_patches/backport/2.6.32/mlx4_semaphore_include.patch because >>> the latter ends lines with carriage return and newline. I checked >>> other patches and they only have newline. Should I submit a patch to >>> the patch? Thanks. >> I find the ^M's in: >> >> kernel_patches/backport/2.6.32/new_frags_interface.patch >> kernel_patches/backport/2.6.32/net_skb-dst_accessors.patch >> >> as well. Is there a special option I need to give to ofed_checkout.sh? >> Thanks. > > After fixing the ^M's and getting ofed_patch.sh to complete, a basic build: > > configure --with-core-mod --with-user_mad-mod --with-user_access-mod > --with-addr_trans-mod --with-mlx4-mod > > builds fine against the SLES 11 SP1 kernel. Now to test it... > > -jeff >> -jeff >> >>> -jeff > > > > > > ___ > ewg mailing list > ewg@lists.openfabrics.org > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] 2.6.32 patch has carriage returns in it that are causing rejects
Hi Vlad On 06/15/10 06:42, Vladimir Sokolovsky wrote: > Jeff Becker wrote: > >> Some good news for SLES 11 SP1 below... >> >> > Hi Jeff, > Please send me updated patches or your git tree to pull from. > Sure - if I need to change anything. Modulo the carriage return problem, OFED 1.5.2 built fine. Hence, there aren't any patches yet. > Do you have quilt installed? I think that quilt knows how to handle such > issues. > At least, ofed_makedist.sh passed successfully on the OFA server. > You're right - quilt was not installed. That's probably it, since I had another independent reply from someone who didn't see the carriage return problem either. I'll install it, and hopefully it fixes things. Thanks. -jeff > Thanks, > Vladimir > > >> On 06/14/10 12:55, Jeff Becker wrote: >> >>> On 06/14/10 11:16, Jeff Becker wrote: >>> I cloned ofed_1_5/linux-2.6.git and tried to do: ./ofed_scripts/ofed_patch.sh --with-backport=2.6.32 It rejected kernel_patches/backport/2.6.32/mlx4_semaphore_include.patch because the latter ends lines with carriage return and newline. I checked other patches and they only have newline. Should I submit a patch to the patch? Thanks. >>> I find the ^M's in: >>> >>> kernel_patches/backport/2.6.32/new_frags_interface.patch >>> kernel_patches/backport/2.6.32/net_skb-dst_accessors.patch >>> >>> as well. Is there a special option I need to give to ofed_checkout.sh? >>> Thanks. >>> >> After fixing the ^M's and getting ofed_patch.sh to complete, a basic build: >> >> configure --with-core-mod --with-user_mad-mod --with-user_access-mod >> --with-addr_trans-mod --with-mlx4-mod >> >> builds fine against the SLES 11 SP1 kernel. Now to test it... >> >> -jeff >> >>> -jeff >>> >>> -jeff >> >> >> >> >> ___ >> ewg mailing list >> ewg@lists.openfabrics.org >> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg >> > ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
