Re: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma?
Thanks to everyone for the feedback and the explanation. I'm going to save off Woody's answer to our in house wiki so my co-workers won't have the same confusion. -Original Message- From: Woodruff, Robert J [mailto:robert.j.woodr...@intel.com] Sent: Wednesday, May 26, 2010 6:58 PM To: Mike Heinz; openfabrics-...@openib.org Subject: RE: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma? In general, we would like kernel code to be reviewed and accepted (or at least queued for acceptance) upstream first and then submitted to to the ewg for the next OFED release. There are sometimes exceptions where things go into OFED before being accepted upstream but in general, we would like to follow the model where they are submitted upsteam first if possible. Some things, like backport patches or OFED installation scripts, are only mainatained by the EWG, so in those cases, they only need to be submitted to the EWG list. Hope this helps. woody -Original Message- From: ewg-boun...@lists.openfabrics.org [mailto:ewg-boun...@lists.openfabrics.org] On Behalf Of Mike Heinz Sent: Wednesday, May 26, 2010 1:34 PM To: openfabrics-...@openib.org Subject: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma? The subject says it all. If I have a patch that can be applied against either the current OFED git repository or against the upstream kernel - where do I post it? ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma?
On 5/27/2010 1:57 AM, Woodruff, Robert J wrote: > In general, we would like kernel code to be reviewed and accepted (or at > least queued for > acceptance) upstream first and then submitted to to the ewg for the next OFED > release. > > There are sometimes exceptions where things go into OFED before being accepted > upstream but in general, we would like to follow the model where they are > submitted upsteam first if possible. > > Some things, like backport patches or OFED installation scripts, > are only mainatained by the EWG, so in those cases, they only need to > be submitted to the EWG list. > > I fully agree with Woody here. I wanted to make one point clear: When the fix accepted by the kernel it will get automatically into next OFED release (1.6 in our case) that will be based on this kernel version or beyond. However if you wish to have the fix also in OFED today (1.5.x) you have to send a specific patch to OFED too. Since current OFED kernel base is 2.6.30 many time the patch to OFED and the kernel will not be identical. Tziporet ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma?
On Wed, 26 May 2010 13:58:41 -0700 Mike Heinz wrote: > My preference for bug fixes is that they be applied so that they go into the > upstream kernel - assuming they don't require EWG-only changes. But I need > to understand the correlation between the two source trees - if you accept a > bug fix for the upstream kernel, will that end up in OFED as well, or do I > need to submit the patch to both groups? There is a reason upstream is called "upstream". If you get it into the upstream kernel it will flow down and everyone will get it. If you only submit to EWG then it will stay there in OFED purgatory. That is not to say you can't submit to OFED for "critical" things which your customers need but that should be an exception rather than the rule. Ira > > -Original Message- > From: Roland Dreier [mailto:rdre...@cisco.com] > Sent: Wednesday, May 26, 2010 4:50 PM > To: Mike Heinz > Cc: openfabrics-...@openib.org > Subject: Re: [ewg] Question: When should patches be submitted to EWG and when > should they be submitted to linux-rdma? > > > The subject says it all. If I have a patch that can be applied > > against either the current OFED git repository or against the > > upstream kernel - where do I post it? > > What do you want to happen to the patch? If you want it applied to the > upstream kernel, then send it to me and linux-rdma. If you want it > applied to an OFED tree, send it to ewg. > -- > Roland Dreier || For corporate legal information go to: > http://*www.*cisco.com/web/about/doing_business/legal/cri/index.html > ___ > ewg mailing list > ewg@lists.openfabrics.org > http://*lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg > ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma?
In general, we would like kernel code to be reviewed and accepted (or at least queued for acceptance) upstream first and then submitted to to the ewg for the next OFED release. There are sometimes exceptions where things go into OFED before being accepted upstream but in general, we would like to follow the model where they are submitted upsteam first if possible. Some things, like backport patches or OFED installation scripts, are only mainatained by the EWG, so in those cases, they only need to be submitted to the EWG list. Hope this helps. woody -Original Message- From: ewg-boun...@lists.openfabrics.org [mailto:ewg-boun...@lists.openfabrics.org] On Behalf Of Mike Heinz Sent: Wednesday, May 26, 2010 1:34 PM To: openfabrics-...@openib.org Subject: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma? The subject says it all. If I have a patch that can be applied against either the current OFED git repository or against the upstream kernel - where do I post it? ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma?
My preference for bug fixes is that they be applied so that they go into the upstream kernel - assuming they don't require EWG-only changes. But I need to understand the correlation between the two source trees - if you accept a bug fix for the upstream kernel, will that end up in OFED as well, or do I need to submit the patch to both groups? -Original Message- From: Roland Dreier [mailto:rdre...@cisco.com] Sent: Wednesday, May 26, 2010 4:50 PM To: Mike Heinz Cc: openfabrics-...@openib.org Subject: Re: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma? > The subject says it all. If I have a patch that can be applied > against either the current OFED git repository or against the > upstream kernel - where do I post it? What do you want to happen to the patch? If you want it applied to the upstream kernel, then send it to me and linux-rdma. If you want it applied to an OFED tree, send it to ewg. -- Roland Dreier || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
Re: [ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma?
> The subject says it all. If I have a patch that can be applied > against either the current OFED git repository or against the > upstream kernel - where do I post it? What do you want to happen to the patch? If you want it applied to the upstream kernel, then send it to me and linux-rdma. If you want it applied to an OFED tree, send it to ewg. -- Roland Dreier || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Question: When should patches be submitted to EWG and when should they be submitted to linux-rdma?
The subject says it all. If I have a patch that can be applied against either the current OFED git repository or against the upstream kernel - where do I post it? ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
