Re: [ewg] Re: [PATCH] Set the dependencies of openibd and iscsi services

2008-02-12 Thread Vladimir Sokolovsky

Doron Shoham wrote:

Vladimir Sokolovsky wrote:

Doron Shoham wrote:

 iscsi service should start after openibd service.
 iscsi service should stop before openibd service.

Signed-off-by: Doron Shoham [EMAIL PROTECTED]
---

Hi Doron,
Why can't you just put in the /etc/init.d/iscsi:

# chkconfig: 2345 16 84


Why is openibd's start 15 and stop 85?
will it always be correct?


Because the network start is 10 and stop is 90.
This is correct for now...




And in the /etc/init.d/open-iscsi:
Required-Start: openibd

And then update ofa_kernel.spec to set
Required-Stop: open-iscsi
In case that iser was selected and OS is SuSE.


You are right.
I'll do it that way.


This will change about 5 lines of code instead of about 150 lines of
your patch.

Regards,
Vladimir


I'll make a new patch.

Thanks,
Doron



Tell me if you need help with ofa_kernel.spec.


Regards,
Vladimir
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg


[ewg] Re: [PATCH] Set the dependencies of openibd and iscsi services

2008-02-12 Thread Doron Shoham
Vladimir Sokolovsky wrote:
 Doron Shoham wrote:
  iscsi service should start after openibd service.
  iscsi service should stop before openibd service.

 Signed-off-by: Doron Shoham [EMAIL PROTECTED]
 ---
 
 Hi Doron,
 Why can't you just put in the /etc/init.d/iscsi:
 
 # chkconfig: 2345 16 84

Why is openibd's start 15 and stop 85?
will it always be correct?

 
 And in the /etc/init.d/open-iscsi:
 Required-Start: openibd
 
 And then update ofa_kernel.spec to set
 Required-Stop: open-iscsi
 In case that iser was selected and OS is SuSE.

You are right.
I'll do it that way.

 
 This will change about 5 lines of code instead of about 150 lines of
 your patch.
 
 Regards,
 Vladimir

I'll make a new patch.

Thanks,
Doron

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg