Re: [ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-19 Thread Eli Cohen 

 Eli, can you add the upstream change-log description (commit 
 727f89d27d623f87a637c1868dc8b6af7103fa19) such that this patch instance 
 in ofed will be documented?
 
 Or

Sure, I updated the changelog.

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-19 Thread Or Gerlitz 

Roland Dreier wrote:

OK, applied, although that link points to an HTML-mangled version of
the patch, and I also had to figure out why we needed that change and
write the patch description myself.


Eli, can you add the upstream change-log description (commit 
727f89d27d623f87a637c1868dc8b6af7103fa19) such that this patch instance 
in ofed will be documented?


Or

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-19 Thread Stefan Roscher 
On Monday 18 February 2008 23:49:30 Roland Dreier wrote:
   Here is the link to the patch sent previously:
 
   http://lists.openfabrics.org/pipermail/general/2008-February/046463.html
 
 OK, applied, although that link points to an HTML-mangled version of
 the patch, and I also had to figure out why we needed that change and
 write the patch description myself.
 

Hi Roland,

here is the link to my description of this problem. Maybe it will help.
http://lists.openfabrics.org/pipermail/ewg/2008-February/005905.html

regards Stefan 


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-18 Thread Pradeep Satyanarayana 
Eli Cohen wrote:
 On Sun, 2008-02-17 at 11:21 +0200, Or Gerlitz wrote:
 Thanks, this sheds more light on the solution but I still can not 
 understand how can the upstream code live without the QPs getting 
 destroyed? or the bug exist also there? if yes, I would recommend to 
 reshape the change-log to the extent explaining well the problem and 
 solution and then resend to Roland.

 Pradeep, I think it's your call.

Hello Eli, I have already submitted this patch to mainline. I will follow
up with Roland to get this merged there.

Pradeep


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-18 Thread Roland Dreier 
  Hello Eli, I have already submitted this patch to mainline. I will follow
  up with Roland to get this merged there.

I didn't see the submission... can you resend?
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-18 Thread Pradeep Satyanarayana 
Roland Dreier wrote:
   Hello Eli, I have already submitted this patch to mainline. I will follow
   up with Roland to get this merged there.
 
 I didn't see the submission... can you resend?
Roland,

Here is the link to the patch sent previously:

http://lists.openfabrics.org/pipermail/general/2008-February/046463.html

Pradeep

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-18 Thread Pradeep Satyanarayana 
Roland Dreier wrote:
   Here is the link to the patch sent previously:
 
   http://lists.openfabrics.org/pipermail/general/2008-February/046463.html
 
 OK, applied, although that link points to an HTML-mangled version of
 the patch, and I also had to figure out why we needed that change and
 write the patch description myself.

Roland,

Thanks for your help.

Pradeep

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-17 Thread Or Gerlitz 

Eli Cohen wrote:

We took Pradeep's patch which moves the CM rx objects from the
error, flush and drain lists and puts them in the reap list. Putting
them in the reap list will cause the corresponding QPs to be destroyed.


Thanks, this sheds more light on the solution but I still can not 
understand how can the upstream code live without the QPs getting 
destroyed? or the bug exist also there? if yes, I would recommend to 
reshape the change-log to the extent explaining well the problem and 
solution and then resend to Roland.


Or

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-17 Thread Eli Cohen 

On Sun, 2008-02-17 at 11:21 +0200, Or Gerlitz wrote:
 Thanks, this sheds more light on the solution but I still can not 
 understand how can the upstream code live without the QPs getting 
 destroyed? or the bug exist also there? if yes, I would recommend to 
 reshape the change-log to the extent explaining well the problem and 
 solution and then resend to Roland.
 
Pradeep, I think it's your call.

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-16 Thread Or Gerlitz 

Tziporet Koren wrote:

We will take this one


Can you please explain what was the problem and what was the fix? I 
can't learn that from the patch change-log nor from the thread.


Or

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [PATCH]IPOIB/CM fix for bug# 906 -OFED-1.3

2008-02-14 Thread Tziporet Koren 

Pradeep Satyanarayana wrote:

This patch fixes -fail to destroy ipoib rx QP 
(https://bugs.openfabrics.org/show_bug.cgi?id=906)
Hence the usecnt issue reported previously on ehca is solved and allows the qp 
to be destroyed.

As per Eli's request, I am splitting up the patches. This is first portion of 
yesterday's patch.
Tested on ppc64 machines with ehca and mthca.

Signed-off-by: Pradeep Satyanarayana [EMAIL PROTECTED]
---

--- ofa_kernel-1.3_a/drivers/infiniband/ulp/ipoib/ipoib_cm.c2008-02-11 
14:28:47.0 -0500
+++ ofa_kernel-1.3_b/drivers/infiniband/ulp/ipoib/ipoib_cm.c2008-02-12 
17:44:07.0 -0500
@@ -883,9 +883,9 @@ void ipoib_cm_dev_stop(struct net_device
/*
 * assume the HW is wedged and just free up everything.
 */
-   list_splice_init(priv-cm.rx_flush_list, list);
-   list_splice_init(priv-cm.rx_error_list, list);
-   list_splice_init(priv-cm.rx_drain_list, list);
+   list_splice_init(priv-cm.rx_flush_list, 
priv-cm.rx_reap_list);
+   list_splice_init(priv-cm.rx_error_list, 
priv-cm.rx_reap_list);
+   list_splice_init(priv-cm.rx_drain_list, 
priv-cm.rx_reap_list);
break;
}
spin_unlock_irq(priv-lock);


  


We will take this one
Tziporet
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg