[ewg] RE: [ofa-general] [PATCH 0/6] nes: Cosmetic changes; support virtual WQs and PPC
> > OK, I just pushed out a few more small cleanups (running unifdef, > fixing signedness warnings, and fixing a locking bug on an error > path). One question: what is the point of the monkeying with > SPIN_BUG_ON on in nes.c? > Probably just some leftover debugging. I can remove it. Thanks for letting me know that you've push content to your branch. I'll pick it up. Btw, I'll be preparing another set of patches that should be ready very soon. Glenn. > - R. > ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Re: [ofa-general] [PATCH 0/6] nes: Cosmetic changes; support virtual WQs and PPC
OK, I just pushed out a few more small cleanups (running unifdef, fixing signedness warnings, and fixing a locking bug on an error path). One question: what is the point of the monkeying with SPIN_BUG_ON on in nes.c? - R. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Re: [ofa-general] [PATCH 0/6] nes: Cosmetic changes; support virtual WQs and PPC
> Or you said I could submit patches to you. One problem with > only using your tree is that I need to supply updates and backports > for OFED builds. I've cloned Vlad's tree for that. How you manage OFED is up to you. However, once your driver is in the upstream tree there is no alternative except to supply patches that apply to my tree or the upstream tree, and you might as well get in the habit now. (And in fact, making a convincing case that you can maintain a driver in the upstream kernel is part of getting your driver merged) > How about this for the future: Let me know when you've made > changes and I'll pull and merge your changes into my code. > That way I can still provide everything for OFED and patches > I create should apply cleanly in your branch. I assume > you could also pull from my tree as well, right? If you have > a better way to satisfy all we can discuss it. I can't pull from your current tree, because it has a bunch of OFED crap in it. If you want me to pull, then you need to provide a tree that is based on the tree I'm pulling into and has no changes except the ones you're trying to give to me. Anyway. I just threw away my old neteffect branch, and pushed out a new branch with the nes driver from your OFED tree. It seems as if that tree already had all the patches you emailed out. I also ran scripts/cleanfile on the nes driver to fix the obvious whitespace problems. However there is still a lot of cosmetic work that needs to get done -- for example, while I'm not a stickler about the 80-column limit, having lines more than 150 characters long is clearly excessive. - R. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] RE: [ofa-general] [PATCH 0/6] nes: Cosmetic changes; support virtual WQs and PPC
Or you said I could submit patches to you. One problem with only using your tree is that I need to supply updates and backports for OFED builds. I've cloned Vlad's tree for that. How about this for the future: Let me know when you've made changes and I'll pull and merge your changes into my code. That way I can still provide everything for OFED and patches I create should apply cleanly in your branch. I assume you could also pull from my tree as well, right? If you have a better way to satisfy all we can discuss it. The last set of patches were 99% cosmetic changes and I shouldn't need to submit something that unwieldy again. On that note, I've got another set of patches almost ready to go and I've split them by issue/fix. Maybe you should wait to modify anything in the nes directory until I've pushed my changes to the OFA servers. Sorry for the mixup. Thanks, Glenn. > > Arghh... these don't apply to my "neteffect" branch, so you've lost > the cleanup work that I did (eg trailing whitespace removal, > formatting fixes, etc). I thought we agreed that I would pull the > driver into my tree for merging into 2.6.25 and we would work on it > there. > > Anwyay. I'll reimport the nes driver into a new "neteffect" branch in > my tree (and maybe recreate the work I did). In the future please > post updates as incremental patches to that tree. And when I say > incremental patches I mean reviewable things that are split up > conceptually and not by which files they touch. (That is, patches > like "Fix types of workqueue work functions" rather than "Fix > nes_cm.c") > > Thanks... > ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Re: [ofa-general] [PATCH 0/6] nes: Cosmetic changes; support virtual WQs and PPC
Arghh... these don't apply to my "neteffect" branch, so you've lost the cleanup work that I did (eg trailing whitespace removal, formatting fixes, etc). I thought we agreed that I would pull the driver into my tree for merging into 2.6.25 and we would work on it there. Anwyay. I'll reimport the nes driver into a new "neteffect" branch in my tree (and maybe recreate the work I did). In the future please post updates as incremental patches to that tree. And when I say incremental patches I mean reviewable things that are split up conceptually and not by which files they touch. (That is, patches like "Fix types of workqueue work functions" rather than "Fix nes_cm.c") Thanks... ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
[ewg] Re: [ofa-general] [PATCH 0/6] nes: Cosmetic changes; support virtual WQs and PPC
Glenn Grundstrom (NetEffect) wrote: Updated code for the NetEffect NE020 adapter. Updates include: - Support for userspace/virtual WQs. - PowerPC - Support for multiple debugging levels - Many, many cosmetic changes inline with kernel.org standards It would be possible to review this if each change were self contained, rather than grouped together with patches based on which files were affected. - Sean ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
