[ewg] Re: split CQs for IPOIB UD

2008-04-28 Thread Or Gerlitz

Roland Dreier wrote:

  what about this patch:
  http://lists.openfabrics.org/pipermail/general/2008-March/048322.html

Looks mostly OK, I plan to merge it.


Hi Eli,

OK, so we start a review here, good! I see now (that you made a day later a v1 post for 
this patch @ http://lists.openfabrics.org/pipermail/general/2008-March/048381.html fixing 
some receive size calculations, and that some variations plus fixes exist in the copy and 
related patches in ofed 1.3. For example the call to skb_orphan() was moved from where it 
is placed here, there's a bug fix for the CQ size calculations, ipoib_ib_handle_tx_wc() 
gets a need_lock flag, etc.

Please let us know if you want to merge the v1 post (can it be updated such 
that it
applies against the current git?) or you want first to update it etc.

thanks,

Or.


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg


[ewg] Re: split CQs for IPOIB UD

2008-04-28 Thread Eli Cohen

On Mon, 2008-04-28 at 10:13 +0300, Or Gerlitz wrote:
 Roland Dreier wrote:
what about this patch:
http://lists.openfabrics.org/pipermail/general/2008-March/048322.html
 
  Looks mostly OK, I plan to merge it.
 
 Hi Eli,
 
 OK, so we start a review here, good! I see now (that you made a day later a 
 v1 post for this patch @ 
 http://lists.openfabrics.org/pipermail/general/2008-March/048381.html fixing 
 some receive size calculations, and that some variations plus fixes exist in 
 the copy and related patches in ofed 1.3. For example the call to 
 skb_orphan() was moved from where it is placed here, there's a bug fix for 
 the CQ size calculations, ipoib_ib_handle_tx_wc() gets a need_lock flag, 
 etc.
 
 Please let us know if you want to merge the v1 post (can it be updated such 
 that it
 applies against the current git?) or you want first to update it etc.

Hi Or,
thanks for noticing the v1 post. However, the v1 post only fixed CQ size
calculation and all the other changes you mention I can't see. Also v1
matches what I have in my git tree. Did I miss something?
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg