[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
https://bugs.exim.org/show_bug.cgi?id=1578 Jeremy Harris changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #10 from Jeremy Harris --- Since there have been no further comments, closing assumed fixed. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
https://bugs.exim.org/show_bug.cgi?id=1578 --- Comment #9 from Git Commit --- Git commit: http://git.exim.org/exim.git/commitdiff/43ff44e918b762b98b495a91fcd4f0d2f8049bce commit 43ff44e918b762b98b495a91fcd4f0d2f8049bce Author: Jeremy Harris AuthorDate: Mon Mar 14 12:13:43 2016 + Commit: Jeremy Harris CommitDate: Mon Mar 14 14:00:41 2016 + fix build for solaris: "all" must be the first make target. broken-by: dfe7d917154a bug 1578 src/OS/Makefile-Base | 2 +- src/OS/Makefile-HP-UX | 2 +- src/OS/Makefile-SunOS5 | 2 +- src/OS/os.c-HP-UX | 4 +++- src/OS/os.c-SunOS5 | 2 +- 5 files changed, 7 insertions(+), 5 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
https://bugs.exim.org/show_bug.cgi?id=1578 Todd Rinaldo changed: What|Removed |Added CC||to...@cpanel.net --- Comment #8 from Todd Rinaldo --- (In reply to Phil Pennock from comment #1) > There's a minor robustness problem with the current code, since I don't > _think_ unsetenv() is guaranteed to remove _all_ instances of a given > environment variable name from environ; the FreeBSD unsetenv(3) documents > that it does so, the Linux man-pages document does not, SUSv4 does not. So > starting Exim with ["TZ=a", "TZ=b"] may result in unsetenv not entirely > removing TZ as expected. You gave me bug eyes when I read this this morning. I don't think that's true. At least not for glibc http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2000-0824 -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
https://bugs.exim.org/show_bug.cgi?id=1578 --- Comment #7 from Git Commit --- Git commit: http://git.exim.org/exim.git/commitdiff/dfe7d917154afce0e4016a60f142bd540677930f commit dfe7d917154afce0e4016a60f142bd540677930f Author: Jeremy Harris AuthorDate: Tue Mar 8 23:57:37 2016 + Commit: Jeremy Harris CommitDate: Wed Mar 9 00:05:58 2016 + fix build for hp-ux and older solaris: (un)setenv. bug 1578 broken-by: bc3c7bb7d4ab doc/doc-txt/ChangeLog | 4 src/OS/Makefile-Base | 2 +- src/OS/Makefile-HP-UX | 2 ++ src/OS/Makefile-SunOS5 | 2 ++ src/OS/os.c-HP-UX | 14 ++ src/OS/os.c-SunOS5 | 16 src/OS/os.h-HP-UX | 1 - src/src/setenv.c | 8 src/src/tls.c | 23 ++- 9 files changed, 53 insertions(+), 19 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
https://bugs.exim.org/show_bug.cgi?id=1578 --- Comment #6 from Jeremy Harris --- Thanks for testing. The patch is no longer needed, the code being in the mainline - but as you note it no longer builds for Solaris 8 following a different commit. I'll commit a fix for that. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
https://bugs.exim.org/show_bug.cgi?id=1578 Dean Brooks changed: What|Removed |Added CC||d...@iglou.com --- Comment #5 from Dean Brooks --- Tried recompiling on an older Solaris 8 box using the patch, but compilation failed. Two issues: 1. Typo due to #endif being misspelled as #endof 2. There is another instance of setenv/unsetenv in environment.c that would not compile due to the functions only being in tls.c. -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
https://bugs.exim.org/show_bug.cgi?id=1578 Git Commit changed: What|Removed |Added CC||g...@exim.org --- Comment #4 from Git Commit --- Git commit: http://git.exim.org/exim.git/commitdiff/06cf6fdcb4b33f3751ec8d121c98e00553c8b069 commit 06cf6fdcb4b33f3751ec8d121c98e00553c8b069 Author: Jeremy Harris AuthorDate: Sun Dec 27 13:18:42 2015 + Commit: Jeremy Harris CommitDate: Sun Dec 27 13:28:00 2015 + provide setenv/unsetenv for environments lacking them. bug 1578 currently this covers hp-ux and older solaris. src/OS/Makefile-Base | 4 +++- src/OS/os.h-HP-UX | 1 + src/OS/os.h-SunOS5| 6 ++ src/scripts/MakeLinks | 1 + src/src/setenv.c | 55 +++ src/src/tls.c | 14 - 6 files changed, 75 insertions(+), 6 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
--- You are receiving this mail because: --- You are on the CC list for the bug. http://bugs.exim.org/show_bug.cgi?id=1578 Jeremy Harris changed: What|Removed |Added Version|N/A |4.85 --- Comment #3 from Jeremy Harris 2015-04-26 17:11:28 --- Still waiting for a verification of the proposed fix, from someone running that environment -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
--- You are receiving this mail because: --- You are on the CC list for the bug. http://bugs.exim.org/show_bug.cgi?id=1578 --- Comment #2 from Jeremy Harris 2015-02-11 20:57:32 --- Created an attachment (id=788) --> (http://bugs.exim.org/attachment.cgi?id=788) written blind and by guesswork -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
--- You are receiving this mail because: --- You are on the CC list for the bug. http://bugs.exim.org/show_bug.cgi?id=1578 Jeremy Harris changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1578] Solaris 8 build with TLS failed due to undefined setenv/unsetenv
--- You are receiving this mail because: --- You are on the CC list for the bug. http://bugs.exim.org/show_bug.cgi?id=1578 Phil Pennock changed: What|Removed |Added AssignedTo|p...@exim.org|jgh146...@wizmail.org --- Comment #1 from Phil Pennock 2015-01-27 00:08:41 --- Appears to have been introduced with commit e9477a08 2014-11-10 with the restore_tz() function for bug 1541 "Handle UTC vs specified-timezone for certificate extractors". SUSv4 text for "setenv" says "First released in Issue 6. Derived from the IEEE P1003.1a draft standard." There's a minor robustness problem with the current code, since I don't _think_ unsetenv() is guaranteed to remove _all_ instances of a given environment variable name from environ; the FreeBSD unsetenv(3) documents that it does so, the Linux man-pages document does not, SUSv4 does not. So starting Exim with ["TZ=a", "TZ=b"] may result in unsetenv not entirely removing TZ as expected. -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
